| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8d7796f3-af4f-5e48-dafc-8d3b4bc978b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB6A:4C357:1C61AD4:2731007:6A4ECDEB |
| html-safe-nonce | eb6b610e7c9fb698870634fae7d3c0de346e56cc72a6453607ae61be37b67ad2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjZBOjRDMzU3OjFDNjFBRDQ6MjczMTAwNzo2QTRFQ0RFQiIsInZpc2l0b3JfaWQiOiIzNDgwNjQ2NzU5Nzk2ODg3MDE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f58436194ed2f339c6f2e69237af2574b3def57c1f93a92f60e5df7bc124b5e2 |
| hovercard-subject-tag | pull_request:281088355 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27816/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/032196c82a95ebc95b1c64ce295a9ffc69e8b76bab672e19ad887af62372f634/nodejs/node/pull/27816 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/032196c82a95ebc95b1c64ce295a9ffc69e8b76bab672e19ad887af62372f634/nodejs/node/pull/27816 |
| og:image:alt | Make tls.connect() support the hints option for feature parity with
net.connect().
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
docume... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27816#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27816 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27816 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27816 |
| Reload | https://github.com/nodejs/node/pull/27816 |
| Reload | https://github.com/nodejs/node/pull/27816 |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:support/hints-option | https://github.com/lpinca/node/tree/support/hints-option |
| Conversation | https://github.com/nodejs/node/pull/27816 |
| Commits2 (2) | https://github.com/nodejs/node/pull/27816/commits |
| Checks | https://github.com/nodejs/node/pull/27816/checks |
| Files changed | https://github.com/nodejs/node/pull/27816/files |
| tls: support the hints option | https://github.com/nodejs/node/pull/27816#top |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:support/hints-option | https://github.com/lpinca/node/tree/support/hints-option |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 22, 2019 | https://github.com/nodejs/node/pull/27816#issue-447004129 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
|
| https://github.com/lpinca |
| tls: support the hints option | https://github.com/nodejs/node/pull/27816/commits/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| 53f9983 | https://github.com/nodejs/node/pull/27816/commits/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 22, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-494709041 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3594 | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3594 |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| May 22, 2019 | https://github.com/nodejs/node/pull/27816#event-2358521769 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-240499837 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 22, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-494719349 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-240596927 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-240602351 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 22, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-494785661 |
| https://ci.nodejs.org/job/node-test-pull-request/23270/ | https://ci.nodejs.org/job/node-test-pull-request/23270/ |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-240620897 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-240705775 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| lib/_tls_wrap.js | https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8 |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
|
| https://github.com/lpinca |
| fixup! tls: support the hints option | https://github.com/nodejs/node/pull/27816/commits/2243f596dcc5b49c554701304a8c2a87e6c352de |
| 2243f59 | https://github.com/nodejs/node/pull/27816/commits/2243f596dcc5b49c554701304a8c2a87e6c352de |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 23, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-495092210 |
| https://ci.nodejs.org/job/node-test-pull-request/23288/ | https://ci.nodejs.org/job/node-test-pull-request/23288/ |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 23, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-241017608 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
May 23, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-241243299 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 25, 2019
| https://github.com/nodejs/node/pull/27816#pullrequestreview-241989996 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 25, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-495859617 |
| https://ci.nodejs.org/job/node-test-pull-request/23318/ | https://ci.nodejs.org/job/node-test-pull-request/23318/ |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 25, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-495864273 |
| https://ci.nodejs.org/job/node-test-pull-request/23319/ | https://ci.nodejs.org/job/node-test-pull-request/23319/ |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 25, 2019 | https://github.com/nodejs/node/pull/27816#issuecomment-495870582 |
| ff8539e | https://github.com/nodejs/node/commit/ff8539e9e747db61a2adac6d4498ef4ee5826900 |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 25, 2019 | https://github.com/nodejs/node/pull/27816#event-2367141583 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 25, 2019 06:51 | https://github.com/nodejs/node/pull/27816#event-2367141621 |
| lpinca | https://github.com/lpinca |
|
May 25, 2019
| https://github.com/nodejs/node/pull/27816#ref-commit-ff8539e |
|
| https://github.com/lpinca |
| tls: support the hints option | https://github.com/nodejs/node/commit/ff8539e9e747db61a2adac6d4498ef4ee5826900 |
| ff8539e | https://github.com/nodejs/node/commit/ff8539e9e747db61a2adac6d4498ef4ee5826900 |
| #27816 | https://github.com/nodejs/node/pull/27816 |
| targos | https://github.com/targos |
|
May 28, 2019
| https://github.com/nodejs/node/pull/27816#ref-commit-10e0d7f |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
| tls: support the hints option | https://github.com/nodejs/node/commit/10e0d7f2acf1f82bde7d909d9d8979e2040f30e2 |
| 10e0d7f | https://github.com/nodejs/node/commit/10e0d7f2acf1f82bde7d909d9d8979e2040f30e2 |
| #27816 | https://github.com/nodejs/node/pull/27816 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/27816#ref-pullrequest-451450524 |
|
v12.4.0 release proposal
#28040
| https://github.com/nodejs/node/pull/28040 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27816 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/27816/files/53f9983d9d87b2c68a8cf0a5af7b23b61ab440e3 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/27816/files/2243f596dcc5b49c554701304a8c2a87e6c352de |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/27816 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BridgeAR |
|
| https://github.com/sam-github |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |