René's URL Explorer Experiment


Title: esm: refactor createDynamicModule() by cjihrig · Pull Request #27809 · nodejs/node · GitHub

Open Graph Title: esm: refactor createDynamicModule() by cjihrig · Pull Request #27809 · nodejs/node

X Title: esm: refactor createDynamicModule() by cjihrig · Pull Request #27809 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit refactors createDynamicModule() for readability: The map() callback functions are named and moved to a higher scope. The two export map() loops are combined. JSON.stringify() is only c...

X Description: This commit refactors createDynamicModule() for readability: The map() callback functions are named and moved to a higher scope. The two export map() loops are combined. JSON.stringify() is only c...

Opengraph URL: https://github.com/nodejs/node/pull/27809

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b4ae842-db35-61e0-11c2-2646af5ec9b3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A46:2095E1:1772DE8:1FF9897:6A4F0C40
html-safe-nonceff28974a8f8c266694a6bc4bcd5899133fb3224dd2f11c5318c3803534c6e570
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTQ2OjIwOTVFMToxNzcyREU4OjFGRjk4OTc6NkE0RjBDNDAiLCJ2aXNpdG9yX2lkIjoiMjAwMDQwODgwODMzMzk3MDQ5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace07c479a8887b7837a095e43a240cc878a69068c19bc2c59d056eac428608dc8
hovercard-subject-tagpull_request:281018474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27809/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cc6ef598a3c2e144f9d0f330a3626da19c5a8ab9c9057d37494c2fb9facc1655/nodejs/node/pull/27809
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cc6ef598a3c2e144f9d0f330a3626da19c5a8ab9c9057d37494c2fb9facc1655/nodejs/node/pull/27809
og:image:altThis commit refactors createDynamicModule() for readability: The map() callback functions are named and moved to a higher scope. The two export map() loops are combined. JSON.stringify() is only c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27809#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27809
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27809
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27809
Reloadhttps://github.com/nodejs/node/pull/27809
Reloadhttps://github.com/nodejs/node/pull/27809
Please reload this pagehttps://github.com/nodejs/node/pull/27809
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27809
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 966 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dyn-modhttps://github.com/cjihrig/node/tree/dyn-mod
Conversationhttps://github.com/nodejs/node/pull/27809
Commits1 (1)https://github.com/nodejs/node/pull/27809/commits
Checkshttps://github.com/nodejs/node/pull/27809/checks
Files changedhttps://github.com/nodejs/node/pull/27809/files
esm: refactor createDynamicModule()https://github.com/nodejs/node/pull/27809#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dyn-modhttps://github.com/cjihrig/node/tree/dyn-mod
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 22, 2019https://github.com/nodejs/node/pull/27809#issue-446913625
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27809
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2019https://github.com/nodejs/node/pull/27809#issuecomment-494636445
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3591https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3591
Please reload this pagehttps://github.com/nodejs/node/pull/27809
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240392652
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/danbev
danbevhttps://github.com/danbev
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240394849
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/devsnek
devsnekhttps://github.com/devsnek
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
May 22, 2019https://github.com/nodejs/node/pull/27809#event-2358015880
https://github.com/mihalskiy
mihalskiyhttps://github.com/mihalskiy
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240434077
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/timofeichaplinskiy
timofeichaplinskiyhttps://github.com/timofeichaplinskiy
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240434898
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240443470
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240774040
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 22, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240842587
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2019https://github.com/nodejs/node/pull/27809#issuecomment-495054631
Please reload this pagehttps://github.com/nodejs/node/pull/27809
https://ci.nodejs.org/job/node-test-pull-request/23287/https://ci.nodejs.org/job/node-test-pull-request/23287/
Please reload this pagehttps://github.com/nodejs/node/pull/27809
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 23, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-240990000
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 23, 2019https://github.com/nodejs/node/pull/27809#event-2361259177
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2019 https://github.com/nodejs/node/pull/27809#pullrequestreview-241018052
View reviewed changes https://github.com/nodejs/node/pull/27809/files
https://github.com/cjihrig
esm: refactor createDynamicModule()https://github.com/nodejs/node/pull/27809/commits/3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
3293bbfhttps://github.com/nodejs/node/pull/27809/commits/3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
nodejs#27809https://github.com/nodejs/node/pull/27809
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/b735f6866f49f4fb4f0f07da1ad11d4a2621a831..3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
b735f68https://github.com/nodejs/node/commit/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
3293bbfhttps://github.com/nodejs/node/commit/3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
Compare https://github.com/nodejs/node/compare/b735f6866f49f4fb4f0f07da1ad11d4a2621a831..3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
May 24, 2019 12:34https://github.com/nodejs/node/pull/27809#event-2365391162
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
3293bbfhttps://github.com/nodejs/node/commit/3293bbf77a4e940ccb8f250b65129b3c4dc44fb5
May 24, 2019https://github.com/nodejs/node/pull/27809#event-2365394639
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 24, 2019 12:36https://github.com/nodejs/node/pull/27809#event-2365396538
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27809#ref-commit-be1166f
https://github.com/cjihrig
https://github.com/targos
esm: refactor createDynamicModule()https://github.com/nodejs/node/commit/be1166fd01b4f9451850d39e9acfaf0020204896
be1166fhttps://github.com/nodejs/node/commit/be1166fd01b4f9451850d39e9acfaf0020204896
#27809https://github.com/nodejs/node/pull/27809
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27809#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27809
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/mihalskiy
mihalskiy https://github.com/mihalskiy
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
https://github.com/timofeichaplinskiy
timofeichaplinskiy https://github.com/timofeichaplinskiy
https://github.com/nodejs/node/pull/27809/files/b735f6866f49f4fb4f0f07da1ad11d4a2621a831
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
Please reload this pagehttps://github.com/nodejs/node/pull/27809
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/jasnell
https://github.com/guybedford
https://github.com/Fishrock123
https://github.com/lpinca
https://github.com/devsnek
https://github.com/ZYSzys
https://github.com/mihalskiy
https://github.com/timofeichaplinskiy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.