René's URL Explorer Experiment


Title: src: remove util-inl.h include in node.h by addaleax · Pull Request #27804 · nodejs/node · GitHub

Open Graph Title: src: remove util-inl.h include in node.h by addaleax · Pull Request #27804 · nodejs/node

X Title: src: remove util-inl.h include in node.h by addaleax · Pull Request #27804 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: node.h may only include public APIs, which util-inl.h is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not...

X Description: node.h may only include public APIs, which util-inl.h is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not...

Opengraph URL: https://github.com/nodejs/node/pull/27804

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:338e50c3-846b-9ec5-e9fa-f252ddab578e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4EC:2E51E:1181B6:191019:6A4E63BE
html-safe-nonce1f2b42f93f25046bcf92049b35d42efdd93e7d999cdf6055da091f85bec1e1d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEVDOjJFNTFFOjExODFCNjoxOTEwMTk6NkE0RTYzQkUiLCJ2aXNpdG9yX2lkIjoiODQwODE4Njk0MDkxNDgyMDAzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd206486aa7cedac0956261177e5712ffe7fa2db37d99c648c015d055c733b6ec
hovercard-subject-tagpull_request:280927022
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27804/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9bb0f704bf92552188cc1bfc5e141197d16f41aaec0bbfc67b209e3220426de8/nodejs/node/pull/27804
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9bb0f704bf92552188cc1bfc5e141197d16f41aaec0bbfc67b209e3220426de8/nodejs/node/pull/27804
og:image:altnode.h may only include public APIs, which util-inl.h is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27804#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27804
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27804
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27804
Reloadhttps://github.com/nodejs/node/pull/27804
Reloadhttps://github.com/nodejs/node/pull/27804
Please reload this pagehttps://github.com/nodejs/node/pull/27804
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27804
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:addons-fixhttps://github.com/addaleax/node/tree/addons-fix
Conversationhttps://github.com/nodejs/node/pull/27804
Commits1 (1)https://github.com/nodejs/node/pull/27804/commits
Checkshttps://github.com/nodejs/node/pull/27804/checks
Files changedhttps://github.com/nodejs/node/pull/27804/files
src: remove util-inl.h include in node.hhttps://github.com/nodejs/node/pull/27804#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:addons-fixhttps://github.com/addaleax/node/tree/addons-fix
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#issue-446798248
#27631https://github.com/nodejs/node/pull/27631
#27803https://github.com/nodejs/node/issues/27803
@BridgeARhttps://github.com/BridgeAR
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/addaleax
src: remove util-inl.h include in node.hhttps://github.com/nodejs/node/pull/27804/commits/3853b0ce876ba20e613631c4de5f49b0936f4e1b
3853b0chttps://github.com/nodejs/node/pull/27804/commits/3853b0ce876ba20e613631c4de5f49b0936f4e1b
nodejs#27631https://github.com/nodejs/node/pull/27631
nodejs#27803https://github.com/nodejs/node/issues/27803
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494535743
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3589https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3589
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 21, 2019https://github.com/nodejs/node/pull/27804#event-2357291795
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 21, 2019 https://github.com/nodejs/node/pull/27804#pullrequestreview-240268173
View reviewed changes https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 21, 2019https://github.com/nodejs/node/pull/27804#event-2357301204
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494537137
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494537143
https://ci.nodejs.org/job/node-test-pull-request/23263/https://ci.nodejs.org/job/node-test-pull-request/23263/
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/targos
targoshttps://github.com/targos
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494537382
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019 https://github.com/nodejs/node/pull/27804#pullrequestreview-240270743
View reviewed changes https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494538297
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 21, 2019 https://github.com/nodejs/node/pull/27804#pullrequestreview-240280233
View reviewed changes https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494545543
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/targos
targoshttps://github.com/targos
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494549046
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494549969
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 21, 2019 https://github.com/nodejs/node/pull/27804#pullrequestreview-240288816
View reviewed changes https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 21, 2019 https://github.com/nodejs/node/pull/27804#pullrequestreview-240305708
View reviewed changes https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494566755
47c5c3dhttps://github.com/nodejs/node/commit/47c5c3da862e7107cdf2ca4a31a4ae70be2d85a7
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019https://github.com/nodejs/node/pull/27804#event-2357518348
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 21, 2019 21:31https://github.com/nodejs/node/pull/27804#event-2357518626
addaleaxhttps://github.com/addaleax
May 21, 2019 https://github.com/nodejs/node/pull/27804#ref-commit-47c5c3d
https://github.com/addaleax
src: remove util-inl.h include in node.hhttps://github.com/nodejs/node/commit/47c5c3da862e7107cdf2ca4a31a4ae70be2d85a7
47c5c3dhttps://github.com/nodejs/node/commit/47c5c3da862e7107cdf2ca4a31a4ae70be2d85a7
#27631https://github.com/nodejs/node/pull/27631
#27803https://github.com/nodejs/node/issues/27803
#27804https://github.com/nodejs/node/pull/27804
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494570668
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 21, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494577106
#12231https://github.com/nodejs/node/pull/12231
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/msimerson
msimersonhttps://github.com/msimerson
May 21, 2019 https://github.com/nodejs/node/pull/27804#ref-pullrequest-446851530
node: remove 6, add 11,12 haraka/Haraka#2650 https://github.com/haraka/Haraka/pull/2650
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-issue-446913717
v12.3.0 causes "fatal error: util-inl.h: No such file or directory" #27810 https://github.com/nodejs/node/issues/27810
https://github.com/jacobq
jacobqhttps://github.com/jacobq
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-issue-446912919
Fails to build on node v12.3.0 jduncanator/node-diskusage#40 https://github.com/jduncanator/node-diskusage/issues/40
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 22, 2019https://github.com/nodejs/node/pull/27804#issuecomment-494641808
#12231https://github.com/nodejs/node/pull/12231
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/27804
BridgeARhttps://github.com/BridgeAR
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-commit-7438a55
https://github.com/addaleax
https://github.com/BridgeAR
src: remove util-inl.h include in node.hhttps://github.com/nodejs/node/commit/7438a557af191595b23f103cae73ee79c23bdb9e
7438a55https://github.com/nodejs/node/commit/7438a557af191595b23f103cae73ee79c23bdb9e
#27631https://github.com/nodejs/node/pull/27631
#27803https://github.com/nodejs/node/issues/27803
#27804https://github.com/nodejs/node/pull/27804
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-pullrequest-446986211
v12.3.1 proposal #27814 https://github.com/nodejs/node/pull/27814
BridgeARhttps://github.com/BridgeAR
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-commit-2817fde
https://github.com/BridgeAR
2019-05-22, Version v12.3.1 (Current)https://github.com/nodejs/node/commit/2817fde844de39b0e8c17c352433ee6124b5ef09
2817fdehttps://github.com/nodejs/node/commit/2817fde844de39b0e8c17c352433ee6124b5ef09
#27792https://github.com/nodejs/node/pull/27792
#27718https://github.com/nodejs/node/pull/27718
#27804https://github.com/nodejs/node/pull/27804
#27814https://github.com/nodejs/node/pull/27814
BridgeARhttps://github.com/BridgeAR
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-commit-8a282dc
https://github.com/BridgeAR
2019-05-22, Version v12.3.1 (Current)https://github.com/BridgeAR/node/commit/8a282dc93a7edf998007702dd44bf1059eef1678
8a282dchttps://github.com/BridgeAR/node/commit/8a282dc93a7edf998007702dd44bf1059eef1678
nodejs#27792https://github.com/nodejs/node/pull/27792
nodejs#27718https://github.com/nodejs/node/pull/27718
nodejs#27804https://github.com/nodejs/node/pull/27804
nodejs#27814https://github.com/nodejs/node/pull/27814
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 22, 2019 https://github.com/nodejs/node/pull/27804#ref-issue-447159023
npm install fails on node 12.3.0 bnoordhuis/node-iconv#200 https://github.com/bnoordhuis/node-iconv/issues/200
https://github.com/Martii
Martiihttps://github.com/Martii
May 24, 2019 https://github.com/nodejs/node/pull/27804#ref-pullrequest-446999559
Some dep updates OpenUserJS/OpenUserJS.org#1607 https://github.com/OpenUserJS/OpenUserJS.org/pull/1607
https://github.com/abretaud
abretaudhttps://github.com/abretaud
Jul 30, 2019 https://github.com/nodejs/node/pull/27804#ref-issue-474589783
12.3.0 bug, update to 12.3.1? conda-forge/nodejs-feedstock#82 https://github.com/conda-forge/nodejs-feedstock/issues/82
https://github.com/mistersandman
mistersandmanhttps://github.com/mistersandman
Dec 1, 2019 https://github.com/nodejs/node/pull/27804#ref-issue-472583089
🐛 sha3@1.x produces node-gyp deprecation warnings and/or build error on install phusion/node-sha3#60 https://github.com/phusion/node-sha3/issues/60
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27804
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/27804/files/3853b0ce876ba20e613631c4de5f49b0936f4e1b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
util-inl.h missing https://github.com/nodejs/node/issues/27803
Please reload this pagehttps://github.com/nodejs/node/pull/27804
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/BridgeAR
https://github.com/richardlau
https://github.com/sam-github
https://github.com/Fishrock123
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.