| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6ed3d29e-7518-74bf-d96b-ef2e010496c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A562:281BD4:E6B2E3:14091A1:6A4E8994 |
| html-safe-nonce | 7176877fc84dc643f4512c20d04f97944f010172f9d2fe49bc78b25e123fb9ea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTYyOjI4MUJENDpFNkIyRTM6MTQwOTFBMTo2QTRFODk5NCIsInZpc2l0b3JfaWQiOiIzNTU0OTY4NTAwNTUxMzc2ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 510c71fb7d5fb08d694fe7135a3f8686ec39e9f9dc5184a18a9da54a0d69d19c |
| hovercard-subject-tag | pull_request:280632356 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27791/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a35dfa8f1ad2ccd6dc0bebb6de5b627624cc7b81777b675b58466e87992a8752/nodejs/node/pull/27791 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a35dfa8f1ad2ccd6dc0bebb6de5b627624cc7b81777b675b58466e87992a8752/nodejs/node/pull/27791 |
| og:image:alt | Ref: #27592
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | legendecas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27791#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27791 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27791 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27791 |
| Reload | https://github.com/nodejs/node/pull/27791 |
| Reload | https://github.com/nodejs/node/pull/27791 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| legendecas | https://github.com/legendecas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| legendecas:tsfn | https://github.com/legendecas/node/tree/tsfn |
| Conversation | https://github.com/nodejs/node/pull/27791 |
| Commits1 (1) | https://github.com/nodejs/node/pull/27791/commits |
| Checks | https://github.com/nodejs/node/pull/27791/checks |
| Files changed | https://github.com/nodejs/node/pull/27791/files |
| n-api: make func argument of napi_create_threadsafe_function optional | https://github.com/nodejs/node/pull/27791#top |
| legendecas | https://github.com/legendecas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| legendecas:tsfn | https://github.com/legendecas/node/tree/tsfn |
|
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issue-446429110 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| #27592 | https://github.com/nodejs/node/issues/27592 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#event-2355015487 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node/compare/a2bcde8ae757fd198f77b66e2bed5d8cacaa2f69..dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
| a2bcde8 | https://github.com/nodejs/node/commit/a2bcde8ae757fd198f77b66e2bed5d8cacaa2f69 |
| dc0cb8e | https://github.com/nodejs/node/commit/dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
|
Compare
| https://github.com/nodejs/node/compare/a2bcde8ae757fd198f77b66e2bed5d8cacaa2f69..dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
| May 21, 2019 06:19 | https://github.com/nodejs/node/pull/27791#event-2355056478 |
| https://github.com/josephg |
| josephg | https://github.com/josephg |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494261153 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 21, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-239921801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 21, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-239972801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494344716 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/josephg |
| josephg | https://github.com/josephg |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494429876 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 21, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-240141472 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| test/node-api/test_threadsafe_function/binding.c | https://github.com/nodejs/node/pull/27791/files#diff-7025abd678052220b281a720c8e5f2b995120dd65ccd8f8557b0158a1a43025b |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494454556 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494457143 |
| @legendecas | https://github.com/legendecas |
| https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_threadsafe_function_call_js | https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_threadsafe_function_call_js |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494457352 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494459501 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| May 21, 2019 | https://github.com/nodejs/node/pull/27791#event-2356733531 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node/compare/dc0cb8e6175e0ba8825cdab0be2197c189c934bf..3767947b50d3db40219ac1288c9d5bd7dbac0836 |
| dc0cb8e | https://github.com/nodejs/node/commit/dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
| 3767947 | https://github.com/nodejs/node/commit/3767947b50d3db40219ac1288c9d5bd7dbac0836 |
|
Compare
| https://github.com/nodejs/node/compare/dc0cb8e6175e0ba8825cdab0be2197c189c934bf..3767947b50d3db40219ac1288c9d5bd7dbac0836 |
| May 22, 2019 06:54 | https://github.com/nodejs/node/pull/27791#event-2358270381 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 22, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-240786181 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/pull/27791#pullrequestreview-240786181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| src/node_api.cc | https://github.com/nodejs/node/pull/27791/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 22, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-494924760 |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node/compare/7bfb88fa7822ba932a8d7f1ecd95826cc83de324..b985dd269ced7ac08d3d798806fb3b6fb44d8ae2 |
| 7bfb88f | https://github.com/nodejs/node/commit/7bfb88fa7822ba932a8d7f1ecd95826cc83de324 |
| b985dd2 | https://github.com/nodejs/node/commit/b985dd269ced7ac08d3d798806fb3b6fb44d8ae2 |
|
Compare
| https://github.com/nodejs/node/compare/7bfb88fa7822ba932a8d7f1ecd95826cc83de324..b985dd269ced7ac08d3d798806fb3b6fb44d8ae2 |
| May 24, 2019 07:11 | https://github.com/nodejs/node/pull/27791#event-2364595448 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 26, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-242051137 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 26, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-242051361 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/nodejs/node/pull/27791#pullrequestreview-242051361 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node/compare/bc653a9155046e358ff57999c5845cd46787c0c5..4142960f017e31f0e8bd7066d063651e6d74fee9 |
| bc653a9 | https://github.com/nodejs/node/commit/bc653a9155046e358ff57999c5845cd46787c0c5 |
| 4142960 | https://github.com/nodejs/node/commit/4142960f017e31f0e8bd7066d063651e6d74fee9 |
|
Compare
| https://github.com/nodejs/node/compare/bc653a9155046e358ff57999c5845cd46787c0c5..4142960f017e31f0e8bd7066d063651e6d74fee9 |
| May 27, 2019 01:06 | https://github.com/nodejs/node/pull/27791#event-2368102546 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 27, 2019 | https://github.com/nodejs/node/pull/27791#issuecomment-496048685 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| stale review | https://github.com/nodejs/node/pull/27791#pullrequestreview-242051361 |
| May 28, 2019 20:51 | https://github.com/nodejs/node/pull/27791#event-2373104053 |
| @Trott | https://github.com/Trott |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 28, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-242915787 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 28, 2019 | https://github.com/nodejs/node/pull/27791#event-2373112104 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node/compare/4142960f017e31f0e8bd7066d063651e6d74fee9..af66250b77eabd1776139dff8238af7d2d13a53d |
| 4142960 | https://github.com/nodejs/node/commit/4142960f017e31f0e8bd7066d063651e6d74fee9 |
| af66250 | https://github.com/nodejs/node/commit/af66250b77eabd1776139dff8238af7d2d13a53d |
|
Compare
| https://github.com/nodejs/node/compare/4142960f017e31f0e8bd7066d063651e6d74fee9..af66250b77eabd1776139dff8238af7d2d13a53d |
| May 29, 2019 05:37 | https://github.com/nodejs/node/pull/27791#event-2373903886 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 30, 2019
| https://github.com/nodejs/node/pull/27791#pullrequestreview-243973467 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27791/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27791/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 24, 2019
| https://github.com/nodejs/node/pull/27791#ref-pullrequest-459643077 |
|
[v8.x] n-api: make func argument of napi_create_threadsafe_function optional
#28400
| https://github.com/nodejs/node/pull/28400 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 24, 2019
| https://github.com/nodejs/node/pull/27791#ref-pullrequest-460121583 |
|
doc,n-api: fix metadata for napi_create_threadsafe_function
#28410
| https://github.com/nodejs/node/pull/28410 |
| richardlau | https://github.com/richardlau |
|
Jun 24, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-88db3e4 |
|
| https://github.com/richardlau |
| doc,n-api: fix metadata for napi_create_threadsafe_function | https://github.com/richardlau/node-1/commit/88db3e431f56bb5e068080e3f9303878f5bcf985 |
| 88db3e4 | https://github.com/richardlau/node-1/commit/88db3e431f56bb5e068080e3f9303878f5bcf985 |
| nodejs#28410 | https://github.com/nodejs/node/pull/28410 |
| nodejs#27791 | https://github.com/nodejs/node/pull/27791 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-53297e6 |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| n-api: make func argument of napi_create_threadsafe_function optional | https://github.com/nodejs/node/commit/53297e66cb61c80916664d97888dd5d25d0c790e |
| 53297e6 | https://github.com/nodejs/node/commit/53297e66cb61c80916664d97888dd5d25d0c790e |
| #27791 | https://github.com/nodejs/node/pull/27791 |
| #27592 | https://github.com/nodejs/node/issues/27592 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-91d5a4d |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
| doc,n-api: fix metadata for napi_create_threadsafe_function | https://github.com/nodejs/node/commit/91d5a4df040cf9ad1816f42d4a08f3f03c759794 |
| 91d5a4d | https://github.com/nodejs/node/commit/91d5a4df040cf9ad1816f42d4a08f3f03c759794 |
| #28410 | https://github.com/nodejs/node/pull/28410 |
| #27791 | https://github.com/nodejs/node/pull/27791 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/27791#ref-pullrequest-463146264 |
|
Release v12.6.0 proposal
#28508
| https://github.com/nodejs/node/pull/28508 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Jul 3, 2019
| https://github.com/nodejs/node/pull/27791#ref-issue-463801628 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#288
| https://github.com/beevelop/docker-nodejs/issues/288 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 3, 2019
| https://github.com/nodejs/node/pull/27791#ref-issue-441028750 |
|
napi_create_threadsafe_function func should be optional
#27592
| https://github.com/nodejs/node/issues/27592 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#289
| https://github.com/beevelop/docker-nodejs/issues/289 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#290
| https://github.com/beevelop/docker-nodejs/issues/290 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 2, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-d0a05d0 |
|
| https://github.com/legendecas |
| n-api: make func argument of napi_create_threadsafe_function optional | https://github.com/gabrielschulhof/node/commit/d0a05d061d69cd8a3f63cdf91826932765e3c719 |
| d0a05d0 | https://github.com/gabrielschulhof/node/commit/d0a05d061d69cd8a3f63cdf91826932765e3c719 |
| nodejs#27791 | https://github.com/nodejs/node/pull/27791 |
| nodejs#27592 | https://github.com/nodejs/node/issues/27592 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Sep 3, 2019 | https://github.com/nodejs/node/pull/27791#event-2604012755 |
| https://github.com/marco-ms |
| marco-ms | https://github.com/marco-ms |
|
Sep 9, 2019
| https://github.com/nodejs/node/pull/27791#ref-issue-490597810 |
|
Question about ThreadSafeFunction
nodejs/node-addon-api#536
| https://github.com/nodejs/node-addon-api/issues/536 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Sep 17, 2019
| https://github.com/nodejs/node/pull/27791#ref-issue-494718169 |
|
Add example/api to use ThreadSafeFunction with optional callback param
nodejs/node-addon-api#544
| https://github.com/nodejs/node-addon-api/issues/544 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 19, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-116f8ec |
|
| https://github.com/legendecas |
| n-api: make func argument of napi_create_threadsafe_function optional | https://github.com/gabrielschulhof/node/commit/116f8ecb47175c3468d10fd76c6708d27ac7f58f |
| 116f8ec | https://github.com/gabrielschulhof/node/commit/116f8ecb47175c3468d10fd76c6708d27ac7f58f |
| nodejs#27791 | https://github.com/nodejs/node/pull/27791 |
| nodejs#27592 | https://github.com/nodejs/node/issues/27592 |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-f862276 |
|
| https://github.com/legendecas |
|
| https://github.com/BethGriggs |
| n-api: make func argument of napi_create_threadsafe_function optional | https://github.com/nodejs/node/commit/f8622762e37f6b6881db1b4ce5d4392b9d233e4a |
| f862276 | https://github.com/nodejs/node/commit/f8622762e37f6b6881db1b4ce5d4392b9d233e4a |
| #27791 | https://github.com/nodejs/node/pull/27791 |
| #28399 | https://github.com/nodejs/node/pull/28399 |
| #27592 | https://github.com/nodejs/node/issues/27592 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/27791#event-2692161899 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/27791#ref-pullrequest-503572635 |
|
v10.17.0 proposal
#29875
| https://github.com/nodejs/node/pull/29875 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-5dae3ef |
|
| https://github.com/BethGriggs |
| 2019-10-22, Version 10.17.0 'Dubnium' (LTS) | https://github.com/nodejs/node/commit/5dae3ef88bea3bb2e37ea68cafc5795da1406e76 |
| 5dae3ef | https://github.com/nodejs/node/commit/5dae3ef88bea3bb2e37ea68cafc5795da1406e76 |
| #24081 | https://github.com/nodejs/node/pull/24081 |
| #28799 | https://github.com/nodejs/node/pull/28799 |
| #29430 | https://github.com/nodejs/node/pull/29430 |
| #29921 | https://github.com/nodejs/node/pull/29921 |
| #26592 | https://github.com/nodejs/node/pull/26592 |
| #26581 | https://github.com/nodejs/node/pull/26581 |
| #25974 | https://github.com/nodejs/node/pull/25974 |
| #25974 | https://github.com/nodejs/node/pull/25974 |
| #27791 | https://github.com/nodejs/node/pull/27791 |
| #29401 | https://github.com/nodejs/node/pull/29401 |
| #25917 | https://github.com/nodejs/node/pull/25917 |
| #26599 | https://github.com/nodejs/node/pull/26599 |
| #27660 | https://github.com/nodejs/node/pull/27660 |
| #26989 | https://github.com/nodejs/node/pull/26989 |
| #29875 | https://github.com/nodejs/node/pull/29875 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/27791#ref-commit-afbbcb0 |
|
| https://github.com/BethGriggs |
| 2019-10-22, Version 10.17.0 'Dubnium' (LTS) | https://github.com/nodejs/node/commit/afbbcb050e0c1db9c6fc17fb0140680ac00f37e8 |
| afbbcb0 | https://github.com/nodejs/node/commit/afbbcb050e0c1db9c6fc17fb0140680ac00f37e8 |
| #24081 | https://github.com/nodejs/node/pull/24081 |
| #28799 | https://github.com/nodejs/node/pull/28799 |
| #29430 | https://github.com/nodejs/node/pull/29430 |
| #29921 | https://github.com/nodejs/node/pull/29921 |
| #26592 | https://github.com/nodejs/node/pull/26592 |
| #26581 | https://github.com/nodejs/node/pull/26581 |
| #25974 | https://github.com/nodejs/node/pull/25974 |
| #25974 | https://github.com/nodejs/node/pull/25974 |
| #27791 | https://github.com/nodejs/node/pull/27791 |
| #29401 | https://github.com/nodejs/node/pull/29401 |
| #25917 | https://github.com/nodejs/node/pull/25917 |
| #26599 | https://github.com/nodejs/node/pull/26599 |
| #27660 | https://github.com/nodejs/node/pull/27660 |
| #26989 | https://github.com/nodejs/node/pull/26989 |
| #29875 | https://github.com/nodejs/node/pull/29875 |
| https://github.com/williamluke4 |
| williamluke4 | https://github.com/williamluke4 |
|
Aug 16, 2021
| https://github.com/nodejs/node/pull/27791#ref-issue-918987159 |
|
Unexpected UnhandledPromiseRejectionWarning with Node-API library on Node 12.2.0 on Ubuntu
prisma/prisma#7621
| https://github.com/prisma/prisma/issues/7621 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27791 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/27791/files/dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27791/files/dc0cb8e6175e0ba8825cdab0be2197c189c934bf |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/27791/files/6b30a687656aac9ef90087b93e017b47984dfaf7 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/27791 |
|
| https://github.com/legendecas |
|
| https://github.com/josephg |
|
| https://github.com/addaleax |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |