René's URL Explorer Experiment


Title: tls: set tlsSocket.servername as early as possible by oyyd · Pull Request #27759 · nodejs/node · GitHub

Open Graph Title: tls: set tlsSocket.servername as early as possible by oyyd · Pull Request #27759 · nodejs/node

X Title: tls: set tlsSocket.servername as early as possible by oyyd · Pull Request #27759 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit makes TLSSocket set the servername property on SSL_CTX_set_tlsext_servername_callback so that we could get it later even if errors happen. Fixes: #27699 Checklist make -j4 test (UNI...

X Description: This commit makes TLSSocket set the servername property on SSL_CTX_set_tlsext_servername_callback so that we could get it later even if errors happen. Fixes: #27699 Checklist make -j4 test (UNI...

Opengraph URL: https://github.com/nodejs/node/pull/27759

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:75477946-afed-2762-8d33-e9e832d2f7af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD56:CD446:B1468B:FA2575:6A4E86D1
html-safe-noncefae63b9cb4fbb14c8cab65a8e852ad11d2b67d509939dc4fa5883650908b4dcf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDU2OkNENDQ2OkIxNDY4QjpGQTI1NzU6NkE0RTg2RDEiLCJ2aXNpdG9yX2lkIjoiNjY5MzQyMDI5MDIwOTEyMjAwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacab4658978203ff59919c08f3687af03e0f7f4db37bfd8ef0880c120a96fd5cbb
hovercard-subject-tagpull_request:280095518
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27759/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f42891f904b96aa96322dae61a327f4ae592e237a571b4b21b81735dac531465/nodejs/node/pull/27759
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f42891f904b96aa96322dae61a327f4ae592e237a571b4b21b81735dac531465/nodejs/node/pull/27759
og:image:altThis commit makes TLSSocket set the servername property on SSL_CTX_set_tlsext_servername_callback so that we could get it later even if errors happen. Fixes: #27699 Checklist make -j4 test (UNI...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoyyd
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27759#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27759
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27759
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27759
Reloadhttps://github.com/nodejs/node/pull/27759
Reloadhttps://github.com/nodejs/node/pull/27759
Please reload this pagehttps://github.com/nodejs/node/pull/27759
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27759
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
oyydhttps://github.com/oyyd
nodejs:masterhttps://github.com/nodejs/node/tree/master
oyyd:tls-servernamehttps://github.com/oyyd/node/tree/tls-servername
Conversationhttps://github.com/nodejs/node/pull/27759
Commits2 (2)https://github.com/nodejs/node/pull/27759/commits
Checkshttps://github.com/nodejs/node/pull/27759/checks
Files changedhttps://github.com/nodejs/node/pull/27759/files
tls: set tlsSocket.servername as early as possiblehttps://github.com/nodejs/node/pull/27759#top
oyydhttps://github.com/oyyd
nodejs:masterhttps://github.com/nodejs/node/tree/master
oyyd:tls-servernamehttps://github.com/oyyd/node/tree/tls-servername
https://github.com/oyyd
oyydhttps://github.com/oyyd
May 18, 2019https://github.com/nodejs/node/pull/27759#issue-445706647
#27699https://github.com/nodejs/node/issues/27699
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/oyyd
tls: set tlsSocket.servername as early as possiblehttps://github.com/nodejs/node/pull/27759/commits/cfb88988938b1e9bbe05ba7ec570e94d3daaa035
cfb8898https://github.com/nodejs/node/pull/27759/commits/cfb88988938b1e9bbe05ba7ec570e94d3daaa035
nodejs#27699https://github.com/nodejs/node/issues/27699
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 18, 2019https://github.com/nodejs/node/pull/27759#issuecomment-493669727
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3559https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3559
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
May 18, 2019https://github.com/nodejs/node/pull/27759#event-2350929378
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 18, 2019 https://github.com/nodejs/node/pull/27759#pullrequestreview-239197004
View reviewed changes https://github.com/nodejs/node/pull/27759/files/cfb88988938b1e9bbe05ba7ec570e94d3daaa035
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27759#pullrequestreview-239197004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27759
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/27759/files/cfb88988938b1e9bbe05ba7ec570e94d3daaa035#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
bnoordhuishttps://github.com/bnoordhuis
May 18, 2019https://github.com/nodejs/node/pull/27759#discussion_r285340802
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27759
oyydhttps://github.com/oyyd
May 19, 2019https://github.com/nodejs/node/pull/27759#discussion_r285362059
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27759
src/tls_wrap.cchttps://github.com/nodejs/node/pull/27759/files/cfb88988938b1e9bbe05ba7ec570e94d3daaa035#diff-9a26c15dbc849b7d50bca401da5a640629db383c5ec6b7d3668af529afd1383d
bnoordhuishttps://github.com/bnoordhuis
May 18, 2019https://github.com/nodejs/node/pull/27759#discussion_r285340990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27759
oyydhttps://github.com/oyyd
May 19, 2019https://github.com/nodejs/node/pull/27759#discussion_r285362132
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/oyyd
fixup! tls: set tlsSocket.servername as early as possiblehttps://github.com/nodejs/node/pull/27759/commits/44f2e3d75a42a305d3b93f2afccd1ad928630a51
44f2e3dhttps://github.com/nodejs/node/pull/27759/commits/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2019https://github.com/nodejs/node/pull/27759#issuecomment-493722785
https://ci.nodejs.org/job/node-test-pull-request/23191/https://ci.nodejs.org/job/node-test-pull-request/23191/
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/oyyd
oyydhttps://github.com/oyyd
May 19, 2019https://github.com/nodejs/node/pull/27759#issuecomment-493722815
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2019https://github.com/nodejs/node/pull/27759#issuecomment-493733959
https://ci.nodejs.org/job/node-test-pull-request/23194/https://ci.nodejs.org/job/node-test-pull-request/23194/
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2019 https://github.com/nodejs/node/pull/27759#pullrequestreview-239233865
View reviewed changes https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 20, 2019https://github.com/nodejs/node/pull/27759#issuecomment-493819942
https://ci.nodejs.org/job/node-test-pull-request/23219/https://ci.nodejs.org/job/node-test-pull-request/23219/
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/Trott
Trotthttps://github.com/Trott
May 20, 2019 https://github.com/nodejs/node/pull/27759#pullrequestreview-239662383
View reviewed changes https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 20, 2019 https://github.com/nodejs/node/pull/27759#pullrequestreview-239745955
View reviewed changes https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 21, 2019 https://github.com/nodejs/node/pull/27759#pullrequestreview-240335138
View reviewed changes https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/danbev
danbevhttps://github.com/danbev
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 22, 2019https://github.com/nodejs/node/pull/27759#event-2358009744
oyydhttps://github.com/oyyd
May 23, 2019 https://github.com/nodejs/node/pull/27759#ref-commit-d2cabee
https://github.com/oyyd
tls: set tlsSocket.servername as early as possiblehttps://github.com/oyyd/node/commit/d2cabee64c60a7d6e2023dfb60c26cb66dc2eaa4
d2cabeehttps://github.com/oyyd/node/commit/d2cabee64c60a7d6e2023dfb60c26cb66dc2eaa4
nodejs#27699https://github.com/nodejs/node/issues/27699
nodejs#27759https://github.com/nodejs/node/pull/27759
https://github.com/oyyd
oyydhttps://github.com/oyyd
May 23, 2019https://github.com/nodejs/node/pull/27759#issuecomment-495045957
d2cabeehttps://github.com/nodejs/node/commit/d2cabee64c60a7d6e2023dfb60c26cb66dc2eaa4
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/oyyd
oyydhttps://github.com/oyyd
May 23, 2019https://github.com/nodejs/node/pull/27759#event-2361099205
targoshttps://github.com/targos
May 23, 2019 https://github.com/nodejs/node/pull/27759#ref-commit-4716caa
https://github.com/oyyd
https://github.com/targos
tls: set tlsSocket.servername as early as possiblehttps://github.com/nodejs/node/commit/4716caa12e1ca61c8cb66a494499ad8c8370903b
4716caahttps://github.com/nodejs/node/commit/4716caa12e1ca61c8cb66a494499ad8c8370903b
#27699https://github.com/nodejs/node/issues/27699
#27759https://github.com/nodejs/node/pull/27759
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27759#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Oct 8, 2019 https://github.com/nodejs/node/pull/27759#ref-issue-503976615
Expose whether a TLS server requested a client certificate #29882 https://github.com/nodejs/node/issues/29882
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27759
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27759/files/cfb88988938b1e9bbe05ba7ec570e94d3daaa035
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/27759/files/44f2e3d75a42a305d3b93f2afccd1ad928630a51
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Servername is not set on TLS sockets if there is a TLS client error https://github.com/nodejs/node/issues/27699
Please reload this pagehttps://github.com/nodejs/node/pull/27759
https://github.com/oyyd
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/bnoordhuis
https://github.com/Trott
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/danbev
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.