René's URL Explorer Experiment


Title: http: always call response.write() callback by lpinca · Pull Request #27709 · nodejs/node · GitHub

Open Graph Title: http: always call response.write() callback by lpinca · Pull Request #27709 · nodejs/node

X Title: http: always call response.write() callback by lpinca · Pull Request #27709 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Ensure that the callback of OutgoingMessage.prototype.write() is called even when writing empty chunks. Fixes: #22066 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

X Description: Ensure that the callback of OutgoingMessage.prototype.write() is called even when writing empty chunks. Fixes: #22066 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

Opengraph URL: https://github.com/nodejs/node/pull/27709

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6601e90-c9f2-433e-6049-68e73f50b764
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCF6:446DE:1479D4B:1DB1489:6A4FAFFC
html-safe-noncec50c3bb96bd74cb3ed9f71100f2b7db4e9e532a512431b217663d974eae49451
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0Y2OjQ0NkRFOjE0NzlENEI6MURCMTQ4OTo2QTRGQUZGQyIsInZpc2l0b3JfaWQiOiI2MjA5NTA1NTU2MTY5NzMyMDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac421a9c6238ea0ee34edc357bea2e1038d70818f7ac130c980ab3c291d9ca5063
hovercard-subject-tagpull_request:278951124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27709/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b731439456879f603d3f4e50818b76b122218fe251f7651dfb5e67699e819d4e/nodejs/node/pull/27709
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b731439456879f603d3f4e50818b76b122218fe251f7651dfb5e67699e819d4e/nodejs/node/pull/27709
og:image:altEnsure that the callback of OutgoingMessage.prototype.write() is called even when writing empty chunks. Fixes: #22066 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27709#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27709
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27709
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27709
Reloadhttps://github.com/nodejs/node/pull/27709
Reloadhttps://github.com/nodejs/node/pull/27709
Please reload this pagehttps://github.com/nodejs/node/pull/27709
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27709
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-22066https://github.com/lpinca/node/tree/gh-22066
Conversationhttps://github.com/nodejs/node/pull/27709
Commits1 (1)https://github.com/nodejs/node/pull/27709/commits
Checkshttps://github.com/nodejs/node/pull/27709/checks
Files changedhttps://github.com/nodejs/node/pull/27709/files
http: always call response.write() callbackhttps://github.com/nodejs/node/pull/27709#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-22066https://github.com/lpinca/node/tree/gh-22066
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 15, 2019https://github.com/nodejs/node/pull/27709#issue-444254910
#22066https://github.com/nodejs/node/issues/22066
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/lpinca
http: always call response.write() callbackhttps://github.com/nodejs/node/pull/27709/commits/57b29882285ddb3502c5b86e942c0c917db5a8b8
57b2988https://github.com/nodejs/node/pull/27709/commits/57b29882285ddb3502c5b86e942c0c917db5a8b8
nodejs#22066https://github.com/nodejs/node/issues/22066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2019https://github.com/nodejs/node/pull/27709#issuecomment-492518952
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3527https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3527
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
May 15, 2019https://github.com/nodejs/node/pull/27709#event-2342197673
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 15, 2019https://github.com/nodejs/node/pull/27709#issuecomment-492530335
#22066https://github.com/nodejs/node/issues/22066
node/lib/_http_outgoing.jshttps://github.com/nodejs/node/blob/53bef423f31bb383212a6754228c21ca3d3231b6/lib/_http_outgoing.js#L714
53bef42https://github.com/nodejs/node/commit/53bef423f31bb383212a6754228c21ca3d3231b6
node/lib/net.jshttps://github.com/nodejs/node/blob/53bef423f31bb383212a6754228c21ca3d3231b6/lib/net.js#L696
53bef42https://github.com/nodejs/node/commit/53bef423f31bb383212a6754228c21ca3d3231b6
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2019 https://github.com/nodejs/node/pull/27709#pullrequestreview-238034781
View reviewed changes https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/27709#pullrequestreview-238034781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/Trott
Trotthttps://github.com/Trott
May 18, 2019 https://github.com/nodejs/node/pull/27709#pullrequestreview-239183546
View reviewed changes https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 18, 2019https://github.com/nodejs/node/pull/27709#event-2350782693
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 18, 2019https://github.com/nodejs/node/pull/27709#issuecomment-493646149
https://ci.nodejs.org/job/node-test-pull-request/23181/https://ci.nodejs.org/job/node-test-pull-request/23181/
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2019https://github.com/nodejs/node/pull/27709#issuecomment-493728162
https://ci.nodejs.org/job/node-test-pull-request/23193/https://ci.nodejs.org/job/node-test-pull-request/23193/
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2019https://github.com/nodejs/node/pull/27709#issuecomment-493749940
https://ci.nodejs.org/job/node-test-pull-request/23195/https://ci.nodejs.org/job/node-test-pull-request/23195/
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2019https://github.com/nodejs/node/pull/27709#issuecomment-493791610
https://ci.nodejs.org/job/node-test-pull-request/23214/https://ci.nodejs.org/job/node-test-pull-request/23214/
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2019 https://github.com/nodejs/node/pull/27709#pullrequestreview-239255431
View reviewed changes https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2019https://github.com/nodejs/node/pull/27709#issuecomment-493795885
0df581chttps://github.com/nodejs/node/commit/0df581c30728fae75405e7aa66102d98571cec87
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2019https://github.com/nodejs/node/pull/27709#event-2351659976
addaleaxhttps://github.com/addaleax
May 19, 2019 https://github.com/nodejs/node/pull/27709#ref-commit-0df581c
https://github.com/lpinca
https://github.com/addaleax
http: always call response.write() callbackhttps://github.com/nodejs/node/commit/0df581c30728fae75405e7aa66102d98571cec87
0df581chttps://github.com/nodejs/node/commit/0df581c30728fae75405e7aa66102d98571cec87
#22066https://github.com/nodejs/node/issues/22066
#27709https://github.com/nodejs/node/pull/27709
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 20, 2019 05:19https://github.com/nodejs/node/pull/27709#event-2351967341
lpincahttps://github.com/lpinca
May 20, 2019 https://github.com/nodejs/node/pull/27709#ref-commit-1b8ef7d
https://github.com/lpinca
http: call write callback even if there is no message bodyhttps://github.com/lpinca/node/commit/1b8ef7da01b0eb6d8a96747f1468394e511f4545
1b8ef7dhttps://github.com/lpinca/node/commit/1b8ef7da01b0eb6d8a96747f1468394e511f4545
nodejs#27709https://github.com/nodejs/node/pull/27709
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 20, 2019 https://github.com/nodejs/node/pull/27709#ref-pullrequest-445995533
http: call write callback even if there is no message body #27777 https://github.com/nodejs/node/pull/27777
targoshttps://github.com/targos
May 20, 2019 https://github.com/nodejs/node/pull/27709#ref-commit-206ae31
https://github.com/lpinca
https://github.com/targos
http: always call response.write() callbackhttps://github.com/nodejs/node/commit/206ae31a7ecc01b9e3a4d42e765efc50e85430d1
206ae31https://github.com/nodejs/node/commit/206ae31a7ecc01b9e3a4d42e765efc50e85430d1
#22066https://github.com/nodejs/node/issues/22066
#27709https://github.com/nodejs/node/pull/27709
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019 https://github.com/nodejs/node/pull/27709#ref-pullrequest-446555712
v12.3.0 proposal #27799 https://github.com/nodejs/node/pull/27799
Trotthttps://github.com/Trott
Jun 1, 2019 https://github.com/nodejs/node/pull/27709#ref-commit-2a850cd
https://github.com/lpinca
https://github.com/Trott
http: call write callback even if there is no message bodyhttps://github.com/Trott/io.js/commit/2a850cd0664a4eee51f44d0bb8c2f7a3fe444154
2a850cdhttps://github.com/Trott/io.js/commit/2a850cd0664a4eee51f44d0bb8c2f7a3fe444154
nodejs#27709https://github.com/nodejs/node/pull/27709
nodejs#27777https://github.com/nodejs/node/pull/27777
targoshttps://github.com/targos
Jun 1, 2019 https://github.com/nodejs/node/pull/27709#ref-commit-8b38dfb
https://github.com/lpinca
https://github.com/targos
http: call write callback even if there is no message bodyhttps://github.com/nodejs/node/commit/8b38dfbf39f4ed26c9f546fa8673a9568786b5c0
8b38dfbhttps://github.com/nodejs/node/commit/8b38dfbf39f4ed26c9f546fa8673a9568786b5c0
#27709https://github.com/nodejs/node/pull/27709
#27777https://github.com/nodejs/node/pull/27777
https://github.com/awwright
awwrighthttps://github.com/awwright
Sep 20, 2019 https://github.com/nodejs/node/pull/27709#ref-issue-495521369
HTTP parser premature close #29609 https://github.com/nodejs/node/issues/29609
https://github.com/awwright
awwrighthttps://github.com/awwright
Sep 24, 2019https://github.com/nodejs/node/pull/27709#issuecomment-534422860
Please reload this pagehttps://github.com/nodejs/node/pull/27709
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 24, 2019https://github.com/nodejs/node/pull/27709#issuecomment-534461088
@awwrighthttps://github.com/awwright
#22066 (comment)https://github.com/nodejs/node/issues/22066#issuecomment-415971148
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/awwright
awwrighthttps://github.com/awwright
Sep 26, 2019https://github.com/nodejs/node/pull/27709#issuecomment-535697812
#22066 (comment)https://github.com/nodejs/node/issues/22066#issuecomment-415971148
#29649https://github.com/nodejs/node/pull/29649
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 10, 2021 https://github.com/nodejs/node/pull/27709#ref-issue-826588684
Performance issue when sending large responses for concurrent requests #37680 https://github.com/nodejs/node/issues/37680
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27709
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27709/files/57b29882285ddb3502c5b86e942c0c917db5a8b8
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
http: Stream#write with an empty buffer does not call callback https://github.com/nodejs/node/issues/22066
Please reload this pagehttps://github.com/nodejs/node/pull/27709
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/awwright
https://github.com/jasnell
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.