René's URL Explorer Experiment


Title: tools: force common be required before any other modules by ZYSzys · Pull Request #27650 · nodejs/node · GitHub

Open Graph Title: tools: force common be required before any other modules by ZYSzys · Pull Request #27650 · nodejs/node

X Title: tools: force common be required before any other modules by ZYSzys · Pull Request #27650 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Add a new eslint rule require-common-first to enforce common be loaded in tests before any other modules. The common module should be required in tests before any other module: https://github.com/...

X Description: Add a new eslint rule require-common-first to enforce common be loaded in tests before any other modules. The common module should be required in tests before any other module: https://github.com/...

Opengraph URL: https://github.com/nodejs/node/pull/27650

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3d043e27-a26b-a790-4ca0-e10976f52b69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB736:16CCCC:1C7233D:26F9B0E:6A4F25AA
html-safe-noncee493fc79760804ee2e12321c903e8aef6f4eced5a58e0e047b9338c5106ed024
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzM2OjE2Q0NDQzoxQzcyMzNEOjI2RjlCMEU6NkE0RjI1QUEiLCJ2aXNpdG9yX2lkIjoiOTAyMDE5MjY4MzY0NjE5OTIxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac78810be97f2436653975db4f93db2b43d33ec521a0bd10c7ed51159f87a8447f
hovercard-subject-tagpull_request:277972034
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27650/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d7f04d37c7240dc609b6e64a923fc7c143359b68284a74a72d1bd27eece6ff87/nodejs/node/pull/27650
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d7f04d37c7240dc609b6e64a923fc7c143359b68284a74a72d1bd27eece6ff87/nodejs/node/pull/27650
og:image:altAdd a new eslint rule require-common-first to enforce common be loaded in tests before any other modules. The common module should be required in tests before any other module: https://github.com/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27650#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27650
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27650
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27650
Reloadhttps://github.com/nodejs/node/pull/27650
Reloadhttps://github.com/nodejs/node/pull/27650
Please reload this pagehttps://github.com/nodejs/node/pull/27650
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27650
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/27650
Commits2 (2)https://github.com/nodejs/node/pull/27650/commits
Checkshttps://github.com/nodejs/node/pull/27650/checks
Files changedhttps://github.com/nodejs/node/pull/27650/files
tools: force common be required before any other moduleshttps://github.com/nodejs/node/pull/27650#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 11, 2019https://github.com/nodejs/node/pull/27650#issue-442979469
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-1-3https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-1-3
#27455 (comment)https://github.com/nodejs/node/pull/27455#discussion_r279222145
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27650
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
May 11, 2019https://github.com/nodejs/node/pull/27650#event-2334695781
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27650
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 11, 2019 https://github.com/nodejs/node/pull/27650#pullrequestreview-236376318
View reviewed changes https://github.com/nodejs/node/pull/27650/files
tools/eslint-rules/required-modules.jshttps://github.com/nodejs/node/pull/27650/files#diff-07e267d94ff25b5deaf5a1d7fee93a79344a64858da5cb770688cb87de393947
lpincahttps://github.com/lpinca
May 11, 2019https://github.com/nodejs/node/pull/27650#discussion_r283095575
Please reload this pagehttps://github.com/nodejs/node/pull/27650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27650
ZYSzyshttps://github.com/ZYSzys
May 11, 2019https://github.com/nodejs/node/pull/27650#discussion_r283096409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/test/.eslintrc.yamlhttps://github.com/nodejs/node/blob/56ab82e9106f87512f18a5c80be6cc0a26bda66a/test/.eslintrc.yaml#L23-L24
56ab82ehttps://github.com/nodejs/node/commit/56ab82e9106f87512f18a5c80be6cc0a26bda66a
Please reload this pagehttps://github.com/nodejs/node/pull/27650
lpincahttps://github.com/lpinca
May 11, 2019https://github.com/nodejs/node/pull/27650#discussion_r283096665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/27650
Trotthttps://github.com/Trott
May 12, 2019https://github.com/nodejs/node/pull/27650#discussion_r283151040
Please reload this pagehttps://github.com/nodejs/node/pull/27650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27650
ZYSzyshttps://github.com/ZYSzys
May 13, 2019https://github.com/nodejs/node/pull/27650#discussion_r283163695
Please reload this pagehttps://github.com/nodejs/node/pull/27650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
tools: force common be required before any other moduleshttps://github.com/nodejs/node/pull/27650/commits/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
0f9918bhttps://github.com/nodejs/node/pull/27650/commits/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
https://github.com/Trott
Trotthttps://github.com/Trott
May 12, 2019 https://github.com/nodejs/node/pull/27650#pullrequestreview-236433188
View reviewed changes https://github.com/nodejs/node/pull/27650/files/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 12, 2019 https://github.com/nodejs/node/pull/27650#pullrequestreview-236434517
View reviewed changes https://github.com/nodejs/node/pull/27650/files/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
tools/eslint-rules/require-common-first.jshttps://github.com/nodejs/node/pull/27650/files/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8#diff-f882c219dfbc1052f9ae15aac92bf0207cd7c32530ce9bd41e447bb79a4466af
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
fixup! tools: force common be required before any other moduleshttps://github.com/nodejs/node/pull/27650/commits/e7850e7caed9b71e1aad0b46693811aa54865ed4
e7850e7https://github.com/nodejs/node/pull/27650/commits/e7850e7caed9b71e1aad0b46693811aa54865ed4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2019https://github.com/nodejs/node/pull/27650#issuecomment-491644306
https://ci.nodejs.org/job/node-test-pull-request/23071/https://ci.nodejs.org/job/node-test-pull-request/23071/
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 13, 2019 https://github.com/nodejs/node/pull/27650#pullrequestreview-236533872
View reviewed changes https://github.com/nodejs/node/pull/27650/files/e7850e7caed9b71e1aad0b46693811aa54865ed4
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 13, 2019https://github.com/nodejs/node/pull/27650#event-2336133061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2019https://github.com/nodejs/node/pull/27650#issuecomment-491737489
https://ci.nodejs.org/job/node-test-pull-request/23081/https://ci.nodejs.org/job/node-test-pull-request/23081/
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 13, 2019https://github.com/nodejs/node/pull/27650#issuecomment-491787871
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 13, 2019https://github.com/nodejs/node/pull/27650#event-2336656630
ZYSzyshttps://github.com/ZYSzys
May 13, 2019 https://github.com/nodejs/node/pull/27650#ref-commit-dcc5e51
https://github.com/ZYSzys
tools: force common be required before any other moduleshttps://github.com/nodejs/node/commit/dcc5e51e1cb4e102effd7fc515681446b07e428e
dcc5e51https://github.com/nodejs/node/commit/dcc5e51e1cb4e102effd7fc515681446b07e428e
#27650https://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 13, 2019 12:02https://github.com/nodejs/node/pull/27650#event-2336710017
targoshttps://github.com/targos
May 13, 2019 https://github.com/nodejs/node/pull/27650#ref-commit-169ddc5
https://github.com/ZYSzys
https://github.com/targos
tools: force common be required before any other moduleshttps://github.com/nodejs/node/commit/169ddc509760b56b376f26d3c68c18f2bea37d3e
169ddc5https://github.com/nodejs/node/commit/169ddc509760b56b376f26d3c68c18f2bea37d3e
#27650https://github.com/nodejs/node/pull/27650
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019 https://github.com/nodejs/node/pull/27650#ref-pullrequest-446555712
v12.3.0 proposal #27799 https://github.com/nodejs/node/pull/27799
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27650
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27650/files/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27650/files/0f9918b8caddf44f80cf134a786fc1eceb7a8cf8
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27650/files/e7850e7caed9b71e1aad0b46693811aa54865ed4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/27650
https://github.com/ZYSzys
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.