René's URL Explorer Experiment


Title: tools: allow RegExp in required-modules eslint rule by richardlau · Pull Request #27647 · nodejs/node · GitHub

Open Graph Title: tools: allow RegExp in required-modules eslint rule by richardlau · Pull Request #27647 · nodejs/node

X Title: tools: allow RegExp in required-modules eslint rule by richardlau · Pull Request #27647 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #27545 (review) The fixup commit is to tidy up the error message when the lint rule fails (kept separate here for ease of reviewing) and should be autosquashed on landing. Checklist make ...

X Description: Refs: #27545 (review) The fixup commit is to tidy up the error message when the lint rule fails (kept separate here for ease of reviewing) and should be autosquashed on landing. Checklist make ...

Opengraph URL: https://github.com/nodejs/node/pull/27647

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:21896d3c-67d9-1748-fea3-43c6718b764f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD26C:22EFAB:B491CB:107342C:6A4E1C43
html-safe-nonce9d45912a596829be2da24e72f380f60dde591751fcd2196a0bf5e47ab6fee9ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZDOjIyRUZBQjpCNDkxQ0I6MTA3MzQyQzo2QTRFMUM0MyIsInZpc2l0b3JfaWQiOiIxMzEwNzMwNjUyMjI4NjU2MTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b338d10ffa7fd185789b1b667c7d669650d142d9547c2cd3ac1fa14f16b6f33
hovercard-subject-tagpull_request:277951975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27647/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d09879b9d3bc5a97ccbe0d5a6f6f43d59aed5a86071be17bb28a13b9977ad217/nodejs/node/pull/27647
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d09879b9d3bc5a97ccbe0d5a6f6f43d59aed5a86071be17bb28a13b9977ad217/nodejs/node/pull/27647
og:image:altRefs: #27545 (review) The fixup commit is to tidy up the error message when the lint rule fails (kept separate here for ease of reviewing) and should be autosquashed on landing. Checklist make ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27647#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27647
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27647
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27647
Reloadhttps://github.com/nodejs/node/pull/27647
Reloadhttps://github.com/nodejs/node/pull/27647
Please reload this pagehttps://github.com/nodejs/node/pull/27647
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27647
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:eslint-required-modules-regexphttps://github.com/richardlau/node-1/tree/eslint-required-modules-regexp
Conversationhttps://github.com/nodejs/node/pull/27647
Commits1 (1)https://github.com/nodejs/node/pull/27647/commits
Checkshttps://github.com/nodejs/node/pull/27647/checks
Files changedhttps://github.com/nodejs/node/pull/27647/files
tools: allow RegExp in required-modules eslint rulehttps://github.com/nodejs/node/pull/27647#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:eslint-required-modules-regexphttps://github.com/richardlau/node-1/tree/eslint-required-modules-regexp
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2019https://github.com/nodejs/node/pull/27647#issue-442948666
#27545 (review)https://github.com/nodejs/node/pull/27545#pullrequestreview-233314045
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2019https://github.com/nodejs/node/pull/27647#issuecomment-491475521
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3484https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3484
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
May 11, 2019https://github.com/nodejs/node/pull/27647#event-2334555851
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2019 https://github.com/nodejs/node/pull/27647#ref-pullrequest-439818042
tools: fix node-core/required-modules eslint rule #27545 https://github.com/nodejs/node/pull/27545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2019https://github.com/nodejs/node/pull/27647#issuecomment-491475829
https://ci.nodejs.org/job/node-test-pull-request/23048/https://ci.nodejs.org/job/node-test-pull-request/23048/
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/Trott
Trotthttps://github.com/Trott
May 11, 2019 https://github.com/nodejs/node/pull/27647#pullrequestreview-236367486
View reviewed changes https://github.com/nodejs/node/pull/27647/files
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 11, 2019https://github.com/nodejs/node/pull/27647#event-2334641427
https://github.com/targos
targoshttps://github.com/targos
May 11, 2019 https://github.com/nodejs/node/pull/27647#pullrequestreview-236367530
View reviewed changes https://github.com/nodejs/node/pull/27647/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 13, 2019 https://github.com/nodejs/node/pull/27647#pullrequestreview-236534774
View reviewed changes https://github.com/nodejs/node/pull/27647/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/3e6983ac62a963383703a920a9388e88d5cfef60..45a4230145525edc9d380f2ad401e6545bff9feb
3e6983ahttps://github.com/nodejs/node/commit/3e6983ac62a963383703a920a9388e88d5cfef60
45a4230https://github.com/nodejs/node/commit/45a4230145525edc9d380f2ad401e6545bff9feb
Compare https://github.com/nodejs/node/compare/3e6983ac62a963383703a920a9388e88d5cfef60..45a4230145525edc9d380f2ad401e6545bff9feb
May 13, 2019 19:01https://github.com/nodejs/node/pull/27647#event-2337930975
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2019https://github.com/nodejs/node/pull/27647#issuecomment-491946198
https://ci.nodejs.org/job/node-test-pull-request/23091/https://ci.nodejs.org/job/node-test-pull-request/23091/
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2019https://github.com/nodejs/node/pull/27647#issuecomment-491955463
https://ci.nodejs.org/job/node-test-pull-request/23094/https://ci.nodejs.org/job/node-test-pull-request/23094/
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/richardlau
tools: allow RegExp in required-modules eslint rulehttps://github.com/nodejs/node/pull/27647/commits/1df3080af393a338df4cfbb56b442fe4b8345495
1df3080https://github.com/nodejs/node/pull/27647/commits/1df3080af393a338df4cfbb56b442fe4b8345495
nodejs#27647https://github.com/nodejs/node/pull/27647
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/45a4230145525edc9d380f2ad401e6545bff9feb..1df3080af393a338df4cfbb56b442fe4b8345495
45a4230https://github.com/nodejs/node/commit/45a4230145525edc9d380f2ad401e6545bff9feb
1df3080https://github.com/nodejs/node/commit/1df3080af393a338df4cfbb56b442fe4b8345495
Compare https://github.com/nodejs/node/compare/45a4230145525edc9d380f2ad401e6545bff9feb..1df3080af393a338df4cfbb56b442fe4b8345495
May 13, 2019 20:08https://github.com/nodejs/node/pull/27647#event-2338094035
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 13, 2019https://github.com/nodejs/node/pull/27647#issuecomment-491967636
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/richardlau
richardlauhttps://github.com/richardlau
1df3080https://github.com/nodejs/node/commit/1df3080af393a338df4cfbb56b442fe4b8345495
May 13, 2019https://github.com/nodejs/node/pull/27647#event-2338099136
targoshttps://github.com/targos
May 14, 2019 https://github.com/nodejs/node/pull/27647#ref-commit-1365683
https://github.com/richardlau
https://github.com/targos
tools: allow RegExp in required-modules eslint rulehttps://github.com/nodejs/node/commit/1365683c23c1e4302331b98fb26ff32bc6317462
1365683https://github.com/nodejs/node/commit/1365683c23c1e4302331b98fb26ff32bc6317462
#27647https://github.com/nodejs/node/pull/27647
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2019 https://github.com/nodejs/node/pull/27647#ref-pullrequest-446555712
v12.3.0 proposal #27799 https://github.com/nodejs/node/pull/27799
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27647
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27647/files/3e6983ac62a963383703a920a9388e88d5cfef60
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/27647/files/3e6983ac62a963383703a920a9388e88d5cfef60
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27647/files/3e6983ac62a963383703a920a9388e88d5cfef60
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/27647
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/targos
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.