| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1da7906a-c0ed-356f-1ef4-6000c2493a25 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 81A4:90996:40BBE50:5C5045A:6A4FF483 |
| html-safe-nonce | bc5eb76e800cccfe5d78b07b7a029e849f09c873b3349a4a1681087642db1335 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUE0OjkwOTk2OjQwQkJFNTA6NUM1MDQ1QTo2QTRGRjQ4MyIsInZpc2l0b3JfaWQiOiI3NDE5ODY1MTYxNjY0NTU4MjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | afcc0ff3833f3d48421fb84260ef36d85c27beded02251d6138f040ee1b88539 |
| hovercard-subject-tag | pull_request:277542292 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27628/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ed1e20e1ec35c6d5f1aeeb9d1f49901f56fd104d0d12fb0b7042df693115583/nodejs/node/pull/27628 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ed1e20e1ec35c6d5f1aeeb9d1f49901f56fd104d0d12fb0b7042df693115583/nodejs/node/pull/27628 |
| og:image:alt | For napi_set_property(), each one of the following arguments is checked:
napi_env env,
napi_value object,
napi_value key,
napi_value* value.
For napi_has_property(), each one of the follow... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | octaviansoldea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f7e270be010aa4de2871991025fbb97f3afe2bcb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27628#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27628 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27628 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27628 |
| Reload | https://github.com/nodejs/node/pull/27628 |
| Reload | https://github.com/nodejs/node/pull/27628 |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
976
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:napi_properties | https://github.com/octaviansoldea/node/tree/napi_properties |
| Conversation | https://github.com/nodejs/node/pull/27628 |
| Commits1 (1) | https://github.com/nodejs/node/pull/27628/commits |
| Checks | https://github.com/nodejs/node/pull/27628/checks |
| Files changed | https://github.com/nodejs/node/pull/27628/files |
| test: pass null params to napi_xxx_property() | https://github.com/nodejs/node/pull/27628#top |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:napi_properties | https://github.com/octaviansoldea/node/tree/napi_properties |
|
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
| May 9, 2019 | https://github.com/nodejs/node/pull/27628#issue-442425222 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
| test: pass null params to napi_xxx_property() | https://github.com/nodejs/node/pull/27628/commits/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
| aeb34c8 | https://github.com/nodejs/node/pull/27628/commits/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 9, 2019 | https://github.com/nodejs/node/pull/27628#event-2331410551 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 10, 2019 | https://github.com/nodejs/node/pull/27628#issuecomment-491382003 |
| https://ci.nodejs.org/job/node-test-pull-request/23037/ | https://ci.nodejs.org/job/node-test-pull-request/23037/ |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#event-2335611905 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#issuecomment-491654314 |
| https://ci.nodejs.org/job/node-test-pull-request/23073/ | https://ci.nodejs.org/job/node-test-pull-request/23073/ |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 13, 2019
| https://github.com/nodejs/node/pull/27628#pullrequestreview-236464303 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27628/files/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#event-2336159329 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#issuecomment-491902673 |
| https://ci.nodejs.org/job/node-test-pull-request/23088/ | https://ci.nodejs.org/job/node-test-pull-request/23088/ |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 13, 2019
| https://github.com/nodejs/node/pull/27628#pullrequestreview-236963755 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27628/files/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#issuecomment-492022524 |
| ddbaddc | https://github.com/nodejs/node/commit/ddbaddcce108855f517308f7bd5d910379b59a3b |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 13, 2019 | https://github.com/nodejs/node/pull/27628#event-2338494791 |
| Trott | https://github.com/Trott |
|
May 13, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-ddbaddc |
|
| https://github.com/Trott |
| test: pass null params to napi_xxx_property() | https://github.com/Trott/io.js/commit/ddbaddcce108855f517308f7bd5d910379b59a3b |
| ddbaddc | https://github.com/Trott/io.js/commit/ddbaddcce108855f517308f7bd5d910379b59a3b |
| nodejs#27628 | https://github.com/nodejs/node/pull/27628 |
| targos | https://github.com/targos |
|
May 14, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-7252a64 |
|
| https://github.com/targos |
| test: pass null params to napi_xxx_property() | https://github.com/nodejs/node/commit/7252a64a236a9bcc004a7552c355c8e631baf3a7 |
| 7252a64 | https://github.com/nodejs/node/commit/7252a64a236a9bcc004a7552c355c8e631baf3a7 |
| #27628 | https://github.com/nodejs/node/pull/27628 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
May 21, 2019
| https://github.com/nodejs/node/pull/27628#ref-pullrequest-446555712 |
|
v12.3.0 proposal
#27799
| https://github.com/nodejs/node/pull/27799 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 30, 2019
| https://github.com/nodejs/node/pull/27628#ref-pullrequest-449591652 |
|
src: add napi_define_class() null checks
#27945
| https://github.com/nodejs/node/pull/27945 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 24, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-7723333 |
| n-api: refactoring a previous commit | https://github.com/octaviansoldea/node/commit/77233338017f39ba0fab94d7047144912acca12f |
| 7723333 | https://github.com/octaviansoldea/node/commit/77233338017f39ba0fab94d7047144912acca12f |
| nodejs#27628 | https://github.com/nodejs/node/pull/27628 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 24, 2019
| https://github.com/nodejs/node/pull/27628#ref-pullrequest-472562175 |
|
n-api: refactoring a previous commit
#28848
| https://github.com/nodejs/node/pull/28848 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 26, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-db1c4a7 |
| n-api: refactor a previous commit | https://github.com/nodejs/node/commit/db1c4a7592a896053a8f791d7cc38a6de5c4a059 |
| db1c4a7 | https://github.com/nodejs/node/commit/db1c4a7592a896053a8f791d7cc38a6de5c4a059 |
| #27628 | https://github.com/nodejs/node/pull/27628 |
| #28505 | https://github.com/nodejs/node/pull/28505 |
| #28848 | https://github.com/nodejs/node/pull/28848 |
| gntem | https://github.com/gntem |
|
Jul 27, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-3d65e58 |
|
| https://github.com/gntem |
| n-api: refactor a previous commit | https://github.com/gntem/node/commit/3d65e5809aca2efc63744ffc6f80db89ecdc83ce |
| 3d65e58 | https://github.com/gntem/node/commit/3d65e5809aca2efc63744ffc6f80db89ecdc83ce |
| nodejs#27628 | https://github.com/nodejs/node/pull/27628 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| nodejs#28848 | https://github.com/nodejs/node/pull/28848 |
| targos | https://github.com/targos |
|
Aug 2, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-e6b3bfe |
|
| https://github.com/targos |
| n-api: refactor a previous commit | https://github.com/nodejs/node/commit/e6b3bfe1118cf6830388422b764c99fa67ed9fce |
| e6b3bfe | https://github.com/nodejs/node/commit/e6b3bfe1118cf6830388422b764c99fa67ed9fce |
| #27628 | https://github.com/nodejs/node/pull/27628 |
| #28505 | https://github.com/nodejs/node/pull/28505 |
| #28848 | https://github.com/nodejs/node/pull/28848 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/27628#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27628 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/27628/files/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/27628/files/aeb34c8345aa224ceae13b181d2beeeb5d39fa32 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/27628 |
|
| https://github.com/octaviansoldea |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |