René's URL Explorer Experiment


Title: tls: disallow conflicting TLS protocol options by sam-github · Pull Request #27521 · nodejs/node · GitHub

Open Graph Title: tls: disallow conflicting TLS protocol options by sam-github · Pull Request #27521 · nodejs/node

X Title: tls: disallow conflicting TLS protocol options by sam-github · Pull Request #27521 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not allow the minimum protocol level to be set higher than the max protocol level. See: #26951, 109c097 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchma...

X Description: Do not allow the minimum protocol level to be set higher than the max protocol level. See: #26951, 109c097 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchma...

Opengraph URL: https://github.com/nodejs/node/pull/27521

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:66f0684c-a059-008b-6495-9b9e5c49f7e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD76:2C03D:3BDE6E2:524A9B9:6A4F2D3A
html-safe-nonceb3c42ba6ee3f75f0d3bd967a936556dc6e98b96358774d177479393abd8f2584
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDc2OjJDMDNEOjNCREU2RTI6NTI0QTlCOTo2QTRGMkQzQSIsInZpc2l0b3JfaWQiOiI2NDUyODU1OTIwNjY5OTYxNTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac70e53f0857cf208389b9a72da8aaa5f9b5eb1ecf7eae62270fedaa4e0bf4687b
hovercard-subject-tagpull_request:275136844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27521/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57bacbe0a1950c4739b28b5a0887b4a17d34404b03cbf8bcb21c36fd9e681d81/nodejs/node/pull/27521
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57bacbe0a1950c4739b28b5a0887b4a17d34404b03cbf8bcb21c36fd9e681d81/nodejs/node/pull/27521
og:image:altDo not allow the minimum protocol level to be set higher than the max protocol level. See: #26951, 109c097 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27521#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27521
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27521
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27521
Reloadhttps://github.com/nodejs/node/pull/27521
Reloadhttps://github.com/nodejs/node/pull/27521
Please reload this pagehttps://github.com/nodejs/node/pull/27521
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27521
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:cli-tls-impossiblehttps://github.com/sam-github/node/tree/cli-tls-impossible
Conversationhttps://github.com/nodejs/node/pull/27521
Commits1 (1)https://github.com/nodejs/node/pull/27521/commits
Checkshttps://github.com/nodejs/node/pull/27521/checks
Files changedhttps://github.com/nodejs/node/pull/27521/files
tls: disallow conflicting TLS protocol optionshttps://github.com/nodejs/node/pull/27521#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:cli-tls-impossiblehttps://github.com/sam-github/node/tree/cli-tls-impossible
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 1, 2019https://github.com/nodejs/node/pull/27521#issue-439299583
Please reload this pagehttps://github.com/nodejs/node/pull/27521
#26951https://github.com/nodejs/node/pull/26951
109c097https://github.com/nodejs/node/commit/109c097797b82efb2eb081a1e87284000c094871
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488396275
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3417https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3417
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 1, 2019https://github.com/nodejs/node/pull/27521#event-2312708473
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 1, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488396326
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 1, 2019 https://github.com/nodejs/node/pull/27521#pullrequestreview-232745275
View reviewed changes https://github.com/nodejs/node/pull/27521/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 1, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488436863
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/Trott
Trotthttps://github.com/Trott
May 2, 2019 https://github.com/nodejs/node/pull/27521#pullrequestreview-232855217
View reviewed changes https://github.com/nodejs/node/pull/27521/files
test/parallel/test-tls-cli-min-version-1.3-max-version-1.2.jshttps://github.com/nodejs/node/pull/27521/files#diff-86e6998d6404b45c47987a4bf4e428ddb95b1c9d0c1a4ec01a59bf105f432bc5
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/927ad7972a3b6f435ac05fbb08294c2b70350734..c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf
927ad79https://github.com/nodejs/node/commit/927ad7972a3b6f435ac05fbb08294c2b70350734
c6533c3https://github.com/nodejs/node/commit/c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf
Compare https://github.com/nodejs/node/compare/927ad7972a3b6f435ac05fbb08294c2b70350734..c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf
May 2, 2019 18:19https://github.com/nodejs/node/pull/27521#event-2315319758
https://github.com/sam-github
tls: disallow conflicting TLS protocol optionshttps://github.com/nodejs/node/pull/27521/commits/918c0edeb5cdf31af219ffe2ae982c48bb188c23
918c0edhttps://github.com/nodejs/node/pull/27521/commits/918c0edeb5cdf31af219ffe2ae982c48bb188c23
nodejs#26951https://github.com/nodejs/node/pull/26951
109c097https://github.com/sam-github/node/commit/109c097797b82efb2eb081a1e87284000c094871
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf..918c0edeb5cdf31af219ffe2ae982c48bb188c23
c6533c3https://github.com/nodejs/node/commit/c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf
918c0edhttps://github.com/nodejs/node/commit/918c0edeb5cdf31af219ffe2ae982c48bb188c23
Compare https://github.com/nodejs/node/compare/c6533c36569bbbbcd2a3817fd6aeed5ad04c4fdf..918c0edeb5cdf31af219ffe2ae982c48bb188c23
May 2, 2019 18:19https://github.com/nodejs/node/pull/27521#event-2315321572
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 2, 2019https://github.com/nodejs/node/pull/27521#event-2315322750
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 2, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488778796
https://ci.nodejs.org/job/node-test-pull-request/22893/https://ci.nodejs.org/job/node-test-pull-request/22893/
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 2, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488779047
@bnoordhuishttps://github.com/bnoordhuis
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 2, 2019 https://github.com/nodejs/node/pull/27521#pullrequestreview-233242477
View reviewed changes https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
src/node_options.cchttps://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
bnoordhuishttps://github.com/bnoordhuis
May 2, 2019https://github.com/nodejs/node/pull/27521#discussion_r280599717
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27521
BridgeARhttps://github.com/BridgeAR
May 2, 2019https://github.com/nodejs/node/pull/27521#discussion_r280605625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2019 https://github.com/nodejs/node/pull/27521#pullrequestreview-233250064
View reviewed changes https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
src/node_options.cchttps://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
BridgeARhttps://github.com/BridgeAR
May 2, 2019https://github.com/nodejs/node/pull/27521#discussion_r280605625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 2, 2019https://github.com/nodejs/node/pull/27521#issuecomment-488848733
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/Trott
Trotthttps://github.com/Trott
May 3, 2019 https://github.com/nodejs/node/pull/27521#pullrequestreview-233312488
View reviewed changes https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/27521#pullrequestreview-233312488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 3, 2019https://github.com/nodejs/node/pull/27521#issuecomment-489267364
cb848b4https://github.com/nodejs/node/commit/cb848b4546eeca234ce59434bb8a6bc6a6da4fc4
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 3, 2019https://github.com/nodejs/node/pull/27521#event-2318671719
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 3, 2019 23:12https://github.com/nodejs/node/pull/27521#event-2318671923
sam-githubhttps://github.com/sam-github
May 3, 2019 https://github.com/nodejs/node/pull/27521#ref-commit-cb848b4
https://github.com/sam-github
tls: disallow conflicting TLS protocol optionshttps://github.com/nodejs/node/commit/cb848b4546eeca234ce59434bb8a6bc6a6da4fc4
cb848b4https://github.com/nodejs/node/commit/cb848b4546eeca234ce59434bb8a6bc6a6da4fc4
#26951https://github.com/nodejs/node/pull/26951
109c097https://github.com/nodejs/node/commit/109c097797b82efb2eb081a1e87284000c094871
#27521https://github.com/nodejs/node/pull/27521
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27521#ref-commit-7bbf951
https://github.com/sam-github
https://github.com/targos
tls: disallow conflicting TLS protocol optionshttps://github.com/nodejs/node/commit/7bbf95109567bfbf75b655e4c81679e914c3c036
7bbf951https://github.com/nodejs/node/commit/7bbf95109567bfbf75b655e4c81679e914c3c036
#26951https://github.com/nodejs/node/pull/26951
109c097https://github.com/nodejs/node/commit/109c097797b82efb2eb081a1e87284000c094871
#27521https://github.com/nodejs/node/pull/27521
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27521#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27521
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/27521/files/8b46f75d7dca8e74a496991520d7241567d23dbe
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27521/files/918c0edeb5cdf31af219ffe2ae982c48bb188c23
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/27521
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com/Trott
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.