René's URL Explorer Experiment


Title: cpp: make deleted function public by gengjiawen · Pull Request #27509 · nodejs/node · GitHub

Open Graph Title: cpp: make deleted function public by gengjiawen · Pull Request #27509 · nodejs/node

X Title: cpp: make deleted function public by gengjiawen · Pull Request #27509 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Hopefully when #26840 launched, we can find this earlier. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or adde...

X Description: Hopefully when #26840 launched, we can find this earlier. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or adde...

Opengraph URL: https://github.com/nodejs/node/pull/27509

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d266167-d48c-6917-436c-dd8f57e662d3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB334:308E6B:B5980A:FF255D:6A4E876E
html-safe-nonce91af00a7fc34ff0195221704e078b7a5e787c7fbf58b217084644d5f0a2f06ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzM0OjMwOEU2QjpCNTk4MEE6RkYyNTVEOjZBNEU4NzZFIiwidmlzaXRvcl9pZCI6Ijg0OTkzMjM5NDI0ODk2Mzk1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac88f093153c18f983560f94890dcf8e556b705edbea3a22de14abf346d02ff01a
hovercard-subject-tagpull_request:274959856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27509/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/daeac790e0a2bc8d175903862980f8525021dd9791d2f26f5a0ab49c7d6ec676/nodejs/node/pull/27509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/daeac790e0a2bc8d175903862980f8525021dd9791d2f26f5a0ab49c7d6ec676/nodejs/node/pull/27509
og:image:altHopefully when #26840 launched, we can find this earlier. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or adde...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegengjiawen
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27509#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27509
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27509
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27509
Reloadhttps://github.com/nodejs/node/pull/27509
Reloadhttps://github.com/nodejs/node/pull/27509
Please reload this pagehttps://github.com/nodejs/node/pull/27509
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27509
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:deleted_funchttps://github.com/gengjiawen/node/tree/deleted_func
Conversationhttps://github.com/nodejs/node/pull/27509
Commits2 (2)https://github.com/nodejs/node/pull/27509/commits
Checkshttps://github.com/nodejs/node/pull/27509/checks
Files changedhttps://github.com/nodejs/node/pull/27509/files
cpp: make deleted function publichttps://github.com/nodejs/node/pull/27509#top
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:deleted_funchttps://github.com/gengjiawen/node/tree/deleted_func
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
May 1, 2019https://github.com/nodejs/node/pull/27509#issue-439072888
#26840https://github.com/nodejs/node/pull/26840
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27509
gengjiawenhttps://github.com/gengjiawen
May 1, 2019 13:25https://github.com/nodejs/node/pull/27509#commits-pushed-f9e3be9
https://github.com/gengjiawen
src: make deleted function public in node_main_instance.hhttps://github.com/nodejs/node/pull/27509/commits/f9e3be9b168ee88a8ab847dfc9d3f84cf6f68aa3
f9e3be9https://github.com/nodejs/node/pull/27509/commits/f9e3be9b168ee88a8ab847dfc9d3f84cf6f68aa3
https://github.com/gengjiawen
src: make deleted function public in node_native_module.hhttps://github.com/nodejs/node/pull/27509/commits/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
f2bdf78https://github.com/nodejs/node/pull/27509/commits/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
May 1, 2019https://github.com/nodejs/node/pull/27509#event-2311341690
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 1, 2019 https://github.com/nodejs/node/pull/27509#pullrequestreview-232494228
View reviewed changes https://github.com/nodejs/node/pull/27509/files/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2019 https://github.com/nodejs/node/pull/27509#pullrequestreview-232778173
View reviewed changes https://github.com/nodejs/node/pull/27509/files/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
May 1, 2019https://github.com/nodejs/node/pull/27509#event-2313017373
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27509#issuecomment-488450321
https://ci.nodejs.org/job/node-test-pull-request/22867/https://ci.nodejs.org/job/node-test-pull-request/22867/
Please reload this pagehttps://github.com/nodejs/node/pull/27509
https://github.com/danbev
danbevhttps://github.com/danbev
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 6, 2019https://github.com/nodejs/node/pull/27509#event-2319973926
https://github.com/danbev
danbevhttps://github.com/danbev
May 6, 2019https://github.com/nodejs/node/pull/27509#issuecomment-489492876
64a25b8https://github.com/nodejs/node/commit/64a25b8417a00b425208381753b485b4f1e1618e
8c94d5ehttps://github.com/nodejs/node/commit/8c94d5eccd210109f9f1843893929fa18508ee90
Please reload this pagehttps://github.com/nodejs/node/pull/27509
https://github.com/danbev
danbevhttps://github.com/danbev
May 6, 2019https://github.com/nodejs/node/pull/27509#event-2319984310
danbevhttps://github.com/danbev
May 6, 2019 https://github.com/nodejs/node/pull/27509#ref-commit-64a25b8
https://github.com/gengjiawen
https://github.com/danbev
src: make deleted function public in node_main_instance.hhttps://github.com/nodejs/node/commit/64a25b8417a00b425208381753b485b4f1e1618e
64a25b8https://github.com/nodejs/node/commit/64a25b8417a00b425208381753b485b4f1e1618e
#27509https://github.com/nodejs/node/pull/27509
danbevhttps://github.com/danbev
May 6, 2019 https://github.com/nodejs/node/pull/27509#ref-commit-8c94d5e
https://github.com/gengjiawen
https://github.com/danbev
src: make deleted function public in node_native_module.hhttps://github.com/nodejs/node/commit/8c94d5eccd210109f9f1843893929fa18508ee90
8c94d5ehttps://github.com/nodejs/node/commit/8c94d5eccd210109f9f1843893929fa18508ee90
#27509https://github.com/nodejs/node/pull/27509
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27509#ref-commit-1489d12
https://github.com/gengjiawen
https://github.com/targos
src: make deleted function public in node_main_instance.hhttps://github.com/nodejs/node/commit/1489d1273573508f1d26bfd48da49ba73d77ec21
1489d12https://github.com/nodejs/node/commit/1489d1273573508f1d26bfd48da49ba73d77ec21
#27509https://github.com/nodejs/node/pull/27509
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27509#ref-commit-8724229
https://github.com/gengjiawen
https://github.com/targos
src: make deleted function public in node_native_module.hhttps://github.com/nodejs/node/commit/8724229155029ff4e11b2c4bad10b2ff39c4764a
8724229https://github.com/nodejs/node/commit/8724229155029ff4e11b2c4bad10b2ff39c4764a
#27509https://github.com/nodejs/node/pull/27509
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27509#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27509
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27509/files/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27509/files/f2bdf783e6072030cdafe20f0ea23bb8e31a97f7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/27509
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.