René's URL Explorer Experiment


Title: test: make sure weak references are not GCed to early by BridgeAR · Pull Request #27482 · nodejs/node · GitHub

Open Graph Title: test: make sure weak references are not GCed to early by BridgeAR · Pull Request #27482 · nodejs/node

X Title: test: make sure weak references are not GCed to early by BridgeAR · Pull Request #27482 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes flaky util.inspect tests by making sure that the inspected WeakMap and WeakSet only contains objects that still have other hard references. Otherwise the garbage collection could collect...

X Description: This fixes flaky util.inspect tests by making sure that the inspected WeakMap and WeakSet only contains objects that still have other hard references. Otherwise the garbage collection could collect...

Opengraph URL: https://github.com/nodejs/node/pull/27482

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a64b6937-1db5-602d-3e18-a84f4ce33287
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE76C:25C9D0:C12CC0:1073C31:6A4DC6C0
html-safe-noncee32208e0d53d79180569c759eae9faf302fd5014da92254974f877895a5a969c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzZDOjI1QzlEMDpDMTJDQzA6MTA3M0MzMTo2QTREQzZDMCIsInZpc2l0b3JfaWQiOiI3NTQxMzQ4MjE3MTQyNDk0OTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac64d059aebb888d28abba0e338a4ae3b6fd09e08ba5373def19c6612007fa96fd
hovercard-subject-tagpull_request:274489129
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27482/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/56123b4a2fe9a5a812772f4a2d1ee8577802ecee707819293be07ebe859d7e58/nodejs/node/pull/27482
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/56123b4a2fe9a5a812772f4a2d1ee8577802ecee707819293be07ebe859d7e58/nodejs/node/pull/27482
og:image:altThis fixes flaky util.inspect tests by making sure that the inspected WeakMap and WeakSet only contains objects that still have other hard references. Otherwise the garbage collection could collect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27482#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27482
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27482
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27482
Reloadhttps://github.com/nodejs/node/pull/27482
Reloadhttps://github.com/nodejs/node/pull/27482
Please reload this pagehttps://github.com/nodejs/node/pull/27482
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27482
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-flaky-inspect-testhttps://github.com/BridgeAR/node/tree/fix-flaky-inspect-test
Conversationhttps://github.com/nodejs/node/pull/27482
Commits2 (2)https://github.com/nodejs/node/pull/27482/commits
Checkshttps://github.com/nodejs/node/pull/27482/checks
Files changedhttps://github.com/nodejs/node/pull/27482/files
test: make sure weak references are not GCed to earlyhttps://github.com/nodejs/node/pull/27482#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-flaky-inspect-testhttps://github.com/BridgeAR/node/tree/fix-flaky-inspect-test
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 29, 2019https://github.com/nodejs/node/pull/27482#issue-438463711
#27440 (comment)https://github.com/nodejs/node/pull/27440#issuecomment-487573000
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
targoshttps://github.com/targos
April 29, 2019 19:10https://github.com/nodejs/node/pull/27482#event-2307636321
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Apr 29, 2019https://github.com/nodejs/node/pull/27482#event-2307636501
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 29, 2019https://github.com/nodejs/node/pull/27482#issuecomment-487706081
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3393https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3393
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/targos
targoshttps://github.com/targos
Apr 29, 2019 https://github.com/nodejs/node/pull/27482#pullrequestreview-231876572
View reviewed changes https://github.com/nodejs/node/pull/27482/files
targoshttps://github.com/targos
https://github.com/nodejs/node/pull/27482#pullrequestreview-231876572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 29, 2019 https://github.com/nodejs/node/pull/27482#pullrequestreview-231915637
View reviewed changes https://github.com/nodejs/node/pull/27482/files
test/parallel/test-util-inspect.jshttps://github.com/nodejs/node/pull/27482/files#diff-755e2936fb30a27966acf7a34f5e4f73478d2a19a6bed3372586a7421b43d4b1
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 29, 2019 https://github.com/nodejs/node/pull/27482#pullrequestreview-231916734
View reviewed changes https://github.com/nodejs/node/pull/27482/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 29, 2019 https://github.com/nodejs/node/pull/27482#pullrequestreview-231919523
View reviewed changes https://github.com/nodejs/node/pull/27482/files
BridgeARhttps://github.com/BridgeAR
April 30, 2019 14:18https://github.com/nodejs/node/pull/27482#commits-pushed-8cc10b0
https://github.com/BridgeAR
test: make sure weak references are not GCed too earlyhttps://github.com/nodejs/node/pull/27482/commits/8cc10b07b184a1297948c199d0a916169bdd5b71
8cc10b0https://github.com/nodejs/node/pull/27482/commits/8cc10b07b184a1297948c199d0a916169bdd5b71
https://github.com/BridgeAR
fixup! test: make sure weak references are not GCed too earlyhttps://github.com/nodejs/node/pull/27482/commits/73d936cccbc885747bb8d8a694154ff3d43812cb
73d936chttps://github.com/nodejs/node/pull/27482/commits/73d936cccbc885747bb8d8a694154ff3d43812cb
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/c1131203471dbae40fcf6544e276d24f790af977..73d936cccbc885747bb8d8a694154ff3d43812cb
c113120https://github.com/nodejs/node/commit/c1131203471dbae40fcf6544e276d24f790af977
73d936chttps://github.com/nodejs/node/commit/73d936cccbc885747bb8d8a694154ff3d43812cb
Compare https://github.com/nodejs/node/compare/c1131203471dbae40fcf6544e276d24f790af977..73d936cccbc885747bb8d8a694154ff3d43812cb
April 30, 2019 12:20https://github.com/nodejs/node/pull/27482#event-2309305047
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 30, 2019https://github.com/nodejs/node/pull/27482#event-2309305206
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 30, 2019https://github.com/nodejs/node/pull/27482#issuecomment-487930212
https://ci.nodejs.org/job/node-test-pull-request/22836/https://ci.nodejs.org/job/node-test-pull-request/22836/
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 1, 2019https://github.com/nodejs/node/pull/27482#issuecomment-488474132
caf9d3chttps://github.com/nodejs/node/commit/caf9d3c1d040c0bfd99e063770ea4d5e9f961f88
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 1, 2019https://github.com/nodejs/node/pull/27482#event-2313122544
BridgeARhttps://github.com/BridgeAR
May 1, 2019 https://github.com/nodejs/node/pull/27482#ref-commit-caf9d3c
https://github.com/BridgeAR
test: make sure weak references are not GCed too earlyhttps://github.com/BridgeAR/node/commit/caf9d3c1d040c0bfd99e063770ea4d5e9f961f88
caf9d3chttps://github.com/BridgeAR/node/commit/caf9d3c1d040c0bfd99e063770ea4d5e9f961f88
nodejs#27482https://github.com/nodejs/node/pull/27482
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27482#ref-commit-a278814
https://github.com/BridgeAR
https://github.com/targos
test: make sure weak references are not GCed too earlyhttps://github.com/nodejs/node/commit/a278814818245027606e30a9d2d66ca5b4be2b80
a278814https://github.com/nodejs/node/commit/a278814818245027606e30a9d2d66ca5b4be2b80
#27482https://github.com/nodejs/node/pull/27482
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27482#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 12:03https://github.com/nodejs/node/pull/27482#event-2962698569
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27482
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27482/files/c1131203471dbae40fcf6544e276d24f790af977
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27482/files/c1131203471dbae40fcf6544e276d24f790af977
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/27482/files/c1131203471dbae40fcf6544e276d24f790af977
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/27482
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.