René's URL Explorer Experiment


Title: src: refactor V8ProfilerConnection to be more reusable by joyeecheung · Pull Request #27475 · nodejs/node · GitHub

Open Graph Title: src: refactor V8ProfilerConnection to be more reusable by joyeecheung · Pull Request #27475 · nodejs/node

X Title: src: refactor V8ProfilerConnection to be more reusable by joyeecheung · Pull Request #27475 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: src: refactor profile initialization Process and store --cpu-prof-dir and --cpu-prof-name during Environment creation Start profilers in on profiler::StartProfilers() src: refactor V8ProfilerConn...

X Description: src: refactor profile initialization Process and store --cpu-prof-dir and --cpu-prof-name during Environment creation Start profilers in on profiler::StartProfilers() src: refactor V8ProfilerConn...

Opengraph URL: https://github.com/nodejs/node/pull/27475

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:97fdd1c3-1af2-b1e6-99a0-eeee2eb44f8d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB82:163E47:4D0467:71121D:6A4E09B5
html-safe-nonce69a2e075ba6fc87f9f52c2fe4f166d3fff06cd738f23eb7279dffbcf6ac98ee2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjgyOjE2M0U0Nzo0RDA0Njc6NzExMjFEOjZBNEUwOUI1IiwidmlzaXRvcl9pZCI6IjM1NzExNzQ0Nzg0MzkxMjMzODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5e798f3040f1b442825fdaf177df91af52de1bee4752ea8888f25b74655ce526
hovercard-subject-tagpull_request:274344759
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27475/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1683a6b5be2d4b005428492ac141faffa95cc5f242df62385f600ab87d9aa826/nodejs/node/pull/27475
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1683a6b5be2d4b005428492ac141faffa95cc5f242df62385f600ab87d9aa826/nodejs/node/pull/27475
og:image:altsrc: refactor profile initialization Process and store --cpu-prof-dir and --cpu-prof-name during Environment creation Start profilers in on profiler::StartProfilers() src: refactor V8ProfilerConn...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27475#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27475
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27475
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27475
Reloadhttps://github.com/nodejs/node/pull/27475
Reloadhttps://github.com/nodejs/node/pull/27475
Please reload this pagehttps://github.com/nodejs/node/pull/27475
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27475
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-profhttps://github.com/joyeecheung/node/tree/refactor-prof
Conversationhttps://github.com/nodejs/node/pull/27475
Commits3 (3)https://github.com/nodejs/node/pull/27475/commits
Checkshttps://github.com/nodejs/node/pull/27475/checks
Files changedhttps://github.com/nodejs/node/pull/27475/files
src: refactor V8ProfilerConnection to be more reusablehttps://github.com/nodejs/node/pull/27475#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-profhttps://github.com/joyeecheung/node/tree/refactor-prof
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 29, 2019https://github.com/nodejs/node/pull/27475#issue-438280173
Please reload this pagehttps://github.com/nodejs/node/pull/27475
#27421https://github.com/nodejs/node/issues/27421
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27475
joyeecheunghttps://github.com/joyeecheung
April 29, 2019 19:46https://github.com/nodejs/node/pull/27475#commits-pushed-f1ac159
https://github.com/joyeecheung
src: refactor profile initializationhttps://github.com/nodejs/node/pull/27475/commits/f1ac1599a39646bec687e63856329e6d78cd94b5
f1ac159https://github.com/nodejs/node/pull/27475/commits/f1ac1599a39646bec687e63856329e6d78cd94b5
https://github.com/joyeecheung
src: refactor V8ProfilerConnection to be more reusablehttps://github.com/nodejs/node/pull/27475/commits/026d821aee31befec9104630f89ae6627ca414e7
026d821https://github.com/nodejs/node/pull/27475/commits/026d821aee31befec9104630f89ae6627ca414e7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 29, 2019https://github.com/nodejs/node/pull/27475#issuecomment-487551789
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3390https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3390
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Apr 29, 2019https://github.com/nodejs/node/pull/27475#event-2306471560
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 29, 2019https://github.com/nodejs/node/pull/27475#issuecomment-487552072
https://ci.nodejs.org/job/node-test-pull-request/22806/https://ci.nodejs.org/job/node-test-pull-request/22806/
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 29, 2019 https://github.com/nodejs/node/pull/27475#pullrequestreview-231940185
View reviewed changes https://github.com/nodejs/node/pull/27475/files/026d821aee31befec9104630f89ae6627ca414e7
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/27475#pullrequestreview-231940185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 29, 2019https://github.com/nodejs/node/pull/27475#issuecomment-487772850
https://ci.nodejs.org/job/node-test-pull-request/22826/https://ci.nodejs.org/job/node-test-pull-request/22826/
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 30, 2019 https://github.com/nodejs/node/pull/27475#pullrequestreview-232014949
View reviewed changes https://github.com/nodejs/node/pull/27475/files/f1ac1599a39646bec687e63856329e6d78cd94b5
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27475#pullrequestreview-232014949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27475
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/27475/files/f1ac1599a39646bec687e63856329e6d78cd94b5#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/27475
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/27475/files/f1ac1599a39646bec687e63856329e6d78cd94b5..026d821aee31befec9104630f89ae6627ca414e7#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/27475
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/27475/files/f1ac1599a39646bec687e63856329e6d78cd94b5..026d821aee31befec9104630f89ae6627ca414e7#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/27475
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/27475/files/f1ac1599a39646bec687e63856329e6d78cd94b5..026d821aee31befec9104630f89ae6627ca414e7#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/joyeecheung
fixup! src: refactor V8ProfilerConnection to be more reusablehttps://github.com/nodejs/node/pull/27475/commits/80f8e65151bd7a207ccc96b37176ffd02d91fdfc
80f8e65https://github.com/nodejs/node/pull/27475/commits/80f8e65151bd7a207ccc96b37176ffd02d91fdfc
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27475#issuecomment-488238190
https://ci.nodejs.org/job/node-test-pull-request/22852/https://ci.nodejs.org/job/node-test-pull-request/22852/
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 1, 2019https://github.com/nodejs/node/pull/27475#issuecomment-488238222
Please reload this pagehttps://github.com/nodejs/node/pull/27475
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27475#issuecomment-488247797
https://ci.nodejs.org/job/node-test-pull-request/22854/https://ci.nodejs.org/job/node-test-pull-request/22854/
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 2, 2019https://github.com/nodejs/node/pull/27475#issuecomment-488644768
Please reload this pagehttps://github.com/nodejs/node/pull/27475
6f02f15...58ba952https://github.com/nodejs/node/compare/6f02f159216f4791e1d397aaddcbdb4dbcfd29d1...58ba9527dc5fd3343f719b11a4cef73d23215253
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/27475
joyeecheunghttps://github.com/joyeecheung
May 2, 2019 https://github.com/nodejs/node/pull/27475#ref-commit-30cceae
https://github.com/joyeecheung
src: refactor profile initializationhttps://github.com/nodejs/node/commit/30cceaeccbe6a8c6a58a44ea760188f96951c13e
30cceaehttps://github.com/nodejs/node/commit/30cceaeccbe6a8c6a58a44ea760188f96951c13e
#27475https://github.com/nodejs/node/pull/27475
#27421https://github.com/nodejs/node/issues/27421
joyeecheunghttps://github.com/joyeecheung
May 2, 2019 https://github.com/nodejs/node/pull/27475#ref-commit-58ba952
https://github.com/joyeecheung
src: refactor V8ProfilerConnection to be more reusablehttps://github.com/nodejs/node/commit/58ba9527dc5fd3343f719b11a4cef73d23215253
58ba952https://github.com/nodejs/node/commit/58ba9527dc5fd3343f719b11a4cef73d23215253
#27475https://github.com/nodejs/node/pull/27475
#27421https://github.com/nodejs/node/issues/27421
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 2, 2019https://github.com/nodejs/node/pull/27475#event-2314273475
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27475#ref-commit-c787bb8
https://github.com/joyeecheung
https://github.com/targos
src: refactor profile initializationhttps://github.com/nodejs/node/commit/c787bb85cd2604886b883382e120bd08198cf179
c787bb8https://github.com/nodejs/node/commit/c787bb85cd2604886b883382e120bd08198cf179
#27475https://github.com/nodejs/node/pull/27475
#27421https://github.com/nodejs/node/issues/27421
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27475#ref-commit-0c9bc02
https://github.com/joyeecheung
https://github.com/targos
src: refactor V8ProfilerConnection to be more reusablehttps://github.com/nodejs/node/commit/0c9bc02b966a14e742b59e00bac4094cd4afa1c1
0c9bc02https://github.com/nodejs/node/commit/0c9bc02b966a14e742b59e00bac4094cd4afa1c1
#27475https://github.com/nodejs/node/pull/27475
#27421https://github.com/nodejs/node/issues/27421
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27475#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27475
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27475/files/80f8e65151bd7a207ccc96b37176ffd02d91fdfc
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27475/files/026d821aee31befec9104630f89ae6627ca414e7
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/27475
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.