| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:24774c43-3909-d7c2-9a09-dd00ae31d427 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A07A:193F03:ED88DD:1488EBA:6A4DD640 |
| html-safe-nonce | 59aaffc257be38580da986917b4e1f4e288b80ed434dbeec35f37a5c729109bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDdBOjE5M0YwMzpFRDg4REQ6MTQ4OEVCQTo2QTRERDY0MCIsInZpc2l0b3JfaWQiOiI1ODMzODE1OTQ0OTI1NjY0ODMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c92a477f37d01e7594537c69f16b46896180f9873ea3721ee68784d02b1a4a2f |
| hovercard-subject-tag | pull_request:274097826 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27440/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2599494165a07902519ad0eff439eced14b7eb20304149ae1e0b7323b9bd5c17/nodejs/node/pull/27440 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2599494165a07902519ad0eff439eced14b7eb20304149ae1e0b7323b9bd5c17/nodejs/node/pull/27440 |
| og:image:alt | 2019-04-29, Version 12.1.0 (Current), @targos
Notable changes
intl:
Update ICU to 64.2. This adds support for Japanese Era (Reiwa) (Ujjwal Sharma) #27361.
Fixes a bug in ICU that affected Node.js... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27440#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27440 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27440 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27440 |
| Reload | https://github.com/nodejs/node/pull/27440 |
| Reload | https://github.com/nodejs/node/pull/27440 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| targos | https://github.com/targos |
| v12.x | https://github.com/nodejs/node/tree/v12.x |
| v12.1.0-proposal | https://github.com/nodejs/node/tree/v12.1.0-proposal |
| Conversation | https://github.com/nodejs/node/pull/27440 |
| Commits49 (49) | https://github.com/nodejs/node/pull/27440/commits |
| Checks | https://github.com/nodejs/node/pull/27440/checks |
| Files changed | https://github.com/nodejs/node/pull/27440/files |
| v12.1.0 proposal | https://github.com/nodejs/node/pull/27440#top |
| targos | https://github.com/targos |
| v12.x | https://github.com/nodejs/node/tree/v12.x |
| v12.1.0-proposal | https://github.com/nodejs/node/tree/v12.1.0-proposal |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issue-437929799 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| @targos | https://github.com/targos |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| #27415 | https://github.com/nodejs/node/pull/27415 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| 8ca110cc6f | https://github.com/nodejs/node/commit/8ca110cc6f |
| #27359 | https://github.com/nodejs/node/pull/27359 |
| 2f9bafba08 | https://github.com/nodejs/node/commit/2f9bafba08 |
| #27371 | https://github.com/nodejs/node/pull/27371 |
| e7026f1428 | https://github.com/nodejs/node/commit/e7026f1428 |
| #27370 | https://github.com/nodejs/node/pull/27370 |
| 50234460f9 | https://github.com/nodejs/node/commit/50234460f9 |
| #27365 | https://github.com/nodejs/node/pull/27365 |
| b21b28f653 | https://github.com/nodejs/node/commit/b21b28f653 |
| #27374 | https://github.com/nodejs/node/pull/27374 |
| 3282ccb845 | https://github.com/nodejs/node/commit/3282ccb845 |
| #27435 | https://github.com/nodejs/node/pull/27435 |
| e922a22725 | https://github.com/nodejs/node/commit/e922a22725 |
| #27415 | https://github.com/nodejs/node/pull/27415 |
| d852d9e904 | https://github.com/nodejs/node/commit/d852d9e904 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| ee80a210ff | https://github.com/nodejs/node/commit/ee80a210ff |
| #27338 | https://github.com/nodejs/node/pull/27338 |
| 8302148c83 | https://github.com/nodejs/node/commit/8302148c83 |
| #27414 | https://github.com/nodejs/node/pull/27414 |
| f6ceefa4bd | https://github.com/nodejs/node/commit/f6ceefa4bd |
| #27398 | https://github.com/nodejs/node/pull/27398 |
| 9c30806fb5 | https://github.com/nodejs/node/commit/9c30806fb5 |
| #27354 | https://github.com/nodejs/node/pull/27354 |
| 453510c7ef | https://github.com/nodejs/node/commit/453510c7ef |
| #27336 | https://github.com/nodejs/node/pull/27336 |
| 36762883a0 | https://github.com/nodejs/node/commit/36762883a0 |
| #27282 | https://github.com/nodejs/node/pull/27282 |
| f70588fb67 | https://github.com/nodejs/node/commit/f70588fb67 |
| #27368 | https://github.com/nodejs/node/pull/27368 |
| a6d1fa5954 | https://github.com/nodejs/node/commit/a6d1fa5954 |
| #27348 | https://github.com/nodejs/node/pull/27348 |
| dd709fc84a | https://github.com/nodejs/node/commit/dd709fc84a |
| #26635 | https://github.com/nodejs/node/pull/26635 |
| 4dfe54a89a | https://github.com/nodejs/node/commit/4dfe54a89a |
| #27323 | https://github.com/nodejs/node/pull/27323 |
| 8b5d73867f | https://github.com/nodejs/node/commit/8b5d73867f |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| dc510fb435 | https://github.com/nodejs/node/commit/dc510fb435 |
| #27367 | https://github.com/nodejs/node/pull/27367 |
| 3614a00276 | https://github.com/nodejs/node/commit/3614a00276 |
| #27280 | https://github.com/nodejs/node/pull/27280 |
| 071300b39d | https://github.com/nodejs/node/commit/071300b39d |
| #27304 | https://github.com/nodejs/node/pull/27304 |
| 81e7b49c8f | https://github.com/nodejs/node/commit/81e7b49c8f |
| #27334 | https://github.com/nodejs/node/pull/27334 |
| 8089d29567 | https://github.com/nodejs/node/commit/8089d29567 |
| #27279 | https://github.com/nodejs/node/pull/27279 |
| 619c5b6eb3 | https://github.com/nodejs/node/commit/619c5b6eb3 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| 809cf595eb | https://github.com/nodejs/node/commit/809cf595eb |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| 7bc47cba2e | https://github.com/nodejs/node/commit/7bc47cba2e |
| #27264 | https://github.com/nodejs/node/pull/27264 |
| ad42cd69cf | https://github.com/nodejs/node/commit/ad42cd69cf |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| 228127fc67 | https://github.com/nodejs/node/commit/228127fc67 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| 45d6106129 | https://github.com/nodejs/node/commit/45d6106129 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| 631bea8fd2 | https://github.com/nodejs/node/commit/631bea8fd2 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| a636338945 | https://github.com/nodejs/node/commit/a636338945 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| 50732c1b3f | https://github.com/nodejs/node/commit/50732c1b3f |
| #27014 | https://github.com/nodejs/node/pull/27014 |
| e9021cc498 | https://github.com/nodejs/node/commit/e9021cc498 |
| #27014 | https://github.com/nodejs/node/pull/27014 |
| ebbed6047d | https://github.com/nodejs/node/commit/ebbed6047d |
| #27300 | https://github.com/nodejs/node/pull/27300 |
| f0b2992f5c | https://github.com/nodejs/node/commit/f0b2992f5c |
| #27333 | https://github.com/nodejs/node/pull/27333 |
| d84a6d05a1 | https://github.com/nodejs/node/commit/d84a6d05a1 |
| #27340 | https://github.com/nodejs/node/pull/27340 |
| 8486917b9a | https://github.com/nodejs/node/commit/8486917b9a |
| #27330 | https://github.com/nodejs/node/pull/27330 |
| 6ca0270320 | https://github.com/nodejs/node/commit/6ca0270320 |
| #27390 | https://github.com/nodejs/node/pull/27390 |
| dcbe5b9dff | https://github.com/nodejs/node/commit/dcbe5b9dff |
| #27374 | https://github.com/nodejs/node/pull/27374 |
| 53f0ef36c0 | https://github.com/nodejs/node/commit/53f0ef36c0 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| 481789c235 | https://github.com/nodejs/node/commit/481789c235 |
| #27332 | https://github.com/nodejs/node/pull/27332 |
| d62a3243b1 | https://github.com/nodejs/node/commit/d62a3243b1 |
| #27362 | https://github.com/nodejs/node/pull/27362 |
| b44323f3de | https://github.com/nodejs/node/commit/b44323f3de |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| ae2333db65 | https://github.com/nodejs/node/commit/ae2333db65 |
| #27351 | https://github.com/nodejs/node/pull/27351 |
| 8f3442809a | https://github.com/nodejs/node/commit/8f3442809a |
| #27342 | https://github.com/nodejs/node/pull/27342 |
| 973d705aa9 | https://github.com/nodejs/node/commit/973d705aa9 |
| #27342 | https://github.com/nodejs/node/pull/27342 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| joyeecheung | https://github.com/joyeecheung |
| April 27, 2019 11:35 | https://github.com/nodejs/node/pull/27440#commits-pushed-a636338 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: allow creating NodeMainInstance that does not own the isolate | https://github.com/nodejs/node/pull/27440/commits/a6363389456e19448b9507271b68ccf3f40a3f98 |
| a636338 | https://github.com/nodejs/node/pull/27440/commits/a6363389456e19448b9507271b68ccf3f40a3f98 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: implement IsolateData serialization and deserialization | https://github.com/nodejs/node/pull/27440/commits/631bea8fd2c3e9a344a8e2c53b6c48007c650685 |
| 631bea8 | https://github.com/nodejs/node/pull/27440/commits/631bea8fd2c3e9a344a8e2c53b6c48007c650685 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| tools: implement node_mksnapshot | https://github.com/nodejs/node/pull/27440/commits/b44323f3de8b3ec6d5b834bdcc9362bb5fe6d6a1 |
| b44323f | https://github.com/nodejs/node/pull/27440/commits/b44323f3de8b3ec6d5b834bdcc9362bb5fe6d6a1 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: enable snapshot with per-isolate data | https://github.com/nodejs/node/pull/27440/commits/45d610612981223a9b4e4a8d1d8f21caecceb700 |
| 45d6106 | https://github.com/nodejs/node/pull/27440/commits/45d610612981223a9b4e4a8d1d8f21caecceb700 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: enable context snapshot after running per-context scripts | https://github.com/nodejs/node/pull/27440/commits/228127fc67d9c4da48b78ff5f6a71a4cf883e2cf |
| 228127f | https://github.com/nodejs/node/pull/27440/commits/228127fc67d9c4da48b78ff5f6a71a4cf883e2cf |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: use std::vector instead of IndexArray | https://github.com/nodejs/node/pull/27440/commits/ad42cd69cf9c655a6977a8beac2f09a85e7bf51d |
| ad42cd6 | https://github.com/nodejs/node/pull/27440/commits/ad42cd69cf9c655a6977a8beac2f09a85e7bf51d |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: simplify Collaborator pre-nomination text | https://github.com/nodejs/node/pull/27440/commits/a6d1fa59541eec0bb630cb00d338edfebe306b89 |
| a6d1fa5 | https://github.com/nodejs/node/pull/27440/commits/a6d1fa59541eec0bb630cb00d338edfebe306b89 |
| #27348 | https://github.com/nodejs/node/pull/27348 |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| tools: update tools/license-builder.sh | https://github.com/nodejs/node/pull/27440/commits/d62a3243b1841437e201331e9df09dad7d2db39e |
| d62a324 | https://github.com/nodejs/node/pull/27440/commits/d62a3243b1841437e201331e9df09dad7d2db39e |
| #25614 | https://github.com/nodejs/node/pull/25614 |
| #27362 | https://github.com/nodejs/node/pull/27362 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| build: disable custom v8 snapshot by default | https://github.com/nodejs/node/pull/27440/commits/50234460f9c39f50504fcef067ad0730eca65414 |
| 5023446 | https://github.com/nodejs/node/pull/27440/commits/50234460f9c39f50504fcef067ad0730eca65414 |
| #27365 | https://github.com/nodejs/node/pull/27365 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
|
| https://github.com/BethGriggs |
|
| https://github.com/targos |
| doc: fix v12.0.0 changelog id | https://github.com/nodejs/node/pull/27440/commits/f70588fb6746e4af424188b7126fb9021b6df20b |
| f70588f | https://github.com/nodejs/node/pull/27440/commits/f70588fb6746e4af424188b7126fb9021b6df20b |
| #27368 | https://github.com/nodejs/node/pull/27368 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| benchmark: fix http bench-parser.js | https://github.com/nodejs/node/pull/27440/commits/8ca110cc6f723cca50e1971265363fc895426757 |
| 8ca110c | https://github.com/nodejs/node/pull/27440/commits/8ca110cc6f723cca50e1971265363fc895426757 |
| ece5073 | https://github.com/nodejs/node/commit/ece507394a563bd7e3555a840a3d6980ffbb01ac |
| #27359 | https://github.com/nodejs/node/pull/27359 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: increase coverage in lib/internal/dns/promises.js | https://github.com/nodejs/node/pull/27440/commits/8486917b9a2006ee26b7003c5425c5e8586c9b8f |
| 8486917 | https://github.com/nodejs/node/pull/27440/commits/8486917b9a2006ee26b7003c5425c5e8586c9b8f |
| #27330 | https://github.com/nodejs/node/pull/27330 |
|
| https://github.com/targos |
| dgram: change 'this' to 'self' for 'isConnected' | https://github.com/nodejs/node/pull/27440/commits/ee80a210ffd37eab3b660be6f55fd161ea044ea1 |
| ee80a21 | https://github.com/nodejs/node/pull/27440/commits/ee80a210ffd37eab3b660be6f55fd161ea044ea1 |
| #27338 | https://github.com/nodejs/node/pull/27338 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: make test-worker-esm-missing-main more robust | https://github.com/nodejs/node/pull/27440/commits/d84a6d05a175688bf2f2ba4c48d855dde8f105ed |
| d84a6d0 | https://github.com/nodejs/node/pull/27440/commits/d84a6d05a175688bf2f2ba4c48d855dde8f105ed |
| #27340 | https://github.com/nodejs/node/pull/27340 |
|
| https://github.com/targos |
| test: fix ineffective error tests | https://github.com/nodejs/node/pull/27440/commits/f0b2992f5c2be1afc781b57cfa34f6294c277b1f |
| f0b2992 | https://github.com/nodejs/node/pull/27440/commits/f0b2992f5c2be1afc781b57cfa34f6294c277b1f |
| #27333 | https://github.com/nodejs/node/pull/27333 |
| #26385 | https://github.com/nodejs/node/issues/26385 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
| tools: fix use-after-free mkcodecache warning | https://github.com/nodejs/node/pull/27440/commits/481789c235cbf77e0a0f991567acae0ab15dc5d5 |
| 481789c | https://github.com/nodejs/node/pull/27440/commits/481789c235cbf77e0a0f991567acae0ab15dc5d5 |
| #27332 | https://github.com/nodejs/node/pull/27332 |
|
| https://github.com/sam-github |
|
| https://github.com/targos |
| doc: clarify behaviour of writeFile(fd) | https://github.com/nodejs/node/pull/27440/commits/36762883a020f8f9acc71c67bcc62b6242f28e3f |
| 3676288 | https://github.com/nodejs/node/pull/27440/commits/36762883a020f8f9acc71c67bcc62b6242f28e3f |
| #24923 | https://github.com/nodejs/node/issues/24923 |
| #27282 | https://github.com/nodejs/node/pull/27282 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: apply clang-tidy rule modernize-use-equals-default | https://github.com/nodejs/node/pull/27440/commits/7bc47cba2e69a5c5b97a096306d41150665428e5 |
| 7bc47cb | https://github.com/nodejs/node/pull/27440/commits/7bc47cba2e69a5c5b97a096306d41150665428e5 |
| #27264 | https://github.com/nodejs/node/pull/27264 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: add Environment overload of EmitAsyncDestroy | https://github.com/nodejs/node/pull/27440/commits/809cf595ebce1b9dbb07ba055fbf44957de1e617 |
| 809cf59 | https://github.com/nodejs/node/pull/27440/commits/809cf595ebce1b9dbb07ba055fbf44957de1e617 |
| #27218 | https://github.com/nodejs/node/issues/27218 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| #27218 | https://github.com/nodejs/node/issues/27218 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| n-api: do not require JS Context for napi_async_destroy() | https://github.com/nodejs/node/pull/27440/commits/8b5d73867fe3c4be967af3d47fa801a79afca4f8 |
| 8b5d738 | https://github.com/nodejs/node/pull/27440/commits/8b5d73867fe3c4be967af3d47fa801a79afca4f8 |
| #27218 | https://github.com/nodejs/node/issues/27218 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: do not require JS Context for ~AsyncResoure() | https://github.com/nodejs/node/pull/27440/commits/619c5b6eb3dc04fa791e148110c0f1fcdd543efa |
| 619c5b6 | https://github.com/nodejs/node/pull/27440/commits/619c5b6eb3dc04fa791e148110c0f1fcdd543efa |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| #27218 | https://github.com/nodejs/node/issues/27218 |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
| doc: fix pull request number | https://github.com/nodejs/node/pull/27440/commits/453510c7ef7dae452a44da2752084c1d08246a61 |
| 453510c | https://github.com/nodejs/node/pull/27440/commits/453510c7ef7dae452a44da2752084c1d08246a61 |
| #27336 | https://github.com/nodejs/node/pull/27336 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| lib: throw a special error in internal/assert | https://github.com/nodejs/node/pull/27440/commits/dd709fc84a6c04408221d096ca8e738b8fe4e870 |
| dd709fc | https://github.com/nodejs/node/pull/27440/commits/dd709fc84a6c04408221d096ca8e738b8fe4e870 |
| #26635 | https://github.com/nodejs/node/pull/26635 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| module: initialize module_wrap.callbackMap during pre-execution | https://github.com/nodejs/node/pull/27440/commits/4dfe54a89ac8c0602b88e7c507e4ad9c42e00bdb |
| 4dfe54a | https://github.com/nodejs/node/pull/27440/commits/4dfe54a89ac8c0602b88e7c507e4ad9c42e00bdb |
| #27323 | https://github.com/nodejs/node/pull/27323 |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
| util: improve Symbol.toStringTag handling | https://github.com/nodejs/node/pull/27440/commits/973d705aa9ff7dc8e55742363644f2382482e113 |
| 973d705 | https://github.com/nodejs/node/pull/27440/commits/973d705aa9ff7dc8e55742363644f2382482e113 |
| #27342 | https://github.com/nodejs/node/pull/27342 |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
| util: rename setIteratorBraces to getIteratorBraces | https://github.com/nodejs/node/pull/27440/commits/8f3442809a62c9e69e86e04d3b32d7e5d849c369 |
| 8f34428 | https://github.com/nodejs/node/pull/27440/commits/8f3442809a62c9e69e86e04d3b32d7e5d849c369 |
| #27342 | https://github.com/nodejs/node/pull/27342 |
|
| https://github.com/sam-github |
|
| https://github.com/targos |
| test: rework to remove flakiness, and be parallel | https://github.com/nodejs/node/pull/27440/commits/ebbed6047de1d58e59d19b920e2cdce11bf3933c |
| ebbed60 | https://github.com/nodejs/node/pull/27440/commits/ebbed6047de1d58e59d19b920e2cdce11bf3933c |
| #27300 | https://github.com/nodejs/node/pull/27300 |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| deps: update ICU to 64.2 | https://github.com/nodejs/node/pull/27440/commits/d852d9e904717d5721ecfbcf9ea1ad616ed9e2b2 |
| d852d9e | https://github.com/nodejs/node/pull/27440/commits/d852d9e904717d5721ecfbcf9ea1ad616ed9e2b2 |
| #26388 | https://github.com/nodejs/node/issues/26388 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| tools: update LICENSE and tools/icu/current_ver.dep | https://github.com/nodejs/node/pull/27440/commits/53f0ef36c0b452f9cd59619647491d347496afc7 |
| 53f0ef3 | https://github.com/nodejs/node/pull/27440/commits/53f0ef36c0b452f9cd59619647491d347496afc7 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| #26388 | https://github.com/nodejs/node/issues/26388 |
|
| https://github.com/sam-github |
|
| https://github.com/targos |
| tools: update certdata.txt | https://github.com/nodejs/node/pull/27440/commits/dcbe5b9dff94de3d834dc3442e13debbb4d4ee89 |
| dcbe5b9 | https://github.com/nodejs/node/pull/27440/commits/dcbe5b9dff94de3d834dc3442e13debbb4d4ee89 |
| https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt | https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt |
| #27374 | https://github.com/nodejs/node/pull/27374 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487295769 |
| 50234460f9 | https://github.com/nodejs/node/commit/50234460f9 |
| b44323f3de | https://github.com/nodejs/node/commit/b44323f3de |
| https://ci.nodejs.org/job/node-release-candidate/3/ | https://ci.nodejs.org/job/node-release-candidate/3/ |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487296872 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487296956 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/job/node-release-candidate | https://ci.nodejs.org/job/node-release-candidate |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487297495 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/job/node-release-candidate | https://ci.nodejs.org/job/node-release-candidate |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487297887 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 27, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487299000 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Apr 28, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487345121 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487458559 |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487460681 |
| #27373 | https://github.com/nodejs/node/pull/27373 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| joyeecheung | https://github.com/joyeecheung |
| April 29, 2019 14:32 | https://github.com/nodejs/node/pull/27440#commits-pushed-d00014e |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| process: reduce the number of internal frames in async stack trace | https://github.com/nodejs/node/pull/27440/commits/d00014e5999c41d54b3287498316157a7e64366b |
| d00014e | https://github.com/nodejs/node/pull/27440/commits/d00014e5999c41d54b3287498316157a7e64366b |
| #27392 | https://github.com/nodejs/node/pull/27392 |
|
| https://github.com/targos |
| 2019-04-29, Version 12.1.0 (Current) | https://github.com/nodejs/node/pull/27440/commits/bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
| bf12414 | https://github.com/nodejs/node/pull/27440/commits/bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| #27415 | https://github.com/nodejs/node/pull/27415 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| #27440 | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/36842d7ac4131dded2d4f3a784fbf38147de0259..bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
| 36842d7 | https://github.com/nodejs/node/commit/36842d7ac4131dded2d4f3a784fbf38147de0259 |
| bf12414 | https://github.com/nodejs/node/commit/bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
|
Compare
| https://github.com/nodejs/node/compare/36842d7ac4131dded2d4f3a784fbf38147de0259..bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
| April 29, 2019 12:37 | https://github.com/nodejs/node/pull/27440#event-2306556319 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487562633 |
| https://ci.nodejs.org/job/node-test-pull-request/22808/ | https://ci.nodejs.org/job/node-test-pull-request/22808/ |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487562821 |
| https://ci-release.nodejs.org/job/iojs+release/4413/ | https://ci-release.nodejs.org/job/iojs+release/4413/ |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487573000 |
| @BridgeAR | https://github.com/BridgeAR |
| d00014e | https://github.com/nodejs/node/commit/d00014e5999c41d54b3287498316157a7e64366b |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487577497 |
| https://ci.nodejs.org/job/node-test-pull-request/22812/ | https://ci.nodejs.org/job/node-test-pull-request/22812/ |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487581829 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#issuecomment-487604461 |
| @targos | https://github.com/targos |
| #27373 | https://github.com/nodejs/node/pull/27373 |
| cc7b3fb | https://github.com/nodejs/node/commit/cc7b3fbaab2f0b4788e209178fd78eda88d65375 |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| bf12414 | https://github.com/nodejs/node/commit/bf12414bbf4295cb47c4c8b69bc2aa6828778453 |
| Apr 29, 2019 | https://github.com/nodejs/node/pull/27440#event-2306903183 |
| targos | https://github.com/targos |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-commit-36d6168 |
|
| https://github.com/targos |
| Working on v12.1.1 | https://github.com/nodejs/node/commit/36d61681e19ca2c4c5cd22e342a3762cf1ea3cd7 |
| 36d6168 | https://github.com/nodejs/node/commit/36d61681e19ca2c4c5cd22e342a3762cf1ea3cd7 |
| #27440 | https://github.com/nodejs/node/pull/27440 |
| targos | https://github.com/targos |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-commit-1d4a880 |
|
| https://github.com/targos |
| 2019-04-29, Version 12.1.0 (Current) | https://github.com/nodejs/node/commit/1d4a8807009f0d97175bb8d14007805950a00408 |
| 1d4a880 | https://github.com/nodejs/node/commit/1d4a8807009f0d97175bb8d14007805950a00408 |
| #27361 | https://github.com/nodejs/node/pull/27361 |
| #27415 | https://github.com/nodejs/node/pull/27415 |
| #27255 | https://github.com/nodejs/node/pull/27255 |
| #27440 | https://github.com/nodejs/node/pull/27440 |
| targos | https://github.com/targos |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-commit-9d05633 |
|
| https://github.com/targos |
| Blog: v12.1.0 release post | https://github.com/nodejs/nodejs.org/commit/9d056330d22ff2828322fc3a1fefd0837735a249 |
| 9d05633 | https://github.com/nodejs/nodejs.org/commit/9d056330d22ff2828322fc3a1fefd0837735a249 |
| nodejs/node#27440 | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-pullrequest-438352820 |
|
Blog: v12.1.0 release post
nodejs/nodejs.org#2214
| https://github.com/nodejs/nodejs.org/pull/2214 |
| targos | https://github.com/targos |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-commit-52e985b |
|
| https://github.com/targos |
| Blog: v12.1.0 release post ( | https://github.com/nodejs/nodejs.org/commit/52e985b598e0f6e50968c912f6e45ab06adea47c |
| #2214 | https://github.com/nodejs/nodejs.org/pull/2214 |
| ) | https://github.com/nodejs/nodejs.org/commit/52e985b598e0f6e50968c912f6e45ab06adea47c |
| 52e985b | https://github.com/nodejs/nodejs.org/commit/52e985b598e0f6e50968c912f6e45ab06adea47c |
| nodejs/node#27440 | https://github.com/nodejs/node/pull/27440 |
| https://github.com/targos |
| targos | https://github.com/targos |
| April 29, 2019 14:45 | https://github.com/nodejs/node/pull/27440#event-2306925856 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/27440#ref-pullrequest-438463711 |
|
test: make sure weak references are not GCed to early
#27482
| https://github.com/nodejs/node/pull/27482 |
| https://github.com/Viggo95 |
| Viggo95 | https://github.com/Viggo95 |
|
Dec 11, 2020
| https://github.com/nodejs/node/pull/27440#ref-issue-747362661 |
|
[Bug] 项目启动失败
umijs/umi#5710
| https://github.com/umijs/umi/issues/5710 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
release
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arelease |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Jun 6, 2021 | https://github.com/nodejs/node/pull/27440#event-4847938813 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27440 |
|
release
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arelease |
| Please reload this page | https://github.com/nodejs/node/pull/27440 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/srl295 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
|
| https://github.com/joyeecheung |
|
| https://github.com/Trott |
|
| https://github.com/ryzokuken |
|
| https://github.com/BethGriggs |
|
| https://github.com/bnoordhuis |
|
| https://github.com/sam-github |
|
| https://github.com/gengjiawen |
|
| https://github.com/rivajunior |
|
| https://github.com/MylesBorins |
|
| https://github.com/lpinca |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |