René's URL Explorer Experiment


Title: test: refactor and deflake test-tls-sni-server-client by lpinca · Pull Request #27426 · nodejs/node · GitHub

Open Graph Title: test: refactor and deflake test-tls-sni-server-client by lpinca · Pull Request #27426 · nodejs/node

X Title: test: refactor and deflake test-tls-sni-server-client by lpinca · Pull Request #27426 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Run all tests in parallel. Move socket.end() call to client. Use common.mustCall() and common.mustNotCall(). Fixes: #27219 Refs: #27300 Checklist make -j4 test (UNIX), or vcbuild test (Windows...

X Description: Run all tests in parallel. Move socket.end() call to client. Use common.mustCall() and common.mustNotCall(). Fixes: #27219 Refs: #27300 Checklist make -j4 test (UNIX), or vcbuild test (Windows...

Opengraph URL: https://github.com/nodejs/node/pull/27426

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:534ca285-3ebe-92d8-6ef7-5cc40ea2cf68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB64:2CD26:E9551D:155AA39:6A4E3162
html-safe-noncee53472350d23cf70cc4039d6ef1d429b90520c74794d58bb4938d95c5f50b17c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjY0OjJDRDI2OkU5NTUxRDoxNTVBQTM5OjZBNEUzMTYyIiwidmlzaXRvcl9pZCI6IjQxNzU2NDExNzkxNzY0NDgzNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace739c4e0ce2786a585b6866b0b8e8e3ef2214bef86fad03764885e9730d67185
hovercard-subject-tagpull_request:273919418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27426/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ba84e629f60f3a9f9f4d7673ae1d55be7fb06662368dfabfcab379868996b28/nodejs/node/pull/27426
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ba84e629f60f3a9f9f4d7673ae1d55be7fb06662368dfabfcab379868996b28/nodejs/node/pull/27426
og:image:altRun all tests in parallel. Move socket.end() call to client. Use common.mustCall() and common.mustNotCall(). Fixes: #27219 Refs: #27300 Checklist make -j4 test (UNIX), or vcbuild test (Windows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42a6d378d7587a44c93aca255096cd66b7c8eb2d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27426#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27426
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27426
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27426
Reloadhttps://github.com/nodejs/node/pull/27426
Reloadhttps://github.com/nodejs/node/pull/27426
Please reload this pagehttps://github.com/nodejs/node/pull/27426
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27426
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:deflake/test-tls-sni-server-clienthttps://github.com/lpinca/node/tree/deflake/test-tls-sni-server-client
Conversationhttps://github.com/nodejs/node/pull/27426
Commits1 (1)https://github.com/nodejs/node/pull/27426/commits
Checkshttps://github.com/nodejs/node/pull/27426/checks
Files changedhttps://github.com/nodejs/node/pull/27426/files
test: refactor and deflake test-tls-sni-server-clienthttps://github.com/nodejs/node/pull/27426#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:deflake/test-tls-sni-server-clienthttps://github.com/lpinca/node/tree/deflake/test-tls-sni-server-client
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 26, 2019https://github.com/nodejs/node/pull/27426#issue-437699834
#27219https://github.com/nodejs/node/issues/27219
#27300https://github.com/nodejs/node/pull/27300
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 26, 2019https://github.com/nodejs/node/pull/27426#issuecomment-487076975
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3373https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3373
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Apr 26, 2019https://github.com/nodejs/node/pull/27426#event-2303263595
https://github.com/lpinca
lpincahttps://github.com/lpinca
sam-githubhttps://github.com/sam-github
April 26, 2019 14:27https://github.com/nodejs/node/pull/27426#event-2303264648
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Apr 26, 2019 https://github.com/nodejs/node/pull/27426#pullrequestreview-231213925
View reviewed changes https://github.com/nodejs/node/pull/27426/files
https://github.com/Trott
Trotthttps://github.com/Trott
May 1, 2019 https://github.com/nodejs/node/pull/27426#pullrequestreview-232485658
View reviewed changes https://github.com/nodejs/node/pull/27426/files
test/parallel/test-tls-sni-server-client.jshttps://github.com/nodejs/node/pull/27426/files#diff-b3349d9439bcc17c0cd42f7967b7e59edc5bce977835ecc519dd323c9e964884
Trotthttps://github.com/Trott
May 1, 2019https://github.com/nodejs/node/pull/27426#discussion_r280000850
Please reload this pagehttps://github.com/nodejs/node/pull/27426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27426
lpincahttps://github.com/lpinca
May 1, 2019https://github.com/nodejs/node/pull/27426#discussion_r280008973
Please reload this pagehttps://github.com/nodejs/node/pull/27426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27426
sam-githubhttps://github.com/sam-github
May 1, 2019https://github.com/nodejs/node/pull/27426#discussion_r280134069
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/27426
lpincahttps://github.com/lpinca
May 1, 2019https://github.com/nodejs/node/pull/27426#discussion_r280149065
Please reload this pagehttps://github.com/nodejs/node/pull/27426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/Trott
Trotthttps://github.com/Trott
May 1, 2019 https://github.com/nodejs/node/pull/27426#pullrequestreview-232485766
View reviewed changes https://github.com/nodejs/node/pull/27426/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/27426#pullrequestreview-232485766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/Trott
Trotthttps://github.com/Trott
May 1, 2019https://github.com/nodejs/node/pull/27426#issuecomment-488205204
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/lpinca
test: refactor and deflake test-tls-sni-server-clienthttps://github.com/nodejs/node/pull/27426/commits/8d63f4c444b74393dcad62eb9011773a836321ab
8d63f4chttps://github.com/nodejs/node/pull/27426/commits/8d63f4c444b74393dcad62eb9011773a836321ab
nodejs#27219https://github.com/nodejs/node/issues/27219
nodejs#27300https://github.com/nodejs/node/pull/27300
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/e61b13c851515385e36fdd71113ee17781d982dc..8d63f4c444b74393dcad62eb9011773a836321ab
e61b13chttps://github.com/nodejs/node/commit/e61b13c851515385e36fdd71113ee17781d982dc
8d63f4chttps://github.com/nodejs/node/commit/8d63f4c444b74393dcad62eb9011773a836321ab
Compare https://github.com/nodejs/node/compare/e61b13c851515385e36fdd71113ee17781d982dc..8d63f4c444b74393dcad62eb9011773a836321ab
May 1, 2019 06:02https://github.com/nodejs/node/pull/27426#event-2311365367
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 2, 2019https://github.com/nodejs/node/pull/27426#issuecomment-488564492
https://ci.nodejs.org/job/node-test-pull-request/22881/https://ci.nodejs.org/job/node-test-pull-request/22881/
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/Trott
Trotthttps://github.com/Trott
May 2, 2019https://github.com/nodejs/node/pull/27426#issuecomment-488574632
bc0a330https://github.com/nodejs/node/commit/bc0a33070f48eb2bba99990f367a455c2ca4fcf7
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/Trott
Trotthttps://github.com/Trott
May 2, 2019https://github.com/nodejs/node/pull/27426#event-2313703158
Trotthttps://github.com/Trott
May 2, 2019 https://github.com/nodejs/node/pull/27426#ref-commit-bc0a330
https://github.com/lpinca
https://github.com/Trott
test: refactor and deflake test-tls-sni-server-clienthttps://github.com/Trott/io.js/commit/bc0a33070f48eb2bba99990f367a455c2ca4fcf7
bc0a330https://github.com/Trott/io.js/commit/bc0a33070f48eb2bba99990f367a455c2ca4fcf7
nodejs#27219https://github.com/nodejs/node/issues/27219
nodejs#27300https://github.com/nodejs/node/pull/27300
nodejs#27426https://github.com/nodejs/node/pull/27426
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 4, 2019 07:44https://github.com/nodejs/node/pull/27426#event-2318896433
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27426#ref-commit-df4246e
https://github.com/lpinca
https://github.com/targos
test: refactor and deflake test-tls-sni-server-clienthttps://github.com/nodejs/node/commit/df4246e3b6bdfd18103df250af904434fc7c68fe
df4246ehttps://github.com/nodejs/node/commit/df4246e3b6bdfd18103df250af904434fc7c68fe
#27219https://github.com/nodejs/node/issues/27219
#27300https://github.com/nodejs/node/pull/27300
#27426https://github.com/nodejs/node/pull/27426
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 5, 2019 https://github.com/nodejs/node/pull/27426#ref-pullrequest-440418236
test: fix flaky test-tls-multiple-cas-as-string #27569 https://github.com/nodejs/node/pull/27569
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27426#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27426
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27426/files/e61b13c851515385e36fdd71113ee17781d982dc
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/27426/files/8d63f4c444b74393dcad62eb9011773a836321ab
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Investigate flaky parallel/test-tls-sni-server-client https://github.com/nodejs/node/issues/27219
Please reload this pagehttps://github.com/nodejs/node/pull/27426
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/sam-github
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.