René's URL Explorer Experiment


Title: module: initialize module_wrap.callbackMap during pre-execution by joyeecheung · Pull Request #27323 · nodejs/node · GitHub

Open Graph Title: module: initialize module_wrap.callbackMap during pre-execution by joyeecheung · Pull Request #27323 · nodejs/node

X Title: module: initialize module_wrap.callbackMap during pre-execution by joyeecheung · Pull Request #27323 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since the bootstrap does not actually use ESM at all, there is no need to create this map so early. This patch moves the initialization of the map to pre-execution, so that the only binding loaded ...

X Description: Since the bootstrap does not actually use ESM at all, there is no need to create this map so early. This patch moves the initialization of the map to pre-execution, so that the only binding loaded ...

Opengraph URL: https://github.com/nodejs/node/pull/27323

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2ad13638-79ce-42bf-c8b3-8ea8dbb6a353
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B26:2D209F:5BECDA:8646E5:6A4E0A2C
html-safe-nonce6a3557b6310a236f9c7e00e9c5232e8d05dc3cc8bd7164d7900b0338752ecb55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjI2OjJEMjA5Rjo1QkVDREE6ODY0NkU1OjZBNEUwQTJDIiwidmlzaXRvcl9pZCI6IjE3NDA4Mzk2OTgxMzYxNzMxMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4a6e40f934249d5d8da45ca5266170fa3da6790986f9d076b7769d1afe6e36c8
hovercard-subject-tagpull_request:272154334
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27323/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/06c530f111e1cdd4eb9bb13c452f907ae97679872f106518f970fa7de88c5751/nodejs/node/pull/27323
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/06c530f111e1cdd4eb9bb13c452f907ae97679872f106518f970fa7de88c5751/nodejs/node/pull/27323
og:image:altSince the bootstrap does not actually use ESM at all, there is no need to create this map so early. This patch moves the initialization of the map to pre-execution, so that the only binding loaded ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27323#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27323
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27323
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27323
Reloadhttps://github.com/nodejs/node/pull/27323
Reloadhttps://github.com/nodejs/node/pull/27323
Please reload this pagehttps://github.com/nodejs/node/pull/27323
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27323
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:move-callbackhttps://github.com/joyeecheung/node/tree/move-callback
Conversationhttps://github.com/nodejs/node/pull/27323
Commits1 (1)https://github.com/nodejs/node/pull/27323/commits
Checkshttps://github.com/nodejs/node/pull/27323/checks
Files changedhttps://github.com/nodejs/node/pull/27323/files
module: initialize module_wrap.callbackMap during pre-executionhttps://github.com/nodejs/node/pull/27323#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:move-callbackhttps://github.com/joyeecheung/node/tree/move-callback
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 20, 2019https://github.com/nodejs/node/pull/27323#issue-435401294
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/joyeecheung
module: initialize module_wrap.callbackMap during pre-executionhttps://github.com/nodejs/node/pull/27323/commits/25e0228c833640eebc3b887e75bfd8e213a0309f
25e0228https://github.com/nodejs/node/pull/27323/commits/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 20, 2019https://github.com/nodejs/node/pull/27323#issuecomment-485123069
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3312https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3312
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Apr 20, 2019https://github.com/nodejs/node/pull/27323#event-2289553517
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 20, 2019https://github.com/nodejs/node/pull/27323#issuecomment-485123255
https://ci.nodejs.org/job/node-test-pull-request/22582/https://ci.nodejs.org/job/node-test-pull-request/22582/
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Apr 20, 2019 https://github.com/nodejs/node/pull/27323#pullrequestreview-228878723
View reviewed changes https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 20, 2019 https://github.com/nodejs/node/pull/27323#pullrequestreview-228890990
View reviewed changes https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 21, 2019 https://github.com/nodejs/node/pull/27323#pullrequestreview-228917132
View reviewed changes https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 21, 2019https://github.com/nodejs/node/pull/27323#event-2290175520
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 22, 2019https://github.com/nodejs/node/pull/27323#issuecomment-485387605
https://ci.nodejs.org/job/node-test-pull-request/22620/https://ci.nodejs.org/job/node-test-pull-request/22620/
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 25, 2019https://github.com/nodejs/node/pull/27323#issuecomment-486513053
80c0b89https://github.com/nodejs/node/commit/80c0b89bbbed26eca955f4f70922fa288b664c68
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 25, 2019https://github.com/nodejs/node/pull/27323#event-2299053674
joyeecheunghttps://github.com/joyeecheung
Apr 25, 2019 https://github.com/nodejs/node/pull/27323#ref-commit-80c0b89
https://github.com/joyeecheung
module: initialize module_wrap.callbackMap during pre-executionhttps://github.com/nodejs/node/commit/80c0b89bbbed26eca955f4f70922fa288b664c68
80c0b89https://github.com/nodejs/node/commit/80c0b89bbbed26eca955f4f70922fa288b664c68
#27323https://github.com/nodejs/node/pull/27323
targoshttps://github.com/targos
Apr 27, 2019 https://github.com/nodejs/node/pull/27323#ref-commit-4dfe54a
https://github.com/joyeecheung
https://github.com/targos
module: initialize module_wrap.callbackMap during pre-executionhttps://github.com/nodejs/node/commit/4dfe54a89ac8c0602b88e7c507e4ad9c42e00bdb
4dfe54ahttps://github.com/nodejs/node/commit/4dfe54a89ac8c0602b88e7c507e4ad9c42e00bdb
#27323https://github.com/nodejs/node/pull/27323
https://github.com/targos
targoshttps://github.com/targos
Apr 27, 2019 https://github.com/nodejs/node/pull/27323#ref-pullrequest-437929799
v12.1.0 proposal #27440 https://github.com/nodejs/node/pull/27440
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27323
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/27323/files/25e0228c833640eebc3b887e75bfd8e213a0309f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/27323
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.