| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d5ffb80e-adfc-015e-6fe1-fdfa8a2d4609 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCEE:EC2BF:B33602:1046CCA:6A4E1D63 |
| html-safe-nonce | ac268c87d84fc0a270caac4ed78e6cacc7478bc13910cb59ec8680e765e7da01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0VFOkVDMkJGOkIzMzYwMjoxMDQ2Q0NBOjZBNEUxRDYzIiwidmlzaXRvcl9pZCI6IjgzNDAzMTYzMDQzMzUzMTQyNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b59a8e15c69770bdd88780d256f206aae6077381b65bdb717ce0588a31dc734d |
| hovercard-subject-tag | pull_request:272146235 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27321/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/147d0a3865425a29e3c6a28e02bb9081cc4739ab0eed43bc858a31a8950851d5/nodejs/node/pull/27321 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/147d0a3865425a29e3c6a28e02bb9081cc4739ab0eed43bc858a31a8950851d5/nodejs/node/pull/27321 |
| og:image:alt | This PR adds minimal support for embedded v8 snapshot. The generated snapshot currently includes:
Per-isolate data (symbols and strings)
The main context snapshotted after running the per-context ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5fe497b4815fcce3df76c0e246faa739a82c3124 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27321#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27321 |
| Reload | https://github.com/nodejs/node/pull/27321 |
| Reload | https://github.com/nodejs/node/pull/27321 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:mksnapshot-minimal | https://github.com/joyeecheung/node/tree/mksnapshot-minimal |
| Conversation | https://github.com/nodejs/node/pull/27321 |
| Commits10 (10) | https://github.com/nodejs/node/pull/27321/commits |
| Checks | https://github.com/nodejs/node/pull/27321/checks |
| Files changed | https://github.com/nodejs/node/pull/27321/files |
| src: implement minimal v8 snapshot integration | https://github.com/nodejs/node/pull/27321#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:mksnapshot-minimal | https://github.com/joyeecheung/node/tree/mksnapshot-minimal |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issue-435384124 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| #27236 | https://github.com/nodejs/node/pull/27236 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#event-2289441211 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485090927 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/350/ | https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/350/ |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| April 20, 2019 11:22 | https://github.com/nodejs/node/pull/27321#event-2289461723 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485096479 |
| @hashseed | https://github.com/hashseed |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 20, 2019
| https://github.com/nodejs/node/pull/27321#ref-issue-274286007 |
|
RFC: speeding up Node.js startup using V8 snapshot
#17058
| https://github.com/nodejs/node/issues/17058 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 20, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-228875519 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485099386 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485114977 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485115590 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| joyeecheung | https://github.com/joyeecheung |
| April 20, 2019 21:15 | https://github.com/nodejs/node/pull/27321#commits-pushed-076c31f |
|
| https://github.com/joyeecheung |
| src: allow creating NodeMainInstance that does not own the isolate | https://github.com/nodejs/node/pull/27321/commits/076c31f3eff309df8f7e0129db7a8a1982b3e944 |
| 076c31f | https://github.com/nodejs/node/pull/27321/commits/076c31f3eff309df8f7e0129db7a8a1982b3e944 |
|
| https://github.com/joyeecheung |
| src: implement IsolateData serialization and deserialization | https://github.com/nodejs/node/pull/27321/commits/e354795ae2275a6438d686cfb52e3e59b0ae359c |
| e354795 | https://github.com/nodejs/node/pull/27321/commits/e354795ae2275a6438d686cfb52e3e59b0ae359c |
|
| https://github.com/joyeecheung |
| tools: implement node_mksnapshot | https://github.com/nodejs/node/pull/27321/commits/de02be6b15a1219ae28f75bf44466608afe6d916 |
| de02be6 | https://github.com/nodejs/node/pull/27321/commits/de02be6b15a1219ae28f75bf44466608afe6d916 |
|
| https://github.com/joyeecheung |
| src: enable snapshot with per-isolate data | https://github.com/nodejs/node/pull/27321/commits/52c5c052ea104a8aa4ea849e6451b1a0fb482979 |
| 52c5c05 | https://github.com/nodejs/node/pull/27321/commits/52c5c052ea104a8aa4ea849e6451b1a0fb482979 |
|
| https://github.com/joyeecheung |
| src: enable context snapshot after running per-context scripts | https://github.com/nodejs/node/pull/27321/commits/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| 8248be6 | https://github.com/nodejs/node/pull/27321/commits/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/f8a6cb923b1faa7c8e709eef66b3edb3e7a64a5c..8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| f8a6cb9 | https://github.com/nodejs/node/commit/f8a6cb923b1faa7c8e709eef66b3edb3e7a64a5c |
| 8248be6 | https://github.com/nodejs/node/commit/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
|
Compare
| https://github.com/nodejs/node/compare/f8a6cb923b1faa7c8e709eef66b3edb3e7a64a5c..8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| April 20, 2019 13:15 | https://github.com/nodejs/node/pull/27321#event-2289532730 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485117443 |
| #27276 | https://github.com/nodejs/node/pull/27276 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Apr 20, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-228878305 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| src/node.cc | https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| refack | https://github.com/refack |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277134958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277137479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| src/node_main_instance.h | https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6#diff-8c0146b9ba91ce27b816b6b4cf54c76a7a5b827ed448c88bb17b5872faec0ed5 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| node.gyp | https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485123957 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27321#event-2289556735 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 20, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-228890955 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 21, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-228897680 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
| node.gyp | https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 21, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485234219 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| @refack | https://github.com/refack |
| #27307 | https://github.com/nodejs/node/issues/27307 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
|
| https://github.com/joyeecheung |
| fixup! tools: implement node_mksnapshot | https://github.com/nodejs/node/pull/27321/commits/3055cb1f0e8936b8b986274949956f5374d4184e |
| 3055cb1 | https://github.com/nodejs/node/pull/27321/commits/3055cb1f0e8936b8b986274949956f5374d4184e |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
|
| https://github.com/joyeecheung |
| src: use std::vector instead of IndexArray | https://github.com/nodejs/node/pull/27321/commits/2ac1d81cc208e7baee6e38ddc1f82a43109d43be |
| 2ac1d81 | https://github.com/nodejs/node/pull/27321/commits/2ac1d81cc208e7baee6e38ddc1f82a43109d43be |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 21, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485248325 |
| https://ci.nodejs.org/job/node-test-pull-request/22596/ | https://ci.nodejs.org/job/node-test-pull-request/22596/ |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 22, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-228995765 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be |
| src/api/environment.cc | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-5f2fc380364ef43210af4a28c08f9a0c7ec5f85e3ec1f5c1df5e0204eb9dc721 |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277237490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277247234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277293372 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#discussion_r277339075 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| src/node_main_instance.h | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-8c0146b9ba91ce27b816b6b4cf54c76a7a5b827ed448c88bb17b5872faec0ed5 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| src/node_main_instance.h | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-8c0146b9ba91ce27b816b6b4cf54c76a7a5b827ed448c88bb17b5872faec0ed5 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| tools/snapshot/node_mksnapshot.cc | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-6358982100a4c7cdb8438d9ff1a580c4399a9ac2650973fe09325530d98043e7 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| tools/snapshot/node_mksnapshot.cc | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-6358982100a4c7cdb8438d9ff1a580c4399a9ac2650973fe09325530d98043e7 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| tools/snapshot/node_mksnapshot.cc | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-6358982100a4c7cdb8438d9ff1a580c4399a9ac2650973fe09325530d98043e7 |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| tools/snapshot/snapshot_builder.cc | https://github.com/nodejs/node/pull/27321/files/2ac1d81cc208e7baee6e38ddc1f82a43109d43be#diff-1c8d91f5256e3e77b8b64a9d51c20468dfd6a7816f4543c64a86b23b2592ba7f |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| joyeecheung | https://github.com/joyeecheung |
| April 22, 2019 18:26 | https://github.com/nodejs/node/pull/27321#commits-pushed-1e0210b |
|
| https://github.com/joyeecheung |
| fixup! src: enable context snapshot after running per-context scripts | https://github.com/nodejs/node/pull/27321/commits/1e0210be88e106d949949e5d49aca7ce663c2bea |
| 1e0210b | https://github.com/nodejs/node/pull/27321/commits/1e0210be88e106d949949e5d49aca7ce663c2bea |
|
| https://github.com/joyeecheung |
| fixup! src: allow creating NodeMainInstance that does not own the iso… | https://github.com/nodejs/node/pull/27321/commits/0324fe30e19db42fe0872d796494730ef4e2071b |
| 0324fe3 | https://github.com/nodejs/node/pull/27321/commits/0324fe30e19db42fe0872d796494730ef4e2071b |
|
| https://github.com/joyeecheung |
| fixup! tools: implement node_mksnapshot | https://github.com/nodejs/node/pull/27321/commits/90b5d8d6a6834a8259575b598ea6d23f534b7796 |
| 90b5d8d | https://github.com/nodejs/node/pull/27321/commits/90b5d8d6a6834a8259575b598ea6d23f534b7796 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485387471 |
| https://ci.nodejs.org/job/node-test-pull-request/22619/ | https://ci.nodejs.org/job/node-test-pull-request/22619/ |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 22, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485393378 |
| https://ci.nodejs.org/job/node-test-pull-request/22622/ | https://ci.nodejs.org/job/node-test-pull-request/22622/ |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 22, 2019
| https://github.com/nodejs/node/pull/27321#pullrequestreview-229065826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27321/files/90b5d8d6a6834a8259575b598ea6d23f534b7796 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 23, 2019 | https://github.com/nodejs/node/pull/27321#issuecomment-485630657 |
| d66c7e3...d5d9c34 | https://github.com/nodejs/node/compare/d66c7e347042053740ef8cd54b7ea76eb4de53d5...d5d9c349d3f0ff268f8dc2cc31812581bbe2815e |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 23, 2019 | https://github.com/nodejs/node/pull/27321#event-2292827585 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-70d887e |
|
| https://github.com/joyeecheung |
| src: allow creating NodeMainInstance that does not own the isolate | https://github.com/nodejs/node/commit/70d887e95717a6b89135bf5cfd7b6394f451abe7 |
| 70d887e | https://github.com/nodejs/node/commit/70d887e95717a6b89135bf5cfd7b6394f451abe7 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-ffcc949 |
|
| https://github.com/joyeecheung |
| src: implement IsolateData serialization and deserialization | https://github.com/nodejs/node/commit/ffcc949f1cb72c19e4c7db6704ae02d0f7dac232 |
| ffcc949 | https://github.com/nodejs/node/commit/ffcc949f1cb72c19e4c7db6704ae02d0f7dac232 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-d701667 |
|
| https://github.com/joyeecheung |
| tools: implement node_mksnapshot | https://github.com/nodejs/node/commit/d7016679509cd7f2d50612369509e8797d8157b0 |
| d701667 | https://github.com/nodejs/node/commit/d7016679509cd7f2d50612369509e8797d8157b0 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-bf5dade |
|
| https://github.com/joyeecheung |
| src: enable snapshot with per-isolate data | https://github.com/nodejs/node/commit/bf5dadeef07250763948765e9902edd2ecee5448 |
| bf5dade | https://github.com/nodejs/node/commit/bf5dadeef07250763948765e9902edd2ecee5448 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-eb23b17 |
|
| https://github.com/joyeecheung |
| src: enable context snapshot after running per-context scripts | https://github.com/nodejs/node/commit/eb23b176d8c7122af6add5ee38f87044288d3d39 |
| eb23b17 | https://github.com/nodejs/node/commit/eb23b176d8c7122af6add5ee38f87044288d3d39 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-d5d9c34 |
|
| https://github.com/joyeecheung |
| src: use std::vector instead of IndexArray | https://github.com/nodejs/node/commit/d5d9c349d3f0ff268f8dc2cc31812581bbe2815e |
| d5d9c34 | https://github.com/nodejs/node/commit/d5d9c349d3f0ff268f8dc2cc31812581bbe2815e |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-pullrequest-436217519 |
|
build: disable custom v8 snapshot by default
#27365
| https://github.com/nodejs/node/pull/27365 |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-a41a4ee |
|
| https://github.com/joyeecheung |
| build: disable custom v8 snapshot by default | https://github.com/nodejs/node/commit/a41a4ee61b25698394aeda277546605ea25070c1 |
| a41a4ee | https://github.com/nodejs/node/commit/a41a4ee61b25698394aeda277546605ea25070c1 |
| #27365 | https://github.com/nodejs/node/pull/27365 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-a636338 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: allow creating NodeMainInstance that does not own the isolate | https://github.com/nodejs/node/commit/a6363389456e19448b9507271b68ccf3f40a3f98 |
| a636338 | https://github.com/nodejs/node/commit/a6363389456e19448b9507271b68ccf3f40a3f98 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-631bea8 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: implement IsolateData serialization and deserialization | https://github.com/nodejs/node/commit/631bea8fd2c3e9a344a8e2c53b6c48007c650685 |
| 631bea8 | https://github.com/nodejs/node/commit/631bea8fd2c3e9a344a8e2c53b6c48007c650685 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-b44323f |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| tools: implement node_mksnapshot | https://github.com/nodejs/node/commit/b44323f3de8b3ec6d5b834bdcc9362bb5fe6d6a1 |
| b44323f | https://github.com/nodejs/node/commit/b44323f3de8b3ec6d5b834bdcc9362bb5fe6d6a1 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-45d6106 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: enable snapshot with per-isolate data | https://github.com/nodejs/node/commit/45d610612981223a9b4e4a8d1d8f21caecceb700 |
| 45d6106 | https://github.com/nodejs/node/commit/45d610612981223a9b4e4a8d1d8f21caecceb700 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-228127f |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: enable context snapshot after running per-context scripts | https://github.com/nodejs/node/commit/228127fc67d9c4da48b78ff5f6a71a4cf883e2cf |
| 228127f | https://github.com/nodejs/node/commit/228127fc67d9c4da48b78ff5f6a71a4cf883e2cf |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-ad42cd6 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: use std::vector instead of IndexArray | https://github.com/nodejs/node/commit/ad42cd69cf9c655a6977a8beac2f09a85e7bf51d |
| ad42cd6 | https://github.com/nodejs/node/commit/ad42cd69cf9c655a6977a8beac2f09a85e7bf51d |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| #17058 | https://github.com/nodejs/node/issues/17058 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-commit-5023446 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| build: disable custom v8 snapshot by default | https://github.com/nodejs/node/commit/50234460f9c39f50504fcef067ad0730eca65414 |
| 5023446 | https://github.com/nodejs/node/commit/50234460f9c39f50504fcef067ad0730eca65414 |
| #27365 | https://github.com/nodejs/node/pull/27365 |
| #27321 | https://github.com/nodejs/node/pull/27321 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27321#ref-pullrequest-437929799 |
|
v12.1.0 proposal
#27440
| https://github.com/nodejs/node/pull/27440 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
May 8, 2020
| https://github.com/nodejs/node/pull/27321#ref-pullrequest-604304106 |
|
bootstrap: include bootstrapped Environment in builtin snapshot
#32984
| https://github.com/nodejs/node/pull/32984 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/27321#ref-issue-724902316 |
|
Tracking issue: snapshot integration in Node.js core
#35711
| https://github.com/nodejs/node/issues/35711 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27321 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/27321/files/90b5d8d6a6834a8259575b598ea6d23f534b7796 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27321/files/f8a6cb923b1faa7c8e709eef66b3edb3e7a64a5c |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/27321/files/8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Please reload this page | https://github.com/nodejs/node/pull/27321 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/devsnek |
|
| https://github.com/refack |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |