| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dab188a5-cbac-62d6-54a4-96c5d3fc3044 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3C4:6435C:57BD519:7B1ABFA:6A4FAC12 |
| html-safe-nonce | ec85996db3a61d146b710c9ae4ed2eb15ae13d17ac52b5e2b5661625da4624ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0M0OjY0MzVDOjU3QkQ1MTk6N0IxQUJGQTo2QTRGQUMxMiIsInZpc2l0b3JfaWQiOiIzOTgzMTc1NDA1MzU1OTA0MDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 40cdc67d84fadbb7ce80a184a9e5f3061312f3149f94a088b5ed139ae56a0f7b |
| hovercard-subject-tag | pull_request:271998894 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27310/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bad32046d229bdc268928ee1385318e0f4eb90b2d80ea7f4d2f31b6f9cc8ba70/nodejs/node/pull/27310 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bad32046d229bdc268928ee1385318e0f4eb90b2d80ea7f4d2f31b6f9cc8ba70/nodejs/node/pull/27310 |
| og:image:alt | Refactored RealEnvStore::Get, Set, Query and Delete methods to use uv_os_getenv/setenv/unsetenv methods to avoid conditional OS switches.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devasci |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27310#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27310 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27310 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27310 |
| Reload | https://github.com/nodejs/node/pull/27310 |
| Reload | https://github.com/nodejs/node/pull/27310 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| devasci | https://github.com/devasci |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| devasci:d3v-dev | https://github.com/devasci/node/tree/d3v-dev |
| Conversation | https://github.com/nodejs/node/pull/27310 |
| Commits10 (10) | https://github.com/nodejs/node/pull/27310/commits |
| Checks | https://github.com/nodejs/node/pull/27310/checks |
| Files changed | https://github.com/nodejs/node/pull/27310/files |
| Fix to #27211 - Refactor RealEnvStore methods to use libuv methods for env operations | https://github.com/nodejs/node/pull/27310#top |
| devasci | https://github.com/devasci |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| devasci:d3v-dev | https://github.com/devasci/node/tree/d3v-dev |
|
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#issue-435179846 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#event-2288222901 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#ref-issue-432829195 |
|
Refactor RealEnvStore methods to use uv_os_getenv/setenv/unsetenv
#27211
| https://github.com/nodejs/node/issues/27211 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228697667 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228697885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228731783 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228731783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228737256 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| force-pushed | https://github.com/nodejs/node/compare/7d1720d85ae31b20294232ed7fc77d49028908ac..1936655e15c4a684f41f308d7a482e28c2e3143b |
| 7d1720d | https://github.com/nodejs/node/commit/7d1720d85ae31b20294232ed7fc77d49028908ac |
| 1936655 | https://github.com/nodejs/node/commit/1936655e15c4a684f41f308d7a482e28c2e3143b |
|
Compare
| https://github.com/nodejs/node/compare/7d1720d85ae31b20294232ed7fc77d49028908ac..1936655e15c4a684f41f308d7a482e28c2e3143b |
| April 19, 2019 17:30 | https://github.com/nodejs/node/pull/27310#event-2288670307 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228777386 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228777386 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-484974210 |
| https://ci.nodejs.org/job/node-test-pull-request/22568/ | https://ci.nodejs.org/job/node-test-pull-request/22568/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 19, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228788104 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-484986808 |
| @addaleax | https://github.com/addaleax |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-484987565 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 19, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485006058 |
| @devasci | https://github.com/devasci |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485132848 |
| @addaleax | https://github.com/addaleax |
| https://user-images.githubusercontent.com/6958076/56458711-d07c3500-63a7-11e9-947a-de289f626cd2.png |
| https://user-images.githubusercontent.com/6958076/56458766-526c5e00-63a8-11e9-9308-b62c8bb6cbdb.png |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485148627 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| force-pushed | https://github.com/nodejs/node/compare/4bc0fb4880cf7254118b64752547b3b5c8023c24..d49f5afb9143235c5e8d1a06a6bbae7cfeae65f8 |
| 4bc0fb4 | https://github.com/nodejs/node/commit/4bc0fb4880cf7254118b64752547b3b5c8023c24 |
| d49f5af | https://github.com/nodejs/node/commit/d49f5afb9143235c5e8d1a06a6bbae7cfeae65f8 |
|
Compare
| https://github.com/nodejs/node/compare/4bc0fb4880cf7254118b64752547b3b5c8023c24..d49f5afb9143235c5e8d1a06a6bbae7cfeae65f8 |
| April 20, 2019 18:24 | https://github.com/nodejs/node/pull/27310#event-2289675855 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 20, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228887039 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228887039 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27310#event-2289679019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485149583 |
| https://ci.nodejs.org/job/node-test-pull-request/22585/ | https://ci.nodejs.org/job/node-test-pull-request/22585/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Apr 20, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485150474 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 21, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485242635 |
| @devasci | https://github.com/devasci |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 21, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228908234 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/27310#pullrequestreview-228908234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 21, 2019 | https://github.com/nodejs/node/pull/27310#event-2290193190 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485878493 |
| https://ci.nodejs.org/job/node-test-pull-request/22659/ | https://ci.nodejs.org/job/node-test-pull-request/22659/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-485924757 |
| https://ci.nodejs.org/job/node-test-pull-request/22663/ | https://ci.nodejs.org/job/node-test-pull-request/22663/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 23, 2019
| https://github.com/nodejs/node/pull/27310#pullrequestreview-229731057 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27310/files |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/27310/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-523037584 |
| libuv/libuv#2419 | https://github.com/libuv/libuv/pull/2419 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-529631808 |
| #29508 | https://github.com/nodejs/node/pull/29508 |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Sep 12, 2019 | https://github.com/nodejs/node/pull/27310#event-2628494059 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 12, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-530745949 |
| https://ci.nodejs.org/job/node-test-pull-request/25439/ | https://ci.nodejs.org/job/node-test-pull-request/25439/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 12, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-530909130 |
| https://ci.nodejs.org/job/node-test-pull-request/25449/ | https://ci.nodejs.org/job/node-test-pull-request/25449/ |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| addaleax | https://github.com/addaleax |
|
Sep 12, 2019
| https://github.com/nodejs/node/pull/27310#ref-commit-b354d12 |
|
| https://github.com/devasci |
|
| https://github.com/addaleax |
| src: modified RealEnvStore methods to use libuv functions | https://github.com/nodejs/node/commit/b354d12599ea9e2b29e6b26dedae82b9b474d424 |
| b354d12 | https://github.com/nodejs/node/commit/b354d12599ea9e2b29e6b26dedae82b9b474d424 |
| #27211 | https://github.com/nodejs/node/issues/27211 |
| http://docs.libuv.org/en/v1.x/misc.html | http://docs.libuv.org/en/v1.x/misc.html |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 12, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-530923468 |
| b354d12 | https://github.com/nodejs/node/commit/b354d12599ea9e2b29e6b26dedae82b9b474d424 |
| @devasci | https://github.com/devasci |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 12, 2019 | https://github.com/nodejs/node/pull/27310#event-2629961837 |
| targos | https://github.com/targos |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/27310#ref-commit-981ec7d |
|
| https://github.com/devasci |
|
| https://github.com/targos |
| src: modified RealEnvStore methods to use libuv functions | https://github.com/nodejs/node/commit/981ec7dd4cf6520d85320546454539841ababce1 |
| 981ec7d | https://github.com/nodejs/node/commit/981ec7dd4cf6520d85320546454539841ababce1 |
| #27211 | https://github.com/nodejs/node/issues/27211 |
| http://docs.libuv.org/en/v1.x/misc.html | http://docs.libuv.org/en/v1.x/misc.html |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/27310#ref-pullrequest-497808887 |
|
v12.11.0 proposal
#29695
| https://github.com/nodejs/node/pull/29695 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/27310#ref-commit-4a5ba60 |
|
| https://github.com/devasci |
|
| https://github.com/BridgeAR |
| src: modified RealEnvStore methods to use libuv functions | https://github.com/nodejs/node/commit/4a5ba60e00ffc1223a49c82d05321b68bb3430b7 |
| 4a5ba60 | https://github.com/nodejs/node/commit/4a5ba60e00ffc1223a49c82d05321b68bb3430b7 |
| #27211 | https://github.com/nodejs/node/issues/27211 |
| http://docs.libuv.org/en/v1.x/misc.html | http://docs.libuv.org/en/v1.x/misc.html |
| #27310 | https://github.com/nodejs/node/pull/27310 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#301
| https://github.com/beevelop/docker-nodejs/issues/301 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#333
| https://github.com/beevelop/docker-android-nodejs/issues/333 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#302
| https://github.com/beevelop/docker-nodejs/issues/302 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#334
| https://github.com/beevelop/docker-android-nodejs/issues/334 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#303
| https://github.com/beevelop/docker-nodejs/issues/303 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#335
| https://github.com/beevelop/docker-android-nodejs/issues/335 |
| https://github.com/devasci |
| devasci | https://github.com/devasci |
| Oct 3, 2019 | https://github.com/nodejs/node/pull/27310#issuecomment-537971016 |
| b354d12 | https://github.com/nodejs/node/commit/b354d12599ea9e2b29e6b26dedae82b9b474d424 |
| @devasci | https://github.com/devasci |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 27, 2019
| https://github.com/nodejs/node/pull/27310#ref-issue-542949832 |
|
Assertion failed: len < MAX_ENV_VAR_LENGTH, file c:\ws\deps\uv\src\win\util.c, line 1476
libuv/libuv#2587
| https://github.com/libuv/libuv/issues/2587 |
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
|
Apr 18, 2020
| https://github.com/nodejs/node/pull/27310#ref-pullrequest-602556795 |
|
src: fix empty-named env var assertion failure
#32921
| https://github.com/nodejs/node/pull/32921 |
| addaleax | https://github.com/addaleax |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-3ccdf8a |
|
| https://github.com/bl-ue |
|
| https://github.com/addaleax |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/3ccdf8ad228379703e721c179339c332add0842c |
| 3ccdf8a | https://github.com/nodejs/node/commit/3ccdf8ad228379703e721c179339c332add0842c |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-a3ef502 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/a3ef502c055511aeef68cc4681bcbd7a6a75ffea |
| a3ef502 | https://github.com/nodejs/node/commit/a3ef502c055511aeef68cc4681bcbd7a6a75ffea |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-02653b8 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/02653b8310d99353ab59b2821c99e7b3cae74695 |
| 02653b8 | https://github.com/nodejs/node/commit/02653b8310d99353ab59b2821c99e7b3cae74695 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-018de28 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/018de28bf3aa57b03b23d80b81e0208045926148 |
| 018de28 | https://github.com/nodejs/node/commit/018de28bf3aa57b03b23d80b81e0208045926148 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-23aba12 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/23aba1267960c70e21c3d261883c90863a5943cf |
| 23aba12 | https://github.com/nodejs/node/commit/23aba1267960c70e21c3d261883c90863a5943cf |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-d10c2c6 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/d10c2c69686d774a1e654f00fd05f8f6126d476a |
| d10c2c6 | https://github.com/nodejs/node/commit/d10c2c69686d774a1e654f00fd05f8f6126d476a |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-c4e5950 |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/c4e5950651ed358a0b387d6d5f90a27df69294cc |
| c4e5950 | https://github.com/nodejs/node/commit/c4e5950651ed358a0b387d6d5f90a27df69294cc |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/27310#ref-commit-60db9af |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/60db9afde51c23966549ec6e5a91c283abaa9356 |
| 60db9af | https://github.com/nodejs/node/commit/60db9afde51c23966549ec6e5a91c283abaa9356 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27310 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/27310/files/34c8538aef50d3a392dc4d6522c472f57cc2472e |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27310/files/14cb87201ea5ac0e8389f71c4f9769bd1d014558 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/27310/files/ab80a5b076b119773232dea8605f01b6bc994265 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/27310 |
|
| https://github.com/devasci |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/joyeecheung |
|
| https://github.com/Trott |
|
| https://github.com/devsnek |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |