| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5dd2c78-ad2f-ca3c-01dc-f37f355b26f0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F7E:30372D:B1216:105D3E:6A4DFABD |
| html-safe-nonce | 311709b73e79d44bfc91c3bfc6123911fcf0313cac5be7cbdd65e1f69d0a34ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjdFOjMwMzcyRDpCMTIxNjoxMDVEM0U6NkE0REZBQkQiLCJ2aXNpdG9yX2lkIjoiMTEyMjM1ODc1OTYzMDE3NDkwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f4528b70dca67e4ba518b8a5ad8bfee56dd1f2955dcd8c9f4b1d032c75db82c0 |
| hovercard-subject-tag | pull_request:271352279 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27279/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dc805367fa62c483477588e7b59921642d06438a9ba21f505975975c86de44ea/nodejs/node/pull/27279 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc805367fa62c483477588e7b59921642d06438a9ba21f505975975c86de44ea/nodejs/node/pull/27279 |
| og:image:alt | Found by https://ci.nodejs.org/job/node-clang-tidy/7/console.
cc @refack
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4314b1df11fa8a565684f3a72dc971e3785da365 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27279#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27279 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27279 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27279 |
| Reload | https://github.com/nodejs/node/pull/27279 |
| Reload | https://github.com/nodejs/node/pull/27279 |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:deprecated_headers | https://github.com/gengjiawen/node/tree/deprecated_headers |
| Conversation | https://github.com/nodejs/node/pull/27279 |
| Commits1 (1) | https://github.com/nodejs/node/pull/27279/commits |
| Checks | https://github.com/nodejs/node/pull/27279/checks |
| Files changed | https://github.com/nodejs/node/pull/27279/files |
| src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI | https://github.com/nodejs/node/pull/27279#top |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:deprecated_headers | https://github.com/gengjiawen/node/tree/deprecated_headers |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27279#issue-434339026 |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://ci.nodejs.org/job/node-clang-tidy/7/console | https://ci.nodejs.org/job/node-clang-tidy/7/console |
| @refack | https://github.com/refack |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27279#event-2283080761 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/742af1bbbe45cc7f1b9fb4cdec426bef980f7cd7..9884287149b88413b4e5bd7594409ec1dd806fa0 |
| 742af1b | https://github.com/nodejs/node/commit/742af1bbbe45cc7f1b9fb4cdec426bef980f7cd7 |
| 9884287 | https://github.com/nodejs/node/commit/9884287149b88413b4e5bd7594409ec1dd806fa0 |
|
Compare
| https://github.com/nodejs/node/compare/742af1bbbe45cc7f1b9fb4cdec426bef980f7cd7..9884287149b88413b4e5bd7594409ec1dd806fa0 |
| April 17, 2019 15:53 | https://github.com/nodejs/node/pull/27279#event-2283209946 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27279#event-2283210263 |
|
| https://github.com/gengjiawen |
| src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI | https://github.com/nodejs/node/pull/27279/commits/68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
| 68b9d2d | https://github.com/nodejs/node/pull/27279/commits/68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/9884287149b88413b4e5bd7594409ec1dd806fa0..68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
| 9884287 | https://github.com/nodejs/node/commit/9884287149b88413b4e5bd7594409ec1dd806fa0 |
| 68b9d2d | https://github.com/nodejs/node/commit/68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
|
Compare
| https://github.com/nodejs/node/compare/9884287149b88413b4e5bd7594409ec1dd806fa0..68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
| April 17, 2019 16:44 | https://github.com/nodejs/node/pull/27279#event-2283348391 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 18, 2019 | https://github.com/nodejs/node/pull/27279#issuecomment-484341468 |
| https://ci.nodejs.org/job/node-test-pull-request/22541/ | https://ci.nodejs.org/job/node-test-pull-request/22541/ |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 18, 2019 | https://github.com/nodejs/node/pull/27279#issuecomment-484503906 |
| @addaleax | https://github.com/addaleax |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 18, 2019
| https://github.com/nodejs/node/pull/27279#pullrequestreview-228402968 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27279/files/68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
|
tools: add clang-tidy rule in src
#26840
| https://github.com/nodejs/node/pull/26840 |
|
src: refactor deprecated UVException in node_file.cc
#27280
| https://github.com/nodejs/node/pull/27280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2019 | https://github.com/nodejs/node/pull/27279#issuecomment-486123039 |
| https://ci.nodejs.org/job/node-test-pull-request/22675/ | https://ci.nodejs.org/job/node-test-pull-request/22675/ |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 26, 2019 | https://github.com/nodejs/node/pull/27279#issuecomment-486923305 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 26, 2019 | https://github.com/nodejs/node/pull/27279#issuecomment-486940713 |
| 5fe4d59 | https://github.com/nodejs/node/commit/5fe4d5966fd9c2b30b3da3ec7cb47132aa8cdfdd |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 26, 2019 | https://github.com/nodejs/node/pull/27279#event-2302169074 |
| danbev | https://github.com/danbev |
|
Apr 26, 2019
| https://github.com/nodejs/node/pull/27279#ref-commit-5fe4d59 |
|
| https://github.com/gengjiawen |
|
| https://github.com/danbev |
| src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI | https://github.com/nodejs/node/commit/5fe4d5966fd9c2b30b3da3ec7cb47132aa8cdfdd |
| 5fe4d59 | https://github.com/nodejs/node/commit/5fe4d5966fd9c2b30b3da3ec7cb47132aa8cdfdd |
| #27279 | https://github.com/nodejs/node/pull/27279 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27279#ref-commit-8089d29 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI | https://github.com/nodejs/node/commit/8089d295679f510b206b6261c0010a42b33454be |
| 8089d29 | https://github.com/nodejs/node/commit/8089d295679f510b206b6261c0010a42b33454be |
| #27279 | https://github.com/nodejs/node/pull/27279 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27279#ref-pullrequest-437929799 |
|
v12.1.0 proposal
#27440
| https://github.com/nodejs/node/pull/27440 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27279 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27279/files/68b9d2dbbf6f50a3e8f0f9dd64b957d6d94018b5 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/27279 |
|
| https://github.com/gengjiawen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |