| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fca66133-28ca-1a0b-7b5e-b2bf995eed16 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E2BC:2DA286:12CC9AF:19DE338:6A4DE807 |
| html-safe-nonce | 5395d571ca4688f908e4233bab0d77039d9c220ba1b34e6f6a3293dd77609e6c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkJDOjJEQTI4NjoxMkNDOUFGOjE5REUzMzg6NkE0REU4MDciLCJ2aXNpdG9yX2lkIjoiMTMzODA3MTkyODcwMzY3NDM3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d390cb1fb9aa22752cf4139094088c162cfb58f3c7059ef0f6f32cb0e48e9167 |
| hovercard-subject-tag | pull_request:270959571 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27264/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/371f230d2bc7c2d6727a3151e625d7dd2f8a50f81c788890294425a19e8497cb/nodejs/node/pull/27264 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/371f230d2bc7c2d6727a3151e625d7dd2f8a50f81c788890294425a19e8497cb/nodejs/node/pull/27264 |
| og:image:alt | Also from: https://ci.nodejs.org/job/node-clang-tidy/7/console.
Rule def: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html.
cc @refack
Checklist
make -j4 test (UN... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27264#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27264 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27264 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27264 |
| Reload | https://github.com/nodejs/node/pull/27264 |
| Reload | https://github.com/nodejs/node/pull/27264 |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:clang-tidy-modernize-use-equals-default | https://github.com/gengjiawen/node/tree/clang-tidy-modernize-use-equals-default |
| Conversation | https://github.com/nodejs/node/pull/27264 |
| Commits1 (1) | https://github.com/nodejs/node/pull/27264/commits |
| Checks | https://github.com/nodejs/node/pull/27264/checks |
| Files changed | https://github.com/nodejs/node/pull/27264/files |
| src: apply clang-tidy rule modernize-use-equals-default | https://github.com/nodejs/node/pull/27264#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:clang-tidy-modernize-use-equals-default | https://github.com/gengjiawen/node/tree/clang-tidy-modernize-use-equals-default |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/27264#issue-433842320 |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://ci.nodejs.org/job/node-clang-tidy/7/console | https://ci.nodejs.org/job/node-clang-tidy/7/console |
| https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html | https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html |
| @refack | https://github.com/refack |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/27264#event-2280064626 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/718ebce675a5cc0302898192bd1e0add5b24966f..d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
| 718ebce | https://github.com/nodejs/node/commit/718ebce675a5cc0302898192bd1e0add5b24966f |
| d4b8961 | https://github.com/nodejs/node/commit/d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
|
Compare
| https://github.com/nodejs/node/compare/718ebce675a5cc0302898192bd1e0add5b24966f..d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
| April 17, 2019 15:03 | https://github.com/nodejs/node/pull/27264#event-2283047679 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27264#issuecomment-484129376 |
| @addaleax | https://github.com/addaleax |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Apr 17, 2019
| https://github.com/nodejs/node/pull/27264#pullrequestreview-227827606 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27264/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27264#issuecomment-484138171 |
| https://ci.nodejs.org/job/node-test-pull-request/22525/ | https://ci.nodejs.org/job/node-test-pull-request/22525/ |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 17, 2019
| https://github.com/nodejs/node/pull/27264#pullrequestreview-227873957 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27264/files |
| src/fs_event_wrap.cc | https://github.com/nodejs/node/pull/27264/files#diff-6910052af7ef7bf89669b7c516ab0475bbeb13c29be858b9a71ad242381afeb2 |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| src/tracing/traced_value.cc | https://github.com/nodejs/node/pull/27264/files#diff-e7aea3440b410c1b3fdb6f4cc0aa814d58cb9d86391a1ce22f84c8e8dca8052d |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| src/spawn_sync.cc | https://github.com/nodejs/node/pull/27264/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7 |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 17, 2019 | https://github.com/nodejs/node/pull/27264#issuecomment-484219952 |
| https://ci.nodejs.org/job/node-test-pull-request/22532/ | https://ci.nodejs.org/job/node-test-pull-request/22532/ |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/d4b8961c75f34cde5d48a4f8a010746ca5caed06..38a817a87c392d7df4f57a648c2a21b05ef57184 |
| d4b8961 | https://github.com/nodejs/node/commit/d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
| 38a817a | https://github.com/nodejs/node/commit/38a817a87c392d7df4f57a648c2a21b05ef57184 |
|
Compare
| https://github.com/nodejs/node/compare/d4b8961c75f34cde5d48a4f8a010746ca5caed06..38a817a87c392d7df4f57a648c2a21b05ef57184 |
| April 18, 2019 13:16 | https://github.com/nodejs/node/pull/27264#event-2285673159 |
|
tools: add clang-tidy rule in src
#26840
| https://github.com/nodejs/node/pull/26840 |
|
src: refactor deprecated UVException in node_file.cc
#27280
| https://github.com/nodejs/node/pull/27280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2019 | https://github.com/nodejs/node/pull/27264#issuecomment-486123123 |
| https://ci.nodejs.org/job/node-test-pull-request/22676/ | https://ci.nodejs.org/job/node-test-pull-request/22676/ |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2019 | https://github.com/nodejs/node/pull/27264#issuecomment-486311178 |
| https://ci.nodejs.org/job/node-test-pull-request/22687/ | https://ci.nodejs.org/job/node-test-pull-request/22687/ |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
|
| https://github.com/gengjiawen |
|
| https://github.com/refack |
| src: apply clang-tidy rule modernize-use-equals-default | https://github.com/nodejs/node/pull/27264/commits/51079db826601425f4364a010a6468d734519d95 |
| 51079db | https://github.com/nodejs/node/pull/27264/commits/51079db826601425f4364a010a6468d734519d95 |
| nodejs#27264 | https://github.com/nodejs/node/pull/27264 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/38a817a87c392d7df4f57a648c2a21b05ef57184..51079db826601425f4364a010a6468d734519d95 |
| 38a817a | https://github.com/nodejs/node/commit/38a817a87c392d7df4f57a648c2a21b05ef57184 |
| 51079db | https://github.com/nodejs/node/commit/51079db826601425f4364a010a6468d734519d95 |
|
Compare
| https://github.com/nodejs/node/compare/38a817a87c392d7df4f57a648c2a21b05ef57184..51079db826601425f4364a010a6468d734519d95 |
| April 24, 2019 17:33 | https://github.com/nodejs/node/pull/27264#event-2297950065 |
| https://github.com/refack |
| refack | https://github.com/refack |
| 51079db | https://github.com/nodejs/node/commit/51079db826601425f4364a010a6468d734519d95 |
| Apr 24, 2019 | https://github.com/nodejs/node/pull/27264#event-2297953033 |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27264#ref-commit-7bc47cb |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: apply clang-tidy rule modernize-use-equals-default | https://github.com/nodejs/node/commit/7bc47cba2e69a5c5b97a096306d41150665428e5 |
| 7bc47cb | https://github.com/nodejs/node/commit/7bc47cba2e69a5c5b97a096306d41150665428e5 |
| #27264 | https://github.com/nodejs/node/pull/27264 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 27, 2019
| https://github.com/nodejs/node/pull/27264#ref-pullrequest-437929799 |
|
v12.1.0 proposal
#27440
| https://github.com/nodejs/node/pull/27440 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27264 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/27264/files/d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/27264/files/d4b8961c75f34cde5d48a4f8a010746ca5caed06 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/27264 |
|
| https://github.com/gengjiawen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |