René's URL Explorer Experiment


Title: src: handle fatal error when Environment is not assigned to context by joyeecheung · Pull Request #27236 · nodejs/node · GitHub

Open Graph Title: src: handle fatal error when Environment is not assigned to context by joyeecheung · Pull Request #27236 · nodejs/node

X Title: src: handle fatal error when Environment is not assigned to context by joyeecheung · Pull Request #27236 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously when an uncaught JS error is thrown before Environment was assigned to the context (e.g. a SyntaxError in a per-context script), it triggered an infinite recursion: The error message li...

X Description: Previously when an uncaught JS error is thrown before Environment was assigned to the context (e.g. a SyntaxError in a per-context script), it triggered an infinite recursion: The error message li...

Opengraph URL: https://github.com/nodejs/node/pull/27236

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d840efd8-f7bd-3bf6-158e-9604da55d8ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8418:13C54:4D7932:693771:6A4EBA54
html-safe-nonce59f7bd3d519e632ef738986633aa5cf4091e917e52122b45e27bc0e95edcf00b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDE4OjEzQzU0OjRENzkzMjo2OTM3NzE6NkE0RUJBNTQiLCJ2aXNpdG9yX2lkIjoiNzIyMDc0NjgzMTM5NDY4MzQ3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86170a9aab625da95d46884174c28be493b8b0c532a22583c1de482a031cec91
hovercard-subject-tagpull_request:270353474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27236/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eac6e2812f3dc235af6b648ae93348a2b437e1bc87b7e3a327c7e422f82d49dd/nodejs/node/pull/27236
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eac6e2812f3dc235af6b648ae93348a2b437e1bc87b7e3a327c7e422f82d49dd/nodejs/node/pull/27236
og:image:altPreviously when an uncaught JS error is thrown before Environment was assigned to the context (e.g. a SyntaxError in a per-context script), it triggered an infinite recursion: The error message li...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27236#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27236
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27236
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27236
Reloadhttps://github.com/nodejs/node/pull/27236
Reloadhttps://github.com/nodejs/node/pull/27236
Please reload this pagehttps://github.com/nodejs/node/pull/27236
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27236
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:infihttps://github.com/joyeecheung/node/tree/infi
Conversationhttps://github.com/nodejs/node/pull/27236
Commits2 (2)https://github.com/nodejs/node/pull/27236/commits
Checkshttps://github.com/nodejs/node/pull/27236/checks
Files changedhttps://github.com/nodejs/node/pull/27236/files
src: handle fatal error when Environment is not assigned to contexthttps://github.com/nodejs/node/pull/27236#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:infihttps://github.com/joyeecheung/node/tree/infi
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 15, 2019https://github.com/nodejs/node/pull/27236#issue-433071119
Please reload this pagehttps://github.com/nodejs/node/pull/27236
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
src: handle fatal error when Environment is not assigned to contexthttps://github.com/nodejs/node/pull/27236/commits/cee0872ce85580a86f0d7c7e53e032cebec89e82
cee0872https://github.com/nodejs/node/pull/27236/commits/cee0872ce85580a86f0d7c7e53e032cebec89e82
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27236#issuecomment-483088344
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3256https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3256
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 15, 2019https://github.com/nodejs/node/pull/27236#event-2275322994
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27236#issuecomment-483088630
https://ci.nodejs.org/job/node-test-pull-request/22442/https://ci.nodejs.org/job/node-test-pull-request/22442/
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226435319
View reviewed changes https://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82
src/node_errors.cchttps://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226564948
View reviewed changes https://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27236#pullrequestreview-226564948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27236
src/env-inl.hhttps://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
Please reload this pagehttps://github.com/nodejs/node/pull/27236
src/node_errors.cchttps://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2
Please reload this pagehttps://github.com/nodejs/node/pull/27236
src/node_errors.cchttps://github.com/nodejs/node/pull/27236/files/cee0872ce85580a86f0d7c7e53e032cebec89e82#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
fixup! src: handle fatal error when Environment is not assigned to co…https://github.com/nodejs/node/pull/27236/commits/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
7933801https://github.com/nodejs/node/pull/27236/commits/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27236#issuecomment-483238847
https://ci.nodejs.org/job/node-test-pull-request/22447/https://ci.nodejs.org/job/node-test-pull-request/22447/
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226648956
View reviewed changes https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226648960
View reviewed changes https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226648977
View reviewed changes https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 15, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-226854584
View reviewed changes https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/27236#pullrequestreview-226854584
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 15, 2019https://github.com/nodejs/node/pull/27236#event-2277728229
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 16, 2019 https://github.com/nodejs/node/pull/27236#pullrequestreview-227100377
View reviewed changes https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
src/node_errors.cchttps://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019https://github.com/nodejs/node/pull/27236#issuecomment-484020268
cdba9f2https://github.com/nodejs/node/commit/cdba9f23ec301f834ac686df7e6adcc3ecf59db6
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019https://github.com/nodejs/node/pull/27236#event-2282224442
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019 https://github.com/nodejs/node/pull/27236#ref-commit-cdba9f2
https://github.com/joyeecheung
src: handle fatal error when Environment is not assigned to contexthttps://github.com/nodejs/node/commit/cdba9f23ec301f834ac686df7e6adcc3ecf59db6
cdba9f2https://github.com/nodejs/node/commit/cdba9f23ec301f834ac686df7e6adcc3ecf59db6
#27236https://github.com/nodejs/node/pull/27236
RFC: speeding up Node.js startup using V8 snapshot #17058 https://github.com/nodejs/node/issues/17058
src: implement minimal v8 snapshot integration #27321 https://github.com/nodejs/node/pull/27321
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 20, 2019https://github.com/nodejs/node/pull/27236#issuecomment-485090342
https://ci.nodejs.org/job/node-test-pull-request/22579/https://ci.nodejs.org/job/node-test-pull-request/22579/
Please reload this pagehttps://github.com/nodejs/node/pull/27236
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27236
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27236/files/7933801bed4f24252c4f8b8ee0ae139a27dab2cf
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/27236
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.