René's URL Explorer Experiment


Title: src: disallow calling env-dependent methods during bootstrap by joyeecheung · Pull Request #27234 · nodejs/node · GitHub

Open Graph Title: src: disallow calling env-dependent methods during bootstrap by joyeecheung · Pull Request #27234 · nodejs/node

X Title: src: disallow calling env-dependent methods during bootstrap by joyeecheung · Pull Request #27234 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: These cannot be preserved correctly in v8 snapshot. Currently none of these are called during bootstrap, this adds assertions to make sure future contributors do not accidentally call these in the ...

X Description: These cannot be preserved correctly in v8 snapshot. Currently none of these are called during bootstrap, this adds assertions to make sure future contributors do not accidentally call these in the ...

Opengraph URL: https://github.com/nodejs/node/pull/27234

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8f60789f-e448-5b9b-14f5-0f013694c647
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCD6:CBA04:230C8B:2EE1F6:6A4D8938
html-safe-nonce4c1a6f23a5a1f0ba93e4087d43ed2fddcb14960e05313a12857e1b350241904a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Q2OkNCQTA0OjIzMEM4QjoyRUUxRjY6NkE0RDg5MzgiLCJ2aXNpdG9yX2lkIjoiMTA0MTM1ODgyODkzMzU4MTExMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7545e20b29e387343b4c5683deed25e81a7eadb9f2b2563fb9456ec6f26b6f56
hovercard-subject-tagpull_request:270343151
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27234/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/258e5a2bd4ee5cf91ecae4ab722334b40ee9264254833f8e149cdba8e9b4a58c/nodejs/node/pull/27234
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/258e5a2bd4ee5cf91ecae4ab722334b40ee9264254833f8e149cdba8e9b4a58c/nodejs/node/pull/27234
og:image:altThese cannot be preserved correctly in v8 snapshot. Currently none of these are called during bootstrap, this adds assertions to make sure future contributors do not accidentally call these in the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27234#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27234
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27234
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27234
Reloadhttps://github.com/nodejs/node/pull/27234
Reloadhttps://github.com/nodejs/node/pull/27234
Please reload this pagehttps://github.com/nodejs/node/pull/27234
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27234
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:disallow-cwdhttps://github.com/joyeecheung/node/tree/disallow-cwd
Conversationhttps://github.com/nodejs/node/pull/27234
Commits1 (1)https://github.com/nodejs/node/pull/27234/commits
Checkshttps://github.com/nodejs/node/pull/27234/checks
Files changedhttps://github.com/nodejs/node/pull/27234/files
src: disallow calling env-dependent methods during bootstraphttps://github.com/nodejs/node/pull/27234#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:disallow-cwdhttps://github.com/joyeecheung/node/tree/disallow-cwd
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 15, 2019https://github.com/nodejs/node/pull/27234#issue-433056442
Please reload this pagehttps://github.com/nodejs/node/pull/27234
#27224https://github.com/nodejs/node/pull/27224
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
src: disallow calling env-dependent methods during bootstraphttps://github.com/nodejs/node/pull/27234/commits/aba0729da2d1d516d59aead7038ba30d7afbaed2
aba0729https://github.com/nodejs/node/pull/27234/commits/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483075624
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3255https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3255
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 15, 2019https://github.com/nodejs/node/pull/27234#event-2275241556
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483077721
https://ci.nodejs.org/job/node-test-pull-request/22441/https://ci.nodejs.org/job/node-test-pull-request/22441/
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483092301
https://ci.nodejs.org/job/node-test-pull-request/22445/https://ci.nodejs.org/job/node-test-pull-request/22445/
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 15, 2019 https://github.com/nodejs/node/pull/27234#pullrequestreview-226529303
View reviewed changes https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Apr 15, 2019https://github.com/nodejs/node/pull/27234#event-2276360277
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 15, 2019 https://github.com/nodejs/node/pull/27234#pullrequestreview-226654314
View reviewed changes https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Apr 15, 2019https://github.com/nodejs/node/pull/27234#event-2276730786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 15, 2019 https://github.com/nodejs/node/pull/27234#pullrequestreview-226926296
View reviewed changes https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/27234#pullrequestreview-226926296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 16, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483495627
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 16, 2019 https://github.com/nodejs/node/pull/27234#pullrequestreview-227101823
View reviewed changes https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 16, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483599423
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 16, 2019https://github.com/nodejs/node/pull/27234#issuecomment-483676349
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019https://github.com/nodejs/node/pull/27234#issuecomment-484018428
Please reload this pagehttps://github.com/nodejs/node/pull/27234
83d1ca7https://github.com/nodejs/node/commit/83d1ca7de95b884bcf188ed399056358e1d9d063
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019https://github.com/nodejs/node/pull/27234#event-2282208654
joyeecheunghttps://github.com/joyeecheung
Apr 17, 2019 https://github.com/nodejs/node/pull/27234#ref-commit-83d1ca7
https://github.com/joyeecheung
src: disallow calling env-dependent methods during bootstraphttps://github.com/nodejs/node/commit/83d1ca7de95b884bcf188ed399056358e1d9d063
83d1ca7https://github.com/nodejs/node/commit/83d1ca7de95b884bcf188ed399056358e1d9d063
#27224https://github.com/nodejs/node/pull/27224
#27234https://github.com/nodejs/node/pull/27234
#27224https://github.com/nodejs/node/pull/27224
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27234
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27234/files/aba0729da2d1d516d59aead7038ba30d7afbaed2
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Please reload this pagehttps://github.com/nodejs/node/pull/27234
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.