René's URL Explorer Experiment


Title: v8: fix segmentation faults caused by IntegerValue by pmq20 · Pull Request #2722 · nodejs/node · GitHub

Open Graph Title: v8: fix segmentation faults caused by IntegerValue by pmq20 · Pull Request #2722 · nodejs/node

X Title: v8: fix segmentation faults caused by IntegerValue by pmq20 · Pull Request #2722 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR fixes #2721 and adds a test to guard it. Investigations show that the problem was caused by -O3 optimisations of the compiler. When building a debug version the segmentation fault won't...

X Description: This PR fixes #2721 and adds a test to guard it. Investigations show that the problem was caused by -O3 optimisations of the compiler. When building a debug version the segmentation fault won&#...

Opengraph URL: https://github.com/nodejs/node/pull/2722

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b50d0c1e-a9b7-ca7a-1d46-61160dc52b33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2F2:251B89:A9DEC46:AD46BC7:6A50B110
html-safe-nonce0df63ae9cc9a86d784dfb6d78b462fb5dbd6b87672de1a04a045e81322de160d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkYyOjI1MUI4OTpBOURFQzQ2OkFENDZCQzc6NkE1MEIxMTAiLCJ2aXNpdG9yX2lkIjoiMTEzNjY5OTA0NTU0NjM0MDYyNCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmacd3a01080ed56353951b4a02ba2aa8a6ad81e6e697acd77577312735095384e62
hovercard-subject-tagpull_request:44346873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2722/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98536444fbbf0dac470bcbf51e186e80554c8d6461d35a8b04f49b672c1e0548/nodejs/node/pull/2722
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98536444fbbf0dac470bcbf51e186e80554c8d6461d35a8b04f49b672c1e0548/nodejs/node/pull/2722
og:image:altThis PR fixes #2721 and adds a test to guard it. Investigations show that the problem was caused by -O3 optimisations of the compiler. When building a debug version the segmentation fault won't...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepmq20
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2722#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2722
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2722
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2722
Reloadhttps://github.com/nodejs/node/pull/2722
Reloadhttps://github.com/nodejs/node/pull/2722
Please reload this pagehttps://github.com/nodejs/node/pull/2722
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2722
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
pmq20https://github.com/pmq20
nodejs:v4.0.0-rchttps://github.com/nodejs/node/tree/v4.0.0-rc
pmq20:minqi-pan-2721https://github.com/pmq20/node/tree/minqi-pan-2721
Conversationhttps://github.com/nodejs/node/pull/2722
Commits1 (1)https://github.com/nodejs/node/pull/2722/commits
Checkshttps://github.com/nodejs/node/pull/2722/checks
Files changedhttps://github.com/nodejs/node/pull/2722/files
v8: fix segmentation faults caused by IntegerValuehttps://github.com/nodejs/node/pull/2722#top
pmq20https://github.com/pmq20
nodejs:v4.0.0-rchttps://github.com/nodejs/node/tree/v4.0.0-rc
pmq20:minqi-pan-2721https://github.com/pmq20/node/tree/minqi-pan-2721
https://github.com/pmq20
pmq20https://github.com/pmq20
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issue-105200386
#2721https://github.com/nodejs/node/issues/2721
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138277148
@indutnyhttps://github.com/indutny
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
pmq20https://github.com/pmq20
force-pushedhttps://github.com/nodejs/node/compare/f6af2b244f9532f7392b090933ab45027e660a29..958fe12b53d7b171ae3f1f551921d3b0504407fb
f6af2b2https://github.com/nodejs/node/commit/f6af2b244f9532f7392b090933ab45027e660a29
958fe12https://github.com/nodejs/node/commit/958fe12b53d7b171ae3f1f551921d3b0504407fb
Compare https://github.com/nodejs/node/compare/f6af2b244f9532f7392b090933ab45027e660a29..958fe12b53d7b171ae3f1f551921d3b0504407fb
September 7, 2015 11:46https://github.com/nodejs/node/pull/2722#event-402714943
https://github.com/pmq20
v8: fix segmentation faults caused by IntegerValuehttps://github.com/nodejs/node/pull/2722/commits/958fe12b53d7b171ae3f1f551921d3b0504407fb
958fe12https://github.com/nodejs/node/pull/2722/commits/958fe12b53d7b171ae3f1f551921d3b0504407fb
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138294341
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138313867
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138326309
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 7, 2015 https://github.com/nodejs/node/pull/2722#ref-issue-105199593
Yet another segmentation fault in node-v4.0.0-rc.1 #2721 https://github.com/nodejs/node/issues/2721
https://github.com/silverwind
silverwindhttps://github.com/silverwind
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Sep 7, 2015https://github.com/nodejs/node/pull/2722#event-402905824
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138336895
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138337117
@pmq20https://github.com/pmq20
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/2722
DO NOT MERGE: Reproduce segmentation faults related to IntegerValue (#2721) #2725 https://github.com/nodejs/node/pull/2725
Workaround for crash in #2721 on 4.0.0-rc #2726 https://github.com/nodejs/node/pull/2726
https://github.com/brody2consult
brody2consulthttps://github.com/brody2consult
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138340868
#2726https://github.com/nodejs/node/pull/2726
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138345973
#2727https://github.com/nodejs/node/pull/2727
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/mscdex
mscdexhttps://github.com/mscdex
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Sep 7, 2015https://github.com/nodejs/node/pull/2722#event-402965420
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138356703
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138357598
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138358374
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138358409
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138375817
#2730https://github.com/nodejs/node/pull/2730
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138376463
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138380133
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138387532
#2727https://github.com/nodejs/node/pull/2727
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138387652
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 7, 2015 https://github.com/nodejs/node/pull/2722#ref-pullrequest-105250175
child_process: use stdio.fd even if it is 0 #2727 https://github.com/nodejs/node/pull/2727
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 7, 2015 https://github.com/nodejs/node/pull/2722#ref-pullrequest-105272035
Fix v8_enable_handle_zapping for 4.5 #2731 https://github.com/nodejs/node/pull/2731
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138387761
herehttps://github.com/nodejs/node/pull/2731#issuecomment-138387675
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 7, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138392014
#2727https://github.com/nodejs/node/pull/2727
#2731https://github.com/nodejs/node/pull/2731
#2727https://github.com/nodejs/node/pull/2727
#2731https://github.com/nodejs/node/pull/2731
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138394128
@rvagghttps://github.com/rvagg
#2727https://github.com/nodejs/node/pull/2727
@evanlucashttps://github.com/evanlucas
#2731https://github.com/nodejs/node/pull/2731
#2727https://github.com/nodejs/node/pull/2727
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138394360
@rvagghttps://github.com/rvagg
3bc7e58https://github.com/nodejs/node/commit/3bc7e58ab0797076814a8847a3f74f1ce91f2608
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138394379
#2731https://github.com/nodejs/node/pull/2731
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138405947
@pmq20https://github.com/pmq20
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 8, 2015https://github.com/nodejs/node/pull/2722#event-403135639
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138407724
@pmq20https://github.com/pmq20
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
pmq20https://github.com/pmq20
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138407944
@indutnyhttps://github.com/indutny
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
pmq20https://github.com/pmq20
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138410606
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138412365
@pmq20https://github.com/pmq20
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
pmq20https://github.com/pmq20
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138412549
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
pmq20https://github.com/pmq20
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138491599
@indutnyhttps://github.com/indutny
@bnoordhuishttps://github.com/bnoordhuis
@skomskihttps://github.com/skomski
https://codereview.chromium.org/1303093004/https://codereview.chromium.org/1303093004/
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 8, 2015https://github.com/nodejs/node/pull/2722#issuecomment-138493412
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/aliscco
alisccohttps://github.com/aliscco
May 14, 2024 https://github.com/nodejs/node/pull/2722#ref-pullrequest-2294437362
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#1459 https://github.com/aliscco/alisco-node/pull/1459
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2722
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/2722
https://github.com/pmq20
https://github.com/rvagg
https://github.com/evanlucas
https://github.com/Fishrock123
https://github.com/silverwind
https://github.com/mscdex
https://github.com/brody2consult
https://github.com/indutny
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.