René's URL Explorer Experiment


Title: [v8.x] assert: fix backport regression by BridgeAR · Pull Request #27202 · nodejs/node · GitHub

Open Graph Title: [v8.x] assert: fix backport regression by BridgeAR · Pull Request #27202 · nodejs/node

X Title: [v8.x] assert: fix backport regression by BridgeAR · Pull Request #27202 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes a regression for an error case with assert.rejects and assert.doesNotReject. Fixes: #27185 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks a...

X Description: This fixes a regression for an error case with assert.rejects and assert.doesNotReject. Fixes: #27185 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks a...

Opengraph URL: https://github.com/nodejs/node/pull/27202

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6f5bd1c-5c5a-26a7-39d3-6b3372841521
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD72:2A09C:1866960:1F0D434:69917B79
html-safe-nonce4d879924987ff0b50ec00192d7743f528d3605ee801ab6cfa953a8eb678905fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDcyOjJBMDlDOjE4NjY5NjA6MUYwRDQzNDo2OTkxN0I3OSIsInZpc2l0b3JfaWQiOiI1MTQ1NTQ4OTQzMjYyODQxNzIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6079fb948ecd32a8b9db20ed9942d7e6e976f0dab93ade4c24c055f648fee6b4
hovercard-subject-tagpull_request:270078429
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27202/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/29c23259c236dab3b86124e06687729335d523500b162815293ba7592404ab79/nodejs/node/pull/27202
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/29c23259c236dab3b86124e06687729335d523500b162815293ba7592404ab79/nodejs/node/pull/27202
og:image:altThis fixes a regression for an error case with assert.rejects and assert.doesNotReject. Fixes: #27185 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27202#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27202
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27202
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27202
Reloadhttps://github.com/nodejs/node/pull/27202
Reloadhttps://github.com/nodejs/node/pull/27202
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27202
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
BridgeAR:fix-assert-error-v8https://github.com/BridgeAR/node/tree/fix-assert-error-v8
Conversationhttps://github.com/nodejs/node/pull/27202
Commits1 (1)https://github.com/nodejs/node/pull/27202/commits
Checkshttps://github.com/nodejs/node/pull/27202/checks
Files changedhttps://github.com/nodejs/node/pull/27202/files
[v8.x] assert: fix backport regressionhttps://github.com/nodejs/node/pull/27202#top
BridgeARhttps://github.com/BridgeAR
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
BridgeAR:fix-assert-error-v8https://github.com/BridgeAR/node/tree/fix-assert-error-v8
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 12, 2019https://github.com/nodejs/node/pull/27202#issue-432650300
#27185https://github.com/nodejs/node/issues/27185
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/BridgeAR
assert: fix backport regressionhttps://github.com/nodejs/node/pull/27202/commits/7ce9361c025bc283869d2c5d22d89ea7e697fbca
7ce9361https://github.com/nodejs/node/pull/27202/commits/7ce9361c025bc283869d2c5d22d89ea7e697fbca
nodejs#27185https://github.com/nodejs/node/issues/27185
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x
Apr 12, 2019https://github.com/nodejs/node/pull/27202#event-2272976945
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 12, 2019https://github.com/nodejs/node/pull/27202#issuecomment-482640377
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3236https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3236
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Apr 12, 2019https://github.com/nodejs/node/pull/27202#event-2272977123
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 12, 2019 https://github.com/nodejs/node/pull/27202#ref-pullrequest-425612104
v8.16.0 proposal #26933 https://github.com/nodejs/node/pull/26933
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 12, 2019https://github.com/nodejs/node/pull/27202#issuecomment-482663410
https://ci.nodejs.org/job/node-test-pull-request/22390/https://ci.nodejs.org/job/node-test-pull-request/22390/
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 12, 2019 https://github.com/nodejs/node/pull/27202#pullrequestreview-226217463
View reviewed changes https://github.com/nodejs/node/pull/27202/files/7ce9361c025bc283869d2c5d22d89ea7e697fbca
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 12, 2019 https://github.com/nodejs/node/pull/27202#pullrequestreview-226232445
View reviewed changes https://github.com/nodejs/node/pull/27202/files/7ce9361c025bc283869d2c5d22d89ea7e697fbca
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 14, 2019https://github.com/nodejs/node/pull/27202#issuecomment-482968541
https://ci.nodejs.org/job/node-test-pull-request/22425/https://ci.nodejs.org/job/node-test-pull-request/22425/
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27202#issuecomment-483374650
https://ci.nodejs.org/job/node-test-pull-request/22454/https://ci.nodejs.org/job/node-test-pull-request/22454/
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2019https://github.com/nodejs/node/pull/27202#issuecomment-483414758
https://ci.nodejs.org/job/node-test-pull-request/22460/https://ci.nodejs.org/job/node-test-pull-request/22460/
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 16, 2019https://github.com/nodejs/node/pull/27202#issuecomment-483462077
https://ci.nodejs.org/job/node-test-pull-request/22472/https://ci.nodejs.org/job/node-test-pull-request/22472/
Please reload this pagehttps://github.com/nodejs/node/pull/27202
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2019 https://github.com/nodejs/node/pull/27202#ref-commit-705935d
https://github.com/BridgeAR
https://github.com/MylesBorins
assert: fix backport regressionhttps://github.com/nodejs/node/commit/705935d62059d92543cda43c8cdb29bc34082d5e
705935dhttps://github.com/nodejs/node/commit/705935d62059d92543cda43c8cdb29bc34082d5e
#27185https://github.com/nodejs/node/issues/27185
#27202https://github.com/nodejs/node/pull/27202
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2019https://github.com/nodejs/node/pull/27202#issuecomment-483500748
705935dhttps://github.com/nodejs/node/commit/705935d62059d92543cda43c8cdb29bc34082d5e
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2019https://github.com/nodejs/node/pull/27202#event-2278432900
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 12:02https://github.com/nodejs/node/pull/27202#event-2962694842
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27202
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27202/files/7ce9361c025bc283869d2c5d22d89ea7e697fbca
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/27202/files/7ce9361c025bc283869d2c5d22d89ea7e697fbca
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Please reload this pagehttps://github.com/nodejs/node/pull/27202
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/lpinca
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.