René's URL Explorer Experiment


Title: stream: remove TODO and add a description instead by BridgeAR · Pull Request #27086 · nodejs/node · GitHub

Open Graph Title: stream: remove TODO and add a description instead by BridgeAR · Pull Request #27086 · nodejs/node

X Title: stream: remove TODO and add a description instead by BridgeAR · Pull Request #27086 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: After looking into this it turned out that these two errors are sanity checks that should not be reached. It is unfortunate that we assigned error codes for these but changing it into an assertion ...

X Description: After looking into this it turned out that these two errors are sanity checks that should not be reached. It is unfortunate that we assigned error codes for these but changing it into an assertion ...

Opengraph URL: https://github.com/nodejs/node/pull/27086

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be1bff11-2b04-1156-35fe-87db3fa964d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDDE:7FD8A:98F584:D1E239:6A4DDD9C
html-safe-noncef9eb1d17d5ab17b708baa22e1d664068842ba04ce164a75852207359e055c69b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERERFOjdGRDhBOjk4RjU4NDpEMUUyMzk6NkE0REREOUMiLCJ2aXNpdG9yX2lkIjoiMjkzOTg0NjUyMzk1MTYzNTg2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50becb2c2024dd1cef77bd923ff280b584a34a40045b3b870a290c04280e807b
hovercard-subject-tagpull_request:267484472
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27086/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ecacd976b682d05ac7bb491a414d1a076ab537415e6af4c789eca2f96f35c059/nodejs/node/pull/27086
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ecacd976b682d05ac7bb491a414d1a076ab537415e6af4c789eca2f96f35c059/nodejs/node/pull/27086
og:image:altAfter looking into this it turned out that these two errors are sanity checks that should not be reached. It is unfortunate that we assigned error codes for these but changing it into an assertion ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27086#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27086
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27086
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27086
Reloadhttps://github.com/nodejs/node/pull/27086
Reloadhttps://github.com/nodejs/node/pull/27086
Please reload this pagehttps://github.com/nodejs/node/pull/27086
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27086
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:change-commenthttps://github.com/BridgeAR/node/tree/change-comment
Conversationhttps://github.com/nodejs/node/pull/27086
Commits2 (2)https://github.com/nodejs/node/pull/27086/commits
Checkshttps://github.com/nodejs/node/pull/27086/checks
Files changedhttps://github.com/nodejs/node/pull/27086/files
stream: remove TODO and add a description insteadhttps://github.com/nodejs/node/pull/27086#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:change-commenthttps://github.com/BridgeAR/node/tree/change-comment
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019https://github.com/nodejs/node/pull/27086#issue-429323234
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/BridgeAR
stream: remove TODO and add a description insteadhttps://github.com/nodejs/node/pull/27086/commits/739dc8ef444102286be05df60a129d6ac5b9c963
739dc8ehttps://github.com/nodejs/node/pull/27086/commits/739dc8ef444102286be05df60a129d6ac5b9c963
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Apr 4, 2019https://github.com/nodejs/node/pull/27086#event-2253197002
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 4, 2019https://github.com/nodejs/node/pull/27086#issuecomment-479929547
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3167https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3167
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
mcollinahttps://github.com/mcollina
April 4, 2019 19:03https://github.com/nodejs/node/pull/27086#event-2253903980
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-222994836
View reviewed changes https://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 4, 2019https://github.com/nodejs/node/pull/27086#event-2254216188
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 5, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-223058476
View reviewed changes https://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963
lib/_stream_transform.jshttps://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367
Trotthttps://github.com/Trott
Apr 5, 2019https://github.com/nodejs/node/pull/27086#discussion_r272411965
Please reload this pagehttps://github.com/nodejs/node/pull/27086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
mcollinahttps://github.com/mcollina
Apr 5, 2019https://github.com/nodejs/node/pull/27086#discussion_r272457880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
Trotthttps://github.com/Trott
Apr 5, 2019https://github.com/nodejs/node/pull/27086#discussion_r272675851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
mcollinahttps://github.com/mcollina
Apr 5, 2019https://github.com/nodejs/node/pull/27086#discussion_r272676975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
Trotthttps://github.com/Trott
Apr 5, 2019https://github.com/nodejs/node/pull/27086#discussion_r272678790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
BridgeARhttps://github.com/BridgeAR
Apr 27, 2019https://github.com/nodejs/node/pull/27086#discussion_r279134626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
mcollinahttps://github.com/mcollina
Apr 27, 2019https://github.com/nodejs/node/pull/27086#discussion_r279137229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
BridgeARhttps://github.com/BridgeAR
Apr 29, 2019https://github.com/nodejs/node/pull/27086#discussion_r279500060
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/27086
Trotthttps://github.com/Trott
Apr 29, 2019https://github.com/nodejs/node/pull/27086#discussion_r279551430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/27086
BridgeARhttps://github.com/BridgeAR
May 1, 2019https://github.com/nodejs/node/pull/27086#discussion_r280052031
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 29, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-231918932
View reviewed changes https://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963
lib/_stream_transform.jshttps://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/BridgeAR
fixup! stream: remove TODO and add a description insteadhttps://github.com/nodejs/node/pull/27086/commits/6091ceae2bf18eed667436258b020eb55185aa6e
6091ceahttps://github.com/nodejs/node/pull/27086/commits/6091ceae2bf18eed667436258b020eb55185aa6e
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 1, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-232685171
View reviewed changes https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/27086#pullrequestreview-232685171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-232747677
View reviewed changes https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27086#issuecomment-488416393
https://ci.nodejs.org/job/node-test-pull-request/22861/https://ci.nodejs.org/job/node-test-pull-request/22861/
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/27086#issuecomment-488456317
https://ci.nodejs.org/job/node-test-pull-request/22870/https://ci.nodejs.org/job/node-test-pull-request/22870/
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/Trott
Trotthttps://github.com/Trott
May 2, 2019 https://github.com/nodejs/node/pull/27086#pullrequestreview-232858976
View reviewed changes https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2019https://github.com/nodejs/node/pull/27086#issuecomment-488835404
57fd70fhttps://github.com/nodejs/node/commit/57fd70fc7d3918a6bd4c714fe479488391a563f6
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2019https://github.com/nodejs/node/pull/27086#event-2315743073
BridgeARhttps://github.com/BridgeAR
May 2, 2019 https://github.com/nodejs/node/pull/27086#ref-commit-57fd70f
https://github.com/BridgeAR
stream: remove TODO and add a description insteadhttps://github.com/BridgeAR/node/commit/57fd70fc7d3918a6bd4c714fe479488391a563f6
57fd70fhttps://github.com/BridgeAR/node/commit/57fd70fc7d3918a6bd4c714fe479488391a563f6
nodejs#27086https://github.com/nodejs/node/pull/27086
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/27086#ref-commit-9d6d45e
https://github.com/BridgeAR
https://github.com/targos
stream: remove TODO and add a description insteadhttps://github.com/nodejs/node/commit/9d6d45e7d22e482c9ad1c4cae0385a9eb1715310
9d6d45ehttps://github.com/nodejs/node/commit/9d6d45e7d22e482c9ad1c4cae0385a9eb1715310
#27086https://github.com/nodejs/node/pull/27086
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/27086#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 12:03https://github.com/nodejs/node/pull/27086#event-2962698750
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27086
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27086/files/739dc8ef444102286be05df60a129d6ac5b9c963
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27086/files/6091ceae2bf18eed667436258b020eb55185aa6e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/27086
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/Trott
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.