René's URL Explorer Experiment


Title: fs: improve mode and flags validation by BridgeAR · Pull Request #27044 · nodejs/node · GitHub

Open Graph Title: fs: improve mode and flags validation by BridgeAR · Pull Request #27044 · nodejs/node

X Title: fs: improve mode and flags validation by BridgeAR · Pull Request #27044 · nodejs/node

Description: This fixes a bug in fs.promises.access as it accepted strings as mode. It should have only accepted numbers. It will now always validate the flags and the mode argument in an consistent way. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: This fixes a bug in fs.promises.access as it accepted strings as mode. It should have only accepted numbers. It will now always validate the flags and the mode argument in an consistent way. Check...

X Description: This fixes a bug in fs.promises.access as it accepted strings as mode. It should have only accepted numbers. It will now always validate the flags and the mode argument in an consistent way. Check...

Opengraph URL: https://github.com/nodejs/node/pull/27044

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d91e7211-e8f6-625f-2da9-3f0808de3aaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3A8:8FA3F:7736D9:9ECF63:6AEDC4E9
html-safe-nonceec49d9ad4322348ca1e3ac46cf768e05cdfd5658a1dc03801cbc55eb5f6782a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0E4OjhGQTNGOjc3MzZEOTo5RUNGNjM6NkFFREM0RTkiLCJ2aXNpdG9yX2lkIjoiMzg0NjYwNTkxNjQ4MzczMjcxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfc74c7d2365acf79e50f6dfb585a20fc876b7e535e51542f15c97e2da2f5a9d4
hovercard-subject-tagpull_request:266436995
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
twitter:imagehttps://avatars.githubusercontent.com/u/8822573?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8822573?s=400&v=4
og:image:altThis fixes a bug in fs.promises.access as it accepted strings as mode. It should have only accepted numbers. It will now always validate the flags and the mode argument in an consistent way. Check...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec7d2f3ac4f4f560c56267b765892ba5b093e8a5fb2c0ed937edd8947746942e9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0cac2d0cb993b0ad48c49b076135ac558c742c30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27044%2Ffiles%2Facc80ae59c6c533abbcac5bb5e4f36cb24c44c21
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27044%2Ffiles%2Facc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Reloadhttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Reloadhttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-fs-validationhttps://github.com/BridgeAR/node/tree/fix-fs-validation
Conversation 40 https://github.com/nodejs/node/pull/27044
Commits 3 https://github.com/nodejs/node/pull/27044/commits
Checks 0 https://github.com/nodejs/node/pull/27044/checks
Files changed https://github.com/nodejs/node/pull/27044/files
Please reload this pagehttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
fs: improve mode and flags validation https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#top
Show all changes 3 commits https://github.com/nodejs/node/pull/27044/files
ceb8df9 doc: fix mode and flags being mistaken in fs BridgeAR Sep 25, 2019 https://github.com/nodejs/node/pull/27044/commits/ceb8df9f09e037b4a69de9443a00e210bce4d235
047fbc8 fs: improve mode and flags validation BridgeAR Apr 1, 2019 https://github.com/nodejs/node/pull/27044/commits/047fbc8f135d85a7007432797f33f2438e5f6185
acc80ae doc: use shorter fs.copyFile examples BridgeAR Sep 26, 2019 https://github.com/nodejs/node/pull/27044/commits/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Clear filters https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Please reload this pagehttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
Please reload this pagehttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
fs.md https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
fs.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
does_own_process_state.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-fbf04c890dda04afe276d612677c9da8282ffdadacabb2c5f2d63a1a28b53bd6
promises.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
utils.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894
validators.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-84047e9de2de28fd3ae796466cebdbae912d724504cb1b44c4f45b3517c1fa5f
test-fs-access.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-9f28bba0b9948a16a3905ddc942f5c0a49cfd2e34214dc7ce331c7e33fb1c13f
test-fs-copyfile.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-cfc21718a6576cbb2a74ca59b88ded014596576b81afbe6bcf65cba682a57422
test-fs-error-messages.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-455dd1c2dc85a1b8757c583e26c214127f6209384269667ab887f363a099d7f9
test-fs-open-flags.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-8d25f81a216e323afd99f894568f3a6bf162e39438255972457ffd1c91f08910
test-fs-promises-file-handle-sync.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-4c1f045a2e48ee0ae1d54d8475e448288a272b9607bb26b3da13889f6341bfd3
test-fs-promises.js https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-1ff0d07958f5cf5b0aef4a7cf63f5f14fe08abe050cee2bb0a4f9d0869e30033
doc/api/fs.mdhttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
View file https://github.com/BridgeAR/node/blob/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21/doc/api/fs.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/27044/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
https://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Please reload this pagehttps://github.com/nodejs/node/pull/27044/files/acc80ae59c6c533abbcac5bb5e4f36cb24c44c21
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.