René's URL Explorer Experiment


Title: fix private key export without cipher crash by panva · Pull Request #27041 · nodejs/node · GitHub

Open Graph Title: fix private key export without cipher crash by panva · Pull Request #27041 · nodejs/node

X Title: fix private key export without cipher crash by panva · Pull Request #27041 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes the following by type checking the cipher ...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes the following by type checking the cipher ...

Opengraph URL: https://github.com/nodejs/node/pull/27041

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9836e81f-68bc-9f69-ad27-58badbcbf847
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB472:3337F1:F5532E:1567EEF:6A4E995C
html-safe-nonced11c806884c8dd885323ca9f572959c43c2038813af76e04dc0681a39f13aedd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDcyOjMzMzdGMTpGNTUzMkU6MTU2N0VFRjo2QTRFOTk1QyIsInZpc2l0b3JfaWQiOiIxNDExMTgxMTU0MDc0MDA3OTAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac00648b1b0d2125e53f29504209c1c29e2537ce19f0ad65b26845d2e42c40469b
hovercard-subject-tagpull_request:266282550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27041/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e078fa240a0cb682ada3de3aace4344f94d6aa2553b2a4796d6a685630f080ce/nodejs/node/pull/27041
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e078fa240a0cb682ada3de3aace4344f94d6aa2553b2a4796d6a685630f080ce/nodejs/node/pull/27041
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes the following by type checking the cipher ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27041#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27041
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27041
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27041
Reloadhttps://github.com/nodejs/node/pull/27041
Reloadhttps://github.com/nodejs/node/pull/27041
Please reload this pagehttps://github.com/nodejs/node/pull/27041
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27041
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/27041
Commits3 (3)https://github.com/nodejs/node/pull/27041/commits
Checkshttps://github.com/nodejs/node/pull/27041/checks
Files changedhttps://github.com/nodejs/node/pull/27041/files
fix private key export without cipher crashhttps://github.com/nodejs/node/pull/27041#top
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/panva
panvahttps://github.com/panva
Apr 1, 2019https://github.com/nodejs/node/pull/27041#issue-427758549
Please reload this pagehttps://github.com/nodejs/node/pull/27041
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/panva
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/pull/27041/commits/b2064cb61015a2699f60d8a4a73d7e3642a4ffdd
b2064cbhttps://github.com/nodejs/node/pull/27041/commits/b2064cb61015a2699f60d8a4a73d7e3642a4ffdd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Apr 1, 2019https://github.com/nodejs/node/pull/27041#event-2243651189
https://github.com/panva
panvahttps://github.com/panva
Apr 1, 2019https://github.com/nodejs/node/pull/27041#issuecomment-478629252
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/tniessen
tniessenhttps://github.com/tniessen
confirmed-bug https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfirmed-bug
Apr 1, 2019https://github.com/nodejs/node/pull/27041#event-2243996527
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 1, 2019 https://github.com/nodejs/node/pull/27041#pullrequestreview-221315744
View reviewed changes https://github.com/nodejs/node/pull/27041/files/b2064cb61015a2699f60d8a4a73d7e3642a4ffdd
lib/internal/crypto/keys.jshttps://github.com/nodejs/node/pull/27041/files/b2064cb61015a2699f60d8a4a73d7e3642a4ffdd#diff-dc0c77ec6254d6ea006052823a4d90dda37543cc4c4bf451a6fd8d079b9fa9f3
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 2, 2019 https://github.com/nodejs/node/pull/27041#pullrequestreview-221410047
View reviewed changes https://github.com/nodejs/node/pull/27041/files
lib/internal/crypto/keys.jshttps://github.com/nodejs/node/pull/27041/files#diff-dc0c77ec6254d6ea006052823a4d90dda37543cc4c4bf451a6fd8d079b9fa9f3
Please reload this pagehttps://github.com/nodejs/node/pull/27041
panvahttps://github.com/panva
April 2, 2019 09:04https://github.com/nodejs/node/pull/27041#commits-pushed-75f9b08
https://github.com/panva
fixup! crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/pull/27041/commits/75f9b0878768aa3539e5e720688cf4f9864e77ab
75f9b08https://github.com/nodejs/node/pull/27041/commits/75f9b0878768aa3539e5e720688cf4f9864e77ab
https://github.com/panva
fixup! crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/pull/27041/commits/ff04443c9dbf244f15be49f3bf4f371b2dd1d109
ff04443https://github.com/nodejs/node/pull/27041/commits/ff04443c9dbf244f15be49f3bf4f371b2dd1d109
https://github.com/panva
panvahttps://github.com/panva
Apr 2, 2019https://github.com/nodejs/node/pull/27041#issuecomment-478893456
@bnoordhuishttps://github.com/bnoordhuis
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 3, 2019 https://github.com/nodejs/node/pull/27041#pullrequestreview-221974021
View reviewed changes https://github.com/nodejs/node/pull/27041/files/ff04443c9dbf244f15be49f3bf4f371b2dd1d109
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 3, 2019https://github.com/nodejs/node/pull/27041#event-2248404539
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 3, 2019https://github.com/nodejs/node/pull/27041#issuecomment-479291708
https://ci.nodejs.org/job/node-test-pull-request/22142/https://ci.nodejs.org/job/node-test-pull-request/22142/
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019https://github.com/nodejs/node/pull/27041#issuecomment-479907007
b2bb6c2https://github.com/nodejs/node/commit/b2bb6c2b80e250e5b9dfd27662797fc7b3d12713
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019https://github.com/nodejs/node/pull/27041#event-2253012951
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-b2bb6c2
https://github.com/panva
https://github.com/BridgeAR
crypto: fix crash of encrypted private key export without cipherhttps://github.com/BridgeAR/node/commit/b2bb6c2b80e250e5b9dfd27662797fc7b3d12713
b2bb6c2https://github.com/BridgeAR/node/commit/b2bb6c2b80e250e5b9dfd27662797fc7b3d12713
nodejs#27041https://github.com/nodejs/node/pull/27041
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-1d2f4c4
https://github.com/panva
https://github.com/BethGriggs
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/commit/1d2f4c4c6f77c77b5e2d7755a8d28a5d90e02a29
1d2f4c4https://github.com/nodejs/node/commit/1d2f4c4c6f77c77b5e2d7755a8d28a5d90e02a29
#27041https://github.com/nodejs/node/pull/27041
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-2b791d8
https://github.com/panva
https://github.com/BethGriggs
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/commit/2b791d8697ec559bc638fdf0fe975a7bcbd28120
2b791d8https://github.com/nodejs/node/commit/2b791d8697ec559bc638fdf0fe975a7bcbd28120
#27041https://github.com/nodejs/node/pull/27041
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/27041#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-a71e88b
https://github.com/panva
https://github.com/BethGriggs
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/commit/a71e88bebdd8358cfc2268509dc80e3b33eef575
a71e88bhttps://github.com/nodejs/node/commit/a71e88bebdd8358cfc2268509dc80e3b33eef575
#27041https://github.com/nodejs/node/pull/27041
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-066cd60
https://github.com/panva
https://github.com/BethGriggs
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/commit/066cd6090f89d258b515b6ee5abea9d4cae6e9fb
066cd60https://github.com/nodejs/node/commit/066cd6090f89d258b515b6ee5abea9d4cae6e9fb
#27041https://github.com/nodejs/node/pull/27041
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/27041#ref-commit-a00d840
https://github.com/panva
https://github.com/BethGriggs
crypto: fix crash of encrypted private key export without cipherhttps://github.com/nodejs/node/commit/a00d840600800da689101d4283af8cb58015d4ed
a00d840https://github.com/nodejs/node/commit/a00d840600800da689101d4283af8cb58015d4ed
#27041https://github.com/nodejs/node/pull/27041
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27041
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/27041/files/6811d5e0accbe02022d3682aaf8757ec90fd44f0
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27041/files/ff04443c9dbf244f15be49f3bf4f371b2dd1d109
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
confirmed-bug https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfirmed-bug
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/27041
https://github.com/panva
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/bnoordhuis
https://github.com/tniessen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.