René's URL Explorer Experiment


Title: build: only emit download ICU warnings once by richardlau · Pull Request #27031 · nodejs/node · GitHub

Open Graph Title: build: only emit download ICU warnings once by richardlau · Pull Request #27031 · nodejs/node

X Title: build: only emit download ICU warnings once by richardlau · Pull Request #27031 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The check that the user specified icu in --download only needs to be done once and not for each entry in tools/icu/current_ver.dep. Fixes: #26860 cc @srl295 Checklist make -j4 test (UNIX), or v...

X Description: The check that the user specified icu in --download only needs to be done once and not for each entry in tools/icu/current_ver.dep. Fixes: #26860 cc @srl295 Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/27031

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a8359dc-0fc1-7849-5a95-05fe49b36adb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C30:102756:2195C7A:2E83DED:6A4F51BF
html-safe-noncef3ca044aa12c0cc1e32776133e3be2342c23e77e7ad9e63effd78a80de7a8d45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzMwOjEwMjc1NjoyMTk1QzdBOjJFODNERUQ6NkE0RjUxQkYiLCJ2aXNpdG9yX2lkIjoiNTk4NTc0MzI5MTk2NTk4NTIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac766e5517b856ee193a10b1ce863d703cc630895706c8ec085604ff756fb4826f
hovercard-subject-tagpull_request:266034514
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27031/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c60cd9ba1a50d500ab90af2d8cfb94e40d2bac64230debb7188cfdd842805d0/nodejs/node/pull/27031
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c60cd9ba1a50d500ab90af2d8cfb94e40d2bac64230debb7188cfdd842805d0/nodejs/node/pull/27031
og:image:altThe check that the user specified icu in --download only needs to be done once and not for each entry in tools/icu/current_ver.dep. Fixes: #26860 cc @srl295 Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27031#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27031
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27031
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27031
Reloadhttps://github.com/nodejs/node/pull/27031
Reloadhttps://github.com/nodejs/node/pull/27031
Please reload this pagehttps://github.com/nodejs/node/pull/27031
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27031
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:downloadwarningshttps://github.com/richardlau/node-1/tree/downloadwarnings
Conversationhttps://github.com/nodejs/node/pull/27031
Commits1 (1)https://github.com/nodejs/node/pull/27031/commits
Checkshttps://github.com/nodejs/node/pull/27031/checks
Files changedhttps://github.com/nodejs/node/pull/27031/files
build: only emit download ICU warnings oncehttps://github.com/nodejs/node/pull/27031#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:downloadwarningshttps://github.com/richardlau/node-1/tree/downloadwarnings
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 31, 2019https://github.com/nodejs/node/pull/27031#issue-427427728
#26860https://github.com/nodejs/node/issues/26860
@srl295https://github.com/srl295
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 31, 2019https://github.com/nodejs/node/pull/27031#issuecomment-478366620
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3125https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3125
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Mar 31, 2019https://github.com/nodejs/node/pull/27031#event-2241697697
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 31, 2019 https://github.com/nodejs/node/pull/27031#ref-issue-424295681
tools: configure --with-intl=full-icu warns 3x #26860 https://github.com/nodejs/node/issues/26860
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 31, 2019https://github.com/nodejs/node/pull/27031#issuecomment-478367417
https://ci.nodejs.org/job/node-test-pull-request/22074/https://ci.nodejs.org/job/node-test-pull-request/22074/
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 31, 2019https://github.com/nodejs/node/pull/27031#issuecomment-478373274
https://ci.nodejs.org/job/node-test-pull-request/22076/https://ci.nodejs.org/job/node-test-pull-request/22076/
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/refack
refackhttps://github.com/refack
Mar 31, 2019 https://github.com/nodejs/node/pull/27031#pullrequestreview-220886365
View reviewed changes https://github.com/nodejs/node/pull/27031/files
https://github.com/refack
refackhttps://github.com/refack
Mar 31, 2019https://github.com/nodejs/node/pull/27031#issuecomment-478390015
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/refack
refackhttps://github.com/refack
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Mar 31, 2019https://github.com/nodejs/node/pull/27031#event-2241814573
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 31, 2019https://github.com/nodejs/node/pull/27031#event-2241814747
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 1, 2019 https://github.com/nodejs/node/pull/27031#pullrequestreview-221318541
View reviewed changes https://github.com/nodejs/node/pull/27031/files
CI failures: 20190330-20190402 nodejs/reliability#22 https://github.com/nodejs/reliability/issues/22
Investigate flaky test-fs-readfile-tostring-fail #16601 https://github.com/nodejs/node/issues/16601
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/1b407f3bf13fff87ba9c4ebd5866cd2b93620b4d..0ee603477aba94c4e5df6ce4791cbce4f5c6deb3
1b407f3https://github.com/nodejs/node/commit/1b407f3bf13fff87ba9c4ebd5866cd2b93620b4d
0ee6034https://github.com/nodejs/node/commit/0ee603477aba94c4e5df6ce4791cbce4f5c6deb3
Compare https://github.com/nodejs/node/compare/1b407f3bf13fff87ba9c4ebd5866cd2b93620b4d..0ee603477aba94c4e5df6ce4791cbce4f5c6deb3
April 3, 2019 21:08https://github.com/nodejs/node/pull/27031#event-2251132398
https://github.com/richardlau
build: only emit download ICU warnings oncehttps://github.com/nodejs/node/pull/27031/commits/b180a1572768a16d14c08d1f847e2b8aa7afe87c
b180a15https://github.com/nodejs/node/pull/27031/commits/b180a1572768a16d14c08d1f847e2b8aa7afe87c
nodejs#26860https://github.com/nodejs/node/issues/26860
nodejs#27031https://github.com/nodejs/node/pull/27031
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/0ee603477aba94c4e5df6ce4791cbce4f5c6deb3..b180a1572768a16d14c08d1f847e2b8aa7afe87c
0ee6034https://github.com/nodejs/node/commit/0ee603477aba94c4e5df6ce4791cbce4f5c6deb3
b180a15https://github.com/nodejs/node/commit/b180a1572768a16d14c08d1f847e2b8aa7afe87c
Compare https://github.com/nodejs/node/compare/0ee603477aba94c4e5df6ce4791cbce4f5c6deb3..b180a1572768a16d14c08d1f847e2b8aa7afe87c
April 3, 2019 22:56https://github.com/nodejs/node/pull/27031#event-2251337002
https://github.com/richardlau
richardlauhttps://github.com/richardlau
b180a15https://github.com/nodejs/node/commit/b180a1572768a16d14c08d1f847e2b8aa7afe87c
Apr 3, 2019https://github.com/nodejs/node/pull/27031#event-2251343389
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 3, 2019https://github.com/nodejs/node/pull/27031#issuecomment-479689051
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/srl295
srl295https://github.com/srl295
Apr 3, 2019 https://github.com/nodejs/node/pull/27031#pullrequestreview-222494905
View reviewed changes https://github.com/nodejs/node/pull/27031/files/b180a1572768a16d14c08d1f847e2b8aa7afe87c
srl295https://github.com/srl295
https://github.com/nodejs/node/pull/27031#pullrequestreview-222494905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27031
BethGriggshttps://github.com/BethGriggs
Apr 4, 2019 https://github.com/nodejs/node/pull/27031#ref-commit-5199a28
https://github.com/richardlau
https://github.com/BethGriggs
build: only emit download ICU warnings oncehttps://github.com/nodejs/node/commit/5199a28344cf0521da16c58445a671346915bb69
5199a28https://github.com/nodejs/node/commit/5199a28344cf0521da16c58445a671346915bb69
#26860https://github.com/nodejs/node/issues/26860
#27031https://github.com/nodejs/node/pull/27031
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/27031#ref-commit-ab5dbf9
https://github.com/richardlau
https://github.com/BethGriggs
build: only emit download ICU warnings oncehttps://github.com/nodejs/node/commit/ab5dbf9eb0e27534ab29116262c5b73bfbedd78d
ab5dbf9https://github.com/nodejs/node/commit/ab5dbf9eb0e27534ab29116262c5b73bfbedd78d
#26860https://github.com/nodejs/node/issues/26860
#27031https://github.com/nodejs/node/pull/27031
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/27031#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/27031#ref-commit-a58437d
https://github.com/richardlau
https://github.com/BethGriggs
build: only emit download ICU warnings oncehttps://github.com/nodejs/node/commit/a58437da3ff0e3b94731381875d4233c6e3bf644
a58437dhttps://github.com/nodejs/node/commit/a58437da3ff0e3b94731381875d4233c6e3bf644
#26860https://github.com/nodejs/node/issues/26860
#27031https://github.com/nodejs/node/pull/27031
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27031
https://github.com/srl295
srl295 https://github.com/srl295
https://github.com/nodejs/node/pull/27031/files/b180a1572768a16d14c08d1f847e2b8aa7afe87c
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27031/files/1b407f3bf13fff87ba9c4ebd5866cd2b93620b4d
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/27031/files/1b407f3bf13fff87ba9c4ebd5866cd2b93620b4d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
tools: configure --with-intl=full-icu warns 3x https://github.com/nodejs/node/issues/26860
Please reload this pagehttps://github.com/nodejs/node/pull/27031
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/srl295
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.