| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f3c95752-a6f3-f69b-75d6-02900d58f9fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 824A:8A2B5:34215B8:4922C4F:6A4F8843 |
| html-safe-nonce | c87f8c14ae67c039a035e4d86e54838ca40ca0b550cbaef30271060cb9728803 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjRBOjhBMkI1OjM0MjE1Qjg6NDkyMkM0Rjo2QTRGODg0MyIsInZpc2l0b3JfaWQiOiI4NjcyNzY4MTAxODUzMzk5MTA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9d799bd8e539dd22f31e69620b6b588efb6b56058ad49350d2742a657c2c98af |
| hovercard-subject-tag | pull_request:265856664 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26998/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f3fbd9c3b37ec2533cd9ad46ace8458c6e645465391e48f8a9221c67c1a5cc19/nodejs/node/pull/26998 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f3fbd9c3b37ec2533cd9ad46ace8458c6e645465391e48f8a9221c67c1a5cc19/nodejs/node/pull/26998 |
| og:image:alt | Each one of the following arguments is checked:
napi_env env,
const char* utf8name,
napi_callback cb,
napi_value* result.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | octaviansoldea |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26998#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26998 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26998 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26998 |
| Reload | https://github.com/nodejs/node/pull/26998 |
| Reload | https://github.com/nodejs/node/pull/26998 |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:test_create_function_parameters | https://github.com/octaviansoldea/node/tree/test_create_function_parameters |
| Conversation | https://github.com/nodejs/node/pull/26998 |
| Commits1 (1) | https://github.com/nodejs/node/pull/26998/commits |
| Checks | https://github.com/nodejs/node/pull/26998/checks |
| Files changed | https://github.com/nodejs/node/pull/26998/files |
| test: pass null params to napi_create_function() | https://github.com/nodejs/node/pull/26998#top |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:test_create_function_parameters | https://github.com/octaviansoldea/node/tree/test_create_function_parameters |
|
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
| Mar 29, 2019 | https://github.com/nodejs/node/pull/26998#issue-427167002 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| test: pass null params to napi_create_function() | https://github.com/nodejs/node/pull/26998/commits/d67fa82c0be82396b59f44bc33b7de033bead4c7 |
| d67fa82 | https://github.com/nodejs/node/pull/26998/commits/d67fa82c0be82396b59f44bc33b7de033bead4c7 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Mar 29, 2019 | https://github.com/nodejs/node/pull/26998#event-2240378341 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Mar 30, 2019 | https://github.com/nodejs/node/pull/26998#event-2240787769 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 31, 2019
| https://github.com/nodejs/node/pull/26998#pullrequestreview-220888073 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26998/files/d67fa82c0be82396b59f44bc33b7de033bead4c7 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/pull/26998#pullrequestreview-220888073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| test/js-native-api/test_function/test_function.c | https://github.com/nodejs/node/pull/26998/files/d67fa82c0be82396b59f44bc33b7de033bead4c7#diff-b287b92b404ee18aa5c697b65297aa0f2ae790d11339d8cd08ba2cba1957e5fa |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 31, 2019 | https://github.com/nodejs/node/pull/26998#discussion_r270688890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| test/js-native-api/test_function/test_function.c | https://github.com/nodejs/node/pull/26998/files/d67fa82c0be82396b59f44bc33b7de033bead4c7#diff-b287b92b404ee18aa5c697b65297aa0f2ae790d11339d8cd08ba2cba1957e5fa |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 31, 2019 | https://github.com/nodejs/node/pull/26998#discussion_r270688911 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Apr 5, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-480358750 |
| https://ci.nodejs.org/job/node-test-pull-request/22228/ | https://ci.nodejs.org/job/node-test-pull-request/22228/ |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 5, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-480358844 |
| https://ci.nodejs.org/job/node-test-pull-request/22228/ | https://ci.nodejs.org/job/node-test-pull-request/22228/ |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 9, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481274916 |
| @octaviansoldea | https://github.com/octaviansoldea |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Apr 9, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481480315 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 10, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481548171 |
| https://ci.nodejs.org/job/node-test-pull-request/22332/ | https://ci.nodejs.org/job/node-test-pull-request/22332/ |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 10, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481703261 |
| https://ci.nodejs.org/job/node-test-pull-request/22345/ | https://ci.nodejs.org/job/node-test-pull-request/22345/ |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 10, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481830346 |
| https://ci.nodejs.org/job/node-test-pull-request/22352/ | https://ci.nodejs.org/job/node-test-pull-request/22352/ |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Apr 10, 2019 | https://github.com/nodejs/node/pull/26998#issuecomment-481911103 |
| 06c803d | https://github.com/nodejs/node/commit/06c803d9b929880dc21eeb5f8eb40fe17ff2e499 |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Apr 10, 2019 | https://github.com/nodejs/node/pull/26998#event-2267696472 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Apr 10, 2019
| https://github.com/nodejs/node/pull/26998#ref-commit-06c803d |
| test: pass null params to napi_create_function() | https://github.com/nodejs/node/commit/06c803d9b929880dc21eeb5f8eb40fe17ff2e499 |
| 06c803d | https://github.com/nodejs/node/commit/06c803d9b929880dc21eeb5f8eb40fe17ff2e499 |
| #26998 | https://github.com/nodejs/node/pull/26998 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-android-nodejs#302
| https://github.com/beevelop/docker-android-nodejs/issues/302 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-nodejs#275
| https://github.com/beevelop/docker-nodejs/issues/275 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-nodejs#276
| https://github.com/beevelop/docker-nodejs/issues/276 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-android-nodejs#303
| https://github.com/beevelop/docker-android-nodejs/issues/303 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-nodejs#277
| https://github.com/beevelop/docker-nodejs/issues/277 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-android-nodejs#304
| https://github.com/beevelop/docker-android-nodejs/issues/304 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-nodejs#278
| https://github.com/beevelop/docker-nodejs/issues/278 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-android-nodejs#305
| https://github.com/beevelop/docker-android-nodejs/issues/305 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-nodejs#279
| https://github.com/beevelop/docker-nodejs/issues/279 |
|
2019-04-23 Version 12.0.0 (Current) @BethGriggs
beevelop/docker-android-nodejs#306
| https://github.com/beevelop/docker-android-nodejs/issues/306 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 28, 2019
| https://github.com/nodejs/node/pull/26998#ref-commit-7da1633 |
| n-api: refactoring napi_create_function testing | https://github.com/octaviansoldea/node/commit/7da1633037b0857414311ad33959f7cbcacc4530 |
| 7da1633 | https://github.com/octaviansoldea/node/commit/7da1633037b0857414311ad33959f7cbcacc4530 |
| nodejs#26998 | https://github.com/nodejs/node/pull/26998 |
| nodejs#26998 | https://github.com/nodejs/node/pull/26998 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| nodejs#28848 | https://github.com/nodejs/node/pull/28848 |
| nodejs#26998 | https://github.com/nodejs/node/pull/26998 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| nodejs#28848 | https://github.com/nodejs/node/pull/28848 |
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 29, 2019
| https://github.com/nodejs/node/pull/26998#ref-pullrequest-474194120 |
|
n-api: refactoring napi_create_function testing
#28894
| https://github.com/nodejs/node/pull/28894 |
| Trott | https://github.com/Trott |
|
Aug 1, 2019
| https://github.com/nodejs/node/pull/26998#ref-commit-1ee47d5 |
|
| https://github.com/Trott |
| n-api: refactoring napi_create_function testing | https://github.com/Trott/io.js/commit/1ee47d550c6de132f06110aa13eceb7551d643b3 |
| 1ee47d5 | https://github.com/Trott/io.js/commit/1ee47d550c6de132f06110aa13eceb7551d643b3 |
| nodejs#26998 | https://github.com/nodejs/node/pull/26998 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| nodejs#28848 | https://github.com/nodejs/node/pull/28848 |
| nodejs#28894 | https://github.com/nodejs/node/pull/28894 |
| targos | https://github.com/targos |
|
Aug 2, 2019
| https://github.com/nodejs/node/pull/26998#ref-commit-c93df0c |
|
| https://github.com/targos |
| n-api: refactoring napi_create_function testing | https://github.com/nodejs/node/commit/c93df0cfc397c9430e22d21059f16424880bb140 |
| c93df0c | https://github.com/nodejs/node/commit/c93df0cfc397c9430e22d21059f16424880bb140 |
| #26998 | https://github.com/nodejs/node/pull/26998 |
| #28505 | https://github.com/nodejs/node/pull/28505 |
| #28848 | https://github.com/nodejs/node/pull/28848 |
| #28894 | https://github.com/nodejs/node/pull/28894 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26998 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/26998/files/d67fa82c0be82396b59f44bc33b7de033bead4c7 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/26998 |
|
| https://github.com/octaviansoldea |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |