René's URL Explorer Experiment


Title: src: remove internal includes from node_crypto.h by sam-github · Pull Request #26966 · nodejs/node · GitHub

Open Graph Title: src: remove internal includes from node_crypto.h by sam-github · Pull Request #26966 · nodejs/node

X Title: src: remove internal includes from node_crypto.h by sam-github · Pull Request #26966 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Remove headers used by node_crypto.cc that were included in node_crypto.h. The header file should only include what it uses itself. Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

X Description: Remove headers used by node_crypto.cc that were included in node_crypto.h. The header file should only include what it uses itself. Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

Opengraph URL: https://github.com/nodejs/node/pull/26966

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46687032-0727-622f-b0be-d8b92e9c5518
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDBE:371DAA:BCE64D:C06077:6A512822
html-safe-nonce31b20ea3961eddc86d062a9b66a075b20f89f28ef576a10cd24e005306417739
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREJFOjM3MURBQTpCQ0U2NEQ6QzA2MDc3OjZBNTEyODIyIiwidmlzaXRvcl9pZCI6IjQ3Mjk2NTk1MTE4ODI3MjEzMTQiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmac348ba5bd0bab7de6a7147d9c5632c5a02654e3690451c30cfb4dc9e3ea25a172
hovercard-subject-tagpull_request:265492220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26966/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d2c6959233344a7067a965d7fbfb3df5a22bfd6d8e85d130c4ab1026b5e81a3a/nodejs/node/pull/26966
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d2c6959233344a7067a965d7fbfb3df5a22bfd6d8e85d130c4ab1026b5e81a3a/nodejs/node/pull/26966
og:image:altRemove headers used by node_crypto.cc that were included in node_crypto.h. The header file should only include what it uses itself. Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
Nonea74ad1f4971203e7676c31c6c5233aa0b6995813088e47ba7b62c270d4b1ebfc
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea4218abefb3ba97edd71b38e508f263fc8c0d1c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26966#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26966
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26966
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26966
Reloadhttps://github.com/nodejs/node/pull/26966
Reloadhttps://github.com/nodejs/node/pull/26966
Please reload this pagehttps://github.com/nodejs/node/pull/26966
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26966
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:remove-internal-includes-from-node_crypto.hhttps://github.com/sam-github/node/tree/remove-internal-includes-from-node_crypto.h
Conversationhttps://github.com/nodejs/node/pull/26966
Commits1 (1)https://github.com/nodejs/node/pull/26966/commits
Checkshttps://github.com/nodejs/node/pull/26966/checks
Files changedhttps://github.com/nodejs/node/pull/26966/files
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/pull/26966#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:remove-internal-includes-from-node_crypto.hhttps://github.com/sam-github/node/tree/remove-internal-includes-from-node_crypto.h
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 28, 2019https://github.com/nodejs/node/pull/26966#issue-426693303
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/sam-github
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/pull/26966/commits/2065f764ad26c289a008da5d57ed3c882474348f
2065f76https://github.com/nodejs/node/pull/26966/commits/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2019https://github.com/nodejs/node/pull/26966#issuecomment-477758901
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 28, 2019https://github.com/nodejs/node/pull/26966#event-2237517993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 28, 2019 https://github.com/nodejs/node/pull/26966#pullrequestreview-220258803
View reviewed changes https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2019https://github.com/nodejs/node/pull/26966#issuecomment-477761242
https://ci.nodejs.org/job/node-test-pull-request/21994/https://ci.nodejs.org/job/node-test-pull-request/21994/
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 28, 2019 https://github.com/nodejs/node/pull/26966#pullrequestreview-220263826
View reviewed changes https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 28, 2019 https://github.com/nodejs/node/pull/26966#pullrequestreview-220277561
View reviewed changes https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 28, 2019https://github.com/nodejs/node/pull/26966#event-2237626926
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 29, 2019 https://github.com/nodejs/node/pull/26966#ref-pullrequest-427051525
src: remove header unneeded by OpenSSL 1.1.1 #26986 https://github.com/nodejs/node/pull/26986
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 29, 2019 https://github.com/nodejs/node/pull/26966#pullrequestreview-220665306
View reviewed changes https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 29, 2019 https://github.com/nodejs/node/pull/26966#pullrequestreview-220723266
View reviewed changes https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 2, 2019https://github.com/nodejs/node/pull/26966#issuecomment-478826871
https://ci.nodejs.org/job/node-test-pull-request/22108/https://ci.nodejs.org/job/node-test-pull-request/22108/
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Apr 2, 2019https://github.com/nodejs/node/pull/26966#issuecomment-478827112
dada2ebhttps://github.com/nodejs/node/commit/dada2eba937cc88b323f5251b8e4cccbacee6d5b
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Apr 2, 2019https://github.com/nodejs/node/pull/26966#event-2245170769
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
April 2, 2019 03:11https://github.com/nodejs/node/pull/26966#event-2245170840
sam-githubhttps://github.com/sam-github
Apr 2, 2019 https://github.com/nodejs/node/pull/26966#ref-commit-dada2eb
https://github.com/sam-github
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/commit/dada2eba937cc88b323f5251b8e4cccbacee6d5b
dada2ebhttps://github.com/nodejs/node/commit/dada2eba937cc88b323f5251b8e4cccbacee6d5b
#26966https://github.com/nodejs/node/pull/26966
CI failures: 20190330-20190402 nodejs/reliability#22 https://github.com/nodejs/reliability/issues/22
Investigate flaky test-fs-readfile-tostring-fail #16601 https://github.com/nodejs/node/issues/16601
BethGriggshttps://github.com/BethGriggs
Apr 5, 2019 https://github.com/nodejs/node/pull/26966#ref-commit-e22126c
https://github.com/sam-github
https://github.com/BethGriggs
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/commit/e22126ca4469d1cf63cc3e05b6f2eb4e0b52d891
e22126chttps://github.com/nodejs/node/commit/e22126ca4469d1cf63cc3e05b6f2eb4e0b52d891
#26966https://github.com/nodejs/node/pull/26966
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26966#ref-commit-a25ec8f
https://github.com/sam-github
https://github.com/BethGriggs
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/commit/a25ec8fc7c210a3c0981a6fa5b6949c17b49b124
a25ec8fhttps://github.com/nodejs/node/commit/a25ec8fc7c210a3c0981a6fa5b6949c17b49b124
#26966https://github.com/nodejs/node/pull/26966
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26966#ref-commit-f65cb75
https://github.com/sam-github
https://github.com/BethGriggs
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/commit/f65cb75c74aa45e94b759846d289272e1e26eb41
f65cb75https://github.com/nodejs/node/commit/f65cb75c74aa45e94b759846d289272e1e26eb41
#26966https://github.com/nodejs/node/pull/26966
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26966#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/26966#ref-commit-5102d69
https://github.com/sam-github
https://github.com/BethGriggs
src: remove internal includes from node_crypto.hhttps://github.com/nodejs/node/commit/5102d696fb5373c26204f59f911e790ab32a4601
5102d69https://github.com/nodejs/node/commit/5102d696fb5373c26204f59f911e790ab32a4601
#26966https://github.com/nodejs/node/pull/26966
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26966
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26966/files/2065f764ad26c289a008da5d57ed3c882474348f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/26966
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.