René's URL Explorer Experiment


Title: url: add ws: and wss: to slashedProtocol set by lpinca · Pull Request #26941 · nodejs/node · GitHub

Open Graph Title: url: add ws: and wss: to slashedProtocol set by lpinca · Pull Request #26941 · nodejs/node

X Title: url: add ws: and wss: to slashedProtocol set by lpinca · Pull Request #26941 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fix cases where the pathname is incorrectly parsed as null. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...

X Description: Fix cases where the pathname is incorrectly parsed as null. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...

Opengraph URL: https://github.com/nodejs/node/pull/26941

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f403bc74-b48e-7baf-cfea-2027aa6b5e0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA038:3AF9A7:222E96:308E7C:6A4E6780
html-safe-nonced233c27abcf7ee30cf3a08b6c066fb5d794aeaa8f71ebdb000b62448ab7be6df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDM4OjNBRjlBNzoyMjJFOTY6MzA4RTdDOjZBNEU2NzgwIiwidmlzaXRvcl9pZCI6Ijg3NDU3MTcyMjM3Mjc3MjAzMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdce69d80de74bbb965b6c313ab20254c01e5b1e3495b5ee915baeec85c374ee0
hovercard-subject-tagpull_request:264820197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26941/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/45f7e25fe2652b4f70e7cc4de0bc0a06192a0cf69bc80a04c03593d8eef5697a/nodejs/node/pull/26941
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45f7e25fe2652b4f70e7cc4de0bc0a06192a0cf69bc80a04c03593d8eef5697a/nodejs/node/pull/26941
og:image:altFix cases where the pathname is incorrectly parsed as null. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26941#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26941
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26941
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26941
Reloadhttps://github.com/nodejs/node/pull/26941
Reloadhttps://github.com/nodejs/node/pull/26941
Please reload this pagehttps://github.com/nodejs/node/pull/26941
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26941
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/ws-pathnamehttps://github.com/lpinca/node/tree/fix/ws-pathname
Conversationhttps://github.com/nodejs/node/pull/26941
Commits1 (1)https://github.com/nodejs/node/pull/26941/commits
Checkshttps://github.com/nodejs/node/pull/26941/checks
Files changedhttps://github.com/nodejs/node/pull/26941/files
url: add ws: and wss: to slashedProtocol sethttps://github.com/nodejs/node/pull/26941#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/ws-pathnamehttps://github.com/lpinca/node/tree/fix/ws-pathname
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 27, 2019https://github.com/nodejs/node/pull/26941#issue-425820326
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/lpinca
url: add ws: and wss: to slashedProtocol sethttps://github.com/nodejs/node/pull/26941/commits/20fb558907eb6568b1b45bb9bdda3be53127f7e3
20fb558https://github.com/nodejs/node/pull/26941/commits/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 27, 2019https://github.com/nodejs/node/pull/26941#issuecomment-477031533
@lpincahttps://github.com/lpinca
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3066/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3066/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Mar 27, 2019https://github.com/nodejs/node/pull/26941#event-2232244589
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 27, 2019https://github.com/nodejs/node/pull/26941#issuecomment-477032176
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/mihalskiy
mihalskiyhttps://github.com/mihalskiy
Mar 27, 2019 https://github.com/nodejs/node/pull/26941#pullrequestreview-219347633
View reviewed changes https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 27, 2019 https://github.com/nodejs/node/pull/26941#pullrequestreview-219423161
View reviewed changes https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 27, 2019 https://github.com/nodejs/node/pull/26941#pullrequestreview-219576688
View reviewed changes https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 27, 2019https://github.com/nodejs/node/pull/26941#issuecomment-477237914
https://ci.nodejs.org/job/node-test-pull-request/21965/https://ci.nodejs.org/job/node-test-pull-request/21965/
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 28, 2019https://github.com/nodejs/node/pull/26941#event-2234910497
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2019https://github.com/nodejs/node/pull/26941#issuecomment-477407366
https://ci.nodejs.org/job/node-test-pull-request/21976/https://ci.nodejs.org/job/node-test-pull-request/21976/
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 28, 2019 https://github.com/nodejs/node/pull/26941#pullrequestreview-219829513
View reviewed changes https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2019https://github.com/nodejs/node/pull/26941#issuecomment-477444464
https://ci.nodejs.org/job/node-test-pull-request/21980/https://ci.nodejs.org/job/node-test-pull-request/21980/
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/targos
targoshttps://github.com/targos
Mar 30, 2019https://github.com/nodejs/node/pull/26941#issuecomment-478239652
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/targos
targoshttps://github.com/targos
Mar 30, 2019https://github.com/nodejs/node/pull/26941#event-2241000178
targoshttps://github.com/targos
Mar 30, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-6a34b85
https://github.com/lpinca
https://github.com/targos
url: add ws: and wss: to slashedProtocol sethttps://github.com/nodejs/node/commit/6a34b85b05d61d016a1ca5072c94f6b449ab0e06
6a34b85https://github.com/nodejs/node/commit/6a34b85b05d61d016a1ca5072c94f6b449ab0e06
#26941https://github.com/nodejs/node/pull/26941
https://github.com/lpinca
lpincahttps://github.com/lpinca
March 30, 2019 13:40https://github.com/nodejs/node/pull/26941#event-2241038608
BethGriggshttps://github.com/BethGriggs
Apr 5, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-472e8e4
https://github.com/lpinca
https://github.com/BethGriggs
url: add ws: and wss: to slashedProtocol sethttps://github.com/nodejs/node/commit/472e8e4e8ac83437bfa6126c7ae5556cdc4b912d
472e8e4https://github.com/nodejs/node/commit/472e8e4e8ac83437bfa6126c7ae5556cdc4b912d
#26941https://github.com/nodejs/node/pull/26941
BethGriggshttps://github.com/BethGriggs
Apr 8, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-8798db3
https://github.com/lpinca
https://github.com/BethGriggs
url: add ws: and wss: to slashedProtocol sethttps://github.com/nodejs/node/commit/8798db3bf3e77a1891692ddc7dd963effbe06c86
8798db3https://github.com/nodejs/node/commit/8798db3bf3e77a1891692ddc7dd963effbe06c86
#26941https://github.com/nodejs/node/pull/26941
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26941#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 10, 2019 https://github.com/nodejs/node/pull/26941#ref-pullrequest-520570025
doc: add entry to url.parse() changes metadata #30348 https://github.com/nodejs/node/pull/30348
lpincahttps://github.com/lpinca
Nov 10, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-77885ff
https://github.com/lpinca
doc: add entry to url.parse() changes metadatahttps://github.com/lpinca/node/commit/77885ff39af5d4474a66117a917424f24870061e
77885ffhttps://github.com/lpinca/node/commit/77885ff39af5d4474a66117a917424f24870061e
nodejs#30154https://github.com/nodejs/node/issues/30154
nodejs#26941https://github.com/nodejs/node/pull/26941
lpincahttps://github.com/lpinca
Nov 15, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-04e45db
https://github.com/lpinca
doc: add entry to url.parse() changes metadatahttps://github.com/nodejs/node/commit/04e45db1726e1d2c11ecbf8cbacc82c88672fc83
04e45dbhttps://github.com/nodejs/node/commit/04e45db1726e1d2c11ecbf8cbacc82c88672fc83
#30348https://github.com/nodejs/node/pull/30348
#30154https://github.com/nodejs/node/issues/30154
#26941https://github.com/nodejs/node/pull/26941
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-e4a296c
https://github.com/lpinca
https://github.com/MylesBorins
doc: add entry to url.parse() changes metadatahttps://github.com/nodejs/node/commit/e4a296ce8dabe73b150115d883517fc846763e37
e4a296chttps://github.com/nodejs/node/commit/e4a296ce8dabe73b150115d883517fc846763e37
#30348https://github.com/nodejs/node/pull/30348
#30154https://github.com/nodejs/node/issues/30154
#26941https://github.com/nodejs/node/pull/26941
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-1ef1f4f
https://github.com/lpinca
https://github.com/targos
doc: add entry to url.parse() changes metadatahttps://github.com/nodejs/node/commit/1ef1f4fc6dc725e8a334ef53b2bc7c83f54efee4
1ef1f4fhttps://github.com/nodejs/node/commit/1ef1f4fc6dc725e8a334ef53b2bc7c83f54efee4
#30348https://github.com/nodejs/node/pull/30348
#30154https://github.com/nodejs/node/issues/30154
#26941https://github.com/nodejs/node/pull/26941
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/26941#ref-commit-d979a9d
https://github.com/lpinca
https://github.com/MylesBorins
doc: add entry to url.parse() changes metadatahttps://github.com/nodejs/node/commit/d979a9d391efea38b35143b7f94db3e98c41c688
d979a9dhttps://github.com/nodejs/node/commit/d979a9d391efea38b35143b7f94db3e98c41c688
#30348https://github.com/nodejs/node/pull/30348
#30154https://github.com/nodejs/node/issues/30154
#26941https://github.com/nodejs/node/pull/26941
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26941
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
https://github.com/mihalskiy
mihalskiy https://github.com/mihalskiy
https://github.com/nodejs/node/pull/26941/files/20fb558907eb6568b1b45bb9bdda3be53127f7e3
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Please reload this pagehttps://github.com/nodejs/node/pull/26941
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/ZYSzys
https://github.com/mihalskiy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.