René's URL Explorer Experiment


Title: src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt by joyeecheung · Pull Request #26935 · nodejs/node · GitHub

Open Graph Title: src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt by joyeecheung · Pull Request #26935 · nodejs/node

X Title: src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt by joyeecheung · Pull Request #26935 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If Debugger.setAsyncCallStackDepth is sent during bootstrap, we cannot immediately call into JS to enable the hooks, which could interrupt the JS execution of bootstrap. So instead we save the noti...

X Description: If Debugger.setAsyncCallStackDepth is sent during bootstrap, we cannot immediately call into JS to enable the hooks, which could interrupt the JS execution of bootstrap. So instead we save the noti...

Opengraph URL: https://github.com/nodejs/node/pull/26935

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:449e68e7-30f3-1ab5-c616-9e582d330611
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8160:AF773:26269C:3696AC:6A4E676A
html-safe-nonced75028d37d057c46df9a546bcda58560692a9c0c371825db2276be66b96e3061
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTYwOkFGNzczOjI2MjY5QzozNjk2QUM6NkE0RTY3NkEiLCJ2aXNpdG9yX2lkIjoiMjgwMDMzMjI5MzgyMTg1MTQ5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacef46532eb834d82a55f7b52b2104010ec59c4e962278872e16a48c3972e8bf1c
hovercard-subject-tagpull_request:264675432
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26935/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1ac3048591f11e0cc9b4ef115c72c5e88671bf6fadf28a0b495237452f72b08b/nodejs/node/pull/26935
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1ac3048591f11e0cc9b4ef115c72c5e88671bf6fadf28a0b495237452f72b08b/nodejs/node/pull/26935
og:image:altIf Debugger.setAsyncCallStackDepth is sent during bootstrap, we cannot immediately call into JS to enable the hooks, which could interrupt the JS execution of bootstrap. So instead we save the noti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26935#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26935
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26935
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26935
Reloadhttps://github.com/nodejs/node/pull/26935
Reloadhttps://github.com/nodejs/node/pull/26935
Please reload this pagehttps://github.com/nodejs/node/pull/26935
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26935
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:interrupthttps://github.com/joyeecheung/node/tree/interrupt
Conversationhttps://github.com/nodejs/node/pull/26935
Commits1 (1)https://github.com/nodejs/node/pull/26935/commits
Checkshttps://github.com/nodejs/node/pull/26935/checks
Files changedhttps://github.com/nodejs/node/pull/26935/files
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupthttps://github.com/nodejs/node/pull/26935#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:interrupthttps://github.com/joyeecheung/node/tree/interrupt
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 26, 2019https://github.com/nodejs/node/pull/26935#issue-425623958
Please reload this pagehttps://github.com/nodejs/node/pull/26935
#26798https://github.com/nodejs/node/issues/26798
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/joyeecheung
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupthttps://github.com/nodejs/node/pull/26935/commits/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
d5f9395https://github.com/nodejs/node/pull/26935/commits/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
nodejs#26798https://github.com/nodejs/node/issues/26798
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 26, 2019https://github.com/nodejs/node/pull/26935#issuecomment-476826791
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3063/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3063/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 26, 2019https://github.com/nodejs/node/pull/26935#event-2231036314
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
eugeneohttps://github.com/eugeneo
ofrobotshttps://github.com/ofrobots
March 26, 2019 20:07https://github.com/nodejs/node/pull/26935#event-2231036851
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 26, 2019https://github.com/nodejs/node/pull/26935#issuecomment-476827282
https://ci.nodejs.org/job/node-test-pull-request/21938/https://ci.nodejs.org/job/node-test-pull-request/21938/
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 26, 2019 https://github.com/nodejs/node/pull/26935#ref-issue-423074592
investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI #26798 https://github.com/nodejs/node/issues/26798
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 26, 2019 https://github.com/nodejs/node/pull/26935#pullrequestreview-219134008
View reviewed changes https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 26, 2019https://github.com/nodejs/node/pull/26935#issuecomment-476831736
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://ci.nodejs.org/job/node-stress-single-test/2194/https://ci.nodejs.org/job/node-stress-single-test/2194/
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Mar 26, 2019 https://github.com/nodejs/node/pull/26935#pullrequestreview-219145400
View reviewed changes https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Mar 27, 2019 https://github.com/nodejs/node/pull/26935#pullrequestreview-219334923
View reviewed changes https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 27, 2019https://github.com/nodejs/node/pull/26935#event-2232597380
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2019https://github.com/nodejs/node/pull/26935#issuecomment-477639773
https://ci.nodejs.org/job/node-test-pull-request/21988/https://ci.nodejs.org/job/node-test-pull-request/21988/
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 30, 2019https://github.com/nodejs/node/pull/26935#issuecomment-478203244
7aad63bhttps://github.com/nodejs/node/commit/7aad63ba349d7b9b0eda4149d236ee66e5a26401
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 30, 2019https://github.com/nodejs/node/pull/26935#event-2240815181
joyeecheunghttps://github.com/joyeecheung
Mar 30, 2019 https://github.com/nodejs/node/pull/26935#ref-commit-7aad63b
https://github.com/joyeecheung
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupthttps://github.com/nodejs/node/commit/7aad63ba349d7b9b0eda4149d236ee66e5a26401
7aad63bhttps://github.com/nodejs/node/commit/7aad63ba349d7b9b0eda4149d236ee66e5a26401
#26798https://github.com/nodejs/node/issues/26798
#26935https://github.com/nodejs/node/pull/26935
BethGriggshttps://github.com/BethGriggs
Apr 5, 2019 https://github.com/nodejs/node/pull/26935#ref-commit-4e1fe29
https://github.com/joyeecheung
https://github.com/BethGriggs
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupthttps://github.com/nodejs/node/commit/4e1fe2951a04390646fb7717277816705d49c3c4
4e1fe29https://github.com/nodejs/node/commit/4e1fe2951a04390646fb7717277816705d49c3c4
#26798https://github.com/nodejs/node/issues/26798
#26935https://github.com/nodejs/node/pull/26935
BethGriggshttps://github.com/BethGriggs
Apr 8, 2019 https://github.com/nodejs/node/pull/26935#ref-commit-e776b01
https://github.com/joyeecheung
https://github.com/BethGriggs
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupthttps://github.com/nodejs/node/commit/e776b013ad2826342a45bfeaaccc379e5e2cf628
e776b01https://github.com/nodejs/node/commit/e776b013ad2826342a45bfeaaccc379e5e2cf628
#26798https://github.com/nodejs/node/issues/26798
#26935https://github.com/nodejs/node/pull/26935
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26935#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 29, 2019 https://github.com/nodejs/node/pull/26935#ref-pullrequest-482431790
src,lib: make ^C print a JS stack trace #29207 https://github.com/nodejs/node/pull/29207
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 25, 2020 https://github.com/nodejs/node/pull/26935#ref-issue-444498197
FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this. #27714 https://github.com/nodejs/node/issues/27714
https://github.com/baby636
baby636https://github.com/baby636
Jul 12, 2023 https://github.com/nodejs/node/pull/26935#ref-pullrequest-1801591797
[Snyk] Security upgrade gatsby from 2.24.27 to 2.24.64 baby636/node#104 https://github.com/baby636/node/pull/104
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26935
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/eugeneo
eugeneo https://github.com/eugeneo
https://github.com/nodejs/node/pull/26935/files/d5f9395b7a2c6681aa20b3b35abe9045ceb9f4fc
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/26935
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/eugeneo
https://github.com/addaleax
https://github.com/JungMinu
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.