| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:130920fb-3795-e11d-bbc8-05b7a74c192a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA50:1DA8CE:9FC69B:CD1689:6990C80A |
| html-safe-nonce | 61a4ba07ce2422aa48a82a4f80b5a1219e886a3b5d51e7b919df615243622b52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTUwOjFEQThDRTo5RkM2OUI6Q0QxNjg5OjY5OTBDODBBIiwidmlzaXRvcl9pZCI6IjU2NTY1MDkwMDkwNTU3NjI0NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d595f5a94c870c6058743e4ca2adbc6c46d5a8e07e1230f94ca90f8b0eb8ad2e |
| hovercard-subject-tag | pull_request:264666370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26933/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d4c54880950acc3b58cdde9624c3fedd3832f070469b0cd282326e77246a31f3/nodejs/node/pull/26933 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d4c54880950acc3b58cdde9624c3fedd3832f070469b0cd282326e77246a31f3/nodejs/node/pull/26933 |
| og:image:alt | 2019-04-16, Version 8.16.0 'Carbon' (LTS), @MylesBorins
Notable Changes
n-api:
add API for asynchronous functions (Gabriel Schulhof) #17887
mark thread-safe function as stable (Gabriel Sc... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26933#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26933 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26933 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26933 |
| Reload | https://github.com/nodejs/node/pull/26933 |
| Reload | https://github.com/nodejs/node/pull/26933 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
704
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| MylesBorins | https://github.com/MylesBorins |
| v8.x | https://github.com/nodejs/node/tree/v8.x |
| v8.16.0-proposal | https://github.com/nodejs/node/tree/v8.16.0-proposal |
| Conversation | https://github.com/nodejs/node/pull/26933 |
| Commits34 (34) | https://github.com/nodejs/node/pull/26933/commits |
| Checks | https://github.com/nodejs/node/pull/26933/checks |
| Files changed | https://github.com/nodejs/node/pull/26933/files |
| v8.16.0 proposal | https://github.com/nodejs/node/pull/26933#top |
| MylesBorins | https://github.com/MylesBorins |
| v8.x | https://github.com/nodejs/node/tree/v8.x |
| v8.16.0-proposal | https://github.com/nodejs/node/tree/v8.16.0-proposal |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 26, 2019 | https://github.com/nodejs/node/pull/26933#issue-425612104 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| @MylesBorins | https://github.com/MylesBorins |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| c07ba9681f | https://github.com/nodejs/node/commit/c07ba9681f |
| #21228 | https://github.com/nodejs/node/pull/21228 |
| 63522886ea | https://github.com/nodejs/node/commit/63522886ea |
| #23168 | https://github.com/nodejs/node/pull/23168 |
| e9369073d9 | https://github.com/nodejs/node/commit/e9369073d9 |
| #25447 | https://github.com/nodejs/node/pull/25447 |
| 97cc0fc51d | https://github.com/nodejs/node/commit/97cc0fc51d |
| #25874 | https://github.com/nodejs/node/pull/25874 |
| a1aff28fba | https://github.com/nodejs/node/commit/a1aff28fba |
| #25041 | https://github.com/nodejs/node/pull/25041 |
| 6b7cccc88a | https://github.com/nodejs/node/commit/6b7cccc88a |
| #22998 | https://github.com/nodejs/node/pull/22998 |
| b17819db3d | https://github.com/nodejs/node/commit/b17819db3d |
| #25123 | https://github.com/nodejs/node/pull/25123 |
| ac9b8f7645 | https://github.com/nodejs/node/commit/ac9b8f7645 |
| #24738 | https://github.com/nodejs/node/pull/24738 |
| 1d862610f8 | https://github.com/nodejs/node/commit/1d862610f8 |
| #25459 | https://github.com/nodejs/node/pull/25459 |
| 1e76323061 | https://github.com/nodejs/node/commit/1e76323061 |
| #26439 | https://github.com/nodejs/node/pull/26439 |
| 2b2ad96ef2 | https://github.com/nodejs/node/commit/2b2ad96ef2 |
| #25992 | https://github.com/nodejs/node/pull/25992 |
| d6ffabc37f | https://github.com/nodejs/node/commit/d6ffabc37f |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| 44609d1274 | https://github.com/nodejs/node/commit/44609d1274 |
| #19962 | https://github.com/nodejs/node/pull/19962 |
| fe4328252a | https://github.com/nodejs/node/commit/fe4328252a |
| #24011 | https://github.com/nodejs/node/pull/24011 |
| 902b07959f | https://github.com/nodejs/node/commit/902b07959f |
| #22259 | https://github.com/nodejs/node/pull/22259 |
| 09b88aabb3 | https://github.com/nodejs/node/commit/09b88aabb3 |
| #22520 | https://github.com/nodejs/node/pull/22520 |
| 367505940a | https://github.com/nodejs/node/commit/367505940a |
| #21871 | https://github.com/nodejs/node/pull/21871 |
| c5a11dc58e | https://github.com/nodejs/node/commit/c5a11dc58e |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| 759a0180b5 | https://github.com/nodejs/node/commit/759a0180b5 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| ea5628e77a | https://github.com/nodejs/node/commit/ea5628e77a |
| #23053 | https://github.com/nodejs/node/pull/23053 |
| 67b6e0d19c | https://github.com/nodejs/node/commit/67b6e0d19c |
| #21898 | https://github.com/nodejs/node/pull/21898 |
| eaf474cc5d | https://github.com/nodejs/node/commit/eaf474cc5d |
| #19211 | https://github.com/nodejs/node/pull/19211 |
| 3128cb7da6 | https://github.com/nodejs/node/commit/3128cb7da6 |
| #21298 | https://github.com/nodejs/node/pull/21298 |
| b4c5435a46 | https://github.com/nodejs/node/commit/b4c5435a46 |
| #23051 | https://github.com/nodejs/node/pull/23051 |
| c56f3edb10 | https://github.com/nodejs/node/commit/c56f3edb10 |
| #23053 | https://github.com/nodejs/node/pull/23053 |
| f6ff8c51bc | https://github.com/nodejs/node/commit/f6ff8c51bc |
| #25418 | https://github.com/nodejs/node/pull/25418 |
| d4b6643ac3 | https://github.com/nodejs/node/commit/d4b6643ac3 |
| #25032 | https://github.com/nodejs/node/pull/25032 |
| 60db455961 | https://github.com/nodejs/node/commit/60db455961 |
| #24714 | https://github.com/nodejs/node/pull/24714 |
| fbafe8d311 | https://github.com/nodejs/node/commit/fbafe8d311 |
| #25226 | https://github.com/nodejs/node/pull/25226 |
| 7573b55a15 | https://github.com/nodejs/node/commit/7573b55a15 |
| #26452 | https://github.com/nodejs/node/pull/26452 |
| 91620b8bd6 | https://github.com/nodejs/node/commit/91620b8bd6 |
| #26452 | https://github.com/nodejs/node/pull/26452 |
| 1a9582b7a6 | https://github.com/nodejs/node/commit/1a9582b7a6 |
| #23053 | https://github.com/nodejs/node/pull/23053 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| psmarshall | https://github.com/psmarshall |
| February 28, 2019 23:40 | https://github.com/nodejs/node/pull/26933#commits-pushed-a1aff28 |
|
| https://github.com/psmarshall |
|
| https://github.com/rvagg |
| deps: cherry-pick | https://github.com/nodejs/node/pull/26933/commits/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| 525b396 | https://github.com/nodejs/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| from V8 upstream | https://github.com/nodejs/node/pull/26933/commits/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| a1aff28 | https://github.com/nodejs/node/pull/26933/commits/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| #25041 | https://github.com/nodejs/node/pull/25041 |
|
| https://github.com/jbunton-atlassian |
|
| https://github.com/rvagg |
| doc: update the http.request.setTimeout docs to be accurate | https://github.com/nodejs/node/pull/26933/commits/b17819db3d58693c40a5711bbaa50592fc638816 |
| b17819d | https://github.com/nodejs/node/pull/26933/commits/b17819db3d58693c40a5711bbaa50592fc638816 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| #25123 | https://github.com/nodejs/node/pull/25123 |
|
| https://github.com/addaleax |
|
| https://github.com/rvagg |
| test: fix test-repl-envvars | https://github.com/nodejs/node/pull/26933/commits/fbafe8d311b4abd3154ded212075c2819cbd360a |
| fbafe8d | https://github.com/nodejs/node/pull/26933/commits/fbafe8d311b4abd3154ded212075c2819cbd360a |
| 180f865 | https://github.com/nodejs/node/commit/180f86507d496b11aa35b2df4594629a92cce329 |
| #21451 | https://github.com/nodejs/node/issues/21451 |
| nodejs/build#1377 | https://github.com/nodejs/build/issues/1377 |
| #25219 | https://github.com/nodejs/node/pull/25219 |
| #25226 | https://github.com/nodejs/node/pull/25226 |
|
| https://github.com/rvagg |
| n-api: add API for asynchronous functions | https://github.com/nodejs/node/pull/26933/commits/759a0180b5194686692caab955e371c5efc82e4e |
| 759a018 | https://github.com/nodejs/node/pull/26933/commits/759a0180b5194686692caab955e371c5efc82e4e |
| nodejs/help#1035 | https://github.com/nodejs/help/issues/1035 |
| #20964 | https://github.com/nodejs/node/issues/20964 |
| #13512 | https://github.com/nodejs/node/issues/13512 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
|
| https://github.com/cjihrig |
|
| https://github.com/rvagg |
| n-api: fix compiler warning | https://github.com/nodejs/node/pull/26933/commits/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| c5a11dc | https://github.com/nodejs/node/pull/26933/commits/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
|
| https://github.com/rvagg |
| n-api: guard against cond null dereference | https://github.com/nodejs/node/pull/26933/commits/367505940ab09369262295cf21d3ebe08b943ad5 |
| 3675059 | https://github.com/nodejs/node/pull/26933/commits/367505940ab09369262295cf21d3ebe08b943ad5 |
| nodejs/help#1387 | https://github.com/nodejs/help/issues/1387 |
| #21871 | https://github.com/nodejs/node/pull/21871 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
|
| https://github.com/mhdawson |
|
| https://github.com/rvagg |
| src: fix may be uninitialized warning in n-api | https://github.com/nodejs/node/pull/26933/commits/67b6e0d19ca2ca1fd0705f22730f1fd018568b5c |
| 67b6e0d | https://github.com/nodejs/node/pull/26933/commits/67b6e0d19ca2ca1fd0705f22730f1fd018568b5c |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #21898 | https://github.com/nodejs/node/pull/21898 |
|
| https://github.com/rvagg |
| n-api: remove idle_running from TsFn | https://github.com/nodejs/node/pull/26933/commits/09b88aabb3fd5cfd2da98ae83c2f1edd82d899c5 |
| 09b88aa | https://github.com/nodejs/node/pull/26933/commits/09b88aabb3fd5cfd2da98ae83c2f1edd82d899c5 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22520 | https://github.com/nodejs/node/pull/22520 |
|
| https://github.com/rvagg |
| n-api: clean up thread-safe function | https://github.com/nodejs/node/pull/26933/commits/902b07959f491e80d2f9cfc6f3ce92916f8e0cd4 |
| 902b079 | https://github.com/nodejs/node/pull/26933/commits/902b07959f491e80d2f9cfc6f3ce92916f8e0cd4 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22259 | https://github.com/nodejs/node/pull/22259 |
|
| https://github.com/rvagg |
| doc: fix optional parameters in n-api.md | https://github.com/nodejs/node/pull/26933/commits/6b7cccc88aeb91a6e07a29ab296a7d49f80b614b |
| 6b7cccc | https://github.com/nodejs/node/pull/26933/commits/6b7cccc88aeb91a6e07a29ab296a7d49f80b614b |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22998 | https://github.com/nodejs/node/pull/22998 |
|
| https://github.com/danbev |
|
| https://github.com/rvagg |
| n-api: add missing handle scopes | https://github.com/nodejs/node/pull/26933/commits/fe4328252a95f8096dd559d981bcab26a39dd70a |
| fe43282 | https://github.com/nodejs/node/pull/26933/commits/fe4328252a95f8096dd559d981bcab26a39dd70a |
| https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 | https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24011 | https://github.com/nodejs/node/pull/24011 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/rvagg |
| test: mark test_threadsafe_function/test as flaky | https://github.com/nodejs/node/pull/26933/commits/60db455961477244c6ca4fcf17bcd2c2e90820ca |
| 60db455 | https://github.com/nodejs/node/pull/26933/commits/60db455961477244c6ca4fcf17bcd2c2e90820ca |
| #23621 | https://github.com/nodejs/node/issues/23621 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24714 | https://github.com/nodejs/node/pull/24714 |
|
| https://github.com/Trott |
|
| https://github.com/rvagg |
| test: mark test-cli-node-options flaky on arm | https://github.com/nodejs/node/pull/26933/commits/d4b6643ac333863efd417732ac641582e1a6211d |
| d4b6643 | https://github.com/nodejs/node/pull/26933/commits/d4b6643ac333863efd417732ac641582e1a6211d |
| #25028 | https://github.com/nodejs/node/issues/25028 |
| #25032 | https://github.com/nodejs/node/pull/25032 |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| test: fix module loading error for AIX 7.1 | https://github.com/nodejs/node/pull/26933/commits/f6ff8c51bc6b97882b6d60b6b7f7db099539de00 |
| f6ff8c5 | https://github.com/nodejs/node/pull/26933/commits/f6ff8c51bc6b97882b6d60b6b7f7db099539de00 |
| #25418 | https://github.com/nodejs/node/pull/25418 |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| build: set -blibpath: for AIX | https://github.com/nodejs/node/pull/26933/commits/e9369073d949979e51cee03a61f82c5c4f604e10 |
| e936907 | https://github.com/nodejs/node/pull/26933/commits/e9369073d949979e51cee03a61f82c5c4f604e10 |
| #17604 | https://github.com/nodejs/node/pull/17604 |
| #25444 | https://github.com/nodejs/node/issues/25444 |
| #25521 | https://github.com/nodejs/node/pull/25521 |
| #25447 | https://github.com/nodejs/node/pull/25447 |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| tools: allow input for TTY tests | https://github.com/nodejs/node/pull/26933/commits/1a9582b7a66759d1c478f5b6b2adc91e39cc982a |
| 1a9582b | https://github.com/nodejs/node/pull/26933/commits/1a9582b7a66759d1c478f5b6b2adc91e39cc982a |
| #25351 | https://github.com/nodejs/node/pull/25351 |
| #23053 | https://github.com/nodejs/node/pull/23053 |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| process: allow reading from stdout/stderr sockets | https://github.com/nodejs/node/pull/26933/commits/ea5628e77ae12bdb34e4c1514261ea27c45f6562 |
| ea5628e | https://github.com/nodejs/node/pull/26933/commits/ea5628e77ae12bdb34e4c1514261ea27c45f6562 |
| #21203 | https://github.com/nodejs/node/issues/21203 |
| #25351 | https://github.com/nodejs/node/pull/25351 |
| #23053 | https://github.com/nodejs/node/pull/23053 |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| test: add stdin writable regression test | https://github.com/nodejs/node/pull/26933/commits/c56f3edb103b03ee9b8aaa0b90a36b61278c2aea |
| c56f3ed | https://github.com/nodejs/node/pull/26933/commits/c56f3edb103b03ee9b8aaa0b90a36b61278c2aea |
| #25351 | https://github.com/nodejs/node/pull/25351 |
| #23053 | https://github.com/nodejs/node/pull/23053 |
|
| https://github.com/mcollina |
|
| https://github.com/BethGriggs |
| test: add process.stdin.end() TTY regression test | https://github.com/nodejs/node/pull/26933/commits/b4c5435a46235534062edeb26adef599de7d1b31 |
| b4c5435 | https://github.com/nodejs/node/pull/26933/commits/b4c5435a46235534062edeb26adef599de7d1b31 |
| #25351 | https://github.com/nodejs/node/pull/25351 |
| #23051 | https://github.com/nodejs/node/pull/23051 |
| #22814 | https://github.com/nodejs/node/issues/22814 |
|
| https://github.com/kfarnung |
|
| https://github.com/BethGriggs |
| n-api: restrict exports by version | https://github.com/nodejs/node/pull/26933/commits/44609d1274a1dca879f87d22143137a56f729f48 |
| 44609d1 | https://github.com/nodejs/node/pull/26933/commits/44609d1274a1dca879f87d22143137a56f729f48 |
| #19962 | https://github.com/nodejs/node/pull/19962 |
| #25648 | https://github.com/nodejs/node/pull/25648 |
|
| https://github.com/BethGriggs |
| n-api: mark thread-safe function as stable | https://github.com/nodejs/node/pull/26933/commits/d6ffabc37f95aa4beda2f815e9fad6aed71e1802 |
| d6ffabc | https://github.com/nodejs/node/pull/26933/commits/d6ffabc37f95aa4beda2f815e9fad6aed71e1802 |
| #24249 | https://github.com/nodejs/node/issues/24249 |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| #25648 | https://github.com/nodejs/node/pull/25648 |
|
| https://github.com/BethGriggs |
| http: attach reused parser to correct domain | https://github.com/nodejs/node/pull/26933/commits/1d862610f85aa3ee8ca2e7a4f120794eff7133c4 |
| 1d86261 | https://github.com/nodejs/node/pull/26933/commits/1d862610f85aa3ee8ca2e7a4f120794eff7133c4 |
| #25456 | https://github.com/nodejs/node/issues/25456 |
| #25459 | https://github.com/nodejs/node/pull/25459 |
|
| https://github.com/mscdex |
|
| https://github.com/BethGriggs |
| http: fix error check in Execute() | https://github.com/nodejs/node/pull/26933/commits/ac9b8f7645da1818068336c269e605025b0fb467 |
| ac9b8f7 | https://github.com/nodejs/node/pull/26933/commits/ac9b8f7645da1818068336c269e605025b0fb467 |
| #25938 | https://github.com/nodejs/node/pull/25938 |
| #24585 | https://github.com/nodejs/node/issues/24585 |
| #24738 | https://github.com/nodejs/node/pull/24738 |
|
| https://github.com/BethGriggs |
| n-api: finalize during second-pass callback | https://github.com/nodejs/node/pull/26933/commits/2b2ad96ef284be7370ddf535b39fa05cf1d77fb1 |
| 2b2ad96 | https://github.com/nodejs/node/pull/26933/commits/2b2ad96ef284be7370ddf535b39fa05cf1d77fb1 |
| #25927 | https://github.com/nodejs/node/issues/25927 |
| #25992 | https://github.com/nodejs/node/pull/25992 |
| #26060 | https://github.com/nodejs/node/pull/26060 |
|
| https://github.com/rubys |
|
| https://github.com/BethGriggs |
| build: add loader path to rpath for cctest | https://github.com/nodejs/node/pull/26933/commits/63522886ea298073d8bb6cd4a5ee835c98dce13d |
| 6352288 | https://github.com/nodejs/node/pull/26933/commits/63522886ea298073d8bb6cd4a5ee835c98dce13d |
| #25681 | https://github.com/nodejs/node/pull/25681 |
| #23168 | https://github.com/nodejs/node/pull/23168 |
|
| https://github.com/yhwang |
|
| https://github.com/BethGriggs |
| build: skip cctest on Windows shared lib build | https://github.com/nodejs/node/pull/26933/commits/c07ba9681fd16c5aaa8dce66478efa6a80372d2a |
| c07ba96 | https://github.com/nodejs/node/pull/26933/commits/c07ba9681fd16c5aaa8dce66478efa6a80372d2a |
| #25758 | https://github.com/nodejs/node/pull/25758 |
| #21228 | https://github.com/nodejs/node/pull/21228 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/BethGriggs |
| tls: fix legacy SecurePair session resumption | https://github.com/nodejs/node/pull/26933/commits/91620b8bd61bc7932198c2309b8f3158d04ae4ca |
| 91620b8 | https://github.com/nodejs/node/pull/26933/commits/91620b8bd61bc7932198c2309b8f3158d04ae4ca |
| 75ea11f | https://github.com/nodejs/node/commit/75ea11fc08019bb1ffac81583ed7d0da3241a5b5 |
| #26428 | https://github.com/nodejs/node/issues/26428 |
| #26428 | https://github.com/nodejs/node/issues/26428 |
| #26452 | https://github.com/nodejs/node/pull/26452 |
| #26428 | https://github.com/nodejs/node/issues/26428 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/BethGriggs |
| tls: fix legacy SecurePair clienthello race window | https://github.com/nodejs/node/pull/26933/commits/7573b55a1505e5ea0e2c903e15013bb409fe3c93 |
| 7573b55 | https://github.com/nodejs/node/pull/26933/commits/7573b55a1505e5ea0e2c903e15013bb409fe3c93 |
| #26428 | https://github.com/nodejs/node/issues/26428 |
| #26452 | https://github.com/nodejs/node/pull/26452 |
|
| https://github.com/BethGriggs |
| deps: V8: cherry-pick 3cc6919 | https://github.com/nodejs/node/pull/26933/commits/97cc0fc51d085a49b4b9c3473bdab2e7c2a5ff5b |
| 97cc0fc | https://github.com/nodejs/node/pull/26933/commits/97cc0fc51d085a49b4b9c3473bdab2e7c2a5ff5b |
| https://chromium-review.googlesource.com/c/1430619 | https://chromium-review.googlesource.com/c/1430619 |
| #59049 | https://github.com/nodejs/node/pull/59049 |
| v8/v8@3cc6919 | https://github.com/v8/v8/commit/3cc69194b5ee967d0386fdd47de7a84141fef8cc |
| #25874 | https://github.com/nodejs/node/pull/25874 |
|
| https://github.com/jBarz |
|
| https://github.com/BethGriggs |
| test: avoid running fsync on directory on AIX | https://github.com/nodejs/node/pull/26933/commits/3128cb7da60ecf77dd9ab85b3e14507313fbba23 |
| 3128cb7 | https://github.com/nodejs/node/pull/26933/commits/3128cb7da60ecf77dd9ab85b3e14507313fbba23 |
| #21298 | https://github.com/nodejs/node/pull/21298 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 11, 2019
| https://github.com/nodejs/node/pull/26933#ref-issue-431803573 |
|
[8.x] assert.rejects fails with confusing error message
#27185
| https://github.com/nodejs/node/issues/27185 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 12, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-482640784 |
| @MylesBorins | https://github.com/MylesBorins |
| #27202 | https://github.com/nodejs/node/pull/27202 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 12, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-482663429 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 13, 2019
| https://github.com/nodejs/node/pull/26933#ref-pullrequest-432804332 |
|
test: fix test-dns-idna2008.js
#27208
| https://github.com/nodejs/node/pull/27208 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 14, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-482968420 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 15, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483436780 |
| https://ci.nodejs.org/job/node-test-pull-request/22462/ | https://ci.nodejs.org/job/node-test-pull-request/22462/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 15, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483436787 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1824/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1824/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| BridgeAR | https://github.com/BridgeAR |
| April 15, 2019 23:49 | https://github.com/nodejs/node/pull/26933#commits-pushed-705935d |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix backport regression | https://github.com/nodejs/node/pull/26933/commits/705935d62059d92543cda43c8cdb29bc34082d5e |
| 705935d | https://github.com/nodejs/node/pull/26933/commits/705935d62059d92543cda43c8cdb29bc34082d5e |
| #27185 | https://github.com/nodejs/node/issues/27185 |
| #27202 | https://github.com/nodejs/node/pull/27202 |
|
| https://github.com/anthony-tuininga |
|
| https://github.com/MylesBorins |
| n-api: improve performance creating strings | https://github.com/nodejs/node/pull/26933/commits/d3de1ed653c897c932caa5d8421bc6ddb4c32bca |
| d3de1ed | https://github.com/nodejs/node/pull/26933/commits/d3de1ed653c897c932caa5d8421bc6ddb4c32bca |
| #26439 | https://github.com/nodejs/node/pull/26439 |
| #26437 | https://github.com/nodejs/node/issues/26437 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e..4a6662c70c96a77770fc9f4564896211bb79a521 |
| 3a7f44e | https://github.com/nodejs/node/commit/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e |
| 4a6662c | https://github.com/nodejs/node/commit/4a6662c70c96a77770fc9f4564896211bb79a521 |
|
Compare
| https://github.com/nodejs/node/compare/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e..4a6662c70c96a77770fc9f4564896211bb79a521 |
| April 16, 2019 03:52 | https://github.com/nodejs/node/pull/26933#event-2278435705 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/26933#ref-commit-4a6662c |
|
| https://github.com/MylesBorins |
| 2019-04-18, Version 8.16.0 'Carbon' (LTS) | https://github.com/nodejs/node/commit/4a6662c70c96a77770fc9f4564896211bb79a521 |
| 4a6662c | https://github.com/nodejs/node/commit/4a6662c70c96a77770fc9f4564896211bb79a521 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| #26933 | https://github.com/nodejs/node/pull/26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483501335 |
| https://ci.nodejs.org/job/node-test-pull-request/22481/ | https://ci.nodejs.org/job/node-test-pull-request/22481/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483516435 |
| https://ci.nodejs.org/job/node-test-pull-request/22484/ | https://ci.nodejs.org/job/node-test-pull-request/22484/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483598528 |
| https://ci.nodejs.org/job/node-test-commit-linux/26998/nodes=centos6-64-gcc48/console | https://ci.nodejs.org/job/node-test-commit-linux/26998/nodes=centos6-64-gcc48/console |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483598761 |
| https://ci.nodejs.org/job/node-test-pull-request/22487/ | https://ci.nodejs.org/job/node-test-pull-request/22487/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483694868 |
| https://ci.nodejs.org/job/node-test-pull-request/22308/ | https://ci.nodejs.org/job/node-test-pull-request/22308/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483706107 |
| https://ci.nodejs.org/job/node-test-pull-request/22494/ | https://ci.nodejs.org/job/node-test-pull-request/22494/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483709144 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26933 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483711792 |
| https://ci.nodejs.org/job/node-test-pull-request/22495/ | https://ci.nodejs.org/job/node-test-pull-request/22495/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483713018 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| properly setup | https://ci-release.nodejs.org/job/iojs+release/nodes=centos6-64-gcc48/4356/ |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-483738215 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
|
| https://github.com/MylesBorins |
| 2019-04-16, Version 8.16.0 'Carbon' (LTS) | https://github.com/nodejs/node/pull/26933/commits/5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
| 5f93cf7 | https://github.com/nodejs/node/pull/26933/commits/5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| #26933 | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/4a6662c70c96a77770fc9f4564896211bb79a521..5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
| 4a6662c | https://github.com/nodejs/node/commit/4a6662c70c96a77770fc9f4564896211bb79a521 |
| 5f93cf7 | https://github.com/nodejs/node/commit/5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
|
Compare
| https://github.com/nodejs/node/compare/4a6662c70c96a77770fc9f4564896211bb79a521..5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
| April 16, 2019 16:40 | https://github.com/nodejs/node/pull/26933#event-2280299238 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| 5f93cf7 | https://github.com/nodejs/node/commit/5f93cf7e3a732b0ace1ccc9950d88cdb5d6ff029 |
| Apr 16, 2019 | https://github.com/nodejs/node/pull/26933#event-2280810178 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/26933#ref-commit-07458ba |
|
| https://github.com/MylesBorins |
| Working on v8.16.1 | https://github.com/nodejs/node/commit/07458ba78dfc7ed001ddd5d681055803df91ee48 |
| 07458ba | https://github.com/nodejs/node/commit/07458ba78dfc7ed001ddd5d681055803df91ee48 |
| #26933 | https://github.com/nodejs/node/pull/26933 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/26933#ref-commit-1c26169 |
|
| https://github.com/MylesBorins |
| 2019-04-16, Version 8.16.0 'Carbon' (LTS) | https://github.com/nodejs/node/commit/1c2616971417bee811ea00da436c87a489f9b1ed |
| 1c26169 | https://github.com/nodejs/node/commit/1c2616971417bee811ea00da436c87a489f9b1ed |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25556 | https://github.com/nodejs/node/pull/25556 |
| #26933 | https://github.com/nodejs/node/pull/26933 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/26933#ref-pullrequest-433965337 |
|
blog: release post for v8.16.0
nodejs/nodejs.org#2192
| https://github.com/nodejs/nodejs.org/pull/2192 |
| https://github.com/jim-at-miramontes |
| jim-at-miramontes | https://github.com/jim-at-miramontes |
| May 3, 2019 | https://github.com/nodejs/node/pull/26933#issuecomment-489155603 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
| https://github.com/targos |
| targos | https://github.com/targos |
| June 4, 2019 14:09 | https://github.com/nodejs/node/pull/26933#event-2388278951 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26933 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/26933/files/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/26933/files/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/26933/files/3a7f44e62c22fcebb83c7677d5cac3029e3f8d6e |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/26933 |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/anthony-tuininga |
|
| https://github.com/paulmillr |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com/refack |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com/jim-at-miramontes |
|
| https://github.com/BethGriggs |
|
| https://github.com/psmarshall |
|
| https://github.com/jbunton-atlassian |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/danbev |
|
| https://github.com/Trott |
|
| https://github.com/mcollina |
|
| https://github.com/kfarnung |
|
| https://github.com/mscdex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |