René's URL Explorer Experiment


Title: crypto: allow undefined for saltLength and padding by tniessen · Pull Request #26921 · nodejs/node · GitHub

Open Graph Title: crypto: allow undefined for saltLength and padding by tniessen · Pull Request #26921 · nodejs/node

X Title: crypto: allow undefined for saltLength and padding by tniessen · Pull Request #26921 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Using options.hasOwnProperty is not how we usually validate options. Passing { saltLength } where saltLength === undefined should be equivalent to not passing a saltLength option in my opinion. Fee...

X Description: Using options.hasOwnProperty is not how we usually validate options. Passing { saltLength } where saltLength === undefined should be equivalent to not passing a saltLength option in my opinion. Fee...

Opengraph URL: https://github.com/nodejs/node/pull/26921

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9afebc17-e901-e2df-3840-c02023f425f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD080:69662:1AB8B7B:24DDFFC:6A4EBD0B
html-safe-nonced9aacfd1f95a11ea91e04b61f252633a1fc7f0039636ebf32be415320a981dee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDgwOjY5NjYyOjFBQjhCN0I6MjREREZGQzo2QTRFQkQwQiIsInZpc2l0b3JfaWQiOiI4OTUzNTU1MzgxMjg1NDY5NDUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3fb464702dcdc23a2e8ff10f9ab022d2208362360b01a64379f4831ac59fa64d
hovercard-subject-tagpull_request:264494233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26921/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5806387595fe322b6e417cecead99eea4104eb115a96e0e740b10d69ef25877/nodejs/node/pull/26921
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5806387595fe322b6e417cecead99eea4104eb115a96e0e740b10d69ef25877/nodejs/node/pull/26921
og:image:altUsing options.hasOwnProperty is not how we usually validate options. Passing { saltLength } where saltLength === undefined should be equivalent to not passing a saltLength option in my opinion. Fee...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26921#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26921
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26921
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26921
Reloadhttps://github.com/nodejs/node/pull/26921
Reloadhttps://github.com/nodejs/node/pull/26921
Please reload this pagehttps://github.com/nodejs/node/pull/26921
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26921
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-allow-undefined-for-salt-lengthhttps://github.com/tniessen/node/tree/crypto-allow-undefined-for-salt-length
Conversationhttps://github.com/nodejs/node/pull/26921
Commits1 (1)https://github.com/nodejs/node/pull/26921/commits
Checkshttps://github.com/nodejs/node/pull/26921/checks
Files changedhttps://github.com/nodejs/node/pull/26921/files
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/pull/26921#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-allow-undefined-for-salt-lengthhttps://github.com/tniessen/node/tree/crypto-allow-undefined-for-salt-length
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 26, 2019https://github.com/nodejs/node/pull/26921#issue-425383716
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/tniessen
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/pull/26921/commits/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
13cfbddhttps://github.com/nodejs/node/pull/26921/commits/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 26, 2019https://github.com/nodejs/node/pull/26921#issuecomment-476600221
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3049/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3049/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Mar 26, 2019https://github.com/nodejs/node/pull/26921#event-2229484592
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 26, 2019 https://github.com/nodejs/node/pull/26921#pullrequestreview-218918475
View reviewed changes https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/26921#pullrequestreview-218918475
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 26, 2019 https://github.com/nodejs/node/pull/26921#pullrequestreview-218951181
View reviewed changes https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 26, 2019https://github.com/nodejs/node/pull/26921#issuecomment-476708078
https://ci.nodejs.org/job/node-test-pull-request/21913/https://ci.nodejs.org/job/node-test-pull-request/21913/
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 26, 2019https://github.com/nodejs/node/pull/26921#event-2230232695
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 27, 2019 https://github.com/nodejs/node/pull/26921#pullrequestreview-219289221
View reviewed changes https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/26921#pullrequestreview-219289221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#11705https://github.com/nodejs/node/pull/11705
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/panva
panvahttps://github.com/panva
Mar 27, 2019https://github.com/nodejs/node/pull/26921#issuecomment-477049878
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/tniessen
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26921
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 28, 2019https://github.com/nodejs/node/pull/26921#issuecomment-477597722
c35acc0https://github.com/nodejs/node/commit/c35acc0260b48dc4c656014ef665d811bdd02aa6
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 28, 2019https://github.com/nodejs/node/pull/26921#event-2236286107
tniessenhttps://github.com/tniessen
Mar 28, 2019 https://github.com/nodejs/node/pull/26921#ref-commit-c35acc0
https://github.com/tniessen
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/commit/c35acc0260b48dc4c656014ef665d811bdd02aa6
c35acc0https://github.com/nodejs/node/commit/c35acc0260b48dc4c656014ef665d811bdd02aa6
#26921https://github.com/nodejs/node/pull/26921
migounettehttps://github.com/migounette
Mar 28, 2019 https://github.com/nodejs/node/pull/26921#ref-commit-f04bc6a
https://github.com/tniessen
crypto: allow undefined for saltLength and paddinghttps://github.com/migounette/node-js/commit/f04bc6ab5983bb6a469594969154d3410b9941de
f04bc6ahttps://github.com/migounette/node-js/commit/f04bc6ab5983bb6a469594969154d3410b9941de
nodejs#26921https://github.com/nodejs/node/pull/26921
targoshttps://github.com/targos
Mar 28, 2019 https://github.com/nodejs/node/pull/26921#ref-commit-b922e77
https://github.com/tniessen
https://github.com/targos
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/commit/b922e7771e1567d8dd14118a97f88b735c7c7d7e
b922e77https://github.com/nodejs/node/commit/b922e7771e1567d8dd14118a97f88b735c7c7d7e
#26921https://github.com/nodejs/node/pull/26921
BethGriggshttps://github.com/BethGriggs
Apr 5, 2019 https://github.com/nodejs/node/pull/26921#ref-commit-676fa5f
https://github.com/tniessen
https://github.com/BethGriggs
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/commit/676fa5f965147ab98fe50e521027833659d02364
676fa5fhttps://github.com/nodejs/node/commit/676fa5f965147ab98fe50e521027833659d02364
#26921https://github.com/nodejs/node/pull/26921
BethGriggshttps://github.com/BethGriggs
Apr 8, 2019 https://github.com/nodejs/node/pull/26921#ref-commit-98552f3
https://github.com/tniessen
https://github.com/BethGriggs
crypto: allow undefined for saltLength and paddinghttps://github.com/nodejs/node/commit/98552f3630576c108a350a5784a904bfc1d05e3b
98552f3https://github.com/nodejs/node/commit/98552f3630576c108a350a5784a904bfc1d05e3b
#26921https://github.com/nodejs/node/pull/26921
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26921#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 14, 2021https://github.com/nodejs/node/pull/26921#event-4205690067
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26921
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/26921/files/13cfbdda74d3e85f61a3cfe833db492b52d4b1f4
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/26921
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/sam-github
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.