René's URL Explorer Experiment


Title: console: use consolePropAttributes for k-bind properties in constructor by BeniCheni · Pull Request #26850 · nodejs/node · GitHub

Open Graph Title: console: use consolePropAttributes for k-bind properties in constructor by BeniCheni · Pull Request #26850 · nodejs/node

X Title: console: use consolePropAttributes for k-bind properties in constructor by BeniCheni · Pull Request #26850 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: After checking out the TODO comment in lib/internal/console/constructor.js, this PR follows the suggestion to use consolePropAttributes when defining these k-bind properties in the this object. ...

X Description: After checking out the TODO comment in lib/internal/console/constructor.js, this PR follows the suggestion to use consolePropAttributes when defining these k-bind properties in the this object. ...

Opengraph URL: https://github.com/nodejs/node/pull/26850

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb021646-6e2c-b11e-224e-64787e5fe5ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA460:1846F5:AD0A75:B0D593:6A4DB5CF
html-safe-nonce2d9ed525fa0c667a6c8dd7fa2b80ea13a08e95906a5311f90a623987efc90365
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDYwOjE4NDZGNTpBRDBBNzU6QjBENTkzOjZBNERCNUNGIiwidmlzaXRvcl9pZCI6IjY1NDE0OTAxOTAwOTQ4MDg1MjciLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmacfb5a884d5c31da0058a3d21919589d8bfa75323df6c2007631402adf0979b538
hovercard-subject-tagpull_request:263482541
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26850/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e9999c003d9f0ce746bdb7fe6c5cb8d3f9ddf712be1c3fc14e341b6009f8a1b/nodejs/node/pull/26850
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e9999c003d9f0ce746bdb7fe6c5cb8d3f9ddf712be1c3fc14e341b6009f8a1b/nodejs/node/pull/26850
og:image:altAfter checking out the TODO comment in lib/internal/console/constructor.js, this PR follows the suggestion to use consolePropAttributes when defining these k-bind properties in the this object. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBeniCheni
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32f7b614aca06e6bbd89842b1370df1328264f68
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26850#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26850
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26850
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26850
Reloadhttps://github.com/nodejs/node/pull/26850
Reloadhttps://github.com/nodejs/node/pull/26850
Please reload this pagehttps://github.com/nodejs/node/pull/26850
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26850
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BeniChenihttps://github.com/BeniCheni
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/26850
Commits1 (1)https://github.com/nodejs/node/pull/26850/commits
Checkshttps://github.com/nodejs/node/pull/26850/checks
Files changedhttps://github.com/nodejs/node/pull/26850/files
console: use consolePropAttributes for k-bind properties in constructorhttps://github.com/nodejs/node/pull/26850#top
BeniChenihttps://github.com/BeniCheni
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/BeniCheni
BeniChenihttps://github.com/BeniCheni
Mar 22, 2019https://github.com/nodejs/node/pull/26850#issue-424042062
node/lib/internal/console/constructor.jshttps://github.com/nodejs/node/blob/db40b4ab32cca3805975a63288e9995674ebc0a5/lib/internal/console/constructor.js#L184-L189
db40b4ahttps://github.com/nodejs/node/commit/db40b4ab32cca3805975a63288e9995674ebc0a5
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/BeniCheni
console: use consolePropAttributes for k-bind properties in constructorhttps://github.com/nodejs/node/pull/26850/commits/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
e876a16https://github.com/nodejs/node/pull/26850/commits/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
console https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconsole
Mar 22, 2019https://github.com/nodejs/node/pull/26850#event-2221634805
https://github.com/mihalskiy
mihalskiyhttps://github.com/mihalskiy
Mar 22, 2019 https://github.com/nodejs/node/pull/26850#pullrequestreview-217809419
View reviewed changes https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 23, 2019 https://github.com/nodejs/node/pull/26850#pullrequestreview-218024791
View reviewed changes https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 23, 2019 https://github.com/nodejs/node/pull/26850#pullrequestreview-218028022
View reviewed changes https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 23, 2019https://github.com/nodejs/node/pull/26850#issuecomment-475842835
https://ci.nodejs.org/job/node-test-pull-request/21826/https://ci.nodejs.org/job/node-test-pull-request/21826/
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 25, 2019 https://github.com/nodejs/node/pull/26850#pullrequestreview-218423525
View reviewed changes https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 25, 2019https://github.com/nodejs/node/pull/26850#event-2227037368
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 27, 2019https://github.com/nodejs/node/pull/26850#issuecomment-476980061
ed5e69dhttps://github.com/nodejs/node/commit/ed5e69d7e6eaf5e887ff48aa3fe941d394c44846
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 27, 2019https://github.com/nodejs/node/pull/26850#event-2231940499
danbevhttps://github.com/danbev
Mar 27, 2019 https://github.com/nodejs/node/pull/26850#ref-commit-ed5e69d
https://github.com/BeniCheni
https://github.com/danbev
console: use consolePropAttributes for k-bind properties in constructorhttps://github.com/nodejs/node/commit/ed5e69d7e6eaf5e887ff48aa3fe941d394c44846
ed5e69dhttps://github.com/nodejs/node/commit/ed5e69d7e6eaf5e887ff48aa3fe941d394c44846
#26850https://github.com/nodejs/node/pull/26850
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 27, 2019https://github.com/nodejs/node/pull/26850#issuecomment-477089697
travis CIhttps://travis-ci.com/nodejs/node/jobs/188063751
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 27, 2019https://github.com/nodejs/node/pull/26850#issuecomment-477111168
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 27, 2019 https://github.com/nodejs/node/pull/26850#ref-pullrequest-425916540
Revert "console: use consolePropAttributes for k-bind properties in c… #26943 https://github.com/nodejs/node/pull/26943
danbevhttps://github.com/danbev
Mar 27, 2019 https://github.com/nodejs/node/pull/26850#ref-commit-a8eac78
https://github.com/danbev
Revert "console: use consolePropAttributes for k-bind properties in c…https://github.com/nodejs/node/commit/a8eac78f8dbe778a2aef69d0989416e47c6c403e
a8eac78https://github.com/nodejs/node/commit/a8eac78f8dbe778a2aef69d0989416e47c6c403e
ed5e69dhttps://github.com/nodejs/node/commit/ed5e69d7e6eaf5e887ff48aa3fe941d394c44846
#26943https://github.com/nodejs/node/pull/26943
#26850 (comment)https://github.com/nodejs/node/pull/26850#issuecomment-477089697
https://github.com/BeniCheni
BeniChenihttps://github.com/BeniCheni
March 27, 2019 14:23https://github.com/nodejs/node/pull/26850#event-2233287961
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Mar 27, 2019https://github.com/nodejs/node/pull/26850#event-2234149633
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
BridgeARhttps://github.com/BridgeAR
Apr 29, 2019 https://github.com/nodejs/node/pull/26850#ref-commit-6bfde6a
https://github.com/BridgeAR
console: use consolePropAttributes for k-bind properties (reland)https://github.com/BridgeAR/node/commit/6bfde6a81d81e1a78aee5f14e9cd5ee2b3e0cf13
6bfde6ahttps://github.com/BridgeAR/node/commit/6bfde6a81d81e1a78aee5f14e9cd5ee2b3e0cf13
nodejs#26850https://github.com/nodejs/node/pull/26850
nodejs#27352https://github.com/nodejs/node/pull/27352
nodejs#26943https://github.com/nodejs/node/pull/26943
nodejs#26850https://github.com/nodejs/node/pull/26850
targoshttps://github.com/targos
Apr 30, 2019 https://github.com/nodejs/node/pull/26850#ref-commit-8e876e6
https://github.com/BridgeAR
https://github.com/targos
console: use consolePropAttributes for k-bind properties (reland)https://github.com/nodejs/node/commit/8e876e60aa2bd510a0c93674c2789e5bac61db03
8e876e6https://github.com/nodejs/node/commit/8e876e60aa2bd510a0c93674c2789e5bac61db03
#26850https://github.com/nodejs/node/pull/26850
#27352https://github.com/nodejs/node/pull/27352
#26943https://github.com/nodejs/node/pull/26943
#26850https://github.com/nodejs/node/pull/26850
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26850
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
https://github.com/mihalskiy
mihalskiy https://github.com/mihalskiy
https://github.com/nodejs/node/pull/26850/files/e876a16f7060da4b1193ed354b7ef15f7db9a7e5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
console https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconsole
Please reload this pagehttps://github.com/nodejs/node/pull/26850
https://github.com/BeniCheni
https://github.com/ZYSzys
https://github.com/danbev
https://github.com/joyeecheung
https://github.com/BridgeAR
https://github.com/mihalskiy
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.