| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c538d037-8314-a764-2dc8-3d9e3285ec63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E2B8:B5089:D3BEBD:1278BA3:6A4E8736 |
| html-safe-nonce | 38c85ecf8fa8a586d86841381a890d4d28ea41c98ad20a0360b0f39bea491dcb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkI4OkI1MDg5OkQzQkVCRDoxMjc4QkEzOjZBNEU4NzM2IiwidmlzaXRvcl9pZCI6IjI5NDg0OTE5NzUyOTA5NDczODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 00e9226a9e98b9e3742f94d54429b530414ea84ac5fca3e352c676ac98636164 |
| hovercard-subject-tag | pull_request:262860408 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26815/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/915e1d262d0cb1e6dd9caa1ae33e5d1b5ff2cdb4a5555c5be176c0d17b1a2c51/nodejs/node/pull/26815 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/915e1d262d0cb1e6dd9caa1ae33e5d1b5ff2cdb4a5555c5be176c0d17b1a2c51/nodejs/node/pull/26815 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26815#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26815 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26815 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26815 |
| Reload | https://github.com/nodejs/node/pull/26815 |
| Reload | https://github.com/nodejs/node/pull/26815 |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:small-misc-19-03-20 | https://github.com/gengjiawen/node/tree/small-misc-19-03-20 |
| Conversation | https://github.com/nodejs/node/pull/26815 |
| Commits6 (6) | https://github.com/nodejs/node/pull/26815/commits |
| Checks | https://github.com/nodejs/node/pull/26815/checks |
| Files changed | https://github.com/nodejs/node/pull/26815/files |
| small misc change in src folder 19-03-20 | https://github.com/nodejs/node/pull/26815#top |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:small-misc-19-03-20 | https://github.com/gengjiawen/node/tree/small-misc-19-03-20 |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Mar 20, 2019 | https://github.com/nodejs/node/pull/26815#issue-423246118 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| gengjiawen | https://github.com/gengjiawen |
| March 20, 2019 21:15 | https://github.com/nodejs/node/pull/26815#commits-pushed-257be5a |
|
| https://github.com/gengjiawen |
| src: delete unreachable code in heap_utils.cc | https://github.com/nodejs/node/pull/26815/commits/257be5a3f559dd97a6864ef6f092a324f2feaf9e |
| 257be5a | https://github.com/nodejs/node/pull/26815/commits/257be5a3f559dd97a6864ef6f092a324f2feaf9e |
|
| https://github.com/gengjiawen |
| src: tidy up include headers in env.cc | https://github.com/nodejs/node/pull/26815/commits/431363c79d8123093300db0f71d86fba6f3ab8f1 |
| 431363c | https://github.com/nodejs/node/pull/26815/commits/431363c79d8123093300db0f71d86fba6f3ab8f1 |
|
| https://github.com/gengjiawen |
| src: delete unused field in class ModuleWrap | https://github.com/nodejs/node/pull/26815/commits/555cfe2f4528592310ca2b80e4fc06f34a863730 |
| 555cfe2 | https://github.com/nodejs/node/pull/26815/commits/555cfe2f4528592310ca2b80e4fc06f34a863730 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Mar 20, 2019 | https://github.com/nodejs/node/pull/26815#event-2216770484 |
| gengjiawen | https://github.com/gengjiawen |
| March 20, 2019 21:21 | https://github.com/nodejs/node/pull/26815#commits-pushed-9d724fd |
|
| https://github.com/gengjiawen |
| src: use deleted function for class BaseObject | https://github.com/nodejs/node/pull/26815/commits/9d724fd842865f23e3268d625b5b4d1ff1705f90 |
| 9d724fd | https://github.com/nodejs/node/pull/26815/commits/9d724fd842865f23e3268d625b5b4d1ff1705f90 |
|
| https://github.com/gengjiawen |
| src: fix task release in cares_wrap.cc | https://github.com/nodejs/node/pull/26815/commits/ba40403bd85410a9860b834bad3adac2e1f0aee4 |
| ba40403 | https://github.com/nodejs/node/pull/26815/commits/ba40403bd85410a9860b834bad3adac2e1f0aee4 |
|
| https://github.com/gengjiawen |
| src: delete useless code in cares_wrap.cc | https://github.com/nodejs/node/pull/26815/commits/3a885a8c9e07923647527022470cef8299f0f60c |
| 3a885a8 | https://github.com/nodejs/node/pull/26815/commits/3a885a8c9e07923647527022470cef8299f0f60c |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Mar 21, 2019
| https://github.com/nodejs/node/pull/26815#ref-pullrequest-423236353 |
|
src: apply clang-tidy performance-faster-string-find
#26812
| https://github.com/nodejs/node/pull/26812 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Mar 21, 2019
| https://github.com/nodejs/node/pull/26815#pullrequestreview-217248846 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26815/files/3a885a8c9e07923647527022470cef8299f0f60c |
| src/cares_wrap.cc | https://github.com/nodejs/node/pull/26815/files/ba40403bd85410a9860b834bad3adac2e1f0aee4..3a885a8c9e07923647527022470cef8299f0f60c#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 21, 2019 | https://github.com/nodejs/node/pull/26815#issuecomment-475239787 |
| https://ci.nodejs.org/job/node-test-pull-request/21728/ | https://ci.nodejs.org/job/node-test-pull-request/21728/ |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 25, 2019 | https://github.com/nodejs/node/pull/26815#event-2227171663 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26815#issuecomment-477449531 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26815#issuecomment-477470131 |
| 1b10f0d | https://github.com/nodejs/node/commit/1b10f0d63c74623e1659e45e5116fccbe413bab0 |
| 9addfef | https://github.com/nodejs/node/commit/9addfefd84593497a4aef47d6ac68087b9a2e9d5 |
| 0601f16 | https://github.com/nodejs/node/commit/0601f16a476febf3d20ffe9b91ffdd99afa45c38 |
| 3440cf6 | https://github.com/nodejs/node/commit/3440cf6a27161921cd88873a4ac7b4103b4aceea |
| 78ae094 | https://github.com/nodejs/node/commit/78ae094ed005e7001713fc6aed857610c9bf56ce |
| 230f1f2 | https://github.com/nodejs/node/commit/230f1f2aa4aa2d5800214c4894d1c13a3f153dd0 |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26815#event-2235299153 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26815#issuecomment-477473020 |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| March 28, 2019 06:58 | https://github.com/nodejs/node/pull/26815#event-2235318863 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-65a1954 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unreachable code in heap_utils.cc | https://github.com/nodejs/node/commit/65a19541d7ae3e16662924278a10dc398a374881 |
| 65a1954 | https://github.com/nodejs/node/commit/65a19541d7ae3e16662924278a10dc398a374881 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-6ee4b76 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: tidy up include headers in env.cc | https://github.com/nodejs/node/commit/6ee4b76199948653eda1f2bea3015d51018195d2 |
| 6ee4b76 | https://github.com/nodejs/node/commit/6ee4b76199948653eda1f2bea3015d51018195d2 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-c282388 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unused field in class ModuleWrap | https://github.com/nodejs/node/commit/c282388a7a313a532c7a9b10f885f5e107edd8cc |
| c282388 | https://github.com/nodejs/node/commit/c282388a7a313a532c7a9b10f885f5e107edd8cc |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-53e46f9 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: use deleted function for class BaseObject | https://github.com/nodejs/node/commit/53e46f9a77fb50698607c48d372edb28fe91b134 |
| 53e46f9 | https://github.com/nodejs/node/commit/53e46f9a77fb50698607c48d372edb28fe91b134 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-3b2c775 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: fix task release in cares_wrap.cc | https://github.com/nodejs/node/commit/3b2c77547884b0e7fd8eadf9969e84e3afd05ac6 |
| 3b2c775 | https://github.com/nodejs/node/commit/3b2c77547884b0e7fd8eadf9969e84e3afd05ac6 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-385c0b0 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete useless code in cares_wrap.cc | https://github.com/nodejs/node/commit/385c0b0d78280f4b0ba0afd349d5f74ef4cc8bf4 |
| 385c0b0 | https://github.com/nodejs/node/commit/385c0b0d78280f4b0ba0afd349d5f74ef4cc8bf4 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-ceb0d32 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unreachable code in heap_utils.cc | https://github.com/nodejs/node/commit/ceb0d3240759ad208745bc2480255a3b40657f3e |
| ceb0d32 | https://github.com/nodejs/node/commit/ceb0d3240759ad208745bc2480255a3b40657f3e |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-a016650 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: tidy up include headers in env.cc | https://github.com/nodejs/node/commit/a016650976c70fdb6609930d78e40529d476e124 |
| a016650 | https://github.com/nodejs/node/commit/a016650976c70fdb6609930d78e40529d476e124 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-b883df0 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unused field in class ModuleWrap | https://github.com/nodejs/node/commit/b883df0eeb145f0e534194310684bc261842e716 |
| b883df0 | https://github.com/nodejs/node/commit/b883df0eeb145f0e534194310684bc261842e716 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-32cc3af |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: use deleted function for class BaseObject | https://github.com/nodejs/node/commit/32cc3af80f080b9d7b0ca496262f86ec5131a6df |
| 32cc3af | https://github.com/nodejs/node/commit/32cc3af80f080b9d7b0ca496262f86ec5131a6df |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-6bf92f1 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: fix task release in cares_wrap.cc | https://github.com/nodejs/node/commit/6bf92f13354be48f701898d9aecf542f00be38da |
| 6bf92f1 | https://github.com/nodejs/node/commit/6bf92f13354be48f701898d9aecf542f00be38da |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 29, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-a271968 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete useless code in cares_wrap.cc | https://github.com/nodejs/node/commit/a271968b1cd89a466560419dacf394f1ca7b3857 |
| a271968 | https://github.com/nodejs/node/commit/a271968b1cd89a466560419dacf394f1ca7b3857 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-c1def07 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unreachable code in heap_utils.cc | https://github.com/nodejs/node/commit/c1def0701eb9e2ddb353e9857a84c257d40ff226 |
| c1def07 | https://github.com/nodejs/node/commit/c1def0701eb9e2ddb353e9857a84c257d40ff226 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-ea7e2c0 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: tidy up include headers in env.cc | https://github.com/nodejs/node/commit/ea7e2c0666d55a32b8f634342805d8fd6d79b4ca |
| ea7e2c0 | https://github.com/nodejs/node/commit/ea7e2c0666d55a32b8f634342805d8fd6d79b4ca |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-c824127 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete unused field in class ModuleWrap | https://github.com/nodejs/node/commit/c82412775641f1b949a4d6e3d2f2a1a3dd9fb0c9 |
| c824127 | https://github.com/nodejs/node/commit/c82412775641f1b949a4d6e3d2f2a1a3dd9fb0c9 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-c969731 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: use deleted function for class BaseObject | https://github.com/nodejs/node/commit/c9697317558691bc30172097048bdf92891729e3 |
| c969731 | https://github.com/nodejs/node/commit/c9697317558691bc30172097048bdf92891729e3 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-6bfb17f |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: fix task release in cares_wrap.cc | https://github.com/nodejs/node/commit/6bfb17f52872826d88141ae6ebe61df009535cda |
| 6bfb17f | https://github.com/nodejs/node/commit/6bfb17f52872826d88141ae6ebe61df009535cda |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-0427354 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: delete useless code in cares_wrap.cc | https://github.com/nodejs/node/commit/0427354a9829ccb87572517fd099101dd1a8bf2d |
| 0427354 | https://github.com/nodejs/node/commit/0427354a9829ccb87572517fd099101dd1a8bf2d |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-e3d3852 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: delete unreachable code in heap_utils.cc | https://github.com/nodejs/node/commit/e3d38526941d79f0b21a376304e744dcd3060c26 |
| e3d3852 | https://github.com/nodejs/node/commit/e3d38526941d79f0b21a376304e744dcd3060c26 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-2c3bca4 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: tidy up include headers in env.cc | https://github.com/nodejs/node/commit/2c3bca45dc6b9d99a918cded42d66dd44d4202ae |
| 2c3bca4 | https://github.com/nodejs/node/commit/2c3bca45dc6b9d99a918cded42d66dd44d4202ae |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-9a0aadc |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: delete unused field in class ModuleWrap | https://github.com/nodejs/node/commit/9a0aadc3a9cf996a4dc25025cc5109aa8bf51ceb |
| 9a0aadc | https://github.com/nodejs/node/commit/9a0aadc3a9cf996a4dc25025cc5109aa8bf51ceb |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-8d16edc |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: use deleted function for class BaseObject | https://github.com/nodejs/node/commit/8d16edc05e3488ae45654133f2645150922bfc53 |
| 8d16edc | https://github.com/nodejs/node/commit/8d16edc05e3488ae45654133f2645150922bfc53 |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-ff8109f |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: fix task release in cares_wrap.cc | https://github.com/nodejs/node/commit/ff8109f8fe80425c0737400eaec6ce6753df2f7d |
| ff8109f | https://github.com/nodejs/node/commit/ff8109f8fe80425c0737400eaec6ce6753df2f7d |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 5, 2019
| https://github.com/nodejs/node/pull/26815#ref-commit-fb37d13 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BethGriggs |
| src: delete useless code in cares_wrap.cc | https://github.com/nodejs/node/commit/fb37d1361516af050a4b497ea71e0265a11106ef |
| fb37d13 | https://github.com/nodejs/node/commit/fb37d1361516af050a4b497ea71e0265a11106ef |
| #26815 | https://github.com/nodejs/node/pull/26815 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 9, 2019
| https://github.com/nodejs/node/pull/26815#ref-pullrequest-431232386 |
|
v11.14.0 proposal
#27163
| https://github.com/nodejs/node/pull/27163 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26815 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/26815/files/3a885a8c9e07923647527022470cef8299f0f60c |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/26815 |
|
| https://github.com/gengjiawen |
|
| https://github.com/refack |
|
| https://github.com/danbev |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |