René's URL Explorer Experiment


Title: tools: remove eslint rule no-let-in-for-declaration by gengjiawen · Pull Request #26715 · nodejs/node · GitHub

Open Graph Title: tools: remove eslint rule no-let-in-for-declaration by gengjiawen · Pull Request #26715 · nodejs/node

X Title: tools: remove eslint rule no-let-in-for-declaration by gengjiawen · Pull Request #26715 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In continue our discussion in #26562 (comment) cc @targos @ZYSzys @Trott @BridgeAR Maybe still add a label don't land on 6.x though the last 6.x release has been drafted. Checklist make -j4 ...

X Description: In continue our discussion in #26562 (comment) cc @targos @ZYSzys @Trott @BridgeAR Maybe still add a label don't land on 6.x though the last 6.x release has been drafted. Checklist make ...

Opengraph URL: https://github.com/nodejs/node/pull/26715

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:12fff36d-6b17-57c8-3ea9-2ef13647b030
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8070:E91FD:A1D1D:CFF41:6990CDA3
html-safe-nonceef8d8287bdd3f406a5e6dbe2f203c287c4c2dafe8fe47384ffc9a278e5c27cb8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDcwOkU5MUZEOkExRDFEOkNGRjQxOjY5OTBDREEzIiwidmlzaXRvcl9pZCI6IjI1NjEyNTA4NTYyMTg0NDcyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4d9c795b887bfe29210febe0823cc205512bc1f5040813873a6f2afab5b12d0a
hovercard-subject-tagpull_request:261842763
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26715/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/461713b6bc14e06d44eba72853aceaaa5f8dc20b603d3cb70de7694ff6ca8452/nodejs/node/pull/26715
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/461713b6bc14e06d44eba72853aceaaa5f8dc20b603d3cb70de7694ff6ca8452/nodejs/node/pull/26715
og:image:altIn continue our discussion in #26562 (comment) cc @targos @ZYSzys @Trott @BridgeAR Maybe still add a label don't land on 6.x though the last 6.x release has been drafted. Checklist make -j4 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegengjiawen
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26715#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26715
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26715
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26715
Reloadhttps://github.com/nodejs/node/pull/26715
Reloadhttps://github.com/nodejs/node/pull/26715
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26715
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:remove_no_let_rulehttps://github.com/gengjiawen/node/tree/remove_no_let_rule
Conversationhttps://github.com/nodejs/node/pull/26715
Commits1 (1)https://github.com/nodejs/node/pull/26715/commits
Checkshttps://github.com/nodejs/node/pull/26715/checks
Files changedhttps://github.com/nodejs/node/pull/26715/files
tools: remove eslint rule no-let-in-for-declarationhttps://github.com/nodejs/node/pull/26715#top
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:remove_no_let_rulehttps://github.com/gengjiawen/node/tree/remove_no_let_rule
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 17, 2019https://github.com/nodejs/node/pull/26715#issue-421922608
#26562 (comment)https://github.com/nodejs/node/pull/26562#discussion_r264024305
@targoshttps://github.com/targos
@ZYSzyshttps://github.com/ZYSzys
@Trotthttps://github.com/Trott
@BridgeARhttps://github.com/BridgeAR
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Mar 17, 2019https://github.com/nodejs/node/pull/26715#event-2208694609
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Mar 17, 2019https://github.com/nodejs/node/pull/26715#event-2208702569
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 17, 2019 https://github.com/nodejs/node/pull/26715#pullrequestreview-215356598
View reviewed changes https://github.com/nodejs/node/pull/26715/files
richardlauhttps://github.com/richardlau
https://github.com/nodejs/node/pull/26715#pullrequestreview-215356598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/.eslintrc.yamlhttps://github.com/nodejs/node/blob/32853c0a136b0616844cdf5c276d2f1eb9a4fc50/lib/.eslintrc.yaml#L20
32853c0https://github.com/nodejs/node/commit/32853c0a136b0616844cdf5c276d2f1eb9a4fc50
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/gengjiawen
tools: remove eslint rule no-let-in-for-declarationhttps://github.com/nodejs/node/pull/26715/commits/8da554202a040df37443540cd4e491858e80b952
8da5542https://github.com/nodejs/node/pull/26715/commits/8da554202a040df37443540cd4e491858e80b952
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
force-pushedhttps://github.com/nodejs/node/compare/51768bcf60d694b271154bf06932740b57029441..8da554202a040df37443540cd4e491858e80b952
51768bchttps://github.com/nodejs/node/commit/51768bcf60d694b271154bf06932740b57029441
8da5542https://github.com/nodejs/node/commit/8da554202a040df37443540cd4e491858e80b952
Compare https://github.com/nodejs/node/compare/51768bcf60d694b271154bf06932740b57029441..8da554202a040df37443540cd4e491858e80b952
March 17, 2019 13:50https://github.com/nodejs/node/pull/26715#event-2208703273
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 17, 2019https://github.com/nodejs/node/pull/26715#issuecomment-473667784
node/lib/.eslintrc.yamlhttps://github.com/nodejs/node/blob/32853c0a136b0616844cdf5c276d2f1eb9a4fc50/lib/.eslintrc.yaml#L20
32853c0https://github.com/nodejs/node/commit/32853c0a136b0616844cdf5c276d2f1eb9a4fc50
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 17, 2019 https://github.com/nodejs/node/pull/26715#pullrequestreview-215356687
View reviewed changes https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 17, 2019https://github.com/nodejs/node/pull/26715#issuecomment-473668148
#26684https://github.com/nodejs/node/pull/26684
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 17, 2019https://github.com/nodejs/node/pull/26715#issuecomment-473668428
#26684https://github.com/nodejs/node/pull/26684
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/targos
targoshttps://github.com/targos
Mar 17, 2019 https://github.com/nodejs/node/pull/26715#pullrequestreview-215358142
View reviewed changes https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 17, 2019 https://github.com/nodejs/node/pull/26715#pullrequestreview-215358815
View reviewed changes https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 19, 2019 https://github.com/nodejs/node/pull/26715#pullrequestreview-215911709
View reviewed changes https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 20, 2019https://github.com/nodejs/node/pull/26715#issuecomment-474682792
https://ci.nodejs.org/job/node-test-pull-request/21682/https://ci.nodejs.org/job/node-test-pull-request/21682/
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 25, 2019https://github.com/nodejs/node/pull/26715#event-2227267578
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2019https://github.com/nodejs/node/pull/26715#issuecomment-476293098
https://ci.nodejs.org/job/node-test-pull-request/21887/https://ci.nodejs.org/job/node-test-pull-request/21887/
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 26, 2019https://github.com/nodejs/node/pull/26715#issuecomment-476490352
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/26715
Trotthttps://github.com/Trott
Mar 26, 2019 https://github.com/nodejs/node/pull/26715#ref-commit-8209cae
https://github.com/gengjiawen
https://github.com/Trott
tools: remove eslint rule no-let-in-for-declarationhttps://github.com/Trott/io.js/commit/8209caec3955c029c47d32f0babef627500f3c65
8209caehttps://github.com/Trott/io.js/commit/8209caec3955c029c47d32f0babef627500f3c65
nodejs#26715https://github.com/nodejs/node/pull/26715
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 26, 2019https://github.com/nodejs/node/pull/26715#issuecomment-476741123
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 26, 2019https://github.com/nodejs/node/pull/26715#event-2230457161
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26715#ref-commit-57b872b
https://github.com/gengjiawen
https://github.com/targos
tools: remove eslint rule no-let-in-for-declarationhttps://github.com/targos/node/commit/57b872b2cbb280c4c4c85bff96574d7a3ebb4246
57b872bhttps://github.com/targos/node/commit/57b872b2cbb280c4c4c85bff96574d7a3ebb4246
nodejs#26715https://github.com/nodejs/node/pull/26715
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26715#ref-commit-d80cd50
https://github.com/gengjiawen
https://github.com/targos
tools: remove eslint rule no-let-in-for-declarationhttps://github.com/nodejs/node/commit/d80cd50dbcccb718f5d81fb4bbab21a1e253977b
d80cd50https://github.com/nodejs/node/commit/d80cd50dbcccb718f5d81fb4bbab21a1e253977b
#26715https://github.com/nodejs/node/pull/26715
https://github.com/targos
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26715#ref-pullrequest-426198676
v11.13.0 release proposal #26949 https://github.com/nodejs/node/pull/26949
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26715
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/26715/files/8da554202a040df37443540cd4e491858e80b952
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/26715
https://github.com/gengjiawen
https://github.com/richardlau
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/targos
https://github.com/BridgeAR
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.