| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0e4ed619-7039-ddf8-8424-75eaa1910d49 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 806C:381A8:2BF92:3B5F3:6A4EA87E |
| html-safe-nonce | b9318d0c0c7c7be0f61da9065beb83b7d632c1d3092a4f6794118f38826700c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDZDOjM4MUE4OjJCRjkyOjNCNUYzOjZBNEVBODdFIiwidmlzaXRvcl9pZCI6IjgzODQyNDc3NTk1NzQ1NzUyMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4b1491a2bcb081719bc2fe844699134cc4de1ea61e141f27b981261304b0b809 |
| hovercard-subject-tag | pull_request:261005422 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26650/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b451adb492a1056ca76b63163d6e861c670d38c9feec72acbaf98e8a5320e299/nodejs/node/pull/26650 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b451adb492a1056ca76b63163d6e861c670d38c9feec72acbaf98e8a5320e299/nodejs/node/pull/26650 |
| og:image:alt | PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Checklist
make -j4 test (... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26650#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26650 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26650 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26650 |
| Reload | https://github.com/nodejs/node/pull/26650 |
| Reload | https://github.com/nodejs/node/pull/26650 |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| refack:backport-26548-to-v11.x | https://github.com/refack/node/tree/backport-26548-to-v11.x |
| Conversation | https://github.com/nodejs/node/pull/26650 |
| Commits91 (91) | https://github.com/nodejs/node/pull/26650/commits |
| Checks | https://github.com/nodejs/node/pull/26650/checks |
| Files changed | https://github.com/nodejs/node/pull/26650/files |
| [v11.x backport] http: reduce usage of public util | https://github.com/nodejs/node/pull/26650#top |
| refack | https://github.com/refack |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| refack:backport-26548-to-v11.x | https://github.com/refack/node/tree/backport-26548-to-v11.x |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#issue-420805913 |
| #26548 | https://github.com/nodejs/node/pull/26548 |
| #26546 | https://github.com/nodejs/node/issues/26546 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| mcollina | https://github.com/mcollina |
| March 12, 2019 21:04 | https://github.com/nodejs/node/pull/26650#commits-pushed-4796c7c |
|
| https://github.com/mcollina |
|
| https://github.com/BridgeAR |
| stream: make sure 'readable' is emitted before ending the stream | https://github.com/nodejs/node/pull/26650/commits/4796c7ca7e9ecf7e0c442be845688500934af622 |
| 4796c7c | https://github.com/nodejs/node/pull/26650/commits/4796c7ca7e9ecf7e0c442be845688500934af622 |
| nodejs#25810 | https://github.com/nodejs/node/issues/25810 |
| nodejs#26059 | https://github.com/nodejs/node/pull/26059 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: remove unused variable in node_http2.cc | https://github.com/nodejs/node/pull/26650/commits/0c4e019fde2b18d37a930f1cd8f85c2c9ed16c7b |
| 0c4e019 | https://github.com/nodejs/node/pull/26650/commits/0c4e019fde2b18d37a930f1cd8f85c2c9ed16c7b |
| nodejs#26395 | https://github.com/nodejs/node/pull/26395 |
|
| https://github.com/mcollina |
|
| https://github.com/BridgeAR |
| http: check for existance in resetHeadersTimeoutOnReqEnd | https://github.com/nodejs/node/pull/26650/commits/93ef1e320391a306eff1c6ce9dd3578637b33931 |
| 93ef1e3 | https://github.com/nodejs/node/pull/26650/commits/93ef1e320391a306eff1c6ce9dd3578637b33931 |
| nodejs#26366 | https://github.com/nodejs/node/issues/26366 |
| nodejs#26402 | https://github.com/nodejs/node/pull/26402 |
|
| https://github.com/nitsakh |
|
| https://github.com/BridgeAR |
| src: fix build when NODE_USE_V8_PLATFORM is not defined | https://github.com/nodejs/node/pull/26650/commits/44ef6b06f2cc8bf876d7674d443258aac0645000 |
| 44ef6b0 | https://github.com/nodejs/node/pull/26650/commits/44ef6b06f2cc8bf876d7674d443258aac0645000 |
| nodejs#26380 | https://github.com/nodejs/node/pull/26380 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BridgeAR |
| doc: fix the example implementation of MemoryRetainer | https://github.com/nodejs/node/pull/26650/commits/f74d5c8a3dc9cf42a1389e6e7723f06fa8148a8c |
| f74d5c8 | https://github.com/nodejs/node/pull/26650/commits/f74d5c8a3dc9cf42a1389e6e7723f06fa8148a8c |
| https://github.com/nodejs/node/pull/26161/files#r259170771 | https://github.com/nodejs/node/pull/26161/files#r259170771 |
| nodejs#26262 | https://github.com/nodejs/node/pull/26262 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| doc: edit deprecation section of Collaborator Guide | https://github.com/nodejs/node/pull/26650/commits/fc6023a118c90478cf4987ac62567c9a06366a23 |
| fc6023a | https://github.com/nodejs/node/pull/26650/commits/fc6023a118c90478cf4987ac62567c9a06366a23 |
| nodejs#26419 | https://github.com/nodejs/node/pull/26419 |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
| test: relax timer check in test-report-uv-handles.js | https://github.com/nodejs/node/pull/26650/commits/3570c7744d589176515fabae4b84c6f325b6f5ae |
| 3570c77 | https://github.com/nodejs/node/pull/26650/commits/3570c7744d589176515fabae4b84c6f325b6f5ae |
| nodejs#26434 | https://github.com/nodejs/node/pull/26434 |
|
| https://github.com/BeniCheni |
|
| https://github.com/BridgeAR |
| lib: migrate process.binding to internalBinding | https://github.com/nodejs/node/pull/26650/commits/ff1958d5fdb66309ba63ca593cae1d42b024594e |
| ff1958d | https://github.com/nodejs/node/pull/26650/commits/ff1958d5fdb66309ba63ca593cae1d42b024594e |
| nodejs#24952 | https://github.com/nodejs/node/pull/24952 |
| nodejs#22160 | https://github.com/nodejs/node/issues/22160 |
|
| https://github.com/paroga |
|
| https://github.com/BridgeAR |
| crypto: add KeyObject.asymmetricKeySize | https://github.com/nodejs/node/pull/26650/commits/09c83d8cbddf87efcb68c034962788422383cca1 |
| 09c83d8 | https://github.com/nodejs/node/pull/26650/commits/09c83d8cbddf87efcb68c034962788422383cca1 |
| nodejs#26387 | https://github.com/nodejs/node/pull/26387 |
| nodejs#24234 | https://github.com/nodejs/node/pull/24234 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BridgeAR |
| src: use the config binding to carry --no-browser-globals | https://github.com/nodejs/node/pull/26650/commits/3e6b95e5b7304cb036ea0ccd0857e101c609ae3e |
| 3e6b95e | https://github.com/nodejs/node/pull/26650/commits/3e6b95e5b7304cb036ea0ccd0857e101c609ae3e |
| nodejs#26228 | https://github.com/nodejs/node/pull/26228 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: fix wrong enum reference in node.cc | https://github.com/nodejs/node/pull/26650/commits/b435913911c46d8ade61d9c77d283c90ddbb8dc1 |
| b435913 | https://github.com/nodejs/node/pull/26650/commits/b435913911c46d8ade61d9c77d283c90ddbb8dc1 |
| nodejs#26430 | https://github.com/nodejs/node/pull/26430 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: remove unused function in cares_wrap.cc | https://github.com/nodejs/node/pull/26650/commits/21ca93959a7bde8ae0e0492942bf124decac49f7 |
| 21ca939 | https://github.com/nodejs/node/pull/26650/commits/21ca93959a7bde8ae0e0492942bf124decac49f7 |
| nodejs#26429 | https://github.com/nodejs/node/pull/26429 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: remove redundant cast in string_search.h | https://github.com/nodejs/node/pull/26650/commits/4ff5cfa28a4543c1aff492955b98180030614148 |
| 4ff5cfa | https://github.com/nodejs/node/pull/26650/commits/4ff5cfa28a4543c1aff492955b98180030614148 |
| nodejs#26426 | https://github.com/nodejs/node/pull/26426 |
|
| https://github.com/BridgeAR |
| tools: replace var to let/const | https://github.com/nodejs/node/pull/26650/commits/b3ecaaa6822c3d7a032fdc0203d477f5487a2133 |
| b3ecaaa | https://github.com/nodejs/node/pull/26650/commits/b3ecaaa6822c3d7a032fdc0203d477f5487a2133 |
| nodejs#26398 | https://github.com/nodejs/node/pull/26398 |
|
| https://github.com/BridgeAR |
| tools: add no-var lint rule for tools directory | https://github.com/nodejs/node/pull/26650/commits/a8331fa4e2382ed1f53a4c9cca43f8e11724ae48 |
| a8331fa | https://github.com/nodejs/node/pull/26650/commits/a8331fa4e2382ed1f53a4c9cca43f8e11724ae48 |
| nodejs#26398 | https://github.com/nodejs/node/pull/26398 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| build,win: simplify new msbuild_arg option | https://github.com/nodejs/node/pull/26650/commits/3dd7084ff928a6312c70bf4eea4b1724c44f599b |
| 3dd7084 | https://github.com/nodejs/node/pull/26650/commits/3dd7084ff928a6312c70bf4eea4b1724c44f599b |
| nodejs#26431 | https://github.com/nodejs/node/pull/26431 |
| nodejs#25994 | https://github.com/nodejs/node/pull/25994 |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
| build: indicate that configure has done something | https://github.com/nodejs/node/pull/26650/commits/1351f6ea0f5b7cb898c593c91093024670e647de |
| 1351f6e | https://github.com/nodejs/node/pull/26650/commits/1351f6ea0f5b7cb898c593c91093024670e647de |
| nodejs#23111 | https://github.com/nodejs/node/issues/23111 |
| nodejs#26436 | https://github.com/nodejs/node/pull/26436 |
| nodejs#23111 | https://github.com/nodejs/node/issues/23111 |
|
| https://github.com/BridgeAR |
| buffer: do not affect memory after target for utf16 write | https://github.com/nodejs/node/pull/26650/commits/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea |
| 7d8edec | https://github.com/nodejs/node/pull/26650/commits/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| nodejs#26432 | https://github.com/nodejs/node/pull/26432 |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
|
| https://github.com/nicolas-moteau |
|
| https://github.com/BridgeAR |
| doc: add missing https Agent maxCachedSessions | https://github.com/nodejs/node/pull/26650/commits/4b1c1dc372bc81ae400b72738fa88557c3527224 |
| 4b1c1dc | https://github.com/nodejs/node/pull/26650/commits/4b1c1dc372bc81ae400b72738fa88557c3527224 |
| nodejs#26433 | https://github.com/nodejs/node/pull/26433 |
| nodejs#2228 | https://github.com/nodejs/node/pull/2228 |
| nodejs#4252 | https://github.com/nodejs/node/pull/4252 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| doc: standardize on End-of-Life capitalization | https://github.com/nodejs/node/pull/26650/commits/bd7e2436640bd1ca980dc9a03723a0f061146750 |
| bd7e243 | https://github.com/nodejs/node/pull/26650/commits/bd7e2436640bd1ca980dc9a03723a0f061146750 |
| nodejs#26442 | https://github.com/nodejs/node/pull/26442 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| tools: update remark-preset-lint-node to 1.5.0 | https://github.com/nodejs/node/pull/26650/commits/aa80137e59ee13b1fbc4209a079602bb20c00ce3 |
| aa80137 | https://github.com/nodejs/node/pull/26650/commits/aa80137e59ee13b1fbc4209a079602bb20c00ce3 |
| nodejs#26442 | https://github.com/nodejs/node/pull/26442 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: remove redundant call in inspector_io.cc | https://github.com/nodejs/node/pull/26650/commits/2d7b62902fa01c626f715064f0674e1edcd80059 |
| 2d7b629 | https://github.com/nodejs/node/pull/26650/commits/2d7b62902fa01c626f715064f0674e1edcd80059 |
| nodejs#26427 | https://github.com/nodejs/node/pull/26427 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| src: make parameter name const reference in method TriggerNodeReport | https://github.com/nodejs/node/pull/26650/commits/539a9c0539aa476ed917be4a2ae9c99b93cd0bf6 |
| 539a9c0 | https://github.com/nodejs/node/pull/26650/commits/539a9c0539aa476ed917be4a2ae9c99b93cd0bf6 |
| nodejs#26397 | https://github.com/nodejs/node/pull/26397 |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
| http: remove unused variable in _http_server.js | https://github.com/nodejs/node/pull/26650/commits/5d2c522b2e093d238db095d34289d1f0771ea829 |
| 5d2c522 | https://github.com/nodejs/node/pull/26650/commits/5d2c522b2e093d238db095d34289d1f0771ea829 |
| nodejs#26407 | https://github.com/nodejs/node/pull/26407 |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
| test: fix tests so they work in worker threads | https://github.com/nodejs/node/pull/26650/commits/24b9ae126a33f36c1e1aaf0bcca1bedf90a46c7b |
| 24b9ae1 | https://github.com/nodejs/node/pull/26650/commits/24b9ae126a33f36c1e1aaf0bcca1bedf90a46c7b |
| nodejs#26453 | https://github.com/nodejs/node/pull/26453 |
|
| https://github.com/koh110 |
|
| https://github.com/BridgeAR |
| child_process: fire close event from stdio | https://github.com/nodejs/node/pull/26650/commits/8e94cb2c9c696e8b5df5a6d76b45c68c9cb16f34 |
| 8e94cb2 | https://github.com/nodejs/node/pull/26650/commits/8e94cb2c9c696e8b5df5a6d76b45c68c9cb16f34 |
| nodejs#22892 | https://github.com/nodejs/node/pull/22892 |
|
| https://github.com/BridgeAR |
| test: remove usage of process.binding() | https://github.com/nodejs/node/pull/26650/commits/8c087d2f54ffb243e25a3face8558f1ded9c0b02 |
| 8c087d2 | https://github.com/nodejs/node/pull/26650/commits/8c087d2f54ffb243e25a3face8558f1ded9c0b02 |
| nodejs#26304 | https://github.com/nodejs/node/pull/26304 |
|
| https://github.com/tniessen |
|
| https://github.com/BridgeAR |
| crypto: simplify GetPublicOrPrivateKeyFromJs | https://github.com/nodejs/node/pull/26650/commits/ab1327f91426af893fc9de51c6f88ac2da8b5d97 |
| ab1327f | https://github.com/nodejs/node/pull/26650/commits/ab1327f91426af893fc9de51c6f88ac2da8b5d97 |
| nodejs#26454 | https://github.com/nodejs/node/pull/26454 |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
| test: refactor test/report/test-report-signal.js | https://github.com/nodejs/node/pull/26650/commits/d1c225f9c5cd0afaf798dadd9a5e5c3840e352dd |
| d1c225f | https://github.com/nodejs/node/pull/26650/commits/d1c225f9c5cd0afaf798dadd9a5e5c3840e352dd |
| nodejs#26446 | https://github.com/nodejs/node/pull/26446 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| Revert "build: silence cpp lint by default" | https://github.com/nodejs/node/pull/26650/commits/8c90fe12c402b78c3d660dd8b629847e33411ce4 |
| 8c90fe1 | https://github.com/nodejs/node/pull/26650/commits/8c90fe12c402b78c3d660dd8b629847e33411ce4 |
| 0373836 | https://github.com/refack/node/commit/0373836b390999644d116c96b41ba05a8a0f181a |
| nodejs#26358 | https://github.com/nodejs/node/pull/26358 |
| danbev | https://github.com/danbev |
| March 13, 2019 19:13 | https://github.com/nodejs/node/pull/26650#commits-pushed-b592c2f |
|
| https://github.com/danbev |
|
| https://github.com/BridgeAR |
| test: fix compiler warning in test_string.c | https://github.com/nodejs/node/pull/26650/commits/b592c2ff1552c305fb4e0e2b752eff985842f497 |
| b592c2f | https://github.com/nodejs/node/pull/26650/commits/b592c2ff1552c305fb4e0e2b752eff985842f497 |
| nodejs#26539 | https://github.com/nodejs/node/pull/26539 |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
| src: remove unused variables | https://github.com/nodejs/node/pull/26650/commits/0ed2a017b9a7ef9c7252ac577beafbac1f42686a |
| 0ed2a01 | https://github.com/nodejs/node/pull/26650/commits/0ed2a017b9a7ef9c7252ac577beafbac1f42686a |
| nodejs#26590 | https://github.com/nodejs/node/pull/26590 |
|
| https://github.com/BridgeAR |
| worker: release native Worker object earlier | https://github.com/nodejs/node/pull/26650/commits/8cb7d4b3967eb1db5f2f886094df65b1a1dd54ac |
| 8cb7d4b | https://github.com/nodejs/node/pull/26650/commits/8cb7d4b3967eb1db5f2f886094df65b1a1dd54ac |
| nodejs#26542 | https://github.com/nodejs/node/pull/26542 |
| nodejs#26535 | https://github.com/nodejs/node/issues/26535 |
|
| https://github.com/ZYSzys |
|
| https://github.com/BridgeAR |
| url: require encodeStr from internal/querystring | https://github.com/nodejs/node/pull/26650/commits/f2ebf36359ffb51bb7a54e1f004f86e6fac681bd |
| f2ebf36 | https://github.com/nodejs/node/pull/26650/commits/f2ebf36359ffb51bb7a54e1f004f86e6fac681bd |
| nodejs#26538 | https://github.com/nodejs/node/pull/26538 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BridgeAR |
| lib: import TextEncoder and TextDecoder from internal/encoding | https://github.com/nodejs/node/pull/26650/commits/c43e5b3f190a81bb8753f9822dcbf1a623701da1 |
| c43e5b3 | https://github.com/nodejs/node/pull/26650/commits/c43e5b3f190a81bb8753f9822dcbf1a623701da1 |
| nodejs#26547 | https://github.com/nodejs/node/pull/26547 |
| nodejs#26546 | https://github.com/nodejs/node/issues/26546 |
|
| https://github.com/mscdex |
|
| https://github.com/BridgeAR |
| crypto: fix EdDSA support for KeyObject | https://github.com/nodejs/node/pull/26650/commits/71d0a8a583e074bee59a552f67b5fd65dcb75bbd |
| 71d0a8a | https://github.com/nodejs/node/pull/26650/commits/71d0a8a583e074bee59a552f67b5fd65dcb75bbd |
| nodejs#26319 | https://github.com/nodejs/node/pull/26319 |
| nodejs#26316 | https://github.com/nodejs/node/issues/26316 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| test: fix syntax error in test-dns-idna2008.js when failing | https://github.com/nodejs/node/pull/26650/commits/f03498c6dbbee978cebb3210610a9dd3532a4486 |
| f03498c | https://github.com/nodejs/node/pull/26650/commits/f03498c6dbbee978cebb3210610a9dd3532a4486 |
| 9613221 | https://github.com/refack/node/commit/961322178d69325a46dbcbaea1da818fff12c45a |
| nodejs#26570 | https://github.com/nodejs/node/pull/26570 |
| nodejs#25870 | https://github.com/nodejs/node/issues/25870 |
| nodejs#26473 | https://github.com/nodejs/node/pull/26473 |
|
| https://github.com/BridgeAR |
| process: make Symbol.toStringTag writable | https://github.com/nodejs/node/pull/26650/commits/c6536b4adbde2c6a131d81e6ebba4de9d4e7dd9b |
| c6536b4 | https://github.com/nodejs/node/pull/26650/commits/c6536b4adbde2c6a131d81e6ebba4de9d4e7dd9b |
| nodejs#26488 | https://github.com/nodejs/node/pull/26488 |
|
| https://github.com/ronag |
|
| https://github.com/BridgeAR |
| http2: Http2ServerResponse.end() should always return self | https://github.com/nodejs/node/pull/26650/commits/348d9a6c69010a2a726f3695d5f08e42d37e7ca3 |
| 348d9a6 | https://github.com/nodejs/node/pull/26650/commits/348d9a6c69010a2a726f3695d5f08e42d37e7ca3 |
| nodejs#24346 | https://github.com/nodejs/node/pull/24346 |
|
| https://github.com/BridgeAR |
| test: fix test by removing node-inspect/lib/_inspect | https://github.com/nodejs/node/pull/26650/commits/b581bb0d1039d9cd11cab286217b86d707897640 |
| b581bb0 | https://github.com/nodejs/node/pull/26650/commits/b581bb0d1039d9cd11cab286217b86d707897640 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#issuecomment-472682656 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2901/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2901/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#event-2202139416 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26650#ref-pullrequest-419087683 |
|
http: reduce usage of public util
#26548
| https://github.com/nodejs/node/pull/26548 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#issuecomment-472682808 |
| https://ci.nodejs.org/job/node-test-pull-request/21524/ | https://ci.nodejs.org/job/node-test-pull-request/21524/ |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
|
| https://github.com/ZYSzys |
|
| https://github.com/refack |
| http: reduce usage of public util | https://github.com/nodejs/node/pull/26650/commits/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
| cd77811 | https://github.com/nodejs/node/pull/26650/commits/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
| nodejs#26548 | https://github.com/nodejs/node/pull/26548 |
| nodejs#26546 | https://github.com/nodejs/node/issues/26546 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/d1f1c12a1749fc087be7a535fcdfac705114e34d..cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
| d1f1c12 | https://github.com/nodejs/node/commit/d1f1c12a1749fc087be7a535fcdfac705114e34d |
| cd77811 | https://github.com/nodejs/node/commit/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
|
Compare
| https://github.com/nodejs/node/compare/d1f1c12a1749fc087be7a535fcdfac705114e34d..cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
| March 14, 2019 02:58 | https://github.com/nodejs/node/pull/26650#event-2202158422 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#issuecomment-472686013 |
| #24755 | https://github.com/nodejs/node/pull/24755 |
| @BridgeAR | https://github.com/BridgeAR |
| @mcollina | https://github.com/mcollina |
| @lpinca | https://github.com/lpinca |
| @joyeecheung | https://github.com/joyeecheung |
| #24755 | https://github.com/nodejs/node/pull/24755 |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#issuecomment-472686171 |
| https://ci.nodejs.org/job/node-test-pull-request/21527/ | https://ci.nodejs.org/job/node-test-pull-request/21527/ |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26650#ref-issue-420748941 |
|
Help wanted: Backporting PRs to v11.x-staging
#26645
| https://github.com/nodejs/node/issues/26645 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26650#pullrequestreview-214315366 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26650/files/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
| lib/_http_agent.js | https://github.com/nodejs/node/pull/26650/files/cd77811f8fd9aedf715bef7a41ed5afe6b87439c#diff-82c531677b9ab4e260025e0397fb0ac4d4316459fa5d16346324e39584cfce96 |
| ZYSzys | https://github.com/ZYSzys |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#discussion_r265416512 |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #24755 | https://github.com/nodejs/node/pull/24755 |
| #26468 | https://github.com/nodejs/node/pull/26468 |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| BridgeAR | https://github.com/BridgeAR |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26650#discussion_r265508161 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #26468 | https://github.com/nodejs/node/pull/26468 |
| @ZYSzys | https://github.com/ZYSzys |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/f95e015fe55e5f05bb0ae3eb1adb54a224d50fe7..1fa5004e813d621660a5e0df364efd87bcdacfc0 |
| f95e015 | https://github.com/nodejs/node/commit/f95e015fe55e5f05bb0ae3eb1adb54a224d50fe7 |
| 1fa5004 | https://github.com/nodejs/node/commit/1fa5004e813d621660a5e0df364efd87bcdacfc0 |
|
Compare
| https://github.com/nodejs/node/compare/f95e015fe55e5f05bb0ae3eb1adb54a224d50fe7..1fa5004e813d621660a5e0df364efd87bcdacfc0 |
| March 14, 2019 16:15 | https://github.com/nodejs/node/pull/26650#event-2203981112 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26650#ref-commit-04441b5 |
|
| https://github.com/ZYSzys |
|
| https://github.com/targos |
| http: reduce usage of public util | https://github.com/nodejs/node/commit/04441b506bac9fa43d96378863fa1fcc5d27a2a2 |
| 04441b5 | https://github.com/nodejs/node/commit/04441b506bac9fa43d96378863fa1fcc5d27a2a2 |
| #26650 | https://github.com/nodejs/node/pull/26650 |
| #26548 | https://github.com/nodejs/node/pull/26548 |
| #26546 | https://github.com/nodejs/node/issues/26546 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26650#issuecomment-477755631 |
| 04441b5 | https://github.com/nodejs/node/commit/04441b506bac9fa43d96378863fa1fcc5d27a2a2 |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26650#event-2237493655 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26650#ref-commit-5a29a94 |
|
| https://github.com/ZYSzys |
|
| https://github.com/targos |
| http: reduce usage of public util | https://github.com/nodejs/node/commit/5a29a94f0e167feae0d0e0243c66aa60bb052bdf |
| 5a29a94 | https://github.com/nodejs/node/commit/5a29a94f0e167feae0d0e0243c66aa60bb052bdf |
| #26650 | https://github.com/nodejs/node/pull/26650 |
| #26548 | https://github.com/nodejs/node/pull/26548 |
| #26546 | https://github.com/nodejs/node/issues/26546 |
| https://github.com/refack |
| refack | https://github.com/refack |
| April 14, 2019 21:46 | https://github.com/nodejs/node/pull/26650#event-2275146422 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26650 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/26650/files/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/26650/files/cd77811f8fd9aedf715bef7a41ed5afe6b87439c |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/26650 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/BridgeAR |
|
| https://github.com/ZYSzys |
|
| https://github.com/mcollina |
|
| https://github.com/gengjiawen |
|
| https://github.com/nitsakh |
|
| https://github.com/joyeecheung |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
|
| https://github.com/BeniCheni |
|
| https://github.com/paroga |
|
| https://github.com/addaleax |
|
| https://github.com/nicolas-moteau |
|
| https://github.com/koh110 |
|
| https://github.com/tniessen |
|
| https://github.com/cjihrig |
|
| https://github.com/hashseed |
|
| https://github.com/maclover7 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |