René's URL Explorer Experiment


Title: streams: fix regression introduced in #26059 by mcollina · Pull Request #26643 · nodejs/node · GitHub

Open Graph Title: streams: fix regression introduced in #26059 by mcollina · Pull Request #26643 · nodejs/node

X Title: streams: fix regression introduced in #26059 by mcollina · Pull Request #26643 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the...

X Description: In #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still...

Opengraph URL: https://github.com/nodejs/node/pull/26643

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cb0684fa-3084-e675-b5ec-95723c2f7ca6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8310:1F0B:C7357F:10B364F:6A4EEC01
html-safe-noncefd1e341e67a0872a87c59b0a840e245fe449cf2ed4a84009f0c4620c04746849
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzEwOjFGMEI6QzczNTdGOjEwQjM2NEY6NkE0RUVDMDEiLCJ2aXNpdG9yX2lkIjoiNjczNDMxNDE2ODQ4Mjk4MjkxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccfa4cc37aa72a2a2ddafa1beecdb3cd3bf6ec27c3483c0641756c1d301e2cdd3
hovercard-subject-tagpull_request:260946094
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26643/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/160604ee14265311b931b94d493e7d0444bab99b3f32230d4b05804de4a1930b/nodejs/node/pull/26643
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/160604ee14265311b931b94d493e7d0444bab99b3f32230d4b05804de4a1930b/nodejs/node/pull/26643
og:image:altIn #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Noned12176b31601daf8d3de9a378cbbcf7dac6f33d990d1faedcb9c9b9ff3cbb1ed
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9420180b23897f48b04b8d47ee8b1a9341197b64
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26643#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26643
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26643
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26643
Reloadhttps://github.com/nodejs/node/pull/26643
Reloadhttps://github.com/nodejs/node/pull/26643
Please reload this pagehttps://github.com/nodejs/node/pull/26643
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26643
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fix-dicerhttps://github.com/mcollina/node/tree/fix-dicer
Conversationhttps://github.com/nodejs/node/pull/26643
Commits1 (1)https://github.com/nodejs/node/pull/26643/commits
Checkshttps://github.com/nodejs/node/pull/26643/checks
Files changedhttps://github.com/nodejs/node/pull/26643/files
streams: fix regression introduced in #26059https://github.com/nodejs/node/pull/26643#top
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fix-dicerhttps://github.com/mcollina/node/tree/fix-dicer
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019https://github.com/nodejs/node/pull/26643#issue-420728527
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/mcollina
streams: fix regression introduced inhttps://github.com/nodejs/node/pull/26643/commits/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
nodejs#26059https://github.com/nodejs/node/pull/26059
70c6b7dhttps://github.com/nodejs/node/pull/26643/commits/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
nodejs#26059https://github.com/nodejs/node/pull/26059
nodejs#25810https://github.com/nodejs/node/issues/25810
nodejs#26059https://github.com/nodejs/node/pull/26059
nodejs#25810https://github.com/nodejs/node/issues/25810
https://github.com/mcollina
mcollinahttps://github.com/mcollina
cjihrighttps://github.com/cjihrig
lpincahttps://github.com/lpinca
March 13, 2019 21:30https://github.com/nodejs/node/pull/26643#event-2201678564
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 13, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472613566
@mcollinahttps://github.com/mcollina
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2896/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2896/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Mar 13, 2019https://github.com/nodejs/node/pull/26643#event-2201678659
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019 https://github.com/nodejs/node/pull/26643#ref-pullrequest-420183589
Revert "stream: make sure 'readable' is emitted before ending the stream #26617 https://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472615000
#26617https://github.com/nodejs/node/pull/26617
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472618205
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1762/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1762/
https://ci.nodejs.org/job/node-test-pull-request/21514/https://ci.nodejs.org/job/node-test-pull-request/21514/
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 14, 2019 https://github.com/nodejs/node/pull/26643#pullrequestreview-214335407
View reviewed changes https://github.com/nodejs/node/pull/26643/files/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472814191
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 14, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472815668
#26059https://github.com/nodejs/node/pull/26059
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019https://github.com/nodejs/node/pull/26643#issuecomment-472818384
@mcollinahttps://github.com/mcollina
#26059https://github.com/nodejs/node/pull/26059
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 14, 2019 https://github.com/nodejs/node/pull/26643#pullrequestreview-214520923
View reviewed changes https://github.com/nodejs/node/pull/26643/files/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 16, 2019https://github.com/nodejs/node/pull/26643#issuecomment-473520384
269103ahttps://github.com/nodejs/node/commit/269103a0e5e30cc217bde1660087e87dfc722b8a
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 16, 2019https://github.com/nodejs/node/pull/26643#event-2208115197
https://github.com/mcollina
mcollinahttps://github.com/mcollina
March 16, 2019 10:58https://github.com/nodejs/node/pull/26643#event-2208115220
mcollinahttps://github.com/mcollina
Mar 16, 2019 https://github.com/nodejs/node/pull/26643#ref-commit-269103a
https://github.com/mcollina
stream: fix regression introduced inhttps://github.com/nodejs/node/commit/269103a0e5e30cc217bde1660087e87dfc722b8a
#26059https://github.com/nodejs/node/pull/26059
269103ahttps://github.com/nodejs/node/commit/269103a0e5e30cc217bde1660087e87dfc722b8a
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
#26643https://github.com/nodejs/node/pull/26643
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26643#ref-commit-9fac2c3
https://github.com/mcollina
https://github.com/targos
stream: fix regression introduced inhttps://github.com/targos/node/commit/9fac2c3a8953dca46b4ecc76c7f616e3c5b685be
nodejs#26059https://github.com/nodejs/node/pull/26059
9fac2c3https://github.com/targos/node/commit/9fac2c3a8953dca46b4ecc76c7f616e3c5b685be
nodejs#26059https://github.com/nodejs/node/pull/26059
nodejs#25810https://github.com/nodejs/node/issues/25810
nodejs#26059https://github.com/nodejs/node/pull/26059
nodejs#25810https://github.com/nodejs/node/issues/25810
nodejs#26643https://github.com/nodejs/node/pull/26643
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26643#ref-commit-249bf50
https://github.com/mcollina
https://github.com/targos
stream: fix regression introduced inhttps://github.com/nodejs/node/commit/249bf509a3c2785f1637af721ac38432d3e89ad9
#26059https://github.com/nodejs/node/pull/26059
249bf50https://github.com/nodejs/node/commit/249bf509a3c2785f1637af721ac38432d3e89ad9
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
#26059https://github.com/nodejs/node/pull/26059
#25810https://github.com/nodejs/node/issues/25810
#26643https://github.com/nodejs/node/pull/26643
https://github.com/targos
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26643#ref-pullrequest-426198676
v11.13.0 release proposal #26949 https://github.com/nodejs/node/pull/26949
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 23, 2020 https://github.com/nodejs/node/pull/26643#ref-issue-553727966
Inconsistent behavior with readable stream event "readable" in different versions of Node #31464 https://github.com/nodejs/node/issues/31464
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26643
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/26643/files/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/26643/files/70c6b7dce9166f0eed79e76d540e4a901bfcfeea
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Transform stream misses final readable event for small inputs https://github.com/nodejs/node/issues/25810
Please reload this pagehttps://github.com/nodejs/node/pull/26643
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.