René's URL Explorer Experiment


Title: Revert "stream: make sure 'readable' is emitted before ending the stream by cjihrig · Pull Request #26617 · nodejs/node · GitHub

Open Graph Title: Revert "stream: make sure 'readable' is emitted before ending the stream by cjihrig · Pull Request #26617 · nodejs/node

X Title: Revert "stream: make sure 'readable' is emitted before ending the stream by cjihrig · Pull Request #26617 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit e95e7f9. It was identified as causing breakage for Node 12. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit mess...

X Description: This reverts commit e95e7f9. It was identified as causing breakage for Node 12. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit mess...

Opengraph URL: https://github.com/nodejs/node/pull/26617

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:465f426c-a895-2955-de4b-6aa652f69482
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9104:C8AE2:2C98DD9:3D7EB9D:6A4F0D44
html-safe-nonce9fd6dc4399797624b53b0c5e02afb8ee2477950db14a4636a21594c300e16025
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTA0OkM4QUUyOjJDOThERDk6M0Q3RUI5RDo2QTRGMEQ0NCIsInZpc2l0b3JfaWQiOiI1MzcyMjk2MDE2NDc2MTc5NzgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb4d98fdd07e2d2d46379778b4040d46294861c695d471c6636ad99e5d28a8e3d
hovercard-subject-tagpull_request:260519365
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26617/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67b8152602071d45eac4fd1456c055c443663a8fe53cf68cb11866be950a5d70/nodejs/node/pull/26617
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67b8152602071d45eac4fd1456c055c443663a8fe53cf68cb11866be950a5d70/nodejs/node/pull/26617
og:image:altThis reverts commit e95e7f9. It was identified as causing breakage for Node 12. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit mess...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26617#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26617
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26617
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26617
Reloadhttps://github.com/nodejs/node/pull/26617
Reloadhttps://github.com/nodejs/node/pull/26617
Please reload this pagehttps://github.com/nodejs/node/pull/26617
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26617
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 966 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:reverthttps://github.com/cjihrig/node/tree/revert
Conversationhttps://github.com/nodejs/node/pull/26617
Commits1 (1)https://github.com/nodejs/node/pull/26617/commits
Checkshttps://github.com/nodejs/node/pull/26617/checks
Files changedhttps://github.com/nodejs/node/pull/26617/files
Revert "stream: make sure 'readable' is emitted before ending the streamhttps://github.com/nodejs/node/pull/26617#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:reverthttps://github.com/cjihrig/node/tree/revert
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 12, 2019https://github.com/nodejs/node/pull/26617#issue-420183589
e95e7f9https://github.com/nodejs/node/commit/e95e7f9af540c88e93701ff6ca2f38986deb8e99
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/cjihrig
Revert "stream: make sure 'readable' is emitted before ending the str…https://github.com/nodejs/node/pull/26617/commits/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
7be3f87https://github.com/nodejs/node/pull/26617/commits/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
e95e7f9https://github.com/cjihrig/node/commit/e95e7f9af540c88e93701ff6ca2f38986deb8e99
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 12, 2019https://github.com/nodejs/node/pull/26617#issuecomment-472162135
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2884/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2884/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Mar 12, 2019https://github.com/nodejs/node/pull/26617#event-2198351531
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 12, 2019 https://github.com/nodejs/node/pull/26617#ref-issue-391375675
Ecosystem Modules that will break in Node 12 #25060 https://github.com/nodejs/node/issues/25060
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 12, 2019 https://github.com/nodejs/node/pull/26617#pullrequestreview-213630797
View reviewed changes https://github.com/nodejs/node/pull/26617/files/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 12, 2019https://github.com/nodejs/node/pull/26617#issuecomment-472167138
Please reload this pagehttps://github.com/nodejs/node/pull/26617
#25810https://github.com/nodejs/node/issues/25810
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 12, 2019 https://github.com/nodejs/node/pull/26617#pullrequestreview-213659931
View reviewed changes https://github.com/nodejs/node/pull/26617/files/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/26617#pullrequestreview-213659931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 12, 2019https://github.com/nodejs/node/pull/26617#issuecomment-472188083
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 12, 2019 https://github.com/nodejs/node/pull/26617#ref-issue-404678356
Transform stream misses final readable event for small inputs #25810 https://github.com/nodejs/node/issues/25810
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019https://github.com/nodejs/node/pull/26617#issuecomment-472614890
#26643https://github.com/nodejs/node/pull/26643
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 13, 2019 https://github.com/nodejs/node/pull/26617#ref-pullrequest-420728527
streams: fix regression introduced in #26059 #26643 https://github.com/nodejs/node/pull/26643
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 16, 2019https://github.com/nodejs/node/pull/26617#issuecomment-473520496
269103ahttps://github.com/nodejs/node/commit/269103a0e5e30cc217bde1660087e87dfc722b8a
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 16, 2019https://github.com/nodejs/node/pull/26617#event-2208115766
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
March 16, 2019 16:24https://github.com/nodejs/node/pull/26617#event-2208252991
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26617
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/26617/files/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/26617/files/7be3f87eb941b71e380e51ea17a5c942cf8fe3dd
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/26617
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.