René's URL Explorer Experiment


Title: querystring: simplify stringify method by ZYSzys · Pull Request #26591 · nodejs/node · GitHub

Open Graph Title: querystring: simplify stringify method by ZYSzys · Pull Request #26591 · nodejs/node

X Title: querystring: simplify stringify method by ZYSzys · Pull Request #26591 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since there is no obvious improvement in stringify method, try to simplify stringify method without performance regression. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

X Description: Since there is no obvious improvement in stringify method, try to simplify stringify method without performance regression. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

Opengraph URL: https://github.com/nodejs/node/pull/26591

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f9261f36-720e-d775-53b7-1d825e252994
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF48:141FAF:22D8BE:30DA8B:6A4E678C
html-safe-nonce991f7bef5d5a47d3bca0110ef2ad62c81360b3919950d4cfe8a32943cfcc8e0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjQ4OjE0MUZBRjoyMkQ4QkU6MzBEQThCOjZBNEU2NzhDIiwidmlzaXRvcl9pZCI6Ijg3NTQ2MzI1OTY1ODE2NzI4NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6d997313e37e8a63252130e3e4fdf2b061da9061636f0bb8f4bec799463a9ee8
hovercard-subject-tagpull_request:260044792
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90a56516dfbcd8e5000f8404e4868d3368bf8043e5714e8fd524b90bd215f07b/nodejs/node/pull/26591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90a56516dfbcd8e5000f8404e4868d3368bf8043e5714e8fd524b90bd215f07b/nodejs/node/pull/26591
og:image:altSince there is no obvious improvement in stringify method, try to simplify stringify method without performance regression. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26591#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26591
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26591
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26591
Reloadhttps://github.com/nodejs/node/pull/26591
Reloadhttps://github.com/nodejs/node/pull/26591
Please reload this pagehttps://github.com/nodejs/node/pull/26591
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26591
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/26591
Commits1 (1)https://github.com/nodejs/node/pull/26591/commits
Checkshttps://github.com/nodejs/node/pull/26591/checks
Files changedhttps://github.com/nodejs/node/pull/26591/files
querystring: simplify stringify methodhttps://github.com/nodejs/node/pull/26591#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 11, 2019https://github.com/nodejs/node/pull/26591#issue-419567680
Please reload this pagehttps://github.com/nodejs/node/pull/26591
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
querystring https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring
Mar 11, 2019https://github.com/nodejs/node/pull/26591#event-2194528529
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 11, 2019https://github.com/nodejs/node/pull/26591#issuecomment-471658482
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/303/consolehttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/303/console
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 12, 2019 https://github.com/nodejs/node/pull/26591#pullrequestreview-213168398
View reviewed changes https://github.com/nodejs/node/pull/26591/files
lib/querystring.jshttps://github.com/nodejs/node/pull/26591/files#diff-9d27e6589b63ec9ebc5702898cd7aab37c1bb1d51edf560365e9bdb7d1f19662
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 19, 2019https://github.com/nodejs/node/pull/26591#issuecomment-474272247
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://ci.nodejs.org/job/node-test-pull-request/21657/https://ci.nodejs.org/job/node-test-pull-request/21657/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/305/consolehttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/305/console
@mscdexhttps://github.com/mscdex
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 19, 2019 https://github.com/nodejs/node/pull/26591#pullrequestreview-216055693
View reviewed changes https://github.com/nodejs/node/pull/26591/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/26591#pullrequestreview-216055693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26591
benchmark/querystring/querystring-stringify.jshttps://github.com/nodejs/node/pull/26591/files#diff-0a22e2b2e7bdbcdbd96046e02874537fe78f9b8afc2eaba383a6b9b48074da78
Please reload this pagehttps://github.com/nodejs/node/pull/26591
benchmark/querystring/querystring-stringify.jshttps://github.com/nodejs/node/pull/26591/files#diff-0a22e2b2e7bdbcdbd96046e02874537fe78f9b8afc2eaba383a6b9b48074da78
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 25, 2019 https://github.com/nodejs/node/pull/26591#pullrequestreview-218498439
View reviewed changes https://github.com/nodejs/node/pull/26591/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 25, 2019https://github.com/nodejs/node/pull/26591#event-2227428507
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2019https://github.com/nodejs/node/pull/26591#issuecomment-476314818
https://ci.nodejs.org/job/node-test-pull-request/21892/https://ci.nodejs.org/job/node-test-pull-request/21892/
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/ZYSzys
querystring: simplify stringify methodhttps://github.com/nodejs/node/pull/26591/commits/514c4be9973b0321fcfc8dbc5d4f20a7dd06cb2e
514c4behttps://github.com/nodejs/node/pull/26591/commits/514c4be9973b0321fcfc8dbc5d4f20a7dd06cb2e
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 27, 2019https://github.com/nodejs/node/pull/26591#event-2231795456
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 27, 2019https://github.com/nodejs/node/pull/26591#issuecomment-476955278
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/310/consolehttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/310/console
https://ci.nodejs.org/job/node-test-pull-request/21941/https://ci.nodejs.org/job/node-test-pull-request/21941/
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 27, 2019https://github.com/nodejs/node/pull/26591#issuecomment-476966280
https://ci.nodejs.org/job/node-test-pull-request/21942/https://ci.nodejs.org/job/node-test-pull-request/21942/
Please reload this pagehttps://github.com/nodejs/node/pull/26591
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019 https://github.com/nodejs/node/pull/26591#ref-commit-b965ac2
https://github.com/ZYSzys
https://github.com/BridgeAR
querystring: simplify stringify methodhttps://github.com/BridgeAR/node/commit/b965ac22ca81a449c9e88f066cadcb8abf93f94b
b965ac2https://github.com/BridgeAR/node/commit/b965ac22ca81a449c9e88f066cadcb8abf93f94b
nodejs#26591https://github.com/nodejs/node/pull/26591
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019https://github.com/nodejs/node/pull/26591#issuecomment-479896252
b965ac2https://github.com/nodejs/node/commit/b965ac22ca81a449c9e88f066cadcb8abf93f94b
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 4, 2019https://github.com/nodejs/node/pull/26591#event-2252923651
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
April 4, 2019 15:00https://github.com/nodejs/node/pull/26591#event-2253233404
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26591#ref-commit-6c40f7f
https://github.com/ZYSzys
https://github.com/BethGriggs
querystring: simplify stringify methodhttps://github.com/nodejs/node/commit/6c40f7f940fc07c9a65801af2e897493c428360a
6c40f7fhttps://github.com/nodejs/node/commit/6c40f7f940fc07c9a65801af2e897493c428360a
#26591https://github.com/nodejs/node/pull/26591
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26591#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
BethGriggshttps://github.com/BethGriggs
Apr 10, 2019 https://github.com/nodejs/node/pull/26591#ref-commit-038b778
https://github.com/ZYSzys
https://github.com/BethGriggs
querystring: simplify stringify methodhttps://github.com/nodejs/node/commit/038b7783a70551c00f82a14a836add83532ada6c
038b778https://github.com/nodejs/node/commit/038b7783a70551c00f82a14a836add83532ada6c
#26591https://github.com/nodejs/node/pull/26591
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26591
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26591/files/6cbb12e024d6a0a173a308ccb13fc0e303603454
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/26591/files/c52608a1511d982794ffc4313bc320e33ca4c35a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
querystring https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring
Please reload this pagehttps://github.com/nodejs/node/pull/26591
https://github.com/ZYSzys
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.