René's URL Explorer Experiment


Title: src: refactor coverage connection by joyeecheung · Pull Request #26513 · nodejs/node · GitHub

Open Graph Title: src: refactor coverage connection by joyeecheung · Pull Request #26513 · nodejs/node

X Title: src: refactor coverage connection by joyeecheung · Pull Request #26513 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: src: refactor coverage connection Refactor the C++ class to be resuable for other types of profiles Move the try-catch block around coverage collection callback to be inside the callback to silenc...

X Description: src: refactor coverage connection Refactor the C++ class to be resuable for other types of profiles Move the try-catch block around coverage collection callback to be inside the callback to silenc...

Opengraph URL: https://github.com/nodejs/node/pull/26513

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43a9075e-ece6-2050-ee4c-8d39bd8e829e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD130:2095E1:161F7:1D608:6A4EA82A
html-safe-nonce1b59a6cd4ee6e486fa846752f6123dd99dd539b64ebc4441e3b012f32e844cae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTMwOjIwOTVFMToxNjFGNzoxRDYwODo2QTRFQTgyQSIsInZpc2l0b3JfaWQiOiIzNDc0ODUxMzE1NjExMjQ4NjgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7875c9fb659a7589765db191db8118c4bba72b33b971e0a0ad8ad8d126d6dd96
hovercard-subject-tagpull_request:259469497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26513/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64c7883f8e78ca39e25f0baf73044a502f37138975bfb3beec49ce77d86e09ff/nodejs/node/pull/26513
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64c7883f8e78ca39e25f0baf73044a502f37138975bfb3beec49ce77d86e09ff/nodejs/node/pull/26513
og:image:altsrc: refactor coverage connection Refactor the C++ class to be resuable for other types of profiles Move the try-catch block around coverage collection callback to be inside the callback to silenc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26513#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26513
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26513
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26513
Reloadhttps://github.com/nodejs/node/pull/26513
Reloadhttps://github.com/nodejs/node/pull/26513
Please reload this pagehttps://github.com/nodejs/node/pull/26513
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26513
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-coveragehttps://github.com/joyeecheung/node/tree/refactor-coverage
Conversationhttps://github.com/nodejs/node/pull/26513
Commits2 (2)https://github.com/nodejs/node/pull/26513/commits
Checkshttps://github.com/nodejs/node/pull/26513/checks
Files changedhttps://github.com/nodejs/node/pull/26513/files
src: refactor coverage connectionhttps://github.com/nodejs/node/pull/26513#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-coveragehttps://github.com/joyeecheung/node/tree/refactor-coverage
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2019https://github.com/nodejs/node/pull/26513#issue-418778766
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 8, 2019https://github.com/nodejs/node/pull/26513#issuecomment-470921576
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2809/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2809/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 8, 2019https://github.com/nodejs/node/pull/26513#event-2190037886
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2019https://github.com/nodejs/node/pull/26513#event-2190038065
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2019https://github.com/nodejs/node/pull/26513#issuecomment-470921888
https://ci.nodejs.org/job/node-test-pull-request/21322/https://ci.nodejs.org/job/node-test-pull-request/21322/
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
addaleaxhttps://github.com/addaleax
bcoehttps://github.com/bcoe
March 8, 2019 13:07https://github.com/nodejs/node/pull/26513#event-2190043164
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
coverage https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage
Mar 8, 2019https://github.com/nodejs/node/pull/26513#event-2190051314
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 8, 2019 https://github.com/nodejs/node/pull/26513#pullrequestreview-212288381
View reviewed changes https://github.com/nodejs/node/pull/26513/files
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/26513/files#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 8, 2019 https://github.com/nodejs/node/pull/26513#pullrequestreview-212316128
View reviewed changes https://github.com/nodejs/node/pull/26513/files
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/26513/files#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
gengjiawenhttps://github.com/gengjiawen
Mar 8, 2019https://github.com/nodejs/node/pull/26513#discussion_r263803573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 8, 2019 https://github.com/nodejs/node/pull/26513#pullrequestreview-212317307
View reviewed changes https://github.com/nodejs/node/pull/26513/files
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/26513/files#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 8, 2019 https://github.com/nodejs/node/pull/26513#pullrequestreview-212324039
View reviewed changes https://github.com/nodejs/node/pull/26513/files
src/inspector_profiler.cchttps://github.com/nodejs/node/pull/26513/files#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/bcoe
bcoehttps://github.com/bcoe
Mar 11, 2019 https://github.com/nodejs/node/pull/26513#pullrequestreview-212640881
View reviewed changes https://github.com/nodejs/node/pull/26513/files
bcoehttps://github.com/bcoe
https://github.com/nodejs/node/pull/26513#pullrequestreview-212640881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/26513
joyeecheunghttps://github.com/joyeecheung
March 12, 2019 03:08https://github.com/nodejs/node/pull/26513#commits-pushed-19727d9
https://github.com/joyeecheung
src: refactor coverage connectionhttps://github.com/nodejs/node/pull/26513/commits/19727d9096bfcf5b07e7a9481732f003f7740a20
19727d9https://github.com/nodejs/node/pull/26513/commits/19727d9096bfcf5b07e7a9481732f003f7740a20
https://github.com/joyeecheung
test: show stderr on v8 coverage test failureshttps://github.com/nodejs/node/pull/26513/commits/a7099875a405b6b11f62ebfaf2f59f09133232c7
a709987https://github.com/nodejs/node/pull/26513/commits/a7099875a405b6b11f62ebfaf2f59f09133232c7
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/92ffa3ba420990fb55cf53a227b6be72ed0e896c..a7099875a405b6b11f62ebfaf2f59f09133232c7
92ffa3bhttps://github.com/nodejs/node/commit/92ffa3ba420990fb55cf53a227b6be72ed0e896c
a709987https://github.com/nodejs/node/commit/a7099875a405b6b11f62ebfaf2f59f09133232c7
Compare https://github.com/nodejs/node/compare/92ffa3ba420990fb55cf53a227b6be72ed0e896c..a7099875a405b6b11f62ebfaf2f59f09133232c7
March 11, 2019 19:12https://github.com/nodejs/node/pull/26513#event-2194979767
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019https://github.com/nodejs/node/pull/26513#issuecomment-471681596
https://ci.nodejs.org/job/node-test-pull-request/21434/https://ci.nodejs.org/job/node-test-pull-request/21434/
@gengjiawenhttps://github.com/gengjiawen
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019https://github.com/nodejs/node/pull/26513#issuecomment-471774822
https://user-images.githubusercontent.com/4299420/54163639-eec24d00-4459-11e9-8520-b81f6c5110de.png
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019https://github.com/nodejs/node/pull/26513#issuecomment-471775203
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019https://github.com/nodejs/node/pull/26513#event-2195524599
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-0a3bcdd
https://github.com/joyeecheung
src: refactor coverage connectionhttps://github.com/nodejs/node/commit/0a3bcdd26108bb29045a557bc555c3a53c244a55
0a3bcddhttps://github.com/nodejs/node/commit/0a3bcdd26108bb29045a557bc555c3a53c244a55
#26513https://github.com/nodejs/node/pull/26513
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-eb0bf8d
https://github.com/joyeecheung
test: show stderr on v8 coverage test failureshttps://github.com/nodejs/node/commit/eb0bf8d3077f7fd4d09f187b8bb8290ec8f8171b
eb0bf8dhttps://github.com/nodejs/node/commit/eb0bf8d3077f7fd4d09f187b8bb8290ec8f8171b
#26513https://github.com/nodejs/node/pull/26513
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 12, 2019 https://github.com/nodejs/node/pull/26513#ref-pullrequest-418902619
test: whitelist the expected modules in test-bootstrap-modules.js #26531 https://github.com/nodejs/node/pull/26531
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
backport-requested-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x
Mar 13, 2019https://github.com/nodejs/node/pull/26513#event-2200705639
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019https://github.com/nodejs/node/pull/26513#issuecomment-472479157
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x
Mar 28, 2019https://github.com/nodejs/node/pull/26513#event-2237468341
targoshttps://github.com/targos
Mar 28, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-f618d87
https://github.com/joyeecheung
https://github.com/targos
src: refactor coverage connectionhttps://github.com/nodejs/node/commit/f618d8774da66b190973ce4ce23af76dbf6da463
f618d87https://github.com/nodejs/node/commit/f618d8774da66b190973ce4ce23af76dbf6da463
#26513https://github.com/nodejs/node/pull/26513
targoshttps://github.com/targos
Mar 28, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-91fcb02
https://github.com/joyeecheung
https://github.com/targos
test: show stderr on v8 coverage test failureshttps://github.com/nodejs/node/commit/91fcb02ece4f28c020ef7fcf190c8d7df6772061
91fcb02https://github.com/nodejs/node/commit/91fcb02ece4f28c020ef7fcf190c8d7df6772061
#26513https://github.com/nodejs/node/pull/26513
targoshttps://github.com/targos
Mar 30, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-ab70c96
https://github.com/joyeecheung
https://github.com/targos
src: refactor coverage connectionhttps://github.com/nodejs/node/commit/ab70c96a79f5a3d916888bf6855c055269a8db0b
ab70c96https://github.com/nodejs/node/commit/ab70c96a79f5a3d916888bf6855c055269a8db0b
#26513https://github.com/nodejs/node/pull/26513
targoshttps://github.com/targos
Mar 30, 2019 https://github.com/nodejs/node/pull/26513#ref-commit-03bd649
https://github.com/joyeecheung
https://github.com/targos
test: show stderr on v8 coverage test failureshttps://github.com/nodejs/node/commit/03bd6496557a907ad1fd03524660239f2b34237a
03bd649https://github.com/nodejs/node/commit/03bd6496557a907ad1fd03524660239f2b34237a
#26513https://github.com/nodejs/node/pull/26513
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 9, 2019 https://github.com/nodejs/node/pull/26513#ref-pullrequest-431232386
v11.14.0 proposal #27163 https://github.com/nodejs/node/pull/27163
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26513
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/26513/files/92ffa3ba420990fb55cf53a227b6be72ed0e896c
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/26513/files/92ffa3ba420990fb55cf53a227b6be72ed0e896c
https://github.com/bcoe
bcoe https://github.com/bcoe
https://github.com/nodejs/node/pull/26513/files/92ffa3ba420990fb55cf53a227b6be72ed0e896c
coverage https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/26513
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/bcoe
https://github.com/addaleax
https://github.com/gengjiawen
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.