| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bad579dc-4914-0ca5-0d80-10cbe33c444e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8206:11C2D2:513209:6D6823:6A4EBACB |
| html-safe-nonce | cd3f1ee2968e65c4e5310a759ef5bb119c9d2010446b1481f36e782297ef8136 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjA2OjExQzJEMjo1MTMyMDk6NkQ2ODIzOjZBNEVCQUNCIiwidmlzaXRvcl9pZCI6IjUwNzY1NzU1OTEwMjIzNzc2NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 944e2eac4e7c704a4397c5ae623a702b469ed2904b6ec1512737ce98dec63bf4 |
| hovercard-subject-tag | pull_request:259327520 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26504/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5f45dcc265c56d391b144dff5ca8145a552a9e1502a457288b1f3d74dae385e9/nodejs/node/pull/26504 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5f45dcc265c56d391b144dff5ca8145a552a9e1502a457288b1f3d74dae385e9/nodejs/node/pull/26504 |
| og:image:alt | Refs #26486
@ BeniCheni Can you put the var -> let/const stuff in a separate commit? (Separate PR would be even better!)
Per this comment in #26486 ☝️ , this PR follows up to convert var varia... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BeniCheni |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26504#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26504 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26504 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26504 |
| Reload | https://github.com/nodejs/node/pull/26504 |
| Reload | https://github.com/nodejs/node/pull/26504 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BeniCheni | https://github.com/BeniCheni |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/26504 |
| Commits2 (2) | https://github.com/nodejs/node/pull/26504/commits |
| Checks | https://github.com/nodejs/node/pull/26504/checks |
| Files changed | https://github.com/nodejs/node/pull/26504/files |
| http: convert var to let or const for http | https://github.com/nodejs/node/pull/26504#top |
| BeniCheni | https://github.com/BeniCheni |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issue-418586691 |
| #26486 | https://github.com/nodejs/node/pull/26486 |
| this comment in #26486 | https://github.com/nodejs/node/pull/26486#issuecomment-470663793 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| BeniCheni | https://github.com/BeniCheni |
| March 7, 2019 19:45 | https://github.com/nodejs/node/pull/26504#commits-pushed-ca3ef5c |
|
| https://github.com/BeniCheni |
| http: convert var to let or const in http JavaScript source | https://github.com/nodejs/node/pull/26504/commits/ca3ef5c6d7eb12719f0c195b1d9c40d4f0236db8 |
| ca3ef5c | https://github.com/nodejs/node/pull/26504/commits/ca3ef5c6d7eb12719f0c195b1d9c40d4f0236db8 |
|
| https://github.com/BeniCheni |
| http: convert var to let or const internal http source in lib | https://github.com/nodejs/node/pull/26504/commits/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
| d5cee96 | https://github.com/nodejs/node/pull/26504/commits/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#event-2188925959 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470765500 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470767439 |
| @mscdex | https://github.com/mscdex |
| the comment in another PR | https://github.com/nodejs/node/pull/26486#issuecomment-470663793 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 8, 2019
| https://github.com/nodejs/node/pull/26504#pullrequestreview-212179269 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470844795 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Mar 8, 2019
| https://github.com/nodejs/node/pull/26504#pullrequestreview-212185720 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470901655 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470919029 |
| @himself65 | https://github.com/himself65 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470938170 |
| @BeniCheni | https://github.com/BeniCheni |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470940848 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| @himself65 | https://github.com/himself65 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470941595 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470957799 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-470979996 |
| @ZYSzys | https://github.com/ZYSzys |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-471001699 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 8, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-471102052 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Mar 8, 2019
| https://github.com/nodejs/node/pull/26504#pullrequestreview-212512506 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/26504#pullrequestreview-212512506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 9, 2019 | https://github.com/nodejs/node/pull/26504#issuecomment-471123416 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| Mar 9, 2019 | https://github.com/nodejs/node/pull/26504#event-2191479004 |
| https://github.com/BeniCheni |
| BeniCheni | https://github.com/BeniCheni |
| March 9, 2019 00:23 | https://github.com/nodejs/node/pull/26504#event-2191479287 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Mar 15, 2019
| https://github.com/nodejs/node/pull/26504#ref-pullrequest-421493853 |
|
lib: use const where possible
#26679
| https://github.com/nodejs/node/pull/26679 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Jun 6, 2019
| https://github.com/nodejs/node/pull/26504#ref-pullrequest-452731625 |
|
lib: replace var with let
#28081
| https://github.com/nodejs/node/pull/28081 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26504 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/26504/files/d5cee9661c1df6e56e45c0a5f659f49e2ab4c5f0 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/26504 |
|
| https://github.com/BeniCheni |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/himself65 |
|
| https://github.com/BridgeAR |
|
| https://github.com/ZYSzys |
|
| https://github.com/shisama |
|
| https://github.com/mcollina |
|
| https://github.com/watilde |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |