René's URL Explorer Experiment


Title: crypto: expose KeyObject class by panva · Pull Request #26438 · nodejs/node · GitHub

Open Graph Title: crypto: expose KeyObject class by panva · Pull Request #26438 · nodejs/node

X Title: crypto: expose KeyObject class by panva · Pull Request #26438 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR exposes the KeyObject class as per #26200 discussion. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added commit message follows commit gu...

X Description: This PR exposes the KeyObject class as per #26200 discussion. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added commit message follows commit gu...

Opengraph URL: https://github.com/nodejs/node/pull/26438

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:241e03dd-6767-46f1-fb98-b5a6de3c73f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB522:3CE69D:651CAD:837E15:6AED2E9D
html-safe-nonce752dfcba537a4c6e07865d092d466f56a626c505f32f18c09ce2e1143222fd0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTIyOjNDRTY5RDo2NTFDQUQ6ODM3RTE1OjZBRUQyRTlEIiwidmlzaXRvcl9pZCI6IjQ1Mzk5ODc4ODkxNzYyNjAyNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac83f4c49bc67ef7c8241e0944efa5b11561c27420d29eeca26c38479f189911f1
hovercard-subject-tagpull_request:258049835
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26438/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7af171413ef0c938c46ac2df0d802d56927e5fcfae5e0b1cd826b3fdbdc677be/nodejs/node/pull/26438
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7af171413ef0c938c46ac2df0d802d56927e5fcfae5e0b1cd826b3fdbdc677be/nodejs/node/pull/26438
og:image:altThis PR exposes the KeyObject class as per #26200 discussion. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added commit message follows commit gu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26438#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26438
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26438
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26438
Reloadhttps://github.com/nodejs/node/pull/26438
Reloadhttps://github.com/nodejs/node/pull/26438
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/26438
Commits1 (1)https://github.com/nodejs/node/pull/26438/commits
Checkshttps://github.com/nodejs/node/pull/26438/checks
Files changedhttps://github.com/nodejs/node/pull/26438/files
crypto: expose KeyObject classhttps://github.com/nodejs/node/pull/26438#top
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/panva
panvahttps://github.com/panva
Mar 4, 2019https://github.com/nodejs/node/pull/26438#issue-416941029
Please reload this pagehttps://github.com/nodejs/node/pull/26438
#26200https://github.com/nodejs/node/pull/26200
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@sam-githubhttps://github.com/sam-github
@tniessenhttps://github.com/tniessen
#26200https://github.com/nodejs/node/pull/26200
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Mar 4, 2019https://github.com/nodejs/node/pull/26438#event-2178784688
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 4, 2019 https://github.com/nodejs/node/pull/26438#pullrequestreview-210307168
View reviewed changes https://github.com/nodejs/node/pull/26438/files
sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/nodejs/node/pull/26438#pullrequestreview-210307168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26438
lib/crypto.jshttps://github.com/nodejs/node/pull/26438/files#diff-2dae071ed4c380c6e7b48904c71c7ebc52e3241f4b0615962a57653aa6688e3d
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 4, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469383998
already documentedhttps://nodejs.org/api/crypto.html#crypto_class_keyobject
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 4, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469389165
https://ci.nodejs.org/job/node-test-pull-request/21194/https://ci.nodejs.org/job/node-test-pull-request/21194/
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 4, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469390686
Please reload this pagehttps://github.com/nodejs/node/pull/26438
ci.nodejs.org/job/node-test-pull-request/21194https://ci.nodejs.org/job/node-test-pull-request/21194/
codehttps://github.com/nodejs/node/blob/v11.10.1/lib/internal/crypto/keys.js#L35-L39
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 5, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469730137
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 5, 2019 https://github.com/nodejs/node/pull/26438#ref-pullrequest-411824462
crypto: expose crypto.isKeyObject() helper #26200 https://github.com/nodejs/node/pull/26200
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 5, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469731572
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 5, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469735357
Please reload this pagehttps://github.com/nodejs/node/pull/26438
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 5, 2019 https://github.com/nodejs/node/pull/26438#pullrequestreview-210774831
View reviewed changes https://github.com/nodejs/node/pull/26438/files
test/parallel/test-crypto-key-objects.jshttps://github.com/nodejs/node/pull/26438/files#diff-20d46603bdf095e987f1453e94b57fff0bf05a3d818e9bf1e06d06226d63c4e6
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 5, 2019https://github.com/nodejs/node/pull/26438#issuecomment-469765266
https://ci.nodejs.org/job/node-test-pull-request/21221/https://ci.nodejs.org/job/node-test-pull-request/21221/
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Mar 5, 2019https://github.com/nodejs/node/pull/26438#event-2181631182
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 10, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471343944
@sam-githubhttps://github.com/sam-github
@tniessenhttps://github.com/tniessen
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471686716
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
crypto: expose KeyObject classhttps://github.com/nodejs/node/pull/26438/commits/f449ebdfd1624694cb23895c5b43bcc9a54836b8
f449ebdhttps://github.com/nodejs/node/pull/26438/commits/f449ebdfd1624694cb23895c5b43bcc9a54836b8
https://github.com/panva
panvahttps://github.com/panva
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471717002
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471726445
Please reload this pagehttps://github.com/nodejs/node/pull/26438
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471738075
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
panvahttps://github.com/panva
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471743703
Please reload this pagehttps://github.com/nodejs/node/pull/26438
branchhttps://github.com/nodejs/node/compare/master...panva:keyobject-no-instance
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 11, 2019 https://github.com/nodejs/node/pull/26438#pullrequestreview-213126532
View reviewed changes https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
lib/crypto.jshttps://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8#diff-2dae071ed4c380c6e7b48904c71c7ebc52e3241f4b0615962a57653aa6688e3d
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 11, 2019https://github.com/nodejs/node/pull/26438#issuecomment-471775007
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 12, 2019https://github.com/nodejs/node/pull/26438#issuecomment-472126785
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 12, 2019 https://github.com/nodejs/node/pull/26438#pullrequestreview-213655712
View reviewed changes https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
https://github.com/panva
panvahttps://github.com/panva
Mar 17, 2019https://github.com/nodejs/node/pull/26438#issuecomment-473649113
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 17, 2019 https://github.com/nodejs/node/pull/26438#pullrequestreview-215347737
View reviewed changes https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
tniessenhttps://github.com/tniessen
Mar 17, 2019 https://github.com/nodejs/node/pull/26438#ref-commit-f105654
https://github.com/panva
https://github.com/tniessen
crypto: expose KeyObject classhttps://github.com/nodejs/node/commit/f1056542f0cf2520e122d93afbaada6b6599e49b
f105654https://github.com/nodejs/node/commit/f1056542f0cf2520e122d93afbaada6b6599e49b
#26438https://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 17, 2019https://github.com/nodejs/node/pull/26438#issuecomment-473650767
f105654https://github.com/nodejs/node/commit/f1056542f0cf2520e122d93afbaada6b6599e49b
@panvahttps://github.com/panva
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 17, 2019https://github.com/nodejs/node/pull/26438#event-2208612137
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26438#ref-commit-1a0f66b
https://github.com/targos
crypto: expose KeyObject classhttps://github.com/targos/node/commit/1a0f66be47969a10e1731ee171f21ce04288da49
1a0f66bhttps://github.com/targos/node/commit/1a0f66be47969a10e1731ee171f21ce04288da49
nodejs#26438https://github.com/nodejs/node/pull/26438
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26438#ref-commit-74c6f57
https://github.com/panva
https://github.com/targos
crypto: expose KeyObject classhttps://github.com/nodejs/node/commit/74c6f57aed229ec0e1464cd7065e782a8412464a
74c6f57https://github.com/nodejs/node/commit/74c6f57aed229ec0e1464cd7065e782a8412464a
#26438https://github.com/nodejs/node/pull/26438
https://github.com/targos
targoshttps://github.com/targos
Mar 27, 2019 https://github.com/nodejs/node/pull/26438#ref-pullrequest-426198676
v11.13.0 release proposal #26949 https://github.com/nodejs/node/pull/26949
Feature Request: Safe/reliable crypto.KeyObject and webcrypto.CryptoKey detection in userland #38611 https://github.com/nodejs/node/issues/38611
util: add util.types.isKeyObject and util.types.isCryptoKey #38619 https://github.com/nodejs/node/pull/38619
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26438
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/26438/files/f449ebdfd1624694cb23895c5b43bcc9a54836b8
Please reload this pagehttps://github.com/nodejs/node/pull/26438
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/26438
https://github.com/panva
https://github.com/sam-github
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.