René's URL Explorer Experiment


Title: buffer: do not affect memory after target for utf16 write by addaleax · Pull Request #26432 · nodejs/node · GitHub

Open Graph Title: buffer: do not affect memory after target for utf16 write by addaleax · Pull Request #26432 · nodejs/node

X Title: buffer: do not affect memory after target for utf16 write by addaleax · Pull Request #26432 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not write one character too much before shifting the whole result to the left when using UTF16-LE, possibly overwriting already-used memory while doing so. Fixes: #26422 Checklist make -j4 t...

X Description: Do not write one character too much before shifting the whole result to the left when using UTF16-LE, possibly overwriting already-used memory while doing so. Fixes: #26422 Checklist make -j4 t...

Opengraph URL: https://github.com/nodejs/node/pull/26432

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:58ce62ea-6d46-89c8-618e-0ef42687b587
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E08:371B:654558:854561:6991E9BE
html-safe-nonce51c3cbc9382ab2174fc25e6d77bf734a9240d65372c0680de60a486fff3d91ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTA4OjM3MUI6NjU0NTU4Ojg1NDU2MTo2OTkxRTlCRSIsInZpc2l0b3JfaWQiOiIzNzA1MTgzMTEwMjM4OTU1OTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca7f04fd4f4b2d94c4b2a60b6f33635641b2a003c5cb368b1b7432367f3593274
hovercard-subject-tagpull_request:258003965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26432/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0223961d5e82f800dd4a18c98178ca3ef395c71d7c78ad8767af727c5778cbbf/nodejs/node/pull/26432
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0223961d5e82f800dd4a18c98178ca3ef395c71d7c78ad8767af727c5778cbbf/nodejs/node/pull/26432
og:image:altDo not write one character too much before shifting the whole result to the left when using UTF16-LE, possibly overwriting already-used memory while doing so. Fixes: #26422 Checklist make -j4 t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26432#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26432
Reloadhttps://github.com/nodejs/node/pull/26432
Reloadhttps://github.com/nodejs/node/pull/26432
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26432
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-26422https://github.com/addaleax/node/tree/fix-26422
Conversationhttps://github.com/nodejs/node/pull/26432
Commits1 (1)https://github.com/nodejs/node/pull/26432/commits
Checkshttps://github.com/nodejs/node/pull/26432/checks
Files changedhttps://github.com/nodejs/node/pull/26432/files
buffer: do not affect memory after target for utf16 writehttps://github.com/nodejs/node/pull/26432#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-26422https://github.com/addaleax/node/tree/fix-26422
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 4, 2019https://github.com/nodejs/node/pull/26432#issue-416880367
#26422https://github.com/nodejs/node/issues/26422
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://github.com/addaleax
buffer: do not affect memory after target for utf16 writehttps://github.com/nodejs/node/pull/26432/commits/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
8278fbehttps://github.com/nodejs/node/pull/26432/commits/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
nodejs#26422https://github.com/nodejs/node/issues/26422
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Mar 4, 2019https://github.com/nodejs/node/pull/26432#event-2178391171
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 4, 2019https://github.com/nodejs/node/pull/26432#issuecomment-469314454
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2756/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2756/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Mar 4, 2019https://github.com/nodejs/node/pull/26432#event-2178391352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 4, 2019 https://github.com/nodejs/node/pull/26432#ref-issue-416683403
buffer.write incorrectly written one more byte in utf16le encoding #26422 https://github.com/nodejs/node/issues/26422
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 4, 2019 https://github.com/nodejs/node/pull/26432#pullrequestreview-210241329
View reviewed changes https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Mar 4, 2019https://github.com/nodejs/node/pull/26432#issuecomment-469333989
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://ci.nodejs.org/job/node-test-pull-request/21191/https://ci.nodejs.org/job/node-test-pull-request/21191/
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 4, 2019 https://github.com/nodejs/node/pull/26432#pullrequestreview-210427293
View reviewed changes https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 5, 2019https://github.com/nodejs/node/pull/26432#event-2179512227
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Mar 5, 2019 https://github.com/nodejs/node/pull/26432#pullrequestreview-210664895
View reviewed changes https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019https://github.com/nodejs/node/pull/26432#issuecomment-470321927
31147c4https://github.com/nodejs/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019https://github.com/nodejs/node/pull/26432#event-2185719596
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019 https://github.com/nodejs/node/pull/26432#ref-commit-31147c4
https://github.com/addaleax
https://github.com/BridgeAR
buffer: do not affect memory after target for utf16 writehttps://github.com/BridgeAR/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f
31147c4https://github.com/BridgeAR/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f
nodejs#26422https://github.com/nodejs/node/issues/26422
nodejs#26432https://github.com/nodejs/node/pull/26432
nodejs#26422https://github.com/nodejs/node/issues/26422
BridgeARhttps://github.com/BridgeAR
Mar 12, 2019 https://github.com/nodejs/node/pull/26432#ref-commit-7d8edec
https://github.com/addaleax
https://github.com/BridgeAR
buffer: do not affect memory after target for utf16 writehttps://github.com/BridgeAR/node/commit/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea
7d8edechttps://github.com/BridgeAR/node/commit/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea
nodejs#26422https://github.com/nodejs/node/issues/26422
nodejs#26432https://github.com/nodejs/node/pull/26432
nodejs#26422https://github.com/nodejs/node/issues/26422
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/26432#ref-pullrequest-420740761
2019-03-14, Version 11.12.0 (Current) #26644 https://github.com/nodejs/node/pull/26644
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/26432#ref-commit-68bb1e9
https://github.com/addaleax
https://github.com/BridgeAR
buffer: do not affect memory after target for utf16 writehttps://github.com/nodejs/node/commit/68bb1e9fd8a13d7f826bca0104a862a050424713
68bb1e9https://github.com/nodejs/node/commit/68bb1e9fd8a13d7f826bca0104a862a050424713
#26422https://github.com/nodejs/node/issues/26422
#26432https://github.com/nodejs/node/pull/26432
#26422https://github.com/nodejs/node/issues/26422
BethGriggshttps://github.com/BethGriggs
Apr 16, 2019 https://github.com/nodejs/node/pull/26432#ref-commit-ff647fd
https://github.com/addaleax
https://github.com/BethGriggs
buffer: do not affect memory after target for utf16 writehttps://github.com/nodejs/node/commit/ff647fda13c835702acadf7e9c079e2aef353bbe
ff647fdhttps://github.com/nodejs/node/commit/ff647fda13c835702acadf7e9c079e2aef353bbe
#26422https://github.com/nodejs/node/issues/26422
#26432https://github.com/nodejs/node/pull/26432
#26422https://github.com/nodejs/node/issues/26422
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/26432#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Jul 9, 2019https://github.com/nodejs/node/pull/26432#event-2469793782
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
buffer.write incorrectly written one more byte in utf16le encoding https://github.com/nodejs/node/issues/26422
Please reload this pagehttps://github.com/nodejs/node/pull/26432
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/antsmartian
https://github.com/BridgeAR
https://github.com/JungMinu
https://github.com/richardlau
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.