| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:58ce62ea-6d46-89c8-618e-0ef42687b587 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E08:371B:654558:854561:6991E9BE |
| html-safe-nonce | 51c3cbc9382ab2174fc25e6d77bf734a9240d65372c0680de60a486fff3d91ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTA4OjM3MUI6NjU0NTU4Ojg1NDU2MTo2OTkxRTlCRSIsInZpc2l0b3JfaWQiOiIzNzA1MTgzMTEwMjM4OTU1OTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a7f04fd4f4b2d94c4b2a60b6f33635641b2a003c5cb368b1b7432367f3593274 |
| hovercard-subject-tag | pull_request:258003965 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26432/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0223961d5e82f800dd4a18c98178ca3ef395c71d7c78ad8767af727c5778cbbf/nodejs/node/pull/26432 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0223961d5e82f800dd4a18c98178ca3ef395c71d7c78ad8767af727c5778cbbf/nodejs/node/pull/26432 |
| og:image:alt | Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.
Fixes: #26422
Checklist
make -j4 t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26432#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26432 |
| Reload | https://github.com/nodejs/node/pull/26432 |
| Reload | https://github.com/nodejs/node/pull/26432 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-26422 | https://github.com/addaleax/node/tree/fix-26422 |
| Conversation | https://github.com/nodejs/node/pull/26432 |
| Commits1 (1) | https://github.com/nodejs/node/pull/26432/commits |
| Checks | https://github.com/nodejs/node/pull/26432/checks |
| Files changed | https://github.com/nodejs/node/pull/26432/files |
| buffer: do not affect memory after target for utf16 write | https://github.com/nodejs/node/pull/26432#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-26422 | https://github.com/addaleax/node/tree/fix-26422 |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26432#issue-416880367 |
| #26422 | https://github.com/nodejs/node/issues/26422 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
|
| https://github.com/addaleax |
| buffer: do not affect memory after target for utf16 write | https://github.com/nodejs/node/pull/26432/commits/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
| 8278fbe | https://github.com/nodejs/node/pull/26432/commits/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
lts-watch-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26432#event-2178391171 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26432#issuecomment-469314454 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2756/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2756/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26432#event-2178391352 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26432#ref-issue-416683403 |
|
buffer.write incorrectly written one more byte in utf16le encoding
#26422
| https://github.com/nodejs/node/issues/26422 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26432#pullrequestreview-210241329 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26432#issuecomment-469333989 |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
| https://ci.nodejs.org/job/node-test-pull-request/21191/ | https://ci.nodejs.org/job/node-test-pull-request/21191/ |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26432#pullrequestreview-210427293 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 5, 2019 | https://github.com/nodejs/node/pull/26432#event-2179512227 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Mar 5, 2019
| https://github.com/nodejs/node/pull/26432#pullrequestreview-210664895 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 6, 2019 | https://github.com/nodejs/node/pull/26432#issuecomment-470321927 |
| 31147c4 | https://github.com/nodejs/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 6, 2019 | https://github.com/nodejs/node/pull/26432#event-2185719596 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 6, 2019
| https://github.com/nodejs/node/pull/26432#ref-commit-31147c4 |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
| buffer: do not affect memory after target for utf16 write | https://github.com/BridgeAR/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f |
| 31147c4 | https://github.com/BridgeAR/node/commit/31147c47043827dd8b0a08c1befe4110c8d9174f |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| nodejs#26432 | https://github.com/nodejs/node/pull/26432 |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 12, 2019
| https://github.com/nodejs/node/pull/26432#ref-commit-7d8edec |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
| buffer: do not affect memory after target for utf16 write | https://github.com/BridgeAR/node/commit/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea |
| 7d8edec | https://github.com/BridgeAR/node/commit/7d8edecbd6f425a064ca05b3ae7e55a815e0aaea |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| nodejs#26432 | https://github.com/nodejs/node/pull/26432 |
| nodejs#26422 | https://github.com/nodejs/node/issues/26422 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 13, 2019
| https://github.com/nodejs/node/pull/26432#ref-pullrequest-420740761 |
|
2019-03-14, Version 11.12.0 (Current)
#26644
| https://github.com/nodejs/node/pull/26644 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26432#ref-commit-68bb1e9 |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
| buffer: do not affect memory after target for utf16 write | https://github.com/nodejs/node/commit/68bb1e9fd8a13d7f826bca0104a862a050424713 |
| 68bb1e9 | https://github.com/nodejs/node/commit/68bb1e9fd8a13d7f826bca0104a862a050424713 |
| #26422 | https://github.com/nodejs/node/issues/26422 |
| #26432 | https://github.com/nodejs/node/pull/26432 |
| #26422 | https://github.com/nodejs/node/issues/26422 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/26432#ref-commit-ff647fd |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
| buffer: do not affect memory after target for utf16 write | https://github.com/nodejs/node/commit/ff647fda13c835702acadf7e9c079e2aef353bbe |
| ff647fd | https://github.com/nodejs/node/commit/ff647fda13c835702acadf7e9c079e2aef353bbe |
| #26422 | https://github.com/nodejs/node/issues/26422 |
| #26432 | https://github.com/nodejs/node/pull/26432 |
| #26422 | https://github.com/nodejs/node/issues/26422 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
May 1, 2019
| https://github.com/nodejs/node/pull/26432#ref-pullrequest-439147711 |
|
v10.16.0 proposal
#27514
| https://github.com/nodejs/node/pull/27514 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#315
| https://github.com/beevelop/docker-android-nodejs/issues/315 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#316
| https://github.com/beevelop/docker-android-nodejs/issues/316 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#317
| https://github.com/beevelop/docker-android-nodejs/issues/317 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#318
| https://github.com/beevelop/docker-android-nodejs/issues/318 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#319
| https://github.com/beevelop/docker-android-nodejs/issues/319 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/26432#event-2469793782 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26432 |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/26432/files/8278fbe9c1508d97f441abf1f84a1d7a59511ec9 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
buffer.write incorrectly written one more byte in utf16le encoding
| https://github.com/nodejs/node/issues/26422 |
| Please reload this page | https://github.com/nodejs/node/pull/26432 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/antsmartian |
|
| https://github.com/BridgeAR |
|
| https://github.com/JungMinu |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |