René's URL Explorer Experiment


Title: build,win: simplify new `msbuild_arg` option by refack · Pull Request #26431 · nodejs/node · GitHub

Open Graph Title: build,win: simplify new `msbuild_arg` option by refack · Pull Request #26431 · nodejs/node

X Title: build,win: simplify new `msbuild_arg` option by refack · Pull Request #26431 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Make the mechanism of passing msbuild_args backwards compatible. Refs: #25994 /CC @nodejs/build-files @nodejs/platform-windows Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

X Description: Make the mechanism of passing msbuild_args backwards compatible. Refs: #25994 /CC @nodejs/build-files @nodejs/platform-windows Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

Opengraph URL: https://github.com/nodejs/node/pull/26431

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc607449-a0f2-9376-7734-d857fd509a3a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD464:13117A:1356142:18D6949:69924977
html-safe-noncedae775103124d963c9c3dcd64eb2f602e1ec64267ded8c80924e5979e25d16c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDY0OjEzMTE3QToxMzU2MTQyOjE4RDY5NDk6Njk5MjQ5NzciLCJ2aXNpdG9yX2lkIjoiMjgyMTgzMjIxNzE5MzQ5ODk5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50aa2f088ad80b20b4ef7d6ac63469b31543a527a4e7aa1d42e1a3823b9e1ede
hovercard-subject-tagpull_request:257999670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26431/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c19f3ce7c9953f64482b545546f3afb838ed6d3ba847857e5b2164c1bd53eb4/nodejs/node/pull/26431
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c19f3ce7c9953f64482b545546f3afb838ed6d3ba847857e5b2164c1bd53eb4/nodejs/node/pull/26431
og:image:altMake the mechanism of passing msbuild_args backwards compatible. Refs: #25994 /CC @nodejs/build-files @nodejs/platform-windows Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26431#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26431
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26431
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26431
Reloadhttps://github.com/nodejs/node/pull/26431
Reloadhttps://github.com/nodejs/node/pull/26431
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26431
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:tweak-vcbuld-changehttps://github.com/refack/node/tree/tweak-vcbuld-change
Conversationhttps://github.com/nodejs/node/pull/26431
Commits1 (1)https://github.com/nodejs/node/pull/26431/commits
Checkshttps://github.com/nodejs/node/pull/26431/checks
Files changedhttps://github.com/nodejs/node/pull/26431/files
build,win: simplify new msbuild_arg optionhttps://github.com/nodejs/node/pull/26431#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:tweak-vcbuld-changehttps://github.com/refack/node/tree/tweak-vcbuld-change
https://github.com/refack
refackhttps://github.com/refack
Mar 4, 2019https://github.com/nodejs/node/pull/26431#issue-416874908
#25994https://github.com/nodejs/node/pull/25994
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 4, 2019https://github.com/nodejs/node/pull/26431#issuecomment-469310029
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2755/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2755/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Mar 4, 2019https://github.com/nodejs/node/pull/26431#event-2178355928
https://github.com/refack
refackhttps://github.com/refack
Mar 4, 2019https://github.com/nodejs/node/pull/26431#issuecomment-469310762
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://ci.nodejs.org/job/node-test-commit-windows-fanned/25157/https://ci.nodejs.org/job/node-test-commit-windows-fanned/25157/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/25158/https://ci.nodejs.org/job/node-test-commit-windows-fanned/25158/
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/refack
refackhttps://github.com/refack
Mar 4, 2019https://github.com/nodejs/node/pull/26431#event-2178361905
https://github.com/refack
build,win: simplify new msbuild_arg optionhttps://github.com/nodejs/node/pull/26431/commits/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
0620d5dhttps://github.com/nodejs/node/pull/26431/commits/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/1e43eb0e217af1ee31d9a57dde9b5171dadcd85f..0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
1e43eb0https://github.com/nodejs/node/commit/1e43eb0e217af1ee31d9a57dde9b5171dadcd85f
0620d5dhttps://github.com/nodejs/node/commit/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
Compare https://github.com/nodejs/node/compare/1e43eb0e217af1ee31d9a57dde9b5171dadcd85f..0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
March 4, 2019 16:30https://github.com/nodejs/node/pull/26431#event-2178422384
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Mar 4, 2019 https://github.com/nodejs/node/pull/26431#pullrequestreview-210386378
View reviewed changes https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 4, 2019 https://github.com/nodejs/node/pull/26431#pullrequestreview-210387957
View reviewed changes https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 4, 2019 https://github.com/nodejs/node/pull/26431#pullrequestreview-210430675
View reviewed changes https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 5, 2019https://github.com/nodejs/node/pull/26431#issuecomment-469765018
https://ci.nodejs.org/job/node-test-pull-request/21220/https://ci.nodejs.org/job/node-test-pull-request/21220/
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 5, 2019https://github.com/nodejs/node/pull/26431#event-2181617324
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019 https://github.com/nodejs/node/pull/26431#pullrequestreview-211534154
View reviewed changes https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470321619
dfffb6dhttps://github.com/nodejs/node/commit/dfffb6d2af5ea72ec8829ef96a26308378e40c96
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019https://github.com/nodejs/node/pull/26431#event-2185717734
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019 https://github.com/nodejs/node/pull/26431#ref-commit-dfffb6d
https://github.com/refack
https://github.com/BridgeAR
build,win: simplify new msbuild_arg optionhttps://github.com/BridgeAR/node/commit/dfffb6d2af5ea72ec8829ef96a26308378e40c96
dfffb6dhttps://github.com/BridgeAR/node/commit/dfffb6d2af5ea72ec8829ef96a26308378e40c96
nodejs#26431https://github.com/nodejs/node/pull/26431
nodejs#25994https://github.com/nodejs/node/pull/25994
https://github.com/refack
refackhttps://github.com/refack
Mar 7, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470549820
@BridgeARhttps://github.com/BridgeAR
collaborator guidehttps://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#handling-own-pull-requests
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/refack
refackhttps://github.com/refack
March 7, 2019 14:37https://github.com/nodejs/node/pull/26431#event-2187395037
https://github.com/refack
refackhttps://github.com/refack
landed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alanded
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 7, 2019https://github.com/nodejs/node/pull/26431#event-2187395646
https://github.com/refack
refackhttps://github.com/refack
Mar 7, 2019https://github.com/nodejs/node/pull/26431#event-2187396280
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 7, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470553447
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 7, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470553780
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/refack
refackhttps://github.com/refack
Mar 7, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470557630
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 7, 2019https://github.com/nodejs/node/pull/26431#issuecomment-470576722
Please reload this pagehttps://github.com/nodejs/node/pull/26431
BridgeARhttps://github.com/BridgeAR
Mar 12, 2019 https://github.com/nodejs/node/pull/26431#ref-commit-3dd7084
https://github.com/refack
https://github.com/BridgeAR
build,win: simplify new msbuild_arg optionhttps://github.com/BridgeAR/node/commit/3dd7084ff928a6312c70bf4eea4b1724c44f599b
3dd7084https://github.com/BridgeAR/node/commit/3dd7084ff928a6312c70bf4eea4b1724c44f599b
nodejs#26431https://github.com/nodejs/node/pull/26431
nodejs#25994https://github.com/nodejs/node/pull/25994
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/26431#ref-pullrequest-420740761
2019-03-14, Version 11.12.0 (Current) #26644 https://github.com/nodejs/node/pull/26644
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/26431#ref-commit-c247153
https://github.com/refack
https://github.com/BridgeAR
build,win: simplify new msbuild_arg optionhttps://github.com/nodejs/node/commit/c2471538efe2273028800ffd723b73c3fd56c2d0
c247153https://github.com/nodejs/node/commit/c2471538efe2273028800ffd723b73c3fd56c2d0
#26431https://github.com/nodejs/node/pull/26431
#25994https://github.com/nodejs/node/pull/25994
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26431
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
https://github.com/joaocgreis
joaocgreis https://github.com/joaocgreis
https://github.com/nodejs/node/pull/26431/files/0620d5d0e8b1efff2f17b7c043eb02ff42617b5e
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/26431
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/richardlau
https://github.com/joaocgreis
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.