René's URL Explorer Experiment


Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node · GitHub

Open Graph Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node

X Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node

Description: Inspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the buffer benchmark and seems a bit of improvement, but it took too long and my laptop has no power, so I canceled -:( /cc @mscdex Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: Inspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the buffe...

X Description: Inspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the b...

Opengraph URL: https://github.com/nodejs/node/pull/26400

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:608ed274-b3a7-0fe5-c4a0-368427db6f1e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD98A:2B9FF1:353A2C3:46E4313:6A6557BD
html-safe-nonceffc052d3b4e2195297381b96686e363153a4d862811a320a128846738b6aea29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOThBOjJCOUZGMTozNTNBMkMzOjQ2RTQzMTM6NkE2NTU3QkQiLCJ2aXNpdG9yX2lkIjoiNzg5NjE0NjEzNjc5NzYzMjQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5c67402d02dbaabfc1d05cf90ad3f1ab3b42bd083eb01629b2962475bec2cc3e
hovercard-subject-tagpull_request:257674813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
twitter:imagehttps://avatars.githubusercontent.com/u/23313266?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23313266?s=400&v=4
og:image:altInspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the buffe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26400%2Fcommits%2F50acfb814a88e054e3f503a35386fc50ed634133
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26400%2Fcommits%2F50acfb814a88e054e3f503a35386fc50ed634133
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Reloadhttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Reloadhttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1.1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 24 https://github.com/nodejs/node/pull/26400
Commits 2 https://github.com/nodejs/node/pull/26400/commits
Checks 0 https://github.com/nodejs/node/pull/26400/checks
Files changed https://github.com/nodejs/node/pull/26400/files
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
buffer: improve performance of buffer indexof method https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133#top
Show all changes 2 commits https://github.com/nodejs/node/pull/26400/files
a628ad8 buffer: improve performance of buffer indexof method ZYSzys Mar 7, 2019 https://github.com/nodejs/node/pull/26400/commits/a628ad8cb982da22ffc0c8661f3776da3447a6eb
50acfb8 fixup! buffer: improve performance of buffer indexof method ZYSzys Mar 8, 2019 https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Clear filters https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
Prev https://github.com/nodejs/node/pull/26400/commits/a628ad8cb982da22ffc0c8661f3776da3447a6eb
Please reload this pagehttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
https://github.com/ZYSzys
ZYSzyshttps://github.com/nodejs/node/commits?author=ZYSzys
lib/buffer.jshttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
View file https://github.com/nodejs/node/blob/50acfb814a88e054e3f503a35386fc50ed634133/lib/buffer.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/26400/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.