René's URL Explorer Experiment


Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node · GitHub

Open Graph Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node

X Title: buffer: improve performance of buffer indexof method by ZYSzys · Pull Request #26400 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Inspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the buffe...

X Description: Inspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the b...

Opengraph URL: https://github.com/nodejs/node/pull/26400

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:11f38791-1c80-fa83-3089-b824892da093
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEE8:20E626:1130244:17C5475:6A4DDC23
html-safe-nonced521ba5c41fc94c865424465bf82a3e1d4fea286a700906e41299bce855ae7ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUU4OjIwRTYyNjoxMTMwMjQ0OjE3QzU0NzU6NkE0RERDMjMiLCJ2aXNpdG9yX2lkIjoiNjAwNjQzNDg1NTI2MDExODA1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac22ea0d7383d579a7202ea34ea55faf093a0857d25a99b4f716c7d90ada1b5bdc
hovercard-subject-tagpull_request:257674813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26400/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2bf8309caf3ed6d95d73356b6c66f724635636ea27ffa5ec60275e91dbbb8b24/nodejs/node/pull/26400
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2bf8309caf3ed6d95d73356b6c66f724635636ea27ffa5ec60275e91dbbb8b24/nodejs/node/pull/26400
og:image:altInspired by #12361, making buffer indexof method be consistent with byteLength, stringSlice, Buffer.prototype.write , and IIUC this should have some performance improvement. (I've run the buffe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26400#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26400
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26400
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26400
Reloadhttps://github.com/nodejs/node/pull/26400
Reloadhttps://github.com/nodejs/node/pull/26400
Please reload this pagehttps://github.com/nodejs/node/pull/26400
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26400
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/26400
Commits2 (2)https://github.com/nodejs/node/pull/26400/commits
Checkshttps://github.com/nodejs/node/pull/26400/checks
Files changedhttps://github.com/nodejs/node/pull/26400/files
buffer: improve performance of buffer indexof methodhttps://github.com/nodejs/node/pull/26400#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 2, 2019https://github.com/nodejs/node/pull/26400#issue-416413191
#12361https://github.com/nodejs/node/pull/12361
byteLengthhttps://github.com/nodejs/node/blob/2a5edafabd2cce9cff59321f0b492fa50af2e705/lib/buffer.js#L502
stringSlicehttps://github.com/nodejs/node/blob/2a5edafabd2cce9cff59321f0b492fa50af2e705/lib/buffer.js#L582
Buffer.prototype.writehttps://github.com/nodejs/node/blob/2a5edafabd2cce9cff59321f0b492fa50af2e705/lib/buffer.js#L937
@mscdexhttps://github.com/mscdex
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Mar 2, 2019https://github.com/nodejs/node/pull/26400#event-2175836660
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 2, 2019https://github.com/nodejs/node/pull/26400#issuecomment-468947443
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/298/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/298/
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 4, 2019 https://github.com/nodejs/node/pull/26400#pullrequestreview-209944595
View reviewed changes https://github.com/nodejs/node/pull/26400/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/26400#pullrequestreview-209944595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26400
lib/buffer.jshttps://github.com/nodejs/node/pull/26400/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 5, 2019https://github.com/nodejs/node/pull/26400#issuecomment-469485603
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 5, 2019https://github.com/nodejs/node/pull/26400#issuecomment-469487757
Please reload this pagehttps://github.com/nodejs/node/pull/26400
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 6, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470108506
Please reload this pagehttps://github.com/nodejs/node/pull/26400
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 6, 2019 https://github.com/nodejs/node/pull/26400#pullrequestreview-211286107
View reviewed changes https://github.com/nodejs/node/pull/26400/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/26400#pullrequestreview-211286107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 6, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470152401
Please reload this pagehttps://github.com/nodejs/node/pull/26400
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 7, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470409984
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 7, 2019 https://github.com/nodejs/node/pull/26400#pullrequestreview-211625498
View reviewed changes https://github.com/nodejs/node/pull/26400/files
benchmark/buffers/buffer-indexof.jshttps://github.com/nodejs/node/pull/26400/files#diff-d3ecfc06d5f8256be704501b4c88633a1d631fc05b0d59f7afd878c87bbe228e
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
buffer: improve performance of buffer indexof methodhttps://github.com/nodejs/node/pull/26400/commits/a628ad8cb982da22ffc0c8661f3776da3447a6eb
a628ad8https://github.com/nodejs/node/pull/26400/commits/a628ad8cb982da22ffc0c8661f3776da3447a6eb
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 8, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470755856
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/300/consolehttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/300/console
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
fixup! buffer: improve performance of buffer indexof methodhttps://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
50acfb8https://github.com/nodejs/node/pull/26400/commits/50acfb814a88e054e3f503a35386fc50ed634133
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 8, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470822438
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 8, 2019https://github.com/nodejs/node/pull/26400#issuecomment-470903671
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/301/consolehttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/301/console
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 10, 2019 https://github.com/nodejs/node/pull/26400#pullrequestreview-212622019
View reviewed changes https://github.com/nodejs/node/pull/26400/files/50acfb814a88e054e3f503a35386fc50ed634133
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 10, 2019https://github.com/nodejs/node/pull/26400#issuecomment-471344819
https://ci.nodejs.org/job/node-test-pull-request/21407/https://ci.nodejs.org/job/node-test-pull-request/21407/
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 10, 2019https://github.com/nodejs/node/pull/26400#event-2192513653
https://github.com/refack
refackhttps://github.com/refack
Mar 10, 2019https://github.com/nodejs/node/pull/26400#issuecomment-471354302
Latest resultshttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/301/console
node/lib/buffer.jshttps://github.com/nodejs/node/blob/50acfb814a88e054e3f503a35386fc50ed634133/lib/buffer.js#L768
50acfb8https://github.com/nodejs/node/commit/50acfb814a88e054e3f503a35386fc50ed634133
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/refack
refackhttps://github.com/refack
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 10, 2019https://github.com/nodejs/node/pull/26400#event-2192523731
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 10, 2019https://github.com/nodejs/node/pull/26400#issuecomment-471356495
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/refack
refackhttps://github.com/refack
Mar 10, 2019https://github.com/nodejs/node/pull/26400#issuecomment-471360766
https://user-images.githubusercontent.com/96947/54092439-82185700-4362-11e9-8e2a-caa37e09bc32.png
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 25, 2019https://github.com/nodejs/node/pull/26400#issuecomment-476315958
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 25, 2019https://github.com/nodejs/node/pull/26400#issuecomment-476322102
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 26, 2019 https://github.com/nodejs/node/pull/26400#pullrequestreview-218843593
View reviewed changes https://github.com/nodejs/node/pull/26400/files/50acfb814a88e054e3f503a35386fc50ed634133
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/26400#pullrequestreview-218843593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 26, 2019https://github.com/nodejs/node/pull/26400#issuecomment-476613234
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Mar 26, 2019https://github.com/nodejs/node/pull/26400#event-2229581043
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26400
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/26400/files/50acfb814a88e054e3f503a35386fc50ed634133
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26400/files/50acfb814a88e054e3f503a35386fc50ed634133
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/26400/files/08bf6ed271db870ea832461dc536bb79fb20def3
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/nodejs/node/pull/26400
https://github.com/ZYSzys
https://github.com/mscdex
https://github.com/BridgeAR
https://github.com/refack
https://github.com/Trott
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.