René's URL Explorer Experiment


Title: src: use object to pass `Environment` to functions by addaleax · Pull Request #26382 · nodejs/node · GitHub

Open Graph Title: src: use object to pass `Environment` to functions by addaleax · Pull Request #26382 · nodejs/node

X Title: src: use object to pass `Environment` to functions by addaleax · Pull Request #26382 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use a v8::Object with an internal field, rather than a v8::External. On a GetReturnValue().Set(Environment::GetCurrent(args) == nullptr) noop function, this benchmarks as a ~60 % speedup, as calls ...

X Description: Use a v8::Object with an internal field, rather than a v8::External. On a GetReturnValue().Set(Environment::GetCurrent(args) == nullptr) noop function, this benchmarks as a ~60 % speedup, as calls ...

Opengraph URL: https://github.com/nodejs/node/pull/26382

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c52bce0f-2098-0365-bea8-000d58b852f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD906:23810A:A56097:D485E5:69923A10
html-safe-nonce61fb1894dfea27a60193020acf1db59e51ae87c5cb52a8409761f0bf1357afe0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTA2OjIzODEwQTpBNTYwOTc6RDQ4NUU1OjY5OTIzQTEwIiwidmlzaXRvcl9pZCI6IjU4NjM4NDUwNDE5ODcwMDkwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0bdf047833d2ca33230ec55390d30435b617f3e7aae7f9885e647d1d797d150b
hovercard-subject-tagpull_request:257574947
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26382/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52cdd78efb99b1c0473ff4b49569cd6ff1b81951b4e1dabfc00f1d8941f36a55/nodejs/node/pull/26382
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52cdd78efb99b1c0473ff4b49569cd6ff1b81951b4e1dabfc00f1d8941f36a55/nodejs/node/pull/26382
og:image:altUse a v8::Object with an internal field, rather than a v8::External. On a GetReturnValue().Set(Environment::GetCurrent(args) == nullptr) noop function, this benchmarks as a ~60 % speedup, as calls ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26382#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26382
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26382
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26382
Reloadhttps://github.com/nodejs/node/pull/26382
Reloadhttps://github.com/nodejs/node/pull/26382
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26382
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:env-getcurrent-argshttps://github.com/addaleax/node/tree/env-getcurrent-args
Conversationhttps://github.com/nodejs/node/pull/26382
Commits1 (1)https://github.com/nodejs/node/pull/26382/commits
Checkshttps://github.com/nodejs/node/pull/26382/checks
Files changedhttps://github.com/nodejs/node/pull/26382/files
src: use object to pass Environment to functionshttps://github.com/nodejs/node/pull/26382#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:env-getcurrent-argshttps://github.com/addaleax/node/tree/env-getcurrent-args
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 1, 2019https://github.com/nodejs/node/pull/26382#issue-416270274
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
src: use object to pass Environment to functionshttps://github.com/nodejs/node/pull/26382/commits/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
7ecb92fhttps://github.com/nodejs/node/pull/26382/commits/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 1, 2019https://github.com/nodejs/node/pull/26382#issuecomment-468803842
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2732/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2732/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 1, 2019https://github.com/nodejs/node/pull/26382#event-2175068142
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 1, 2019 https://github.com/nodejs/node/pull/26382#pullrequestreview-209779438
View reviewed changes https://github.com/nodejs/node/pull/26382/files/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 1, 2019https://github.com/nodejs/node/pull/26382#issuecomment-468808781
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://ci.nodejs.org/job/node-test-pull-request/21107/https://ci.nodejs.org/job/node-test-pull-request/21107/
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2019 https://github.com/nodejs/node/pull/26382#pullrequestreview-209865951
View reviewed changes https://github.com/nodejs/node/pull/26382/files/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/26382#pullrequestreview-209865951
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 2, 2019https://github.com/nodejs/node/pull/26382#event-2175739927
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 2, 2019https://github.com/nodejs/node/pull/26382#issuecomment-468915866
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 5, 2019https://github.com/nodejs/node/pull/26382#issuecomment-469477259
955be86https://github.com/nodejs/node/commit/955be8623d58566849cf6a59ff82e78cf14f239a
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 5, 2019https://github.com/nodejs/node/pull/26382#event-2179486195
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
March 5, 2019 00:00https://github.com/nodejs/node/pull/26382#event-2179486349
addaleaxhttps://github.com/addaleax
Mar 5, 2019 https://github.com/nodejs/node/pull/26382#ref-commit-955be86
https://github.com/addaleax
src: use object to pass Environment to functionshttps://github.com/nodejs/node/commit/955be8623d58566849cf6a59ff82e78cf14f239a
955be86https://github.com/nodejs/node/commit/955be8623d58566849cf6a59ff82e78cf14f239a
#26382https://github.com/nodejs/node/pull/26382
BridgeARhttps://github.com/BridgeAR
Mar 12, 2019 https://github.com/nodejs/node/pull/26382#ref-commit-b45c22b
https://github.com/addaleax
https://github.com/BridgeAR
src: use object to pass Environment to functionshttps://github.com/BridgeAR/node/commit/b45c22bc87e1e943853b2033d9686d90e3d851e1
b45c22bhttps://github.com/BridgeAR/node/commit/b45c22bc87e1e943853b2033d9686d90e3d851e1
nodejs#26382https://github.com/nodejs/node/pull/26382
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/26382#ref-pullrequest-420740761
2019-03-14, Version 11.12.0 (Current) #26644 https://github.com/nodejs/node/pull/26644
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Apr 2, 2019 https://github.com/nodejs/node/pull/26382#ref-pullrequest-378054757
src: fixes for V8 6.9 and 7.0 nodejs/llnode#247 https://github.com/nodejs/llnode/pull/247
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 7, 2019https://github.com/nodejs/node/pull/26382#issuecomment-519081673
#26382 (review)https://github.com/nodejs/node/pull/26382#pullrequestreview-209865951
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 27, 2019https://github.com/nodejs/node/pull/26382#issuecomment-569183832
@joyeecheunghttps://github.com/joyeecheung
#28823https://github.com/nodejs/node/issues/28823
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 28, 2019https://github.com/nodejs/node/pull/26382#issuecomment-569422405
Please reload this pagehttps://github.com/nodejs/node/pull/26382
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 10, 2020 https://github.com/nodejs/node/pull/26382#ref-pullrequest-589678896
src: split out per-binding state from Environment #32538 https://github.com/nodejs/node/pull/32538
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 14, 2020 https://github.com/nodejs/node/pull/26382#ref-pullrequest-597910592
src: include Environment in snapshot #32761 https://github.com/nodejs/node/pull/32761
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 21, 2020 https://github.com/nodejs/node/pull/26382#ref-pullrequest-604304106
bootstrap: include bootstrapped Environment in builtin snapshot #32984 https://github.com/nodejs/node/pull/32984
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26382
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/26382/files/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/26382/files/7ecb92f22226999a6ad77b31de5ee29f2e6cf055
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/26382
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.