René's URL Explorer Experiment


Title: Revert "build: silence cpp lint by default" by refack · Pull Request #26358 · nodejs/node · GitHub

Open Graph Title: Revert "build: silence cpp lint by default" by refack · Pull Request #26358 · nodejs/node

X Title: Revert "build: silence cpp lint by default" by refack · Pull Request #26358 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 0373836. PR effect is semver major, and removes an escape hatch. This landed without proper review from @nodejs/build-files Checklist make -j4 test (UNIX), or vcbuild test (...

X Description: This reverts commit 0373836. PR effect is semver major, and removes an escape hatch. This landed without proper review from @nodejs/build-files Checklist make -j4 test (UNIX), or vcbuild test (...

Opengraph URL: https://github.com/nodejs/node/pull/26358

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2db2776-5b8c-c4b9-00da-067a68e73daf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89E8:804D0:1A5CFD0:21D32FD:6991B9BF
html-safe-nonce563377aa4038a0cc416ca88443f6c0ed4d51284061188a04d4e06a9d6e827681
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUU4OjgwNEQwOjFBNUNGRDA6MjFEMzJGRDo2OTkxQjlCRiIsInZpc2l0b3JfaWQiOiI4ODM0MDI2NjA0NjM0MTU5NTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8e9ab9244c577ab2542be3518abbdab61eb340535dfd26c4af4faa8d767096f7
hovercard-subject-tagpull_request:257171807
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26358/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/715f1d3fff784cad2626c8eab394e480e9416fc44bbd86447c30b1d48839dddf/nodejs/node/pull/26358
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/715f1d3fff784cad2626c8eab394e480e9416fc44bbd86447c30b1d48839dddf/nodejs/node/pull/26358
og:image:altThis reverts commit 0373836. PR effect is semver major, and removes an escape hatch. This landed without proper review from @nodejs/build-files Checklist make -j4 test (UNIX), or vcbuild test (...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26358#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26358
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26358
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26358
Reloadhttps://github.com/nodejs/node/pull/26358
Reloadhttps://github.com/nodejs/node/pull/26358
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26358
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:revert-0373836https://github.com/refack/node/tree/revert-0373836
Conversationhttps://github.com/nodejs/node/pull/26358
Commits1 (1)https://github.com/nodejs/node/pull/26358/commits
Checkshttps://github.com/nodejs/node/pull/26358/checks
Files changedhttps://github.com/nodejs/node/pull/26358/files
Revert "build: silence cpp lint by default"https://github.com/nodejs/node/pull/26358#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:revert-0373836https://github.com/refack/node/tree/revert-0373836
https://github.com/refack
refackhttps://github.com/refack
Feb 28, 2019https://github.com/nodejs/node/pull/26358#issue-415752232
0373836https://github.com/nodejs/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
refackhttps://github.com/refack
BridgeARhttps://github.com/BridgeAR
February 28, 2019 18:01https://github.com/nodejs/node/pull/26358#event-2171860446
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 28, 2019https://github.com/nodejs/node/pull/26358#issuecomment-468374210
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2713/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2713/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Feb 28, 2019https://github.com/nodejs/node/pull/26358#event-2171860583
https://github.com/refack
refackhttps://github.com/refack
Feb 28, 2019https://github.com/nodejs/node/pull/26358#issuecomment-468375038
node/Makefilehttps://github.com/nodejs/node/blob/0373836b390999644d116c96b41ba05a8a0f181a/Makefile#L57-L60
0373836https://github.com/nodejs/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
refackhttps://github.com/refack
Feb 28, 2019https://github.com/nodejs/node/pull/26358#event-2171866717
https://github.com/refack
refackhttps://github.com/refack
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Feb 28, 2019https://github.com/nodejs/node/pull/26358#event-2171868343
https://github.com/refack
refackhttps://github.com/refack
danbevhttps://github.com/danbev
jasnellhttps://github.com/jasnell
February 28, 2019 18:05https://github.com/nodejs/node/pull/26358#event-2171870030
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 28, 2019 https://github.com/nodejs/node/pull/26358#pullrequestreview-209240237
View reviewed changes https://github.com/nodejs/node/pull/26358/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 28, 2019 https://github.com/nodejs/node/pull/26358#pullrequestreview-209244101
View reviewed changes https://github.com/nodejs/node/pull/26358/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 28, 2019https://github.com/nodejs/node/pull/26358#issuecomment-468395965
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Mar 3, 2019https://github.com/nodejs/node/pull/26358#event-2176569511
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 7, 2019https://github.com/nodejs/node/pull/26358#issuecomment-470421898
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/danbev
danbevhttps://github.com/danbev
March 7, 2019 07:50https://github.com/nodejs/node/pull/26358#event-2186374150
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 7, 2019https://github.com/nodejs/node/pull/26358#issuecomment-470449224
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
refackhttps://github.com/refack
Mar 7, 2019https://github.com/nodejs/node/pull/26358#issuecomment-470733518
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://ci.nodejs.org/job/node-test-pull-request/21315/https://ci.nodejs.org/job/node-test-pull-request/21315/
node/Makefilehttps://github.com/nodejs/node/blob/0373836b390999644d116c96b41ba05a8a0f181a/Makefile#L57-L60
0373836https://github.com/nodejs/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
refackhttps://github.com/refack
Mar 7, 2019https://github.com/nodejs/node/pull/26358#issuecomment-470736405
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
Revert "build: silence cpp lint by default"https://github.com/nodejs/node/pull/26358/commits/91e1a043a656c58ac25ff5dd4b60e9684f3c3452
91e1a04https://github.com/nodejs/node/pull/26358/commits/91e1a043a656c58ac25ff5dd4b60e9684f3c3452
0373836https://github.com/refack/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
nodejs#26358https://github.com/nodejs/node/pull/26358
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/66b88f963452dccba72208a1c85b9d6473f8c48b..91e1a043a656c58ac25ff5dd4b60e9684f3c3452
66b88f9https://github.com/nodejs/node/commit/66b88f963452dccba72208a1c85b9d6473f8c48b
91e1a04https://github.com/nodejs/node/commit/91e1a043a656c58ac25ff5dd4b60e9684f3c3452
Compare https://github.com/nodejs/node/compare/66b88f963452dccba72208a1c85b9d6473f8c48b..91e1a043a656c58ac25ff5dd4b60e9684f3c3452
March 7, 2019 23:47https://github.com/nodejs/node/pull/26358#event-2188811489
https://github.com/refack
refackhttps://github.com/refack
91e1a04https://github.com/nodejs/node/commit/91e1a043a656c58ac25ff5dd4b60e9684f3c3452
Mar 7, 2019https://github.com/nodejs/node/pull/26358#event-2188813498
https://github.com/refack
refackhttps://github.com/refack
March 8, 2019 14:48https://github.com/nodejs/node/pull/26358#event-2190272938
https://github.com/refack
refackhttps://github.com/refack
Mar 11, 2019https://github.com/nodejs/node/pull/26358#event-2192631684
BridgeARhttps://github.com/BridgeAR
Mar 12, 2019 https://github.com/nodejs/node/pull/26358#ref-commit-8c90fe1
https://github.com/refack
https://github.com/BridgeAR
Revert "build: silence cpp lint by default"https://github.com/BridgeAR/node/commit/8c90fe12c402b78c3d660dd8b629847e33411ce4
8c90fe1https://github.com/BridgeAR/node/commit/8c90fe12c402b78c3d660dd8b629847e33411ce4
0373836https://github.com/BridgeAR/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
nodejs#26358https://github.com/nodejs/node/pull/26358
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/26358#ref-pullrequest-420740761
2019-03-14, Version 11.12.0 (Current) #26644 https://github.com/nodejs/node/pull/26644
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/26358#ref-commit-b2e27a0
https://github.com/refack
https://github.com/BridgeAR
Revert "build: silence cpp lint by default"https://github.com/nodejs/node/commit/b2e27a02b456985642506fb5773ef48392970262
b2e27a0https://github.com/nodejs/node/commit/b2e27a02b456985642506fb5773ef48392970262
0373836https://github.com/nodejs/node/commit/0373836b390999644d116c96b41ba05a8a0f181a
#26358https://github.com/nodejs/node/pull/26358
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26358
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/26358/files/66b88f963452dccba72208a1c85b9d6473f8c48b
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/26358/files/66b88f963452dccba72208a1c85b9d6473f8c48b
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/jasnell
jasnell https://github.com/jasnell
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/26358
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/danbev
https://github.com/joyeecheung
https://github.com/cjihrig
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.